Re: [PATCH v12 21/39] arm64/gcs: Ensure that new threads have a GCS

2024-09-06 Thread Szabolcs Nagy
The 08/29/2024 00:27, Mark Brown wrote: > Unfortunately plain clone() is not extensible and existing clone3() > users will not specify a stack so all existing code would be broken if > we mandated specifying the stack explicitly. For compatibility with > these cases and also x86 (which did not ini

Re: [PATCH v7 1/2] arm64: Define Documentation/arm64/tagged-address-abi.rst

2019-08-08 Thread Szabolcs Nagy
On 07/08/2019 21:38, Dave Hansen wrote: > On 8/7/19 8:53 AM, Catalin Marinas wrote: >> +- The syscall behaviour is undefined for non valid tagged pointers. > > Do you really mean "undefined"? I mean, a bad pointer is a bad pointer. > Why should it matter if it's a tagged bad pointer or an untagg

Re: [PATCH v7 0/2] arm64 tagged address ABI

2019-08-08 Thread Szabolcs Nagy
On 07/08/2019 16:53, Catalin Marinas wrote: > Hi, > > Thanks for the feedback so far. This is an updated series documenting > the AArch64 Tagged Address ABI as implemented by these patches: > > http://lkml.kernel.org/r/cover.1563904656.git.andreyk...@google.com > > Version 6 of the documentation

Re: [PATCH v7 1/2] arm64: Define Documentation/arm64/tagged-address-abi.rst

2019-08-08 Thread Szabolcs Nagy
On 07/08/2019 21:38, Dave Hansen wrote: > On 8/7/19 8:53 AM, Catalin Marinas wrote: >> +- mmap() done by the process itself (or its parent), where either: >> + >> + - flags have the **MAP_ANONYMOUS** bit set >> + - the file descriptor refers to a regular file (including those returned >> +by

Re: [PATCH v7 1/2] arm64: Define Documentation/arm64/tagged-address-abi.rst

2019-08-08 Thread Szabolcs Nagy
On 07/08/2019 16:53, Catalin Marinas wrote: > From: Vincenzo Frascino > > On arm64 the TCR_EL1.TBI0 bit has been always enabled hence > the userspace (EL0) is allowed to set a non-zero value in the > top byte but the resulting pointers are not allowed at the > user-kernel syscall ABI boundary. >

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-12 Thread Szabolcs Nagy
On 12/06/2019 15:21, Vincenzo Frascino wrote: > On arm64 the TCR_EL1.TBI0 bit has been always enabled hence > the userspace (EL0) is allowed to set a non-zero value in the > top byte but the resulting pointers are not allowed at the > user-kernel syscall ABI boundary. > > With the relaxed ABI prop

Re: [PATCH v4 2/2] arm64: Relax Documentation/arm64/tagged-pointers.txt

2019-06-12 Thread Szabolcs Nagy
On 12/06/2019 15:21, Vincenzo Frascino wrote: > On arm64 the TCR_EL1.TBI0 bit has been always enabled hence > the userspace (EL0) is allowed to set a non-zero value in the > top byte but the resulting pointers are not allowed at the > user-kernel syscall ABI boundary. > > With the relaxed ABI prop

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Szabolcs Nagy
On 13/06/2019 12:16, Vincenzo Frascino wrote: > Hi Szabolcs, > > thank you for your review. > > On 13/06/2019 11:14, Szabolcs Nagy wrote: >> On 13/06/2019 10:20, Catalin Marinas wrote: >>> Hi Szabolcs, >>> >>> On Wed, Jun 12, 2019 at 05:30:34PM +

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Szabolcs Nagy
On 13/06/2019 15:03, Vincenzo Frascino wrote: > On 13/06/2019 13:28, Szabolcs Nagy wrote: >> On 13/06/2019 12:16, Vincenzo Frascino wrote: >>> On 13/06/2019 11:14, Szabolcs Nagy wrote: >>>> On 13/06/2019 10:20, Catalin Marinas wrote: >>>>> On Wed, Ju

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Szabolcs Nagy
On 13/06/2019 10:20, Catalin Marinas wrote: > Hi Szabolcs, > > On Wed, Jun 12, 2019 at 05:30:34PM +0100, Szabolcs Nagy wrote: >> On 12/06/2019 15:21, Vincenzo Frascino wrote: >>> +2. ARM64 Tagged Address ABI >>> +--- >>> + >>

Re: [PATCH v5 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-18 Thread Szabolcs Nagy
> to opt-in to such an option. > > Specify and document the way in which sysctl and prctl() can be used > in combination to allow the userspace to opt-in this feature. > > Cc: Catalin Marinas > Cc: Will Deacon > CC: Andrey Konovalov > Signed-off-by: Vincenzo Frascino Acke

Re: [RFC][PATCH 0/3] arm64 relaxed ABI

2019-02-19 Thread Szabolcs Nagy
On 12/02/2019 18:02, Catalin Marinas wrote: > On Mon, Feb 11, 2019 at 12:32:55PM -0800, Evgenii Stepanov wrote: >> On Mon, Feb 11, 2019 at 9:28 AM Kevin Brodsky wrote: >>> On 19/12/2018 12:52, Dave Martin wrote: Really, the kernel should do the expected thing with all "non-weird" memory.

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Szabolcs Nagy
On 22/02/2019 12:53, Andrey Konovalov wrote: > This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. > > arm64 has a feature called Top Byte Ignore, which allows to embed pointer > tags into the top byte of each pointer. Userspace programs (such as > HWASan, a memory debugging

Re: [PATCH v10 00/12] arm64: untag user pointers passed to the kernel

2019-02-22 Thread Szabolcs Nagy
On 22/02/2019 15:40, Andrey Konovalov wrote: > On Fri, Feb 22, 2019 at 4:35 PM Szabolcs Nagy wrote: >> >> On 22/02/2019 12:53, Andrey Konovalov wrote: >>> This patchset is meant to be merged together with "arm64 relaxed ABI" [1]. >>> >>> arm64 h

Re: [RFC][PATCH 0/3] arm64 relaxed ABI

2019-02-25 Thread Szabolcs Nagy
On 25/02/2019 16:57, Catalin Marinas wrote: > On Tue, Feb 19, 2019 at 06:38:31PM +0000, Szabolcs Nagy wrote: >> i think these rules work for the cases i care about, a more >> tricky question is when/how to check for the new syscall abi >> and when/how the TCR_EL1.TBI0 sett

Re: [PATCH v9 00/24] ILP32 for ARM64

2018-10-10 Thread Szabolcs Nagy
On 10/10/18 15:10, Eugene Syromiatnikov wrote: > * What's the reasoning behind capping syscall arguments to 32 bit? x32 >and MIPS N32 do not have such a restriction (and do not need special >wrappers for syscalls that pass 64-bit values as a result, except >when they do, as it is the

Re: [RFC6 PATCH v6 00/21] ILP32 for ARM64

2016-05-17 Thread Szabolcs Nagy
On 05/04/16 23:08, Yury Norov wrote: > This version is rebased on kernel v4.6-rc2, and has fixes in signal subsystem. > It works with updated glibc [1] (though very draft), and tested with LTP. > > It was tested on QEMU and ThunderX machines. No major difference found. > This is RFC because ILP32

Re: [PATCH v6 00/21] ILP32 for ARM64

2016-05-25 Thread Szabolcs Nagy
On 24/05/16 01:04, Yury Norov wrote: > This version is based on kernel v4.6. > It works with glibc-2.23, and tested with LTP. > ... > ILP32 glibc branch is available here: > https://github.com/norov/glibc/tree/ilp32-2.23 > > It is tested with this series with no major downsides. I will send it to

Re: [PATCH 01/23] all: syscall wrappers: add documentation

2016-05-26 Thread Szabolcs Nagy
On 26/05/16 15:20, Catalin Marinas wrote: > While writing the above, I realised the current ILP32 patches still miss > on converting pointers passed from user space (unless I got myself > confused in macros). The new __SC_WRAP() and COMPAT_SYSCALL_WRAPx() > macros take care of zero or sign extensio

Re: [PATCH v6 00/21] ILP32 for ARM64

2016-06-03 Thread Szabolcs Nagy
On 02/06/16 20:03, Yury Norov wrote: > On Tue, May 24, 2016 at 03:04:29AM +0300, Yury Norov wrote: >> ILP32 glibc branch is available here: >> https://github.com/norov/glibc/tree/ilp32-2.23 >> > > So for AARCH64/ILP32 we turn next types to 64-bit in glibc: > #define __INO_T_TYPE__UQUAD