[PATCH bpf-next v4 4/4] igc: Add launch time support to XDP ZC

2025-01-06 Thread Song Yoong Siang
000 (100.016 usec) 0x562ff5dc8880: complete rx idx=132 addr=84110 Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc_main.c | 78 --- 1 file changed, 56 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/

[PATCH bpf-next v4 2/4] selftests/bpf: Add Launch Time request to xdp_hw_metadata

2025-01-06 Thread Song Yoong Siang
Add Launch Time hw offload request to xdp_hw_metadata. User can configure the delta of launch time to HW RX-time by using "-l" argument. The default delta is 100,000,000 nanosecond. Signed-off-by: Song Yoong Siang --- tools/testing/selftests/bpf/xdp_hw_metadata.c | 30

[PATCH bpf-next v4 3/4] net: stmmac: Add launch time support to XDP ZC

2025-01-06 Thread Song Yoong Siang
ime: 1734579065768004454 (sec:1734579065.7680) delta to User TX-complete-time sec:0. (999860.245 usec) HW RX-time: 1734579065767717328 (sec:1734579065.7677) delta to HW TX-complete-time sec:1. (116.963 usec) 0x55b5864717a8: complete rx idx=132 addr=88100 Signed-off-by: Song Yoong Si

[PATCH bpf-next v4 0/4] xsk: TX metadata Launch Time support

2025-01-06 Thread Song Yoong Siang
.org/project/netdevbpf/cover/20231130162028.852006-1-yoong.siang.s...@intel.com/ v2: https://patchwork.kernel.org/project/netdevbpf/cover/20231201062421.1074768-1-yoong.siang.s...@intel.com/ v3: https://patchwork.kernel.org/project/netdevbpf/cover/20231203165129.1740512-1-yoong.siang.s...@intel.com/

[PATCH bpf-next v4 1/4] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-01-06 Thread Song Yoong Siang
field of struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang --- Documentation/netlink/specs/netdev.yaml | 4 ++ Documentation/networking/xsk-tx-metadata.rst | 64 include/net/xdp_sock.h | 10 +++ include/net

[PATCH bpf-next v7 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-03 Thread Song Yoong Siang
field of struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang Acked-by: Stanislav Fomichev --- Documentation/netlink/specs/netdev.yaml | 4 ++ Documentation/networking/xsk-tx-metadata.rst | 62 include/net/xdp_sock.h

[PATCH bpf-next v7 2/5] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-02-03 Thread Song Yoong Siang
aunch time hardware offload feature will be enabled and requested. Additionally, users can configure the Tx Queue to be enabled with the launch time hardware offload using the "-L" argument. By default, Tx Queue 0 will be used. Signed-off-by: Song Yoong Siang Acked-by: Stanislav Fomichev

[PATCH bpf-next v7 0/5] xsk: TX metadata Launch Time support

2025-02-03 Thread Song Yoong Siang
s://lore.kernel.org/netdev/20231130162028.852006-1-yoong.siang.s...@intel.com/ Song Yoong Siang (5): xsk: Add launch time hardware offload support to XDP Tx metadata selftests/bpf: Add launch time request to xdp_hw_metadata net: stmmac: Add launch time support to XDP ZC igc: Refactor emp

[PATCH bpf-next v7 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-03 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 08.410 us Avr delta: 13.854 us Max delta: 17.076 us Total packets forwarded: 1000 Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.

[PATCH bpf-next v7 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-03 Thread Song Yoong Siang
function. This patch introduces no functional changes. Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc_main.c | 42 --- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel

[PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-03 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 0.005 us Avr delta: 0.016 us Max delta: 0.031 us Total packets forwarded: 1000 Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc_main.c | 42 +-- 1 file changed, 40 insertions(+), 2 deletions(-)

RE: [xdp-hints] [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 10:04 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 02:14:00PM +0100, Song, Yoong Siang wrote: >> On Tuesday, February 4, 2025 6:10 PM, Fijalkowski, >> Maciej wrote: >> >On Tue, Feb 04, 2025 at 08:49:07AM +0800, Song Yoong Siang

[PATCH bpf-next v8 2/5] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-02-04 Thread Song Yoong Siang
aunch time hardware offload feature will be enabled and requested. Additionally, users can configure the Tx Queue to be enabled with the launch time hardware offload using the "-L" argument. By default, Tx Queue 0 will be used. Signed-off-by: Song Yoong Siang Acked-by: Stanislav Fomichev

[PATCH bpf-next v8 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-04 Thread Song Yoong Siang
field of struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang Acked-by: Stanislav Fomichev --- Documentation/netlink/specs/netdev.yaml | 4 ++ Documentation/networking/xsk-tx-metadata.rst | 62 include/net/xdp_sock.h

[PATCH bpf-next v8 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-04 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 08.410 us Avr delta: 13.854 us Max delta: 17.076 us Total packets forwarded: 1000 Signed-off-by: Song Yoong Siang Reviewed-by: Choong Yong Liang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/

[PATCH bpf-next v8 0/5] xsk: TX metadata Launch Time support

2025-02-04 Thread Song Yoong Siang
028.852006-1-yoong.siang.s...@intel.com/ Song Yoong Siang (5): xsk: Add launch time hardware offload support to XDP Tx metadata selftests/bpf: Add launch time request to xdp_hw_metadata net: stmmac: Add launch time support to XDP ZC igc: Refactor empty packet insertion into a reusable funct

[PATCH bpf-next v8 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-04 Thread Song Yoong Siang
function. This patch introduces no functional changes. Signed-off-by: Song Yoong Siang Reviewed-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc_main.c | 42 --- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b

[PATCH bpf-next v8 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 0.005 us Avr delta: 0.016 us Max delta: 0.031 us Total packets forwarded: 1000 Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc.h | 1 + drivers/net/ethernet/intel/igc/igc_main.c | 52

RE: [PATCH bpf-next v7 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 8:36 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 12:07:21PM +0100, Song, Yoong Siang wrote: [...] >> >> "insert an empty packet" is a launch time trick to send a packet in >> next Qbv cycle. The design is, the driver w

RE: [xdp-hints] [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 11:18 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 03:49:32PM +0100, Song, Yoong Siang wrote: [...] >> With above, IMHO, we no need to clear igc_tx_buffer::type, >> Are you agree? > >Yes, the contract should be that every

RE: [xdp-hints] [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 6:10 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 08:49:07AM +0800, Song Yoong Siang wrote: > >> Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx >> metadata framework. >> >> This patch has been tested wi

RE: [PATCH bpf-next v7 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 5:50 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 08:49:06AM +0800, Song Yoong Siang wrote: >> Refactor the code for inserting an empty packet into a new function >> igc_insert_empty_packet(). This change extracts the logic for inserting >

RE: [PATCH bpf-next v8 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-05 Thread Song, Yoong Siang
On Wednesday, February 5, 2025 8:31 PM, Fijalkowski, Maciej wrote: >On Wed, Feb 05, 2025 at 10:41:15AM +0800, Song Yoong Siang wrote: >> Refactor the code for inserting an empty packet into a new function >> igc_insert_empty_packet(). This change extracts the logic for insert

RE: [PATCH bpf-next v8 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-05 Thread Song, Yoong Siang
On Thursday, February 6, 2025 12:08 AM, Fijalkowski, Maciej wrote: >On Wed, Feb 05, 2025 at 03:43:19PM +0100, Song, Yoong Siang wrote: >> On Wednesday, February 5, 2025 8:31 PM, Fijalkowski, >> Maciej wrote: >> >On Wed, Feb 05, 2025 at 10:41:15AM +0800, Song Yoong Sia

[PATCH bpf-next v9 0/5] xsk: TX metadata Launch Time support

2025-02-05 Thread Song Yoong Siang
v/20231201062421.1074768-1-yoong.siang.s...@intel.com/ - renamed to use Earliest TxTime First (Willem) - renamed to use txtime (Willem) V1: https://lore.kernel.org/netdev/20231130162028.852006-1-yoong.siang.s...@intel.com/ Song Yoong Siang (5): xsk: Add launch time hardware offload support to XDP T

[PATCH bpf-next v9 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-05 Thread Song Yoong Siang
field of struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Acked-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang --- Documentation/netlink/specs/netdev.yaml | 4 ++ Documentation/networking/xsk-tx-metadata.rst | 62 include/net/xdp_sock.h

[PATCH bpf-next v9 5/5] igc: Add launch time support to XDP ZC

2025-02-05 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 0.005 us Avr delta: 0.016 us Max delta: 0.031 us Total packets forwarded: 1000 Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc.h | 1 + drivers/net/ethernet/intel/igc/igc_main.c | 57

[PATCH bpf-next v9 2/5] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-02-05 Thread Song Yoong Siang
aunch time hardware offload feature will be enabled and requested. Additionally, users can configure the Tx Queue to be enabled with the launch time hardware offload using the "-L" argument. By default, Tx Queue 0 will be used. Acked-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang

[PATCH bpf-next v9 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-05 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 08.410 us Avr delta: 13.854 us Max delta: 17.076 us Total packets forwarded: 1000 Reviewed-by: Choong Yong Liang Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/

[PATCH bpf-next v9 4/5] igc: Refactor empty frame insertion for launch time support

2025-02-05 Thread Song Yoong Siang
behind this handling. Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc_main.c | 84 ++- 1 file changed, 52 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index

[PATCH bpf-next v10 2/5] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-02-06 Thread Song Yoong Siang
aunch time hardware offload feature will be enabled and requested. Additionally, users can configure the Tx Queue to be enabled with the launch time hardware offload using the "-L" argument. By default, Tx Queue 0 will be used. Acked-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang

[PATCH bpf-next v10 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-06 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 08.410 us Avr delta: 13.854 us Max delta: 17.076 us Total packets forwarded: 1000 Reviewed-by: Choong Yong Liang Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/

[PATCH bpf-next v10 4/5] igc: Refactor empty frame insertion for launch time support

2025-02-06 Thread Song Yoong Siang
behind this handling. Reviewed-by: Maciej Fijalkowski Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc_main.c | 82 ++- 1 file changed, 50 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel

[PATCH bpf-next v10 5/5] igc: Add launch time support to XDP ZC

2025-02-06 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 0.005 us Avr delta: 0.016 us Max delta: 0.031 us Total packets forwarded: 1000 Reviewed-by: Maciej Fijalkowski Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc.h | 1 + drivers/net/ethernet/intel/igc/igc_

[PATCH bpf-next v10 0/5] xsk: TX metadata Launch Time support

2025-02-06 Thread Song Yoong Siang
s://lore.kernel.org/netdev/20231201062421.1074768-1-yoong.siang.s...@intel.com/ - renamed to use Earliest TxTime First (Willem) - renamed to use txtime (Willem) V1: https://lore.kernel.org/netdev/20231130162028.852006-1-yoong.siang.s...@intel.com/ Song Yoong Siang (5): xsk: Add launch time hardware

[PATCH bpf-next v10 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-06 Thread Song Yoong Siang
field of struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Acked-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang --- Documentation/netlink/specs/netdev.yaml | 4 ++ Documentation/networking/xsk-tx-metadata.rst | 62 include/net/xdp_sock.h

RE: [PATCH bpf-next v4 2/4] selftests/bpf: Add Launch Time request to xdp_hw_metadata

2025-01-08 Thread Song, Yoong Siang
On Wednesday, January 8, 2025 12:58 AM, Stanislav Fomichev wrote: >On 01/06, Song Yoong Siang wrote: >> Add Launch Time hw offload request to xdp_hw_metadata. User can configure >> the delta of launch time to HW RX-time by using "-l" argument. The default >>

RE: [PATCH bpf-next v4 3/4] net: stmmac: Add launch time support to XDP ZC

2025-01-08 Thread Song, Yoong Siang
On Wednesday, January 8, 2025 1:08 AM, Stanislav Fomichev wrote: >On 01/06, Song Yoong Siang wrote: >> Enable launch time (Time-Based Scheduling) support to XDP zero copy via XDP >> Tx metadata framework. >> >> This patch is tested with tools/testing/selftests/bpf/

RE: [PATCH bpf-next v4 1/4] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-01-08 Thread Song, Yoong Siang
On Wednesday, January 8, 2025 12:50 AM, Stanislav Fomichev wrote: >On 01/06, Song Yoong Siang wrote: >> Extend the XDP Tx metadata framework so that user can requests launch time >> hardware offload, where the Ethernet device will schedule the packet for >> transmission at

RE: [PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC

2025-01-23 Thread Song, Yoong Siang
On Thursday, January 23, 2025 11:40 PM, Bouska, Zdenek wrote: > >Hi Siang, > >I tested this patch series on 6.13 with Intel I226-LM (rev 04). > >I also applied patch "selftests/bpf: Actuate tx_metadata_len in >xdp_hw_metadata" [1] >and "selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata" [2] s

RE: [PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC

2025-01-20 Thread Song, Yoong Siang
On Monday, January 20, 2025 3:25 PM, Choong Yong Liang wrote: >On 20/1/2025 2:25 pm, Abdul Rahim, Faizal wrote: >> >> To be cautious, could we perform a stress test by sending a higher number >> of packets with launch time? For example, we could send 200 packets, each >> configured with a launch

RE: [PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC

2025-01-20 Thread Song, Yoong Siang
On Monday, January 20, 2025 2:26 PM, Abdul Rahim, Faizal wrote: >Hi Siang. > >On 16/1/2025 11:53 pm, Song Yoong Siang wrote: >> Enable Launch Time Control (LTC) support to XDP zero copy via XDP Tx >> metadata framework. >> >> This patch is tested with tools/test

[PATCH bpf-next v5 0/4] xsk: TX metadata Launch Time support

2025-01-14 Thread Song Yoong Siang
devbpf/cover/20231203165129.1740512-1-yoong.siang.s...@intel.com/ v4: https://patchwork.kernel.org/project/netdevbpf/cover/20250106135506.9687-1-yoong.siang.s...@intel.com/ Song Yoong Siang (4): xsk: Add launch time hardware offload support to XDP Tx metadata selftests/bpf: Add launch time request to xdp_hw_me

[PATCH bpf-next v5 1/4] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-01-14 Thread Song Yoong Siang
field of struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang --- Documentation/netlink/specs/netdev.yaml | 4 ++ Documentation/networking/xsk-tx-metadata.rst | 62 include/net/xdp_sock.h | 10 include/net

[PATCH bpf-next v5 2/4] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-01-14 Thread Song Yoong Siang
aunch time hardware offload feature will be enabled and requested. Additionally, users can configure the Tx Queue to be enabled with the launch time hardware offload using the "-L" argument. By default, Tx Queue 0 will be used. Signed-off-by: Song Yoong Siang --- tools/testing/selftests/bpf/xdp

[PATCH bpf-next v5 3/4] net: stmmac: Add launch time support to XDP ZC

2025-01-14 Thread Song Yoong Siang
680) delta to User TX-complete-time sec:0. (999860.245 usec) HW RX-time: 1734579065767717328 (sec:1734579065.7677) delta to HW TX-complete-time sec:1. (116.963 usec) 0x55b5864717a8: complete rx idx=132 addr=88100 Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmi

[PATCH bpf-next v5 4/4] igc: Add launch time support to XDP ZC

2025-01-14 Thread Song Yoong Siang
sec:1734578015.4677) delta to User TX-complete-time sec:0. (29.768 usec) HW RX-time: 1734578015467548904 (sec:1734578015.4675) delta to HW TX-complete-time sec:1. (100.016 usec) 0x562ff5dc8880: complete rx idx=132 addr=84110 Signed-off-by: Song Yoong Siang --- drivers/net/ether

[PATCH bpf-next v6 1/4] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-01-16 Thread Song Yoong Siang
field of struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang Acked-by: Stanislav Fomichev --- Documentation/netlink/specs/netdev.yaml | 4 ++ Documentation/networking/xsk-tx-metadata.rst | 62 include/net/xdp_sock.h

[PATCH bpf-next v6 2/4] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-01-16 Thread Song Yoong Siang
aunch time hardware offload feature will be enabled and requested. Additionally, users can configure the Tx Queue to be enabled with the launch time hardware offload using the "-L" argument. By default, Tx Queue 0 will be used. Signed-off-by: Song Yoong Siang --- tools/testing/selftests/bpf/xdp

[PATCH bpf-next v6 3/4] net: stmmac: Add launch time support to XDP ZC

2025-01-16 Thread Song Yoong Siang
680) delta to User TX-complete-time sec:0. (999860.245 usec) HW RX-time: 1734579065767717328 (sec:1734579065.7677) delta to HW TX-complete-time sec:1. (116.963 usec) 0x55b5864717a8: complete rx idx=132 addr=88100 Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmi

[PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC

2025-01-16 Thread Song Yoong Siang
sec:1734578015.4677) delta to User TX-complete-time sec:0. (29.768 usec) HW RX-time: 1734578015467548904 (sec:1734578015.4675) delta to HW TX-complete-time sec:1. (100.016 usec) 0x562ff5dc8880: complete rx idx=132 addr=84110 Signed-off-by: Song Yoong Siang --- drivers/net/ether

[PATCH bpf-next v6 0/4] xsk: TX metadata Launch Time support

2025-01-16 Thread Song Yoong Siang
/ v5: https://patchwork.kernel.org/project/netdevbpf/cover/20250114152718.120588-1-yoong.siang.s...@intel.com/ Song Yoong Siang (4): xsk: Add launch time hardware offload support to XDP Tx metadata selftests/bpf: Add launch time request to xdp_hw_metadata net: stmmac: Add launch time suppo

RE: [PATCH bpf-next v5 2/4] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-01-15 Thread Song, Yoong Siang
On Wednesday, January 15, 2025 10:57 PM, Daniel Borkmann wrote: >On 1/14/25 4:27 PM, Song Yoong Siang wrote: >[...] >> +/* Add mqprio qdisc with TC and hardware queue one-to-one mapping */ >> +char map[256] = {0}; >> +char queues[256] = {0}; >> +

RE: [PATCH bpf-next v10 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-15 Thread Song, Yoong Siang
On Sunday, February 16, 2025 3:04 AM, Jakub Kicinski wrote: >On Sat, 15 Feb 2025 11:01:59 -0800 Jakub Kicinski wrote: >> On Fri, 7 Feb 2025 10:19:39 +0800 Song Yoong Siang wrote: >> > Extend the XDP Tx metadata framework so that user can requests launch time >> >

[PATCH bpf-next v11 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-15 Thread Song Yoong Siang
field of struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Acked-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang --- Documentation/netlink/specs/netdev.yaml | 4 ++ Documentation/networking/xsk-tx-metadata.rst | 62 include/net/xdp_sock.h

[PATCH bpf-next v11 0/5] xsk: TX metadata Launch Time support

2025-02-15 Thread Song Yoong Siang
xtime (Willem) V1: https://lore.kernel.org/netdev/20231130162028.852006-1-yoong.siang.s...@intel.com/ Song Yoong Siang (5): xsk: Add launch time hardware offload support to XDP Tx metadata selftests/bpf: Add launch time request to xdp_hw_metadata net: stmmac: Add launch time support to XD

[PATCH bpf-next v11 2/5] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-02-15 Thread Song Yoong Siang
aunch time hardware offload feature will be enabled and requested. Additionally, users can configure the Tx Queue to be enabled with the launch time hardware offload using the "-L" argument. By default, Tx Queue 0 will be used. Acked-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang

[PATCH bpf-next v11 4/5] igc: Refactor empty frame insertion for launch time support

2025-02-15 Thread Song Yoong Siang
behind this handling. Reviewed-by: Faizal Rahim Reviewed-by: Maciej Fijalkowski Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc_main.c | 82 ++- 1 file changed, 50 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b

[PATCH bpf-next v11 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-15 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 08.410 us Avr delta: 13.854 us Max delta: 17.076 us Total packets forwarded: 1000 Reviewed-by: Choong Yong Liang Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/

[PATCH bpf-next v11 5/5] igc: Add launch time support to XDP ZC

2025-02-15 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 0.005 us Avr delta: 0.016 us Max delta: 0.031 us Total packets forwarded: 1000 Reviewed-by: Faizal Rahim Reviewed-by: Maciej Fijalkowski Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc.h | 1 + drive

[PATCH bpf-next v12 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-16 Thread Song Yoong Siang
field of struct xsk_tx_metadata. Suggested-by: Stanislav Fomichev Acked-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang --- Documentation/netlink/specs/netdev.yaml | 4 ++ Documentation/networking/xsk-tx-metadata.rst | 62 include/net/xdp_sock.h

[PATCH bpf-next v12 0/5] xsk: TX metadata Launch Time support

2025-02-16 Thread Song Yoong Siang
s://lore.kernel.org/netdev/20231130162028.852006-1-yoong.siang.s...@intel.com/ Song Yoong Siang (5): xsk: Add launch time hardware offload support to XDP Tx metadata selftests/bpf: Add launch time request to xdp_hw_metadata net: stmmac: Add launch time support to XDP ZC igc: Refactor empty frame

[PATCH bpf-next v12 2/5] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-02-16 Thread Song Yoong Siang
aunch time hardware offload feature will be enabled and requested. Additionally, users can configure the Tx Queue to be enabled with the launch time hardware offload using the "-L" argument. By default, Tx Queue 0 will be used. Acked-by: Stanislav Fomichev Signed-off-by: Song Yoong Siang

[PATCH bpf-next v12 4/5] igc: Refactor empty frame insertion for launch time support

2025-02-16 Thread Song Yoong Siang
behind this handling. Reviewed-by: Faizal Rahim Reviewed-by: Maciej Fijalkowski Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc_main.c | 82 ++- 1 file changed, 50 insertions(+), 32 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b

[PATCH bpf-next v12 5/5] igc: Add launch time support to XDP ZC

2025-02-16 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 0.005 us Avr delta: 0.016 us Max delta: 0.031 us Total packets forwarded: 1000 Reviewed-by: Faizal Rahim Reviewed-by: Maciej Fijalkowski Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/intel/igc/igc.h | 1 + drive

[PATCH bpf-next v12 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-16 Thread Song Yoong Siang
tly in sending 1000 packets continuously. Min delta: 08.410 us Avr delta: 13.854 us Max delta: 17.076 us Total packets forwarded: 1000 Reviewed-by: Choong Yong Liang Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/

RE: [PATCH bpf-next v12 5/5] igc: Add launch time support to XDP ZC

2025-03-07 Thread Song, Yoong Siang
On Friday, March 7, 2025 9:25 PM, Bouska, Zdenek wrote: [...] >> @@ -2996,7 +3035,13 @@ static void igc_xdp_xmit_zc(struct igc_ring *ring) >> ntu = ring->next_to_use; >> budget = igc_desc_unused(ring); >> >> -while (xsk_tx_peek_desc(pool, &xdp_desc) && budget--) { >> +/* Packe

RE: [PATCH bpf-next 0/2] Clarify and Enhance XDP Rx Metadata Handling

2025-07-07 Thread Song, Yoong Siang
On Tuesday, July 8, 2025 9:45 AM, Jakub Kicinski wrote: >On Tue, 8 Jul 2025 01:34:13 +0000 Song, Yoong Siang wrote: >> >For normal XDP my understanding is that its the driver's responsibility >> >to move the "reserved" stuff out of place before presenting t

RE: [PATCH bpf-next 0/2] Clarify and Enhance XDP Rx Metadata Handling

2025-07-07 Thread Song, Yoong Siang
On Tuesday, July 8, 2025 4:55 AM, Jakub Kicinski wrote: >On Tue, 1 Jul 2025 12:29:38 +0800 Song Yoong Siang wrote: >> |<---sizeof(xdp_meta)--| >> | | >> struct xdp_meta

RE: [PATCH bpf-next 0/2] Clarify and Enhance XDP Rx Metadata Handling

2025-07-07 Thread Song, Yoong Siang
On Tuesday, July 8, 2025 10:18 AM, Jakub Kicinski wrote: >On Tue, 8 Jul 2025 02:06:11 +0000 Song, Yoong Siang wrote: >>> Why would the driver need to move it back? >>> On XDP_PASS an skb is constructed, so the metadata should >>> be transferred to the skb. There is

RE: [PATCH bpf-next,v3 2/2] selftests/bpf: Enhance XDP Rx metadata handling

2025-07-10 Thread Song, Yoong Siang
On Thursday, July 10, 2025 12:29 AM, Stanislav Fomichev wrote: >On 07/09, Daniel Borkmann wrote: >> On 7/7/25 5:03 PM, Stanislav Fomichev wrote: >> > On 07/04, Daniel Borkmann wrote: >> > > On 7/4/25 11:58 AM, Jesper Dangaard Brouer wrote: >> > > >

RE: [PATCH bpf-next,v3 1/2] doc: enhance explanation of XDP Rx metadata layout and METADATA_SIZE

2025-07-03 Thread Song, Yoong Siang
On Thursday, July 3, 2025 11:58 PM, Daniel Borkmann wrote: >On 7/2/25 6:57 PM, Song Yoong Siang wrote: >[...] >> +It is important to note that some devices may utilize the ``data_meta`` >> area for >> +their own purposes. For example, the IGC device utilizes ``IGC_TS_HD

RE: [PATCH bpf-next,v3 2/2] selftests/bpf: Enhance XDP Rx metadata handling

2025-07-03 Thread Song, Yoong Siang
On Friday, July 4, 2025 1:05 AM, Jesper Dangaard Brouer wrote: >On 02/07/2025 18.57, Song Yoong Siang wrote: >> Introduce the XDP_METADATA_SIZE macro as a conservative measure to >> accommodate any metadata areas reserved by Ethernet devices. >> > >This seems like a slo

[PATCH bpf-next,v3 0/2] Clarify and Enhance XDP Rx Metadata Handling

2025-07-02 Thread Song Yoong Siang
(Stanislav) V1: https://lore.kernel.org/netdev/20250701042940.3272325-1-yoong.siang.s...@intel.com/ Song Yoong Siang (2): doc: enhance explanation of XDP Rx metadata layout and METADATA_SIZE selftests/bpf: Enhance XDP Rx metadata handling Documentation/networking/xdp-rx-metadata.rst | 36

[PATCH bpf-next,v3 1/2] doc: enhance explanation of XDP Rx metadata layout and METADATA_SIZE

2025-07-02 Thread Song Yoong Siang
alignment and size constraints. The updated guidance helps users correctly allocate and access metadata in AF_XDP scenarios. Signed-off-by: Song Yoong Siang --- Documentation/networking/xdp-rx-metadata.rst | 36 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a

[PATCH bpf-next,v3 2/2] selftests/bpf: Enhance XDP Rx metadata handling

2025-07-02 Thread Song Yoong Siang
Introduce the XDP_METADATA_SIZE macro as a conservative measure to accommodate any metadata areas reserved by Ethernet devices. Signed-off-by: Song Yoong Siang --- tools/testing/selftests/bpf/prog_tests/xdp_metadata.c | 2 +- tools/testing/selftests/bpf/progs/xdp_hw_metadata.c | 2 +- tools

RE: [PATCH bpf-next 2/2] selftests/bpf: Enhance XDP Rx Metadata Handling

2025-07-02 Thread Song, Yoong Siang
On Thursday, July 3, 2025 12:04 AM, Stanislav Fomichev wrote: >On 07/02, Song, Yoong Siang wrote: >> On Wednesday, July 2, 2025 11:19 PM, Stanislav Fomichev > wrote: >> >On 07/02, Song, Yoong Siang wrote: >> >> On Wednesday, July 2, 2025 10:23 AM, Song,

RE: [PATCH bpf-next 2/2] selftests/bpf: Enhance XDP Rx Metadata Handling

2025-07-02 Thread Song, Yoong Siang
On Wednesday, July 2, 2025 11:19 PM, Stanislav Fomichev wrote: >On 07/02, Song, Yoong Siang wrote: >> On Wednesday, July 2, 2025 10:23 AM, Song, Yoong Siang > wrote: >> >On Wednesday, July 2, 2025 12:31 AM, Stanislav Fomichev > >> >wrote: >> >>On 07

[PATCH bpf-next,v2 1/2] doc: clarify XDP Rx metadata layout and bpf_xdp_adjust_meta usage

2025-07-01 Thread Song Yoong Siang
correctly allocate and access metadata in AF_XDP use cases. Signed-off-by: Song Yoong Siang --- Documentation/networking/xdp-rx-metadata.rst | 38 1 file changed, 38 insertions(+) diff --git a/Documentation/networking/xdp-rx-metadata.rst b/Documentation/networking/xdp-rx

[PATCH bpf-next,v2 2/2] selftests/bpf: Enhance XDP Rx Metadata Handling

2025-07-01 Thread Song Yoong Siang
a from the data pointer. This ensures the implementation remains functional even when there is device-reserved metadata, making the tests more portable across different NICs. Signed-off-by: Song Yoong Siang --- tools/testing/selftests/bpf/prog_tests/xdp_metadata.c | 2 +- tools/testing/selftes

[PATCH bpf-next,v2 0/2] Clarify and Enhance XDP Rx Metadata Handling

2025-07-01 Thread Song Yoong Siang
uff->data | | |<---sizeof(xdp_meta)--| V2: - unconditionally do bpf_xdp_adjust_meta with -XDP_METADATA_SIZE (Stanislav) V1: https://lore.kernel.org/netdev/20250701042940.3272325-1-yoong.siang.s...@intel.com/ Song Yoong Siang (2): doc: clarify XDP Rx meta

RE: [PATCH bpf-next 2/2] selftests/bpf: Enhance XDP Rx Metadata Handling

2025-07-01 Thread Song, Yoong Siang
On Wednesday, July 2, 2025 12:31 AM, Stanislav Fomichev wrote: >On 07/01, Song Yoong Siang wrote: >> Introduce the XDP_METADATA_SIZE macro to ensure that user applications can >> consistently retrieve the correct location of struct xdp_meta. >> >> Prior to this commi

[PATCH bpf-next 1/2] doc: clarify XDP Rx metadata layout and bpf_xdp_adjust_meta usage

2025-06-30 Thread Song Yoong Siang
correctly allocate and access metadata in AF_XDP use cases. Signed-off-by: Song Yoong Siang --- Documentation/networking/xdp-rx-metadata.rst | 38 1 file changed, 38 insertions(+) diff --git a/Documentation/networking/xdp-rx-metadata.rst b/Documentation/networking/xdp-rx

[PATCH bpf-next 0/2] Clarify and Enhance XDP Rx Metadata Handling

2025-06-30 Thread Song Yoong Siang
uff->data | | |<---sizeof(xdp_meta)--| Song Yoong Siang (2): doc: clarify XDP Rx metadata layout and bpf_xdp_adjust_meta usage selftests/bpf: Enhance XDP Rx Metadata Handling Documentation/networking/xdp-rx-metadata.rst | 38 +++ .../selftests

[PATCH bpf-next 2/2] selftests/bpf: Enhance XDP Rx Metadata Handling

2025-06-30 Thread Song Yoong Siang
a from the data pointer. This ensures the implementation remains functional even when there is device-reserved metadata, making the tests more portable across different NICs. Signed-off-by: Song Yoong Siang --- tools/testing/selftests/bpf/prog_tests/xdp_metadata.c | 2 +- tools/testing/selftes

RE: [PATCH bpf-next 2/2] selftests/bpf: Enhance XDP Rx Metadata Handling

2025-07-01 Thread Song, Yoong Siang
On Wednesday, July 2, 2025 10:23 AM, Song, Yoong Siang wrote: >On Wednesday, July 2, 2025 12:31 AM, Stanislav Fomichev >wrote: >>On 07/01, Song Yoong Siang wrote: >>> Introduce the XDP_METADATA_SIZE macro to ensure that user applications can >>> consistently re