Re: [PATCH RFC net-next v1 5/5] net: devmem: Implement TX path

2025-02-05 Thread Pavel Begunkov
On 2/5/25 20:22, Mina Almasry wrote: On Wed, Feb 5, 2025 at 4:41 AM Pavel Begunkov wrote: On 1/28/25 14:49, Willem de Bruijn wrote: +struct net_devmem_dmabuf_binding * +net_devmem_get_sockc_binding(struct sock *sk, struct sockcm_cookie *sockc) +{ + struct net_devmem_dmabuf_binding

Re: [PATCH RFC net-next v1 5/5] net: devmem: Implement TX path

2025-02-05 Thread Pavel Begunkov
On 2/5/25 22:16, Pavel Begunkov wrote: On 2/5/25 20:22, Mina Almasry wrote: On Wed, Feb 5, 2025 at 4:41 AM Pavel Begunkov wrote: On 1/28/25 14:49, Willem de Bruijn wrote: +struct net_devmem_dmabuf_binding * +net_devmem_get_sockc_binding(struct sock *sk, struct sockcm_cookie *sockc

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

2025-02-05 Thread Pavel Begunkov
err = PTR_ERR(binding); + binding = NULL; + goto out_err; + } + } -- Pavel Begunkov

Re: [PATCH RFC net-next v1 5/5] net: devmem: Implement TX path

2025-02-05 Thread Pavel Begunkov
orse if it works for a while but starts to unpredictably fail as time passes. With binding at least it'd fail fast if the setup is not done correctly. -- Pavel Begunkov

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

2025-02-12 Thread Pavel Begunkov
On 2/10/25 21:09, Mina Almasry wrote: On Wed, Feb 5, 2025 at 4:20 AM Pavel Begunkov wrote: On 2/3/25 22:39, Mina Almasry wrote: ... diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index bb2b751d274a..3ff8f568c382 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

2025-02-13 Thread Pavel Begunkov
On 2/12/25 19:18, Mina Almasry wrote: On Wed, Feb 12, 2025 at 7:52 AM Pavel Begunkov wrote: On 2/10/25 21:09, Mina Almasry wrote: On Wed, Feb 5, 2025 at 4:20 AM Pavel Begunkov wrote: On 2/3/25 22:39, Mina Almasry wrote: ... diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h

Re: [PATCH net-next v9 2/9] net: add get_netmem/put_netmem support

2025-04-22 Thread Pavel Begunkov
r can overwrite the memory with its secrets. Definitely iffy in security terms. -- Pavel Begunkov

Re: [PATCH net-next v9 1/9] netmem: add niov->type attribute to distinguish different net_iov types

2025-04-22 Thread Pavel Begunkov
isation / not unnecessary duplicating it, assuming we'll never have niovs of different types bound to the same struct net_iov_area. -- Pavel Begunkov

Re: [PATCH net-next v9 2/9] net: add get_netmem/put_netmem support

2025-04-22 Thread Pavel Begunkov
On 4/22/25 14:56, Mina Almasry wrote: On Tue, Apr 22, 2025 at 1:43 AM Pavel Begunkov wrote: On 4/18/25 00:15, Mina Almasry wrote: Currently net_iovs support only pp ref counts, and do not support a page ref equivalent. Makes me wonder why it's needed. In theory, nobody should ev

Re: [PATCH net-next v9 1/9] netmem: add niov->type attribute to distinguish different net_iov types

2025-04-22 Thread Pavel Begunkov
On 4/22/25 15:03, Mina Almasry wrote: On Tue, Apr 22, 2025 at 1:16 AM Pavel Begunkov wrote: On 4/18/25 00:15, Mina Almasry wrote: Later patches in the series adds TX net_iovs where there is no pp associated, so we can't rely on niov->pp->mp_ops to tell what is the type of

Re: [PATCH net-next v9 2/9] net: add get_netmem/put_netmem support

2025-04-23 Thread Pavel Begunkov
sticking into generic code. This patch adds a 3rd way to refcount a frag (after page refs and pp_ref_count), which is why it attracted attention. -- Pavel Begunkov

Re: [PATCH net-next v9 2/9] net: add get_netmem/put_netmem support

2025-04-22 Thread Pavel Begunkov
On 4/22/25 19:30, Mina Almasry wrote: On Tue, Apr 22, 2025 at 11:19 AM Pavel Begunkov wrote: On 4/22/25 14:56, Mina Almasry wrote: On Tue, Apr 22, 2025 at 1:43 AM Pavel Begunkov wrote: On 4/18/25 00:15, Mina Almasry wrote: Currently net_iovs support only pp ref counts, and do not support

Re: [PATCH net-next v9 2/9] net: add get_netmem/put_netmem support

2025-04-22 Thread Pavel Begunkov
On 4/22/25 20:47, Pavel Begunkov wrote: On 4/22/25 19:30, Mina Almasry wrote: On Tue, Apr 22, 2025 at 11:19 AM Pavel Begunkov wrote: On 4/22/25 14:56, Mina Almasry wrote: On Tue, Apr 22, 2025 at 1:43 AM Pavel Begunkov wrote: On 4/18/25 00:15, Mina Almasry wrote: Currently net_iovs

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

2025-02-19 Thread Pavel Begunkov
On 2/17/25 23:26, Mina Almasry wrote: On Thu, Feb 13, 2025 at 5:17 AM Pavel Begunkov wrote: ... It's asserting that sizeof(ubuf_info_msgzc) <= sizeof(skb->cb), and I'm guessing increasing skb->cb size is not really the way to go. What I may be able to do here is stash th

Re: [PATCH net-next v3 5/6] net: devmem: Implement TX path

2025-02-20 Thread Pavel Begunkov
On 2/20/25 01:46, Mina Almasry wrote: On Wed, Feb 19, 2025 at 2:40 PM Pavel Begunkov wrote: On 2/17/25 23:26, Mina Almasry wrote: On Thu, Feb 13, 2025 at 5:17 AM Pavel Begunkov wrote: ... It's asserting that sizeof(ubuf_info_msgzc) <= sizeof(skb->cb), and I'm guessing in