Re: [PATCH v5 4/5] KVM: selftests: Add test for PSCI SYSTEM_OFF2

2024-10-15 Thread Oliver Upton
On Sat, Oct 12, 2024 at 10:28:10AM +0100, David Woodhouse wrote: > On Tue, 2024-10-01 at 08:33 -0700, Oliver Upton wrote: > > On Thu, Sep 26, 2024 at 07:37:59PM +0100, David Woodhouse wrote: > > > +   vm = setup_vm(guest_test_system_off2, &source, &target); > &g

Re: [PATCH v5 4/5] KVM: selftests: Add test for PSCI SYSTEM_OFF2

2024-10-15 Thread Oliver Upton
On Tue, Oct 15, 2024 at 09:05:18AM -0700, Oliver Upton wrote: > On Sat, Oct 12, 2024 at 10:28:10AM +0100, David Woodhouse wrote: > > On Tue, 2024-10-01 at 08:33 -0700, Oliver Upton wrote: > > > On Thu, Sep 26, 2024 at 07:37:59PM +0100, David Woodhouse wrote: > > &

Re: [PATCH v6 6/6] arm64: Use SYSTEM_OFF2 PSCI call to power off for hibernate

2024-10-24 Thread Oliver Upton
On Thu, Oct 24, 2024 at 05:56:09PM +0200, David Woodhouse wrote: > On 24 October 2024 17:44:49 CEST, Oliver Upton wrote: > >IIUC, you're really wanting to 0x0 because there are hypervisors out > >there that violate the final spec and *only* accept this value. > > >

Re: [PATCH v6 6/6] arm64: Use SYSTEM_OFF2 PSCI call to power off for hibernate

2024-10-24 Thread Oliver Upton
Hi, On Thu, Oct 24, 2024 at 03:48:26PM +0200, David Woodhouse wrote: > On 24 October 2024 14:54:41 CEST, Miguel Luis wrote: > >Perhaps spec. F.b. could be accommodated by first invoking SYSTEM_OFF2 with > >PSCI_1_3_OFF_TYPE_HIBERNATE_OFF and checking its return value in case of a > >fallback to a

Re: (subset) [PATCH v6 0/6] Add PSCI v1.3 SYSTEM_OFF2 support for hibernation

2024-10-31 Thread Oliver Upton
On Sat, 19 Oct 2024 18:15:41 +0100, David Woodhouse wrote: > The PSCI v1.3 spec (https://developer.arm.com/documentation/den0022) > adds support for a SYSTEM_OFF2 function enabling a HIBERNATE_OFF state > which is analogous to ACPI S4. This will allow hosting environments to > determine that a gues

Re: [PATCH v5 4/5] KVM: selftests: Add test for PSCI SYSTEM_OFF2

2024-10-01 Thread Oliver Upton
On Thu, Sep 26, 2024 at 07:37:59PM +0100, David Woodhouse wrote: > +static void guest_test_system_off2(void) > +{ > + uint64_t ret; > + > + /* assert that SYSTEM_OFF2 is discoverable */ > + GUEST_ASSERT(psci_features(PSCI_1_3_FN_SYSTEM_OFF2) & > + BIT(PSCI_1_3_HIBERNATE

Re: [PATCH v5 2/5] KVM: arm64: Add PSCI v1.3 SYSTEM_OFF2 function for hibernation

2024-10-01 Thread Oliver Upton
Hi David, On Thu, Sep 26, 2024 at 07:37:57PM +0100, David Woodhouse wrote: > @@ -392,6 +403,32 @@ static int kvm_psci_1_x_call(struct kvm_vcpu *vcpu, u32 > minor) > break; > } > break; > + case PSCI_1_3_FN_SYSTEM_OFF2: > + kvm_psci

Re: [PATCH v5 3/5] KVM: arm64: Add support for PSCI v1.2 and v1.3

2024-10-01 Thread Oliver Upton
On Thu, Sep 26, 2024 at 07:37:58PM +0100, David Woodhouse wrote: > From: David Woodhouse Please, add changelogs to your patches. What we really need here is the detail on *why* we can just bump the PSCI version like this, i.e. no new required ABI. On top of that, you could mention that KVM has m

Re: [PATCH v6 6/6] arm64: Use SYSTEM_OFF2 PSCI call to power off for hibernate

2024-10-25 Thread Oliver Upton
On Fri, Oct 25, 2024 at 08:13:03AM +0200, David Woodhouse wrote: > On 24 October 2024 21:57:38 CEST, Oliver Upton wrote: > >On Thu, Oct 24, 2024 at 05:56:09PM +0200, David Woodhouse wrote: > >> On 24 October 2024 17:44:49 CEST, Oliver Upton > >> wrote: > >>

Re: (subset) [PATCH v6 0/6] Add PSCI v1.3 SYSTEM_OFF2 support for hibernation

2024-10-25 Thread Oliver Upton
On Sat, 19 Oct 2024 18:15:41 +0100, David Woodhouse wrote: > The PSCI v1.3 spec (https://developer.arm.com/documentation/den0022) > adds support for a SYSTEM_OFF2 function enabling a HIBERNATE_OFF state > which is analogous to ACPI S4. This will allow hosting environments to > determine that a gues