Re: [PATCH v2] Document /proc/pid PID reuse behavior

2018-11-07 Thread Michal Hocko
On Wed 07-11-18 16:10:01, Daniel Colascione wrote: > On Wed, Nov 7, 2018 at 4:00 PM, Michal Hocko wrote: [...] > > If you really do care about pid space depletion then you > > should use pid cgroup controller. > > Or that, sure. But since cgroups are optional, the problem

Re: [PATCH v2] Document /proc/pid PID reuse behavior

2018-11-08 Thread Michal Hocko
On Wed 07-11-18 18:04:59, Martin Steigerwald wrote: > Michal Hocko - 07.11.18, 17:00: > > > > otherwise anybody could simply DoS the system > > > > by consuming all available pids. > > > > > > People can do that today using the instrument of terror

Re: [PATCH v2] procfs: expose umask in /proc//status

2016-04-15 Thread Michal Hocko
ask_numa_group_id(p); > cred = get_task_cred(p); > > + umask = get_task_umask(p); > + if (umask >= 0) > + seq_printf(m, "Umask:\t%#04o\n", umask); > + > task_lock(p); > if (p->files) > max_fds = files_fdtable(p->files)->max_fds; > -- > 2.7.4 -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Documentation/memcg: remove restriction of setting kmem limit

2016-05-05 Thread Michal Hocko
y default even in the cgroup v1 - see b313aeee2509 ("mm: memcontrol: enable kmem accounting for all cgroups in the legacy hierarchy"). So this _whole_ paragraph could see some update. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-d

Re: [PATCH] Documentation/memcg: update kmem limit doc as codes behavior

2016-05-10 Thread Michal Hocko
ot;). > > Update docs accordingly. I am pretty sure there will be other things out of date in that file but this is an improvemtn already. > Signed-off-by: Qiang Huang Acked-by: Michal Hocko Thanks! > --- > Documentation/cgroup-v1/memory.txt | 14 +++--- > 1 fil

Re: [PATCH 0037/1529] Fix typo

2016-05-22 Thread Michal Hocko
Private_Hugetlb" show the amounts of memory backed by > hugetlbfs page which is *not* counted in "RSS" or "PSS" field for historical > reasons. And these are not included in {Shared,Private}_{Clean,Dirty} field. > "Swap" shows how much would-be-anonymous memor

Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

2016-06-16 Thread Michal Hocko
ustified. struct page layout as some others that such a tool might depend on has changes several times in the past so I fail to see how is it any different this time. struct page is nothing the userspace should depend on. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

2016-06-16 Thread Michal Hocko
On Thu 16-06-16 13:22:27, Vitaly Kuznetsov wrote: > Michal Hocko writes: > > > On Thu 16-06-16 12:30:16, Vitaly Kuznetsov wrote: > >> Christoph Hellwig writes: > >> > >> > On Thu, Jun 16, 2016 at 11:22:46AM +0200, Vitaly Kuznetsov wrote: &g

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-14 Thread Michal Hocko
1 + > fs/proc/internal.h | 3 + > fs/proc/task_mmu.c | 134 > +++++++++ > 4 files changed, 160 insertions(+), 1 deletion(-) > > -- > 2.7.4 > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: sen

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-15 Thread Michal Hocko
On Mon 15-08-16 09:00:04, Robert Foss wrote: > > > On 2016-08-14 05:04 AM, Michal Hocko wrote: > > On Fri 12-08-16 18:04:19, robert.f...@collabora.com wrote: > > > From: Robert Foss > > > > > > This series implements /proc/PID/totmaps, a tool for ret

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-16 Thread Michal Hocko
On Mon 15-08-16 12:25:10, Robert Foss wrote: > > > On 2016-08-15 09:42 AM, Michal Hocko wrote: [...] > > The use case is to speed up monitoring of > > memory consumption in environments where RSS isn't precise. > > > > For example Chrome tends to many

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-17 Thread Michal Hocko
not all that time consuming wrt. smaps handling. That being said I am still very skeptical about a dedicated proc file which accomplishes what userspace can done in a trivial way. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-17 Thread Michal Hocko
On Wed 17-08-16 11:31:25, Jann Horn wrote: > On Wed, Aug 17, 2016 at 10:22:00AM +0200, Michal Hocko wrote: > > On Tue 16-08-16 12:46:51, Robert Foss wrote: > > [...] > > > $ /usr/bin/time -v -p zsh -c "repeat 25 { awk '/^Rss/{rss+=\$2} > > > /^Pss/{pss

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-18 Thread Michal Hocko
On Wed 17-08-16 11:57:56, Sonny Rao wrote: > On Wed, Aug 17, 2016 at 6:03 AM, Michal Hocko wrote: > > On Wed 17-08-16 11:31:25, Jann Horn wrote: [...] > >> That's at least 30.43% + 9.12% + 7.66% = 47.21% of the task's kernel > >> time spent on evaluat

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-18 Thread Michal Hocko
On Thu 18-08-16 10:47:57, Sonny Rao wrote: > On Thu, Aug 18, 2016 at 12:44 AM, Michal Hocko wrote: > > On Wed 17-08-16 11:57:56, Sonny Rao wrote: [...] > >> 2) User space OOM handling -- we'd rather do a more graceful shutdown > >> than let the kernel's OOM ki

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-19 Thread Michal Hocko
On Thu 18-08-16 23:43:39, Sonny Rao wrote: > On Thu, Aug 18, 2016 at 11:01 AM, Michal Hocko wrote: > > On Thu 18-08-16 10:47:57, Sonny Rao wrote: > >> On Thu, Aug 18, 2016 at 12:44 AM, Michal Hocko wrote: > >> > On Wed 17-08-16 11:57:56, Sonny Rao wrote: >

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-19 Thread Michal Hocko
On Fri 19-08-16 11:26:34, Minchan Kim wrote: > Hi Michal, > > On Thu, Aug 18, 2016 at 08:01:04PM +0200, Michal Hocko wrote: > > On Thu 18-08-16 10:47:57, Sonny Rao wrote: > > > On Thu, Aug 18, 2016 at 12:44 AM, Michal Hocko wrote: > > > > On We

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-22 Thread Michal Hocko
ue that > > we want to address it in a generic way as much as possible. > > Sure. What solution do you think as generic way? either optimize seq_printf or replace it with something faster. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubsc

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-22 Thread Michal Hocko
On Fri 19-08-16 10:57:48, Sonny Rao wrote: > On Fri, Aug 19, 2016 at 12:59 AM, Michal Hocko wrote: > > On Thu 18-08-16 23:43:39, Sonny Rao wrote: > >> On Thu, Aug 18, 2016 at 11:01 AM, Michal Hocko wrote: > >> > On Thu 18-08-16 10:47:57, Sonny Rao wrote: > >&

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-22 Thread Michal Hocko
On Mon 22-08-16 23:12:41, Minchan Kim wrote: > On Mon, Aug 22, 2016 at 09:40:52AM +0200, Michal Hocko wrote: > > On Mon 22-08-16 09:07:45, Minchan Kim wrote: > > [...] > > > #!/bin/sh > > > ./smap_test & > > > pid=$! > > > > > > for

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-22 Thread Michal Hocko
On Mon 22-08-16 18:45:54, Michal Hocko wrote: [...] > I have no idea why those numbers are so different on my laptop > yet. It surely looks suspicious. I will try to debug this further > tomorrow. Hmm, so I've tried to use my version of awk on other machine and vice versa and it d

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-22 Thread Michal Hocko
On Mon 22-08-16 19:29:36, Michal Hocko wrote: > On Mon 22-08-16 18:45:54, Michal Hocko wrote: > [...] > > I have no idea why those numbers are so different on my laptop > > yet. It surely looks suspicious. I will try to debug this further > > tomorrow. > > Hmm, so I

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-23 Thread Michal Hocko
On Mon 22-08-16 19:47:09, Michal Hocko wrote: > On Mon 22-08-16 19:29:36, Michal Hocko wrote: > > On Mon 22-08-16 18:45:54, Michal Hocko wrote: > > [...] > > > I have no idea why those numbers are so different on my laptop > > > yet. It surely looks suspicious.

utime accounting regression since 4.6 (was: Re: [PACTH v2 0/3] Implement /proc//totmaps)

2016-08-23 Thread Michal Hocko
On Tue 23-08-16 10:26:03, Michal Hocko wrote: > On Mon 22-08-16 19:47:09, Michal Hocko wrote: > > On Mon 22-08-16 19:29:36, Michal Hocko wrote: > > > On Mon 22-08-16 18:45:54, Michal Hocko wrote: > > > [...] > > > > I have no idea why those numbers are so

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-29 Thread Michal Hocko
[Sorry for a late reply, I was busy with other stuff] On Mon 22-08-16 15:44:53, Sonny Rao wrote: > On Mon, Aug 22, 2016 at 12:54 AM, Michal Hocko wrote: [...] > But what about the private_clean and private_dirty? Surely > those are more generally useful for calculating a lower

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-30 Thread Michal Hocko
On Mon 29-08-16 16:37:04, Michal Hocko wrote: > [Sorry for a late reply, I was busy with other stuff] > > On Mon 22-08-16 15:44:53, Sonny Rao wrote: > > On Mon, Aug 22, 2016 at 12:54 AM, Michal Hocko wrote: > [...] > > But what about the private_clean and private_dirt

Re: [PACTH v2 0/3] Implement /proc//totmaps

2016-08-30 Thread Michal Hocko
7;t heard any sound arguments so far. Everything was just "we know what we are doing in our environment so we know those resouces and therefore those numbers make sense to us". But with all due respect this is not a reason to add a user visible API into the kernel. -- Michal Hocko SUSE L

Re: [PATCH v5 0/3] mm, proc: Implement /proc//totmaps

2016-09-12 Thread Michal Hocko
the value can be more misleading than helpful. So a NACK from me until I am shown that this is usable in general and still helpful. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 0/3] mm, proc: Implement /proc//totmaps

2016-09-12 Thread Michal Hocko
On Mon 12-09-16 08:31:36, Sonny Rao wrote: > On Mon, Sep 12, 2016 at 5:02 AM, Michal Hocko wrote: > > On Mon 05-09-16 16:14:06, robert.f...@collabora.com wrote: > >> From: Robert Foss > >> > >> This series provides the /proc/PID/totmaps feature, which > &g

Re: [PATCH v5 0/3] mm, proc: Implement /proc//totmaps

2016-09-13 Thread Michal Hocko
On Mon 12-09-16 10:28:53, Sonny Rao wrote: > On Mon, Sep 12, 2016 at 10:15 AM, Michal Hocko wrote: > > On Mon 12-09-16 08:31:36, Sonny Rao wrote: [...] > >> but how about the other fields like Swap, Private_Dirty and > >> Private_Shared? > > > > Private

Re: [PATCH v5 0/3] mm, proc: Implement /proc//totmaps

2016-09-14 Thread Michal Hocko
On Tue 13-09-16 13:27:39, Sonny Rao wrote: > On Tue, Sep 13, 2016 at 12:12 AM, Michal Hocko wrote: > > On Mon 12-09-16 10:28:53, Sonny Rao wrote: > >> On Mon, Sep 12, 2016 at 10:15 AM, Michal Hocko wrote: > >> > On Mon 12-09-16 08:31:36, Sonny Rao wrote: > > [

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-18 Thread Michal Hocko
this scarce resource is used. I really do not think users will know how/why to setup this and I wouldn't even bother them thinking about that at all TBH. This is an implementation detail. It is fine to reuse unused flags space as a storage as a performance optimization but why do you want user

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-18 Thread Michal Hocko
On Fri 18-10-24 09:04:24, Suren Baghdasaryan wrote: > On Fri, Oct 18, 2024 at 6:03 AM Michal Hocko wrote: > > > > On Tue 15-10-24 08:58:59, Suren Baghdasaryan wrote: > > > On Tue, Oct 15, 2024 at 8:42 AM David Hildenbrand > > > wrote: > > [...] > &

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Michal Hocko
On Mon 21-10-24 09:16:14, Suren Baghdasaryan wrote: > On Mon, Oct 21, 2024 at 8:57 AM Michal Hocko wrote: > > > > On Mon 21-10-24 08:41:00, Suren Baghdasaryan wrote: > > > On Mon, Oct 21, 2024 at 8:34 AM Michal Hocko wrote: > > > > > > > > On

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Michal Hocko
On Mon 21-10-24 08:41:00, Suren Baghdasaryan wrote: > On Mon, Oct 21, 2024 at 8:34 AM Michal Hocko wrote: > > > > On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: > > [...] > > > Yeah, I thought about adding new values to "mem_profiling" but it's a

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Michal Hocko
On Fri 18-10-24 10:45:39, Suren Baghdasaryan wrote: > On Fri, Oct 18, 2024 at 10:08 AM Michal Hocko wrote: > > > > On Fri 18-10-24 09:04:24, Suren Baghdasaryan wrote: > > > On Fri, Oct 18, 2024 at 6:03 AM Michal Hocko wrote: > > > > > > > > On

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Michal Hocko
On Fri 18-10-24 14:57:26, Suren Baghdasaryan wrote: > On Fri, Oct 18, 2024 at 10:45 AM Suren Baghdasaryan wrote: > > > > On Fri, Oct 18, 2024 at 10:08 AM Michal Hocko wrote: > > > > > > On Fri 18-10-24 09:04:24, Suren Baghdasaryan wrote: > > > >

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Michal Hocko
}[,$YOUR_OPTIONS] While $YOUR_OPTIONS could be compress,fallback,ponies and it would apply or just be ignored if that is not applicable. -- Michal Hocko SUSE Labs

Re: [PATCH 0/4] Add agent coding assistant configuration to Linux kernel

2025-08-04 Thread Michal Hocko
the : project. Additionally, the contributor should provide notice and : attribution of such third party rights, along with information about the : applicable license terms, with their contribution. Is that my responsibility? -- Michal Hocko SUSE Labs

Re: [PATCH 0/4] Add agent coding assistant configuration to Linux kernel

2025-08-04 Thread Michal Hocko
On Mon 04-08-25 11:23:22, Michal Hocko wrote: > On Mon 28-07-25 09:05:37, Sasha Levin wrote: > > On Mon, Jul 28, 2025 at 12:47:55PM +0200, David Hildenbrand wrote: > > > We cannot keep complaining about maintainer overload and, at the same > > > time, encourage people t

<    1   2   3