RE: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

2024-10-31 Thread Kiyanovski, Arthur
> -Original Message- > From: Caleb Sander Mateos > Sent: Wednesday, October 30, 2024 5:23 PM > > net_dim() is currently passed a struct dim_sample argument by value. > struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64 passes > it > on the stack. All callers have alrea

RE: [resend PATCH 1/2] dim: make dim_calc_stats() inputs const pointers

2024-10-31 Thread Kiyanovski, Arthur
On 10/30/24 17:23, Caleb Sander Mateos wrote: > Make the start and end arguments to dim_calc_stats() const pointers to > clarify that the function does not modify their values. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Arthur Kiyanovski Thanks, Arthur