On 2019/1/3 上午4:57, Michael S. Tsirkin wrote:
It's not uncommon to have two access two unrelated memory locations in a
specific order. At the moment one has to use a memory barrier for this.
However, if the first access was a read and the second used an address
depending on the first one we w
On 2019/1/7 下午12:23, Michael S. Tsirkin wrote:
On Mon, Jan 07, 2019 at 11:58:23AM +0800, Jason Wang wrote:
On 2019/1/3 上午4:57, Michael S. Tsirkin wrote:
It's not uncommon to have two access two unrelated memory locations in a
specific order. At the moment one has to use a memory barrie
On Tue, Oct 8, 2024 at 2:55 PM Akihiko Odaki wrote:
>
> RSS is a receive steering algorithm that can be negotiated to use with
> virtio_net. Conventionally the hash calculation was done by the VMM.
> However, computing the hash after the queue was chosen defeats the
> purpose of RSS.
>
> Another a
On Tue, Oct 8, 2024 at 2:55 PM Akihiko Odaki wrote:
>
> tun used to simply advance iov_iter when it needs to pad virtio header,
> which leaves the garbage in the buffer as is. This is especially
> problematic when tun starts to allow enabling the hash reporting
> feature; even if the feature is en
On Tue, Oct 8, 2024 at 2:55 PM Akihiko Odaki wrote:
>
> Allow the guest to reuse the hash value to make receive steering
> consistent between the host and guest, and to save hash computation.
>
> Signed-off-by: Akihiko Odaki
I wonder if this would cause overhead when hash reporting is not enable
On Sat, Oct 12, 2024 at 6:29 PM Akihiko Odaki wrote:
>
> On 2024/10/09 17:14, Jason Wang wrote:
> > On Tue, Oct 8, 2024 at 2:55 PM Akihiko Odaki
> > wrote:
> >>
> >> RSS is a receive steering algorithm that can be negotiated to use with
> >> virtio
On Tue, Sep 24, 2024 at 5:01 PM Akihiko Odaki wrote:
>
> RSS is a receive steering algorithm that can be negotiated to use with
> virtio_net. Conventionally the hash calculation was done by the VMM.
> However, computing the hash after the queue was chosen defeats the
> purpose of RSS.
>
> Another
On Tue, Sep 24, 2024 at 5:01 PM Akihiko Odaki wrote:
>
> virtio-net have two usage of hashes: one is RSS and another is hash
> reporting. Conventionally the hash calculation was done by the VMM.
> However, computing the hash after the queue was chosen defeats the
> purpose of RSS.
>
> Another appr
On Fri, Sep 27, 2024 at 10:11 AM Akihiko Odaki wrote:
>
> On 2024/09/25 12:30, Jason Wang wrote:
> > On Tue, Sep 24, 2024 at 5:01 PM Akihiko Odaki
> > wrote:
> >>
> >> virtio-net have two usage of hashes: one is RSS and another is hash
> >> repor
On Fri, Sep 27, 2024 at 3:51 PM Akihiko Odaki wrote:
>
> On 2024/09/27 13:31, Jason Wang wrote:
> > On Fri, Sep 27, 2024 at 10:11 AM Akihiko Odaki
> > wrote:
> >>
> >> On 2024/09/25 12:30, Jason Wang wrote:
> >>> On Tue, Sep 24, 2024 at 5:01 PM A
On Thu, Jan 9, 2025 at 2:59 PM Akihiko Odaki wrote:
>
> The specification says the device MUST set num_buffers to 1 if
> VIRTIO_NET_F_MRG_RXBUF has not been negotiated.
Have we agreed on how to fix the spec or not?
As I replied in the spec patch, if we just remove this "MUST", it
looks like we a
On Thu, Jan 9, 2025 at 2:59 PM Akihiko Odaki wrote:
>
> tun used to simply advance iov_iter when it needs to pad virtio header,
> which leaves the garbage in the buffer as is. This is especially
> problematic when tun starts to allow enabling the hash reporting
> feature; even if the feature is en
On Thu, Jan 9, 2025 at 2:59 PM Akihiko Odaki wrote:
>
> Both tun and tap exposes the same set of virtio-net-related features.
> Unify their implementations to ease future changes.
>
> Signed-off-by: Akihiko Odaki
> ---
> MAINTAINERS| 1 +
> drivers/net/Kconfig| 5 ++
> driver
On Fri, Jan 17, 2025 at 6:35 PM Akihiko Odaki wrote:
>
> On 2025/01/17 18:23, Willem de Bruijn wrote:
> > Akihiko Odaki wrote:
> >> tun and tap implements the same vnet-related features so reuse the code.
> >>
> >> Signed-off-by: Akihiko Odaki
> >> ---
> >> drivers/net/Kconfig| 1 +
> >>
On Thu, Jan 16, 2025 at 1:30 PM Akihiko Odaki wrote:
>
> On 2025/01/16 10:06, Jason Wang wrote:
> > On Wed, Jan 15, 2025 at 1:07 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/01/13 12:04, Jason Wang wrote:
> >>> On Fri, Jan 10, 2025 at 7:12 PM Ak
On Fri, Jan 10, 2025 at 7:12 PM Akihiko Odaki wrote:
>
> On 2025/01/10 19:23, Michael S. Tsirkin wrote:
> > On Fri, Jan 10, 2025 at 11:27:13AM +0800, Jason Wang wrote:
> >> On Thu, Jan 9, 2025 at 2:59 PM Akihiko Odaki
> >> wrote:
> >>>
> &
On Wed, Jan 15, 2025 at 1:07 PM Akihiko Odaki wrote:
>
> On 2025/01/13 12:04, Jason Wang wrote:
> > On Fri, Jan 10, 2025 at 7:12 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/01/10 19:23, Michael S. Tsirkin wrote:
> >>> On Fri, Jan 10, 2025 at 1
On Sat, Feb 15, 2025 at 1:25 PM Akihiko Odaki wrote:
>
> On 2025/02/14 0:43, Michael S. Tsirkin wrote:
> > On Thu, Feb 13, 2025 at 06:23:55PM +0900, Akihiko Odaki wrote:
> >> On 2025/02/13 16:18, Michael S. Tsirkin wrote:
> >>>
> >>> Commit log needs some work.
> >>>
> >>> So my understanding is,
On Thu, Feb 20, 2025 at 4:45 PM Michael S. Tsirkin wrote:
>
> On Thu, Feb 20, 2025 at 08:58:38AM +0100, Paolo Abeni wrote:
> > Hi,
> >
> > On 2/15/25 7:04 AM, Akihiko Odaki wrote:
> > > tun simply advances iov_iter when it needs to pad virtio header,
> > > which leaves the garbage in the buffer as
On Fri, Feb 28, 2025 at 3:59 PM Akihiko Odaki wrote:
>
> Hash reporting
> --
>
> Allow the guest to reuse the hash value to make receive steering
> consistent between the host and guest, and to save hash computation.
>
> RSS
> ---
>
> RSS is a receive steering algorithm that can be neg
On Mon, Mar 10, 2025 at 3:04 PM Akihiko Odaki wrote:
>
> On 2025/03/10 13:43, Jason Wang wrote:
> > On Fri, Mar 7, 2025 at 7:02 PM Akihiko Odaki
> > wrote:
> >>
> >> VIRTIO_NET_F_HASH_REPORT allows to report hash values calculated on the
> >> host
On Mon, Mar 10, 2025 at 3:45 PM Akihiko Odaki wrote:
>
> On 2025/03/10 12:55, Jason Wang wrote:
> > On Fri, Mar 7, 2025 at 7:01 PM Akihiko Odaki
> > wrote:
> >>
> >> Hash reporting
> >> ==
> >>
> >> Allow the guest t
On Mon, Mar 10, 2025 at 2:53 PM Akihiko Odaki wrote:
>
> On 2025/03/10 12:55, Jason Wang wrote:
> > On Fri, Mar 7, 2025 at 7:01 PM Akihiko Odaki
> > wrote:
> >>
> >> They are useful to implement VIRTIO_NET_F_RSS and
> >> VIRTIO_NET_F_HASH_R
On Mon, Mar 10, 2025 at 3:59 PM Akihiko Odaki wrote:
>
> On 2025/03/10 12:55, Jason Wang wrote:
> > On Fri, Mar 7, 2025 at 7:01 PM Akihiko Odaki
> > wrote:
> >>
> >> Hash reporting
> >> ==
> >>
> >> Allow the guest t
On Fri, Mar 7, 2025 at 7:02 PM Akihiko Odaki wrote:
>
> VIRTIO_NET_F_HASH_REPORT allows to report hash values calculated on the
> host. When VHOST_NET_F_VIRTIO_NET_HDR is employed, it will report no
> hash values (i.e., the hash_report member is always set to
> VIRTIO_NET_HASH_REPORT_NONE). Otherw
On Fri, Mar 7, 2025 at 7:01 PM Akihiko Odaki wrote:
>
> They are useful to implement VIRTIO_NET_F_RSS and
> VIRTIO_NET_F_HASH_REPORT.
>
> Signed-off-by: Akihiko Odaki
> Tested-by: Lei Yang
> ---
> include/linux/virtio_net.h | 188
> +
> 1 file change
On Fri, Mar 7, 2025 at 7:01 PM Akihiko Odaki wrote:
>
> Hash reporting
> ==
>
> Allow the guest to reuse the hash value to make receive steering
> consistent between the host and guest, and to save hash computation.
>
> RSS
> ===
>
> RSS is a receive steering algorithm that can be nego
On Mon, Mar 10, 2025 at 11:55 AM Jason Wang wrote:
>
> On Fri, Mar 7, 2025 at 7:01 PM Akihiko Odaki wrote:
> >
> > Hash reporting
> > ==
> >
> > Allow the guest to reuse the hash value to make receive steering
> > consistent between the ho
On Fri, Mar 7, 2025 at 7:02 PM Akihiko Odaki wrote:
>
> The added tests confirm tun can perform RSS and hash reporting, and
> reject invalid configurations for them.
Let's be more verbose here. E.g what's the network topology used here.
>
> Signed-off-by: Akihiko Odaki
> Tested-by: Lei Yang
>
On Tue, Mar 11, 2025 at 2:11 PM Akihiko Odaki wrote:
>
> On 2025/03/11 9:38, Jason Wang wrote:
> > On Mon, Mar 10, 2025 at 3:45 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/10 12:55, Jason Wang wrote:
> >>> On Fri, Mar 7, 2025 at 7:01 PM
On Tue, Mar 11, 2025 at 2:17 PM Akihiko Odaki wrote:
>
> On 2025/03/11 9:38, Jason Wang wrote:
> > On Mon, Mar 10, 2025 at 3:45 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/10 12:55, Jason Wang wrote:
> >>> On Fri, Mar 7, 2025 at 7:01 PM
On Tue, Mar 11, 2025 at 2:24 PM Akihiko Odaki wrote:
>
> On 2025/03/11 9:42, Jason Wang wrote:
> > On Mon, Mar 10, 2025 at 3:04 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/10 13:43, Jason Wang wrote:
> >>> On Fri, Ma
On Wed, Mar 12, 2025 at 1:03 PM Akihiko Odaki wrote:
>
> On 2025/03/12 11:35, Jason Wang wrote:
> > On Tue, Mar 11, 2025 at 2:11 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/11 9:38, Jason Wang wrote:
> >>> On Mon, Mar 10, 2025 at 3:45 PM Ak
On Wed, Mar 12, 2025 at 1:55 PM Akihiko Odaki wrote:
>
> On 2025/03/12 11:59, Jason Wang wrote:
> > On Tue, Mar 11, 2025 at 2:17 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/11 9:38, Jason Wang wrote:
> >>> On Mon, Mar 10, 2025 at 3:45 PM Ak
On Wed, Mar 12, 2025 at 1:59 PM Akihiko Odaki wrote:
>
> On 2025/03/12 12:36, Jason Wang wrote:
> > On Tue, Mar 11, 2025 at 2:24 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/11 9:42, Jason Wang wrote:
> >>> On Mon, Mar 10, 2025 at 3:04 PM Ak
On Tue, Mar 11, 2025 at 1:49 PM Akihiko Odaki wrote:
>
> On 2025/03/11 9:47, Jason Wang wrote:
> > On Mon, Mar 10, 2025 at 2:53 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/10 12:55, Jason Wang wrote:
> >>> On Fri, Mar 7, 2025 at 7:01 PM Aki
On Thu, Mar 13, 2025 at 3:01 PM Akihiko Odaki wrote:
>
> This clarifies a steering eBPF program takes precedence over the other
> steering algorithms.
>
> Signed-off-by: Akihiko Odaki
> ---
I think we should elaborate more on the advantages of *not* making
this implicit.
Or what's the advantage
On Mon, Mar 17, 2025 at 3:07 PM Akihiko Odaki wrote:
>
> On 2025/03/17 10:12, Jason Wang wrote:
> > On Wed, Mar 12, 2025 at 1:03 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/12 11:35, Jason Wang wrote:
> >>> On Tue, Mar 11, 2025 at 2:11 PM Ak
On Mon, Mar 17, 2025 at 6:58 PM Akihiko Odaki wrote:
>
> virtio-net have two usage of hashes: one is RSS and another is hash
> reporting. Conventionally the hash calculation was done by the VMM.
> However, computing the hash after the queue was chosen defeats the
> purpose of RSS.
>
> Another appr
On Tue, Mar 18, 2025 at 6:10 PM Akihiko Odaki wrote:
>
> On 2025/03/18 9:15, Jason Wang wrote:
> > On Mon, Mar 17, 2025 at 3:07 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/17 10:12, Jason Wang wrote:
> >>> On Wed, Mar 12, 2025 at 1:03 PM Ak
On Wed, Mar 19, 2025 at 1:29 PM Akihiko Odaki wrote:
>
> On 2025/03/19 9:58, Jason Wang wrote:
> > On Tue, Mar 18, 2025 at 6:10 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/18 9:15, Jason Wang wrote:
> >>> On Mon, Mar 17, 2025 at 3:07 PM Akihi
On Thu, Mar 20, 2025 at 1:33 PM Akihiko Odaki wrote:
>
> On 2025/03/20 10:31, Jason Wang wrote:
> > On Wed, Mar 19, 2025 at 1:29 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/19 9:58, Jason Wang wrote:
> >>> On Tue, Mar 18, 2025 at 6:10 PM Ak
On Fri, Mar 21, 2025 at 1:57 PM Akihiko Odaki wrote:
>
> On 2025/03/21 10:13, Jason Wang wrote:
> > On Thu, Mar 20, 2025 at 1:33 PM Akihiko Odaki
> > wrote:
> >>
> >> On 2025/03/20 10:31, Jason Wang wrote:
> >>> On Wed, Mar 19, 2025 at 1:29 PM Ak
43 matches
Mail list logo
