Re: [RFC PATCH 00/14] Prevent cross-cache attacks in the SLUB allocator

2023-09-18 Thread Ingo Molnar
* Matteo Rizzo wrote: > On Fri, 15 Sept 2023 at 18:30, Lameter, Christopher > wrote: > > > > On Fri, 15 Sep 2023, Dave Hansen wrote: > > > > > What's the cost? > > > > The only thing that I see is 1-2% on kernel compilations (and "more on > > machines with lots of cores")? > > I used kernel c

Re: [RFC PATCH 00/14] Prevent cross-cache attacks in the SLUB allocator

2023-09-20 Thread Ingo Molnar
* Matteo Rizzo wrote: > On Mon, 18 Sept 2023 at 19:39, Ingo Molnar wrote: > > > > What's the split of the increase in overhead due to SLAB_VIRTUAL=y, between > > user-space execution and kernel-space execution? > > > > Same benchmark as before (comp

Re: [PATCH] doc:lock: remove reference to clever use of read-write lock

2019-09-02 Thread Ingo Molnar
* Federico Vaga wrote: > On Saturday, August 31, 2019 4:43:44 PM CEST Jonathan Corbet wrote: > > On Sat, 31 Aug 2019 15:41:16 +0200 > > > > Federico Vaga wrote: > > > several CPU's and you want to use spinlocks you can potentially use > > > > > > -cheaper versions of the spinlocks. IFF you

Re: [PATCH 0/6] Address issues with SPDX requirements and PEP-263

2019-09-09 Thread Ingo Molnar
* Thomas Gleixner wrote: > On Sun, 8 Sep 2019, Matthew Wilcox wrote: > > On Sat, Sep 07, 2019 at 11:17:22PM +0200, Thomas Gleixner wrote: > > > On Sat, 7 Sep 2019, Markus Heiser wrote: > > > > Am 07.09.19 um 20:04 schrieb Mauro Carvalho Chehab: > > > > > No idea. I would actually prefer to just

Re: [RFC PATCH] x86/doc/boot_protocol: Correct the description of "reloc"

2019-09-25 Thread Ingo Molnar
* Cao jin wrote: > The fields marked with (reloc) actually are not dedicated for writing, > but communicating info for relocatable kernel with boot loaders. For > example: > > > Field name: pref_address > Type: read (reloc) > Offset/size

Re: [PATCH v7 0/8] efi/firmware/platform-x86: Add EFI embedded fw support

2019-10-07 Thread Ingo Molnar
* Hans de Goede wrote: > Hi All, > > Here is v7 of my patch-set to add support for EFI embedded fw to the kernel. > > v6 was posted a long time ago, around the 4.18 days. The long wait was for > a suitable secure-hash for checking the firmware we find embedded in the EFI > is the one we expec

Re: [PATCH v7 0/8] efi/firmware/platform-x86: Add EFI embedded fw support

2019-10-08 Thread Ingo Molnar
* Hans de Goede wrote: > > So I was looking for a high level 0/ boilerplate description of this > > series, to explain what "EFI embedded fw" is, what problems it solves and > > how it helps the kernel in general - and found this in 2/8: > > Sorry you had to dig into the individual patch chang

Re: [PATCH v2] doc: kernel-parameters.txt: fix documentation of nmi_watchdog parameter

2019-05-14 Thread Ingo Molnar
please see 'nowatchdog'. > This is useful when you use a panic=... timeout and > need the box quickly up again. Acked-by: Ingo Molnar Thanks, Ingo

Re: [PATCH v5 4/4] usb: doc: add document for USB3 debug port usage

2017-01-19 Thread Ingo Molnar
* Lu Baolu wrote: > Add Documentation/usb/usb3-debug-port.rst. This document includes > the user guide for USB3 debug port. > > Cc: linux-doc@vger.kernel.org > Signed-off-by: Lu Baolu > --- > Documentation/usb/usb3-debug-port.rst | 95 > +++ > 1 file changed,

Re: [PATCHv3 1/2] arch: Move CONFIG_DEBUG_RODATA and CONFIG_SET_MODULE_RONX to be common

2017-02-06 Thread Ingo Molnar
arch/s390/Kconfig | 5 ++--- > arch/s390/Kconfig.debug| 3 --- > arch/x86/Kconfig | 5 ++--- > arch/x86/Kconfig.debug | 11 -- > 13 files changed, 51 insertions(+), 68 deletions(-) Acked-by: Ingo Mol

Re: [PATCHv3 2/2] arch: Rename CONFIG_DEBUG_RODATA and CONFIG_DEBUG_MODULE_RONX

2017-02-19 Thread Ingo Molnar
* Kees Cook wrote: > On Thu, Feb 16, 2017 at 2:25 PM, Pavel Machek wrote: > > Hi! > > > >> > >> -config DEBUG_RODATA > >> +config STRICT_KERNEL_RWX > >> bool "Make kernel text and rodata read-only" if > >> ARCH_OPTIONAL_KERNEL_RWX > >> depends on ARCH_HAS_STRICT_KERNEL_RWX > >>

Re: [PATCH v7 1/3] x86/mm: Adapt MODULES_END based on Fixmap section size

2017-03-16 Thread Ingo Molnar
* Thomas Garnier wrote: > This patch aligns MODULES_END to the beginning of the Fixmap section. > It optimizes the space available for both sections. The address is > pre-computed based on the number of pages required by the Fixmap > section. > > It will allow GDT remapping in the Fixmap sectio

Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

2017-03-28 Thread Ingo Molnar
* Masami Hiramatsu wrote: > @@ -1824,6 +1823,30 @@ void unregister_jprobes(struct jprobe **jps, int num) > EXPORT_SYMBOL_GPL(unregister_jprobes); > > #ifdef CONFIG_KRETPROBES > + > +/* Try to use free instance first, if failed, try to allocate new instance */ > +struct kretprobe_instance *kr

Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

2017-03-29 Thread Ingo Molnar
* Masami Hiramatsu wrote: > > So this is something I missed while the original code was merged, but the > > concept > > looks a bit weird: why do we do any "allocation" while a handler is > > executing? > > > > That's fundamentally fragile. What's the maximum number of parallel > > 'kretpro

Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

2017-04-11 Thread Ingo Molnar
* Masami Hiramatsu wrote: > On Thu, 30 Mar 2017 08:53:32 +0200 > Ingo Molnar wrote: > > > > > * Masami Hiramatsu wrote: > > > > > > So this is something I missed while the original code was merged, but > > > > the concept > > >

Re: [PATCH] kbuild: deprecate cc-option-align

2017-06-22 Thread Ingo Molnar
only user arch/x86/Makefile_32.cpu and deprecate the > cc-option-align. > > Signed-off-by: Masahiro Yamada > --- > > x86 maintainers, > > If this patch looks OK, could you give me Acked-by? LGTM in principle, although I haven't tested it: Acked-by: Ingo Molnar Th

Re: [PATCH v9 00/38] x86: Secure Memory Encryption (AMD)

2017-07-08 Thread Ingo Molnar
* Tom Lendacky wrote: > This patch series provides support for AMD's new Secure Memory Encryption > (SME) > feature. I'm wondering, what's the typical performance hit to DRAM access latency when SME is enabled? On that same note, if the performance hit is noticeable I'd expect SME to not b

Re: [PATCH v10 37/38] compiler-gcc.h: Introduce __nostackp function attribute

2017-07-18 Thread Ingo Molnar
* Tom Lendacky wrote: > Create a new function attribute, __nostackp, that can used to turn off > stack protection on a per function basis. > > Signed-off-by: Tom Lendacky > --- > include/linux/compiler-gcc.h | 2 ++ > include/linux/compiler.h | 4 > 2 files changed, 6 insertions(+) >

Re: [PATCH 0/2] acpi, x86: Add SPCR table support

2017-12-07 Thread Ingo Molnar
* Prarit Bhargava wrote: > The SPCR (Serial Port Console Redirection) Table provides information > about the configuration of serial port. This information can be used > to configure the early console. s/about the configuration of serial port /about the configuration of the serial port > SPC

Re: [PATCH 0/2] acpi, x86: Add SPCR table support

2017-12-11 Thread Ingo Molnar
* Prarit Bhargava wrote: > If I disable "Serial Port Console Debug" in my BIOS I still see the SPCR > configured: > > [root@prarit-lab ~]# dmesg | grep SPCR > [0.00] ACPI: SPCR 0x69031000 50 (v01 > ) > > AFAICT the SPCR is always enabled on some syste

Re: [PATCH v2 2/2] acpi, x86: Use SPCR table for earlycon on x86

2017-12-12 Thread Ingo Molnar
Bhupesh Sharma > Cc: Lv Zheng > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x...@kernel.org > Cc: Jonathan Corbet > Cc: Catalin Marinas > Cc: Will Deacon > Cc: "Rafael J. Wysocki" > Cc: Timur Tab

Re: [PATCH] acpi, spcr: Make SPCR available to x86

2018-01-20 Thread Ingo Molnar
hargava > Cc: linux-a...@vger.kernel.org > Cc: linux-doc@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: Bhupesh Sharma > Cc: Lv Zheng > Cc: Thomas Gleixner > Cc: Ingo Molnar > C

Re: [PATCH v12 01/22] selftests/x86: Move protecton key selftest to arch neutral directory

2018-02-21 Thread Ingo Molnar
(-) > create mode 100644 tools/testing/selftests/vm/pkey-helpers.h > create mode 100644 tools/testing/selftests/vm/protection_keys.c > delete mode 100644 tools/testing/selftests/x86/pkey-helpers.h > delete mode 100644 tools/testing/selftests/x86/protection_keys.c Acked-by: Ingo Molnar

Re: [PATCH] x86: Add topology_hw_smt_threads() and remove smp_num_siblings

2018-02-24 Thread Ingo Molnar
* Prarit Bhargava wrote: > Commit bbb65d2d365e ("x86: use cpuid vector 0xb when available for > detecting cpu topology") changed the value of smp_num_siblings from the > active number of threads in a core to the maximum number threads in a > core. e.g.) On Intel Haswell and newer systems smp_nu

Re: [Question] Documentation/features: More automation/scripting help?

2018-03-30 Thread Ingo Molnar
* Andrea Parri wrote: > Hi all, > > The directory (not yet three years old although, I freely admit, I've > only recently become aware of it) provides arch. support matrices for > more than 40 generic kernel features that need per-arch. support: > > This is a superb project! ;-) and not a sim

Re: [RFC PATCH 0/3] Documentation/features: Provide and apply "features-refresh.sh"

2018-04-03 Thread Ingo Molnar
* Andrea Parri wrote: > In Ingo's words [1]: > > "[...] what should be done instead is to write a script that refreshes >all the arch-support.txt files in-place. [...] > >It's OK for the script to have various quirks for weirdly implemented >features and exceptions: i.e. basical

Re: [RFC PATCH 0/3] Documentation/features: Provide and apply "features-refresh.sh"

2018-04-05 Thread Ingo Molnar
* Andrea Parri wrote: > On Wed, Apr 04, 2018 at 06:56:32AM +0200, Ingo Molnar wrote: > > > > * Andrea Parri wrote: > > > > > In Ingo's words [1]: > > > > > > "[...] what should be done instead is to write a script that

[PATCH] Documentation/features: Refresh the features list to v4.20-rc2

2018-11-13 Thread Ingo Molnar
resh the kernel features support matrix list: - The new 'csky' architecture was added - s390now supports KASAN - powerpc now supports stackprotector - xtensa now supports sg-chain - arm64 now supports queued-spinlocks - parisc now supports kprobes-events - RISC-V now supp

Re: [RFC PATCH v6 01/26] Documentation/x86: Add CET description

2018-11-20 Thread Ingo Molnar
* Yu-cheng Yu wrote: > +X86 Documentation > +=== > + > +Control-flow Enforcement > + > + > +.. toctree:: > + :maxdepth: 1 > + > + intel_cet > diff --git a/Documentation/x86/intel_cet.rst b/Documentation/x86/intel_cet.rst > new file mode 100644 > i

Re: [RFC PATCH v6 01/26] Documentation/x86: Add CET description

2018-11-20 Thread Ingo Molnar
* Yu-cheng Yu wrote: > On Tue, 2018-11-20 at 10:52 +0100, Ingo Molnar wrote: > > * Yu-cheng Yu wrote: > > > > > +X86 Documentation > > > [...] > > > + > > > +At run time, /proc/cpuinfo shows the availability of SHSTK and IBT. > > &g

Re: [PATCH v9 01/13] x86/resctrl: Rename and move rdt files to new directory

2018-11-22 Thread Ingo Molnar
* Moger, Babu wrote: > New generation of AMD processors start supporting RDT(or QOS) > features. Together these features will be called as RESCTRL. > With more than one vendors supporting these features, it seems > more appropriate to rename these files. > > Create a new directory with the nam

Re: [PATCH v9 01/13] x86/resctrl: Rename and move rdt files to new directory

2018-11-23 Thread Ingo Molnar
* Borislav Petkov wrote: > On Fri, Nov 23, 2018 at 08:28:39AM +0100, Ingo Molnar wrote: > > Ugh, violent NAK on this unreadable directory naming: 'resctrl' is an > > ugly double/triple abbreviation that nobody recognizes for what it is to > > begin with, a

Re: [PATCH v9 01/13] x86/resctrl: Rename and move rdt files to new directory

2018-11-23 Thread Ingo Molnar
* Borislav Petkov wrote: > On Fri, Nov 23, 2018 at 09:41:17AM +0100, Ingo Molnar wrote: > > Then at least make the directory name resource_control/, which is only > > marginally longer and a lot more readable. > > > > We really don't have to fit directly name

Re: [PATCH v2 0/2] kbuild: Cache exploratory calls to the compiler

2017-10-05 Thread Ingo Molnar
r ] triton:~/tip> taskset 1 perf stat --null --pre "sync" --repeat 10 make kernel/sched/ >/dev/null Performance counter stats for 'make kernel/sched/' (10 runs): 0.148483807 seconds time elapsed ( +- 0.57% ) A 300% s

Re: [PATCH RFC v3 4/6] Documentation: Add three sysctls for smart idle poll

2017-11-13 Thread Ingo Molnar
* Quan Xu wrote: > From: Quan Xu > > To reduce the cost of poll, we introduce three sysctl to control the > poll time when running as a virtual machine with paravirt. > > Signed-off-by: Yang Zhang > Signed-off-by: Quan Xu > --- > Documentation/sysctl/kernel.txt | 35 +

Re: [PATCH RFC v3 4/6] Documentation: Add three sysctls for smart idle poll

2017-11-13 Thread Ingo Molnar
* Quan Xu wrote: > > > On 2017/11/13 23:08, Ingo Molnar wrote: > > * Quan Xu wrote: > > > > > From: Quan Xu > > > > > > To reduce the cost of poll, we introduce three sysctl to control the > > > poll time when running as a virtua

Re: [PATCH v2] sched/deadline: fix runtime accounting in documentation

2017-11-16 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Tue, Nov 14, 2017 at 12:19:26PM +0100, Claudio Scordino wrote: > > Signed-off-by: Claudio Scordino > > Signed-off-by: Luca Abeni > > Acked-by: Daniel Bristot de Oliveira > > CC: Jonathan Corbet > > CC: "Peter Zijlstra (Intel

Re: [RFC PATCH v3 0/6] Documentation/features: Provide and apply 'features-refresh.sh'

2018-05-14 Thread Ingo Molnar
in place; previous discussions about this series are at [1]. > > Looks good, I've applied the set, thanks. A belated: Reviewed-by: Ingo Molnar Thanks guys! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message

Re: [PATCH v2 2/3] x86/mm/doc: Clean up the memory region layout descriptions

2018-10-02 Thread Ingo Molnar
* Baoquan He wrote: > In Documentation/x86/x86_64/mm.txt, the style of descritions about > memory region layout is a little confusing: > > - mix size in TB with 'bits' > - sometimes mention a size in the description and sometimes not > - sometimes list holes by address, sometimes only as an

Re: [PATCH v2 1/3] x86/KASLR: Update document about KERNEL_IMAGE_SIZE

2018-10-03 Thread Ingo Molnar
* Baoquan He wrote: > Currently CONFIG_RANDOMIZE_BASE=y is default set, update the relevant > document about KERNEL_IMAGE_SIZE. Suggested wording: x86/KASLR: Update KERNEL_IMAGE_SIZE description Currently CONFIG_RANDOMIZE_BASE=y is set by default, which makes some of the old comments

Re: [PATCH 0/3] x86/mm/doc: Clean up mm.txt

2018-10-06 Thread Ingo Molnar
* Baoquan He wrote: > This clean up is suggested by Ingo. > > It firstly fix the confusions in mm layout tables by unifying > each memory region description in the consistent style. > > Secondly take the KASLR words out of the mm layout tables to make > it as a separate section to only list m

[PATCH 4/3] x86/mm/doc: Enhance the x86-64 virtual memory layout descriptions

2018-10-06 Thread Ingo Molnar
Thomas Gleixner Cc: cor...@lwn.net Cc: linux-doc@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: thgar...@google.com Signed-off-by: Ingo Molnar --- Documentation/x86/x86_64/mm.txt | 172 kernel/sched/core.c |6 + 2 files changed

Re: [PATCH 4/3] x86/mm/doc: Enhance the x86-64 virtual memory layout descriptions

2018-10-06 Thread Ingo Molnar
* Ingo Molnar wrote: > + > +| Complete virtual memory map with 4-level page tables | > + > +-

[PATCH 4/3 v2] x86/mm/doc: Enhance the x86-64 virtual memory layout descriptions

2018-10-06 Thread Ingo Molnar
sen Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Rik van Riel Cc: Thomas Gleixner Cc: cor...@lwn.net Cc: linux-doc@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: thgar...@google.com Signed-off-by: Ingo Molnar --- Documentation/x86/x86_64/mm.txt |

Re: [PATCH 4/3 v2] x86/mm/doc: Enhance the x86-64 virtual memory layout descriptions

2018-10-06 Thread Ingo Molnar
There's one PTI related layout asymmetry I noticed between 4-level and 5-level kernels: 47-bit: > +| > +| Kernel-space > virtual memory, shared between all processes: > +__

Re: [PATCH v5 0/3] x86: make rsdp address accessible via boot params

2018-10-09 Thread Ingo Molnar
* Juergen Gross wrote: > In the non-EFI boot path the ACPI RSDP table is currently found via > either EBDA or by searching through low memory for the RSDP magic. > This requires the RSDP to be located in the first 1MB of physical > memory. Xen PVH guests, however, get the RSDP address via the s

Re: [PATCH v5 0/3] x86: make rsdp address accessible via boot params

2018-10-10 Thread Ingo Molnar
* Juergen Gross wrote: > You can just dive into the discussion we had back in February: That was half a year and a thousand commits ago! ;-) > https://lore.kernel.org/lkml/20180213163244.j2zuxyhs4kbfh...@gmail.com/ > > The scheme I have used in V5 of the series is the one you agreed to use >

Re: [PATCH V5 0/5] KVM: X86: Introducing ROE Protection Kernel Hardening

2018-10-28 Thread Ingo Molnar
* Ahmed Abd El Mawgood wrote: > This is the 5th version which is 4th version with minor fixes. ROE is a > hypercall that enables host operating system to restrict guest's access to its > own memory. This will provide a hardening mechanism that can be used to stop > rootkits from manipulating k

Re: [PATCH] x86/intel/quark: Parameterize the kernel's IMR lock logic

2016-02-17 Thread Ingo Molnar
* Bryan O'Donoghue wrote: > Currently when setting up an IMR around the kernel's .text area we lock > that IMR, preventing further modification. While superficially this appears > to be the right thing to do, in fact this doesn't account for a legitimate > change in the memory map such as when e

Re: [PATCH] x86/intel/quark: Parameterize the kernel's IMR lock logic

2016-02-18 Thread Ingo Molnar
* Bryan O'Donoghue wrote: > On Thu, 2016-02-18 at 08:58 +0100, Ingo Molnar wrote: > > So why not simply do the patch below? Very few people use boot > > parameters, and the > > complexity does not seem to be worth it. > > > > Furthermore I think an IMR

Re: [PATCH v2] x86: PAT: Documentation: rewrite "MTRR effects on PAT / non-PAT systems"

2016-03-05 Thread Ingo Molnar
* Luis R. Rodriguez wrote: > The current documentation refers to using set_memory_wc() as a > possible hole strategy when you have overlapping ioremap() regions, The whole explanation should talk about virtual aliases over the same physical address, not some 'overlapping regions'. I see where

Re: [PATCH v10 05/12] task_isolation: support CONFIG_TASK_ISOLATION_ALL

2016-03-05 Thread Ingo Molnar
* Chris Metcalf wrote: > On 03/03/2016 01:34 PM, Andi Kleen wrote: > >Chris Metcalf writes: > >>+config TASK_ISOLATION_ALL > >>+ bool "Provide task isolation on all CPUs by default (except CPU 0)" > >>+ depends on TASK_ISOLATION > >>+ help > >>+If the user doesn't pass the task_isolat

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Kees Cook wrote: > On Wed, Apr 6, 2016 at 1:56 PM, Linus Torvalds > wrote: > > On Wed, Apr 6, 2016 at 1:17 PM, Pavel Machek wrote: > >> > >> Why is kASLR incompatible with hibernation? We can hibernate have > >> 4.3 kernel resume hibernation image of 4.2 kernel (on x86-64, and I > >> have pa

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Kees Cook wrote: > > > On Wed, Apr 6, 2016 at 1:56 PM, Linus Torvalds > > wrote: > > > On Wed, Apr 6, 2016 at 1:17 PM, Pavel Machek wrote: > > >> > > >> Why is kASLR incompatible with hibernation? We can hib

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Rafael J. Wysocki wrote: > On Wed, Apr 6, 2016 at 9:44 PM, Kees Cook wrote: > > When building with both CONFIG_HIBERNATION and CONFIG_RANDOMIZE_BASE, > > one or the other must be chosen at boot-time. Until now, hibernation > > was selected when no choice was made on the command line. > > > >

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Kees Cook wrote: > >> I don't think this is a good idea, as it turns off emergency hibernation > >> of > >> laptops - many desktop distros support it by default. > > > > Right, I forgot about this one. > > When I last checked Ubuntu doesn't enable hibernation by default any more: > https:/

Re: [PATCH] Prefer kASLR over Hibernation

2016-04-06 Thread Ingo Molnar
* Rafael J. Wysocki wrote: > [...] > > One of the weak points is the final jump, because it has to be done to the > physical location of the image kernel's entry point even though the virtual > addresses of it may differ between the boot and the image kernels. The seed > is > not needed fo

Re: [PATCH v2] kaslr: allow kASLR to be default over Hibernation

2016-04-15 Thread Ingo Molnar
* Kees Cook wrote: > 1) The x86 hibernation and KASLR code don't play well together currently. Please fix it, don't just work it around ... Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH 0/6] Intel Secure Guard Extensions

2016-04-27 Thread Ingo Molnar
* Andy Lutomirski wrote: > > What new syscalls would be needed for ssh to get all this support? > > This patchset or similar, plus some user code and an enclave to use. > > Sadly, on current CPUs, you also need Intel to bless the enclave. It looks > like > new CPUs might relax that requirem

Re: [PATCH Documentation/memory-barriers.txt] Clarify limited control-dependency scope

2016-06-17 Thread Ingo Molnar
* Paul E. McKenney wrote: > Nothing in the control-dependencies section of memory-barriers.txt > says that control dependencies don't extend beyond the end of the > if-statement containing the control dependency. Worse yet, in many > situations, they do extend beyond that if-statement. In part

Re: [RFC v1 3/4] x86, boot: Implement ASLR for kernel memory sections (x86_64)

2016-06-17 Thread Ingo Molnar
* Thomas Garnier wrote: > arch/x86/include/asm/kaslr.h| 12 +++ Hm, what tree is this patch against? asm/kaslr.h does not exist upstream or in the x86 tree. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to

Re: [RFC v1 3/4] x86, boot: Implement ASLR for kernel memory sections (x86_64)

2016-06-17 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Thomas Garnier wrote: > > > arch/x86/include/asm/kaslr.h| 12 +++ > > Hm, what tree is this patch against? asm/kaslr.h does not exist upstream or > in the > x86 tree. Ah, never mind, introduced by the first patch.

Re: [RFC v1 3/4] x86, boot: Implement ASLR for kernel memory sections (x86_64)

2016-06-17 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Thomas Garnier wrote: > > > arch/x86/include/asm/kaslr.h| 12 +++ > > Hm, what tree is this patch against? asm/kaslr.h does not exist upstream or > in the > x86 tree. So the problem is that this file gets introduced by:

Re: [PATCH] [linux-next] Doc: x86: Fix typo in x86

2016-07-01 Thread Ingo Molnar
* Masanari Iida wrote: > This patch fix some spelling typo found in > Documentation/x86. > > Signed-off-by: Masanari Iida > --- > Documentation/x86/intel_mpx.txt | 6 +++--- > Documentation/x86/tlb.txt | 4 ++-- > Documentation/x86/x86_64/machinecheck | 2 +- > 3 files chang

Re: [PATCH v4 3/3] Doc/memory-barriers: Add Korean translation

2016-07-08 Thread Ingo Molnar
* Byungchul Park wrote: > On Fri, Jul 08, 2016 at 07:50:39AM +0900, SeongJae Park wrote: > > > I will add my opinion in korean. > > > > Thank you for kind and faithful review. I agree with most of your opinions > > and > > suggestions. Most of your suggestions looks much better than mine. >

Re: [PATCH v5 2/2] Doc/memory-barriers: Add Korean translation

2016-07-21 Thread Ingo Molnar
: Paul E. McKenney > > Acked-by: Minchan Kim > > Signed-off-by: SeongJae Park > > If Minchan is OK with this version, if Ingo and Jon have no objections, > and given the small change below, I will take it. Acked-by: Ingo Molnar Thanks, Ingo -- To unsub

Re: [kernel-hardening] Re: [PATCH 1/2] security, perf: allow further restriction of perf_event_open

2016-08-03 Thread Ingo Molnar
* Kees Cook wrote: > > I see 0 up-sides of this approach and, as per the above, a whole bunch of > > very > > serious downsides. > > > > A global (esp. default inhibited) knob is too coarse and limiting. > > I haven't suggested it be default inhibit in the upstream Kconfig. And > having this

Re: [GIT PULL 00/16] perf/core improvements and fixes

2016-02-03 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > This is on top of the previously submitted perf-core-for-mingo tag, > please consider applying, > > - Arnaldo > > The following changes since commit 5ac76283b32b116c58e362e99542182ddcfc8262: > > perf cpumap: Auto initialize cpu__max_{n

Re: [PATCH] hpet: drop stale link

2016-02-03 Thread Ingo Molnar
* Michael S. Tsirkin wrote: > Looks like the HPET spec at intel.com got moved. > It isn't hard to find so drop the link, just mention > the revision assumed. > > Suggested-by: Thomas Gleixner > Signed-off-by: Michael S. Tsirkin > --- > drivers/char/hpet.c | 2 +- > Documentation/ti

Re: [PATCH 3/8] stackleak: Rename CONFIG_GCC_PLUGIN_STACKLEAK to CONFIG_STACKLEAK

2025-05-07 Thread Ingo Molnar
* Kees Cook wrote: > - The STACKLEAK gcc plugin instruments the kernel code for tracking > + The STACKLEAK options instruments the kernel code for tracking speling. Also, any chance to fix this terrible name? Should be something like KSTACKZERO or KSTACKCLEAR, to tell people that

Re: [PATCH 3/8] stackleak: Rename CONFIG_GCC_PLUGIN_STACKLEAK to CONFIG_STACKLEAK

2025-05-07 Thread Ingo Molnar
* Kees Cook wrote: > On Wed, May 07, 2025 at 08:45:15PM +0200, Ingo Molnar wrote: > > > > * Kees Cook wrote: > > > > > - The STACKLEAK gcc plugin instruments the kernel code for tracking > > > + The STACKLEAK options instruments the kernel code for