Re: [PATCH v7 1/2] fTPM: firmware TPM running in TEE

2019-07-04 Thread Ilias Apalodimas
Hi Thirupathaiah, [...] > > > > > I managed to do some quick testing in QEMU. > > > > > Everything works fine when i build this as a module (using IBM's TPM > > > > > 2.0 > > > > > TSS) > > > > > > > > > > - As module > > > > > # insmod > > > > > /lib/modules/5.2.0-rc1/kernel/drivers/char/tpm/tpm

Re: [PATCH v7 1/2] fTPM: firmware TPM running in TEE

2019-07-10 Thread Ilias Apalodimas
Hi Thirupathaiah Apologies for tha lte reply, i somehow misplaced this mail. [...] > > > > Please check the previous mail from Sumit. It explains exaclty what's going > > on. > > The tl;dr version is that the storage is up only when the supplicant is > > running. > > I definitely know that OP-

Re: [PATCH v8 0/2] fTPM: firmware TPM running in TEE

2019-07-11 Thread Ilias Apalodimas
On Thu, Jul 11, 2019 at 11:08:58PM +0300, Jarkko Sakkinen wrote: > On Fri, Jul 05, 2019 at 04:47:44PM -0400, Sasha Levin wrote: > > Changes from v7: > > > > - Address Jarkko's comments. > > > > Sasha Levin (2): > > fTPM: firmware TPM running in TEE > > fTPM: add documentation for ftpm driver

Re: [PATCH v8 0/2] fTPM: firmware TPM running in TEE

2019-07-15 Thread Ilias Apalodimas
On Fri, Jul 12, 2019 at 06:37:58AM +0300, Jarkko Sakkinen wrote: > On Thu, Jul 11, 2019 at 11:10:59PM +0300, Ilias Apalodimas wrote: > > Will report back any issues when we start using it on real hardware > > rather than QEMU > > > > Thanks > > /Ilias > >

Re: [PATCH v4 1/2] fTPM: firmware TPM running in TEE

2019-06-14 Thread Ilias Apalodimas
Hi Sasha, On Thu, Jun 13, 2019 at 01:11:41PM -0400, Sasha Levin wrote: > On Wed, Jun 05, 2019 at 04:39:36PM +0530, Sumit Garg wrote: > >On Wed, 5 Jun 2019 at 01:39, Sasha Levin wrote: > >> > >>On Tue, Jun 04, 2019 at 11:45:52AM +0530, Sumit Garg wrote: > >>>On Thu, 30 May 2019 at 20:58, Sasha Lev

Re: [PATCH v5 1/2] fTPM: firmware TPM running in TEE

2019-06-19 Thread Ilias Apalodimas
Hi Sasha, Can you please include me and Sumit in future iterations of this? We've both commented and did some testing, we'd prefer not scanning the mailing list for new versions. [...] > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) Microsoft Corporation > + * > + * Implements a

Re: [PATCH v7 1/2] fTPM: firmware TPM running in TEE

2019-06-27 Thread Ilias Apalodimas
Hi Jarkko, > On Wed, 2019-06-26 at 19:56 -0400, Sasha Levin wrote: > > > You've used so much on this so shouldn't this have that somewhat new > > > co-developed-by tag? I'm also wondering can this work at all > > > > Honestly, I've just been massaging this patch more than "authoring" it. > > If yo

Re: [PATCH v7 1/2] fTPM: firmware TPM running in TEE

2019-07-02 Thread Ilias Apalodimas
Hi, > On Thu, 2019-06-27 at 16:30 +0300, Ilias Apalodimas wrote: > > is really useful. I don't have hardware to test this at the moment, but > > once i > > get it, i'll give it a spin. > > Thank you for responding, really appreciate it. > No worries &g

Re: [PATCH v7 1/2] fTPM: firmware TPM running in TEE

2019-07-02 Thread Ilias Apalodimas
& (sec_caps & OPTEE_SMC_SEC_CAP_HAVE_RESERVED_SHM)) + if (sec_caps & OPTEE_SMC_SEC_CAP_HAVE_RESERVED_SHM) pool = optee_config_shm_memremap(invoke_fn, &memremaped_shm); if (IS_ERR(pool)) For the module part: Tested-by: Ilias Apalodimas

Re: [PATCH v7 1/2] fTPM: firmware TPM running in TEE

2019-07-03 Thread Ilias Apalodimas
Hi Thirupathaiah, (+Joakim) On Wed, 3 Jul 2019 at 09:58, Ilias Apalodimas wrote: > > Hi Thirupathaiah, > > > > First of all, Thanks a lot for trying to test the driver. > > > np > > [...] > > > I managed to do some quick testing in QEMU. > > >