Re: [PATCH] Documentation/process/coding-style.rst: space around const/volatile

2023-10-10 Thread Greg KH
On Tue, Oct 10, 2023 at 12:12:40PM +0200, Max Kellermann wrote: > There are currently no rules on the placement of "const" and > "volatile", but a recent code submission revealed that there is > clearly a preference for spaces around them. > > checkpatch.pl has no check at all for this; though it

Re: [PATCH] Documentation/process/coding-style.rst: space around const/volatile

2023-10-10 Thread Greg KH
On Tue, Oct 10, 2023 at 02:03:25PM +0200, Max Kellermann wrote: > On Tue, Oct 10, 2023 at 1:37 PM Greg KH wrote: > > Don't encourage the use of volatile please > > I don't mean to - but I figured IF "volatile" is used (for whatever > reason, whether corr

Re: [PATCH v2] Documentation/process/coding-style.rst: space around const

2023-10-10 Thread Greg KH
On Tue, Oct 10, 2023 at 02:29:35PM +0200, Max Kellermann wrote: > There are currently no rules on the placement of "const", but a recent > code submission revealed that there is clearly a preference for spaces > around them. > > checkpatch.pl has no check at all for this; though it does sometimes

Re: [PATCH v3] Documentation/process/coding-style.rst: space around const

2023-10-10 Thread Greg KH
On Tue, Oct 10, 2023 at 02:58:31PM +0200, Max Kellermann wrote: > There are currently no rules on the placement of "const", but a recent > code submission revealed that there is clearly a preference for spaces > around it. > > checkpatch.pl has no check at all for this; though it does sometimes >

Re: [PATCH] Sounds better

2023-12-03 Thread Greg KH
On Sun, Dec 03, 2023 at 07:00:18PM +0530, attreyee-muk wrote: > Respected Maintainers, > > I have made a small change in the submitting-patches.rst document. I was > reading the submitting-patches.rst file as I needed to understand > certain things for submitting patches. That is when I found thi

Re: [PATCH] scripts: kernel-doc: Bug fixed for erroneous warning

2023-12-19 Thread Greg KH
On Wed, Dec 20, 2023 at 11:24:46AM +0500, Muhammad Muzammil wrote: > From: Muzammil Ashraf > > kernel-doc: fixed erroneous warning generated by '__counted_by' > > Signed-off-by: Muzammil Ashraf > --- > scripts/kernel-doc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/kernel-

Re: [PATCH] coding-style: Add guidance to prefer dev_dbg

2024-01-25 Thread Greg KH
On Thu, Jan 25, 2024 at 04:53:11PM -0800, Abhishek Pandit-Subedi wrote: > During review, it was suggested that drivers only emit messages when > something is wrong or it is a debug message. Document this as a formal > recommendation. > > https://lore.kernel.org/linux-usb/2024012525-alienate-frown-

Re: [PATCH] Documentation: embargoed-hardware-issues.rst: Fix Trilok's email

2024-02-02 Thread Greg KH
On Fri, Feb 02, 2024 at 09:41:19AM -0700, Jeffrey Hugo wrote: > The servers for the @codeaurora domain have long been retired and any > messages addressed to @codeaurora will bounce. > > Trilok has an entry in .mailmap, but the raw documentation files still > list an old @codeaurora address. Upda

Re: [PATCH] Documentation: coding-style: don't encourage WARN*()

2024-04-14 Thread Greg KH
On Sun, Apr 14, 2024 at 10:48:35PM +0300, Laurent Pinchart wrote: > Hi Alex, > > Thank you for the patch. > > On Sun, Apr 14, 2024 at 12:08:50PM -0500, Alex Elder wrote: > > Several times recently Greg KH has admonished that variants of WARN() > > should no

Re: [PATCH] Documentation: coding-style: don't encourage WARN*()

2024-04-14 Thread Greg KH
On Sun, Apr 14, 2024 at 12:08:50PM -0500, Alex Elder wrote: > Several times recently Greg KH has admonished that variants of WARN() > should not be used, because when the panic_on_warn kernel option is set, > their use can lead to a panic. His reasoning was that the majority of > Lin

Re: [PATCH] Documentation: coding-style: don't encourage WARN*()

2024-04-15 Thread Greg KH
On Mon, Apr 15, 2024 at 11:25:29AM +0300, Laurent Pinchart wrote: > Hi Greg, > > On Mon, Apr 15, 2024 at 07:21:37AM +0200, Greg KH wrote: > > On Sun, Apr 14, 2024 at 10:48:35PM +0300, Laurent Pinchart wrote: > > > On Sun, Apr 14, 2024 at 12:08:50PM -0500, Alex Elder wrot

Re: [PATCH] Documentation: coding-style: don't encourage WARN*()

2024-04-15 Thread Greg KH
On Mon, Apr 15, 2024 at 01:07:41AM -0700, Christoph Hellwig wrote: > No, this advice is wronger than wrong. If you set panic_on_warn you > get to keep the pieces. > But don't add new WARN() calls please, just properly clean up and handle the error. And any WARN() that userspace can trigger en

Re: [PATCH v1 2/2] Documentation: process: Recommend to put Cc: tags after cutter '---' line

2024-04-23 Thread Greg KH
On Tue, Apr 23, 2024 at 04:19:38PM +0300, Andy Shevchenko wrote: > The recommendation is based on the following rationale: > > - it makes the commit messages much cleaner and easy to read, especially > on the screens of the mobile devices; Reading commits on a mobile device is not what kernel d

Re: [PATCH v1 2/2] Documentation: process: Recommend to put Cc: tags after cutter '---' line

2024-04-23 Thread Greg KH
On Tue, Apr 23, 2024 at 06:28:44PM +0300, Andy Shevchenko wrote: > On Tue, Apr 23, 2024 at 08:13:37AM -0700, Greg KH wrote: > > On Tue, Apr 23, 2024 at 04:19:38PM +0300, Andy Shevchenko wrote: > > > The recommendation is based on the following rationale: > > > > >

Re: [PATCH] docs: maintainer: discourage taking conversations off-list

2024-07-12 Thread Greg KH
On Fri, Jul 12, 2024 at 07:49:03AM -0700, Jakub Kicinski wrote: > Multiple vendors seem to prefer taking discussions off list, and > ask contributors to work with them privately rather than just send > patches to the list. I'd imagine this is because it's hard to fit in > time for random developers

Re: [PATCH 05/15] Documentation: fpga: dfl: add descriptions for virtualization and new interfaces.

2019-07-04 Thread Greg KH
On Thu, Jul 04, 2019 at 02:42:08PM +0800, Wu Hao wrote: > On Thu, Jul 04, 2019 at 07:37:19AM +0200, Greg KH wrote: > > On Thu, Jul 04, 2019 at 07:38:22AM +0800, Wu Hao wrote: > > > On Wed, Jul 03, 2019 at 07:59:26PM +0200, Greg KH wrote: > > > > On Thu, Jun 27, 20

Re: [PATCH 06/15] fpga: dfl: fme: add DFL_FPGA_FME_PORT_RELEASE/ASSIGN ioctl support.

2019-07-04 Thread Greg KH
On Thu, Jul 04, 2019 at 02:31:06PM +0800, Wu Hao wrote: > On Thu, Jul 04, 2019 at 07:39:27AM +0200, Greg KH wrote: > > On Thu, Jul 04, 2019 at 07:30:58AM +0800, Wu Hao wrote: > > > On Wed, Jul 03, 2019 at 08:07:53PM +0200, Greg KH wrote: > > > > On Thu, Jun 27, 20

Re: [PATCH 06/15] fpga: dfl: fme: add DFL_FPGA_FME_PORT_RELEASE/ASSIGN ioctl support.

2019-07-04 Thread Greg KH
On Thu, Jul 04, 2019 at 04:58:55PM +0800, Wu Hao wrote: > > > Hope things could be more clear now. :) > > > > That's nice for the vfio stuff, but you are just a "normal" driver here. > > You want an ioctl that just does one thing, no arguments, no flags, no > > anything. No need for a size argume

Re: [PATCH] Documentation/security-bugs: provide more information about linux-distros

2019-07-11 Thread Greg KH
On Thu, Jul 11, 2019 at 12:36:37PM -0400, Sasha Levin wrote: > Provide more information about how to interact with the linux-distros > mailing list for disclosing security bugs. > > First, clarify that the reporter must read and accept the linux-distros > policies prior to sending a report. > > S

Re: [PATCH v3 02/12] fpga: dfl: fme: add DFL_FPGA_FME_PORT_RELEASE/ASSIGN ioctl support.

2019-07-24 Thread Greg KH
On Tue, Jul 23, 2019 at 12:51:25PM +0800, Wu Hao wrote: > +/** > + * dfl_fpga_cdev_config_port - configure a port feature dev > + * @cdev: parent container device. > + * @port_id: id of the port feature device. > + * @release: release port or assign port back. > + * > + * This function allows user

Re: [PATCH v3 01/12] fpga: dfl: fme: support 512bit data width PR

2019-07-24 Thread Greg KH
On Tue, Jul 23, 2019 at 12:51:24PM +0800, Wu Hao wrote: > In early partial reconfiguration private feature, it only > supports 32bit data width when writing data to hardware for > PR. 512bit data width PR support is an important optimization > for some specific solutions (e.g. XEON with FPGA integr

Re: [PATCH v3 03/12] fpga: dfl: pci: enable SRIOV support.

2019-07-24 Thread Greg KH
On Tue, Jul 23, 2019 at 12:51:26PM +0800, Wu Hao wrote: > This patch enables the standard sriov support. It allows user to > enable SRIOV (and VFs), then user could pass through accelerators > (VFs) into virtual machine or use VFs directly in host. > > Signed-off-by: Zhang Yi Z > Signed-off-by: X

Re: [PATCH v3 04/12] fpga: dfl: afu: add AFU state related sysfs interfaces

2019-07-24 Thread Greg KH
On Tue, Jul 23, 2019 at 12:51:27PM +0800, Wu Hao wrote: > This patch introduces more sysfs interfaces for Accelerated > Function Unit (AFU). These interfaces allow users to read > current AFU Power State (APx), read / clear AFU Power (APx) > events which are sticky to identify transient APx state,

Re: [PATCH v3 09/12] fpga: dfl: afu: add STP (SignalTap) support

2019-07-24 Thread Greg KH
On Tue, Jul 23, 2019 at 12:51:32PM +0800, Wu Hao wrote: > STP (SignalTap) is one of the private features under the port for > debugging. This patch adds private feature driver support for it > to allow userspace applications to mmap related mmio region and > provide STP service. > > Signed-off-by:

Re: [PATCH 1/1] psi: do not require setsched permission from the trigger creator

2019-07-29 Thread Greg KH
On Mon, Jul 29, 2019 at 12:42:05PM -0700, Suren Baghdasaryan wrote: > When a process creates a new trigger by writing into /proc/pressure/* > files, permissions to write such a file should be used to determine whether > the process is allowed to do so or not. Current implementation would also > req

Re: [PATCH v4 04/12] fpga: dfl: afu: add userclock sysfs interfaces.

2019-08-05 Thread Greg KH
On Sun, Aug 04, 2019 at 06:20:14PM +0800, Wu Hao wrote: > This patch introduces userclock sysfs interfaces for AFU, user > could use these interfaces for clock setting to AFU. > > Please note that, this is only working for port header feature > with revision 0, for later revisions, userclock setti

Re: [PATCH v4 06/12] fpga: dfl: afu: export __port_enable/disable function.

2019-08-05 Thread Greg KH
On Sun, Aug 04, 2019 at 06:20:16PM +0800, Wu Hao wrote: > As these two functions are used by other private features. e.g. > in error reporting private feature, it requires to check port status > and reset port for error clearing. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Acked-by: Mo

Re: [PATCH v4 07/12] fpga: dfl: afu: add error reporting support.

2019-08-05 Thread Greg KH
On Sun, Aug 04, 2019 at 06:20:17PM +0800, Wu Hao wrote: > Error reporting is one important private feature, it reports error > detected on port and accelerated function unit (AFU). It introduces > several sysfs interfaces to allow userspace to check and clear > errors detected by hardware. > > Sig

Re: [PATCH v4 11/12] fpga: dfl: fme: add global error reporting support

2019-08-05 Thread Greg KH
On Sun, Aug 04, 2019 at 06:20:21PM +0800, Wu Hao wrote: > +static int fme_global_err_init(struct platform_device *pdev, > +struct dfl_feature *feature) > +{ > + struct device *dev; > + int ret = 0; > + > + dev = kzalloc(sizeof(*dev), GFP_KERNEL); > + if (

Re: [PATCH v4 11/12] fpga: dfl: fme: add global error reporting support

2019-08-07 Thread Greg KH
On Wed, Aug 07, 2019 at 04:08:25PM +0800, Wu Hao wrote: > On Wed, Aug 07, 2019 at 10:45:22AM +0800, Wu Hao wrote: > > On Mon, Aug 05, 2019 at 05:56:26PM +0200, Greg KH wrote: > > > On Sun, Aug 04, 2019 at 06:20:21PM +0800, Wu Hao wrote: > > > > +static

Re: [PATCH v5 0/9] FPGA DFL updates

2019-08-19 Thread Greg KH
On Mon, Aug 19, 2019 at 01:31:33PM +0800, Wu Hao wrote: > On Mon, Aug 12, 2019 at 10:49:55AM +0800, Wu Hao wrote: > > Hi Greg, > > > > This is v5 patchset which adds more features to FPGA DFL. Marjor changes > > against v4 are sysfs related code rework to address comments on v4. > > > > Please he

Re: [PATCH v2 09/11] coresight: etm4x: docs: Update ABI doc for sysfs features added.

2019-09-03 Thread Greg KH
On Thu, Aug 29, 2019 at 10:33:19PM +0100, Mike Leach wrote: > Update document to include the new sysfs features added during this > patchset. > > Updated to reflect the new sysfs component nameing schema. > > Signed-off-by: Mike Leach > --- > .../testing/sysfs-bus-coresight-devices-etm4x | 183

Re: [PATCH v2 09/11] coresight: etm4x: docs: Update ABI doc for sysfs features added.

2019-09-03 Thread Greg KH
On Tue, Sep 03, 2019 at 04:51:40PM -0600, Mathieu Poirier wrote: > On Tue, 3 Sep 2019 at 13:59, Greg KH wrote: > > > > On Thu, Aug 29, 2019 at 10:33:19PM +0100, Mike Leach wrote: > > > Update document to include the new sysfs features added during this > > >

Re: [PATCH v2 09/11] coresight: etm4x: docs: Update ABI doc for sysfs features added.

2019-09-04 Thread Greg KH
On Wed, Sep 04, 2019 at 10:05:51AM -0600, Mathieu Poirier wrote: > On Tue, 3 Sep 2019 at 23:48, Greg KH wrote: > > > > On Tue, Sep 03, 2019 at 04:51:40PM -0600, Mathieu Poirier wrote: > > > On Tue, 3 Sep 2019 at 13:59, Greg KH wrote: > > > > > > > >

Re: [PATCH] Documentation/process/embargoed-hardware-issues: Microsoft ambassador

2019-09-06 Thread Greg KH
On Fri, Sep 06, 2019 at 08:57:28AM -0600, Jonathan Corbet wrote: > On Fri, 6 Sep 2019 05:58:52 -0400 > Sasha Levin wrote: > > > Add Sasha Levin as Microsoft's process ambassador. > > > > Signed-off-by: Sasha Levin > > Signed-off-by: Sasha Levin > > --- > > Documentation/process/embargoed-har

Re: [PATCH 0/4] Documentation/process: embargoed hardware issues additions

2019-09-11 Thread Greg KH
On Tue, Sep 10, 2019 at 10:26:44AM -0700, Dave Hansen wrote: > Intel will adhere to this process for future hardware embargoed > issues. This series contains a patch from Tony Luck with him > volunteering to be Intel's ambassador for this process. > > These are some minor improvements here to the

Re: [PATCH 2/4] Documentation/process: describe relaxing disclosing party NDAs

2019-09-11 Thread Greg KH
On Tue, Sep 10, 2019 at 10:26:49AM -0700, Dave Hansen wrote: > > From: Dave Hansen > > Hardware companies like Intel have lots of information which they > want to disclose to some folks but not others. Non-disclosure > agreements are a tool of choice for helping to ensure that the > flow of inf

Re: [PATCH 3/4] Documentation/process: soften language around conference talk dates

2019-09-11 Thread Greg KH
On Tue, Sep 10, 2019 at 10:26:51AM -0700, Dave Hansen wrote: > > From: Dave Hansen > > Both hardware companies and the kernel community prefer coordinated > disclosure to the alternatives. It is also obvious that sitting on > ready-to-go mitigations for months is not so nice for kernel > mainta

Re: [PATCH 4/4] Documentation/process: add transparency promise to list subscription

2019-09-11 Thread Greg KH
On Tue, Sep 10, 2019 at 10:26:52AM -0700, Dave Hansen wrote: > > From: Dave Hansen > > Transparency is good. It it essential for everyone working under an > embargo to know who is involved and who else is a "knower". Being > transparent allows everyone to always make informed decisions about >

Re: [PATCH 2/4] Documentation/process: describe relaxing disclosing party NDAs

2019-09-29 Thread Greg KH
On Wed, Sep 11, 2019 at 09:09:18AM -0700, Dave Hansen wrote: > On 9/11/19 8:44 AM, Greg KH wrote: > > Intel had months of review time for this document before this was > > published. Your lawyers had it and never objected to this lack of > > inclusion at all, and expl

Re: [PATCH v6 3/5] serial: fsl_linflexuart: Be consistent with the name

2019-10-15 Thread Greg KH
On Thu, Oct 10, 2019 at 07:52:26PM +0300, Stefan-Gabriel Mirea wrote: > For consistency reasons, spell the controller name as "LINFlexD" in > comments and documentation. > > Signed-off-by: Stefan-Gabriel Mirea > --- > Documentation/admin-guide/kernel-parameters.txt | 2 +- > drivers/tty/serial/K

Re: [PATCH v7 0/5] Add initial support for S32V234-EVB

2019-10-16 Thread Greg KH
On Wed, Oct 16, 2019 at 03:48:22PM +0300, Stefan-Gabriel Mirea wrote: > Hello, > > NXP's S32V234[1] ("Treerunner") vision microprocessors are targeted for > high-performance, computationally intensive vision and sensor fusion > applications that require automotive safety levels. They include leadi

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-07 Thread Greg KH
On Thu, Mar 07, 2019 at 10:03:43AM -0500, Joel Fernandes wrote: > On Thu, Mar 07, 2019 at 09:58:24AM +0100, Geert Uytterhoeven wrote: > > Hi Joel, > > > > On Fri, Mar 1, 2019 at 5:10 PM Joel Fernandes (Google) > > wrote: > > > Introduce in-kernel headers and other artifacts which are made availab

Re: [RFC] Provide in-kernel headers for making it easy to extend the kernel

2019-03-07 Thread Greg KH
On Thu, Mar 07, 2019 at 09:41:24PM +0100, Enrico Weigelt, metux IT consult wrote: > On 07.03.19 02:49, Daniel Colascione wrote: > > > Entirely FS-less operation is uncommon, granted. :-) I guess I've just > > spent too much time debugging emulators that refuse to mount their> root > > filesystem

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Greg KH
On Fri, Mar 08, 2019 at 05:42:32AM -0800, Joel Fernandes wrote: > HI Geert, > > On Fri, Mar 8, 2019, 3:53 AM Geert Uytterhoeven wrote: > > > It is just so much easier to use tar + xz at build time, and leave the > > > decompression task to the user. After decompression, the files will live > > >

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Greg KH
On Fri, Mar 08, 2019 at 02:57:24PM +0100, Enrico Weigelt, metux IT consult wrote: > On 08.03.19 14:42, Joel Fernandes wrote: > > Hi folks, > > > That sounds like it could be useful. I don't see any reason off the > > top why that would not be possible to add to the list of archived > > files in

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-08 Thread Greg KH
On Fri, Mar 08, 2019 at 06:59:23PM +0100, Geert Uytterhoeven wrote: > Hi Greg, > > On Fri, Mar 8, 2019 at 6:05 PM Greg KH wrote: > > On Fri, Mar 08, 2019 at 05:42:32AM -0800, Joel Fernandes wrote: > > > On Fri, Mar 8, 2019, 3:53 AM Geert Uytterhoeven > > > wr

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-09 Thread Greg KH
On Sat, Mar 09, 2019 at 12:40:01PM +0100, Geert Uytterhoeven wrote: > > Signing keys should be kept secure, or better yet, just deleted entirely > > after creating and signing with them. That's what I do for my kernels > > and I'm pretty sure that some distros also do this. That way there's no >

Re: [Linux-kernel-mentees] [PATCH] Documentation: platform: convert x86-laptop-drivers.txt to reST

2019-06-17 Thread Greg KH
On Tue, Jun 18, 2019 at 11:02:27AM +0530, Puranjay Mohan wrote: > This converts the plain text documentation to reStructuredText format. > No essential content change. > > Signed-off-by: Puranjay Mohan > --- > Documentation/platform/x86-laptop-drivers.rst | 23 +++ > Documentatio

Re: [Linux-kernel-mentees] [PATCH] Documentation: platform: convert x86-laptop-drivers.txt to reST

2019-06-18 Thread Greg KH
On Tue, Jun 18, 2019 at 07:17:17AM -0600, Jonathan Corbet wrote: > On Tue, 18 Jun 2019 07:41:58 +0200 > Greg KH wrote: > > > On Tue, Jun 18, 2019 at 11:02:27AM +0530, Puranjay Mohan wrote: > > > This converts the plain text documentation to reStructuredText format. &g

Re: [PATCH v2 00/22] Add ABI and features docs to the Kernel documentation

2019-06-21 Thread Greg KH
On Thu, Jun 20, 2019 at 02:22:52PM -0300, Mauro Carvalho Chehab wrote: > This is a rebased version of the scripts with parse > Documentation/ABI and Documentation/feature files > and produce a ReST output. Those scripts are added to the > Kernel building system, in order to output their contents >

Re: [PATCH 04/15] fpga: dfl: fme: support 512bit data width PR

2019-07-03 Thread Greg KH
On Thu, Jun 27, 2019 at 05:49:40PM -0700, Moritz Fischer wrote: > From: Wu Hao > > In early partial reconfiguration private feature, it only > supports 32bit data width when writing data to hardware for > PR. 512bit data width PR support is an important optimization > for some specific solutions

Re: [PATCH 05/15] Documentation: fpga: dfl: add descriptions for virtualization and new interfaces.

2019-07-03 Thread Greg KH
On Thu, Jun 27, 2019 at 05:49:41PM -0700, Moritz Fischer wrote: > From: Wu Hao > > This patch adds virtualization support description for DFL based > FPGA devices (based on PCIe SRIOV), and introductions to new > interfaces added by new dfl private feature drivers. > > [m...@kernel.org: Fixed up

Re: [PATCH 06/15] fpga: dfl: fme: add DFL_FPGA_FME_PORT_RELEASE/ASSIGN ioctl support.

2019-07-03 Thread Greg KH
On Thu, Jun 27, 2019 at 05:49:42PM -0700, Moritz Fischer wrote: > From: Wu Hao > > In order to support virtualization usage via PCIe SRIOV, this patch > adds two ioctls under FPGA Management Engine (FME) to release and > assign back the port device. In order to safely turn Port from PF > into VF

Re: [PATCH 05/15] Documentation: fpga: dfl: add descriptions for virtualization and new interfaces.

2019-07-03 Thread Greg KH
On Thu, Jul 04, 2019 at 07:38:22AM +0800, Wu Hao wrote: > On Wed, Jul 03, 2019 at 07:59:26PM +0200, Greg KH wrote: > > On Thu, Jun 27, 2019 at 05:49:41PM -0700, Moritz Fischer wrote: > > > From: Wu Hao > > > > > > This patch adds virtualization support

Re: [PATCH 06/15] fpga: dfl: fme: add DFL_FPGA_FME_PORT_RELEASE/ASSIGN ioctl support.

2019-07-03 Thread Greg KH
On Thu, Jul 04, 2019 at 07:30:58AM +0800, Wu Hao wrote: > On Wed, Jul 03, 2019 at 08:07:53PM +0200, Greg KH wrote: > > On Thu, Jun 27, 2019 at 05:49:42PM -0700, Moritz Fischer wrote: > > > From: Wu Hao > > > > > > In order to support virtualization usage via P

Re: [PATCH v4 1/2] tiocsti-restrict : Add owner user namespace to tty_struct

2017-05-03 Thread Greg KH
On Wed, May 03, 2017 at 12:32:07PM -0700, Kees Cook wrote: > On Mon, Apr 24, 2017 at 6:57 AM, Serge E. Hallyn wrote: > > Quoting Matt Brown (m...@nmatt.com): > >> This patch adds struct user_namespace *owner_user_ns to the tty_struct. > >> Then it is set to current_user_ns() in the alloc_tty_struc

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

2017-06-06 Thread Greg KH
On Mon, Jun 05, 2017 at 12:22:13PM +0300, Felipe Balbi wrote: > > Hi, > > Ruslan Bilovol writes: > >> Ruslan Bilovol writes: > >>> I came to this patch series when wanted to do two things: > >>> - use UAC1 as virtual ALSA sound card on gadget side, > >>>just like UAC2 is used so it's possi

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2017-06-06 Thread Greg KH
On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > This patchset moves drivers/staging/unisys/include to > include/linux/visorbus, and moves drivers/staging/unisys/visorbus to > drivers/virt/visorbus. Um, are you thinking it is ready to be moved? Have you asked for another review?

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2017-06-06 Thread Greg KH
On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > > This patchset moves drivers/staging/unisys/include to > > include/linux/visorbus, and moves drivers/staging/unisys/visorbus to > > drivers/virt/visor

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2017-06-06 Thread Greg KH
On Tue, Jun 06, 2017 at 04:53:22PM +0200, Greg KH wrote: > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > > On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > > > This patchset moves drivers/staging/unisys/include to > > > include/linux/

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2017-06-06 Thread Greg KH
On Tue, Jun 06, 2017 at 04:54:30PM +0200, Greg KH wrote: > On Tue, Jun 06, 2017 at 04:53:22PM +0200, Greg KH wrote: > > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > > > On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote: > > > > This patchse

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2017-06-06 Thread Greg KH
On Tue, Jun 06, 2017 at 08:33:49AM -0700, Joe Perches wrote: > On Tue, 2017-06-06 at 16:53 +0200, Greg KH wrote: > > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote: > > > I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you > > > have 2 tabs

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2017-06-06 Thread Greg KH
On Tue, Jun 06, 2017 at 08:52:27AM -0700, Joe Perches wrote: > On Tue, 2017-06-06 at 17:39 +0200, Greg KH wrote: > > On Tue, Jun 06, 2017 at 08:33:49AM -0700, Joe Perches wrote: > > > On Tue, 2017-06-06 at 16:53 +0200, Greg KH wrote: > > > > On Tue, Jun 06, 2017 at 0

Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus

2017-06-06 Thread Greg KH
On Tue, Jun 06, 2017 at 06:20:17PM +, Kershner, David A wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, June 6, 2017 11:06 AM > > To: Kershner, David A > > Cc: cor...@lwn.net; t...@linutro

Re: [PATCH v2 6/8] usb: gadget: f_acm: add an ioctl to get the current line coding

2017-06-13 Thread Greg KH
On Tue, Jun 13, 2017 at 09:52:12AM +0300, Tal Shorer wrote: > The user can issue USB_F_GET_LINE_CODING to get the current line coding > as set by the host (or the default if unset yet). > > Signed-off-by: Tal Shorer > --- > Documentation/ioctl/ioctl-number.txt | 1 + > drivers/usb/gadget/functi

Re: [PATCH] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 05:09:32PM +0800, Kai-Heng Feng wrote: > +/* Works only for digits and letters, but small and fast */ > +#define TOLOWER(x) ((x) | 0x20) What is wrong with the in-kernel version of tolower()? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH v2] usb: core: Add "quirks" parameter for usbcore

2017-12-06 Thread Greg KH
On Wed, Dec 06, 2017 at 06:26:21PM +0800, Kai-Heng Feng wrote: > Trying quirks in usbcore needs to rebuild the driver or the entire > kernel if it's builtin. It can save a lot of time if usbcore has similar > ability like "usbhid.quirks=" and "usb-storage.quirks=". > > Rename the original quirk de

Re: device attribute documentation

2017-12-14 Thread Greg KH
On Thu, Dec 14, 2017 at 10:09:44AM -0700, Jonathan Corbet wrote: > On Thu, 14 Dec 2017 15:30:13 +0100 (CET) > Julia Lawall wrote: > > [CC += Greg in case he disagrees] > > > My intern, Aishwarya Pant, is looking into how to improve the > > documentation of device attributes. She collected a lis

Re: [PATCH v3] arm64: v8.4: Support for new floating point multiplication instructions

2018-01-04 Thread Greg KH
On Fri, Jan 05, 2018 at 09:22:54AM +0800, gengdongjiu wrote: > Hi will/catalin > > On 2017/12/13 18:09, Suzuki K Poulose wrote: > > On 13/12/17 10:13, Dongjiu Geng wrote: > >> ARM v8.4 extensions add new neon instructions for performing a > >> multiplication of each FP16 element of one vector with

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Greg KH
On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae Hyun Yoo wrote: > From: Jae Hyun Yoo > > Hello, > > This patch set provides support for PECI of AST2400/2500 which can give us > PECI > functionalities such as temperature monitoring, platform manageability, > processor diagnostics and failure analy

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-10 Thread Greg KH
On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: > +#pragma pack(push, 1) > +struct peci_xfer_msg { > + unsigned char client_addr; > + unsigned char tx_len; > + unsigned char rx_len; > + unsigned char tx_buf[MAX_BUFFER_SIZE]; > + unsigned char rx_buf[MAX_BUFFER_SIZE

Re: [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers

2018-01-10 Thread Greg KH
On Tue, Jan 09, 2018 at 02:31:23PM -0800, Jae Hyun Yoo wrote: > This commit adds driver implementation for Aspeed PECI. Also adds > generic peci.h and peci_ioctl.h files to provide compatibility > to peci drivers that can be implemented later e.g. Nuvoton's BMC > SoC family. We don't add code that

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Greg KH
On Wed, Jan 10, 2018 at 11:14:34AM -0800, Jae Hyun Yoo wrote: > On 1/10/2018 2:17 AM, Greg KH wrote: > > On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae Hyun Yoo wrote: > > > From: Jae Hyun Yoo > > > > > > Hello, > > > > > > This patch set pr

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Greg KH
On Wed, Jan 10, 2018 at 11:30:05AM -0800, Jae Hyun Yoo wrote: > On 1/10/2018 11:17 AM, Greg KH wrote: > > On Wed, Jan 10, 2018 at 11:14:34AM -0800, Jae Hyun Yoo wrote: > > > On 1/10/2018 2:17 AM, Greg KH wrote: > > > > On Tue, Jan 09, 2018 at 02:31:20PM -0800, Jae

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-10 Thread Greg KH
On Wed, Jan 10, 2018 at 01:46:34PM -0800, Jae Hyun Yoo wrote: > On 1/10/2018 12:27 PM, Greg KH wrote: > > On Wed, Jan 10, 2018 at 11:30:05AM -0800, Jae Hyun Yoo wrote: > > > On 1/10/2018 11:17 AM, Greg KH wrote: > > > > On Wed, Jan 10, 2018 at 11:14:34AM -0800, Jae

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-11 Thread Greg KH
On Thu, Jan 11, 2018 at 12:28:48AM -0800, Joel Stanley wrote: > On Wed, Jan 10, 2018 at 11:30 PM, Greg KH wrote: > > On Wed, Jan 10, 2018 at 01:46:34PM -0800, Jae Hyun Yoo wrote: > >> Thanks for your pointing it out and I totally agree with you. Actually, we > >> are pr

Re: [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers

2018-01-11 Thread Greg KH
On Thu, Jan 11, 2018 at 07:56:51PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2018-01-11 at 08:30 +0100, Greg KH wrote: > > 4.13? Why that kernel? It too is obsolete and insecure and > > unsupported. > > Haha, it's n-1. come on :-) And, if you use it in a

Re: [PATCH] Staging: netlogic: platform_net: Fixed '(' at the EOL

2018-01-16 Thread Greg KH
On Tue, Jan 16, 2018 at 07:33:03PM +0530, Naveen Panwar wrote: > Hi Guys, > > I submitted a new patch with the suggestions from Al Viro, did you guys > check it? I do not see any patch from my in my queue :( -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-21 Thread Greg KH
On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: > This commit adds driver implementation for PECI bus into linux > driver framework. > > Signed-off-by: Jae Hyun Yoo > --- Why is there no other Intel developers willing to review and sign off on this patch? Please get their review f

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-21 Thread Greg KH
On Wed, Feb 21, 2018 at 12:42:30PM -0800, Jae Hyun Yoo wrote: > On 2/21/2018 9:58 AM, Greg KH wrote: > > On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: > > > This commit adds driver implementation for PECI bus into linux > > > driver framework. > >

Re: [PATCH] [v2] docs: clarify security-bugs disclosure policy

2018-03-08 Thread Greg KH
On Wed, Mar 07, 2018 at 01:46:24PM -0800, Dave Hansen wrote: > > From: Dave Hansen > > I think we need to soften the language a bit. It might scare folks > off, especially the: > >We prefer to fully disclose the bug as soon as possible. > > which is not really the case. Linus says: >

Re: make xmldocs failed with error after 4.17 merge period

2018-04-06 Thread Greg KH
On Fri, Apr 06, 2018 at 10:51:09AM +0300, Heikki Krogerus wrote: > On Fri, Apr 06, 2018 at 12:38:42PM +0900, Masanari Iida wrote: > > After merge following patch during 4.17 merger period, > > make xmldocs start to fail with error. > > > > [bdecb33af34f79cbfbb656661210f77c8b8b5b5f] > > usb: typec

Re: make xmldocs failed with error after 4.17 merge period

2018-04-06 Thread Greg KH
On Fri, Apr 06, 2018 at 11:15:55AM +0300, Heikki Krogerus wrote: > On Fri, Apr 06, 2018 at 09:57:34AM +0200, Greg KH wrote: > > On Fri, Apr 06, 2018 at 10:51:09AM +0300, Heikki Krogerus wrote: > > > On Fri, Apr 06, 2018 at 12:38:42PM +0900, Masanari Iida wrote: > > > &g

Re: [PATCH] Documentation: fix reST markup error in driver-api/usb/typec.rst

2018-04-08 Thread Greg KH
On Sun, Apr 08, 2018 at 10:47:12AM +0800, changbin...@intel.com wrote: > From: Changbin Du > > There is an format error in driver-api/usb/typec.rst that breaks sphinx > docs building. > > reST markup error: > /home/changbin/work/linux/Documentation/driver-api/usb/typec.rst:215: > (SEVERE/4) Une

Re: [PATCH v3 0/3] Add driver for Synopsys DesignWare I3C master IP

2018-11-11 Thread Greg KH
On Thu, Nov 08, 2018 at 05:14:08PM +, Vitor soares wrote: > This patch series is a proposal for the I3C master driver for Synopsys IP. > This patch is to be applied on top of I3C subsystem RFC V10 submitted by > Boris Brezillon. I'd like to get Boris's reviewed/signed-off on these before I tak

Re: [PATCH v1 1/2]: Documentation/admin-guide: update admin-guide index.rst

2018-11-19 Thread Greg KH
On Mon, Nov 19, 2018 at 08:41:31AM +0300, Alexey Budankov wrote: > > Extend index.rst index file at admin-guide root directory with > the reference to perf-security.rst file being introduced. > > Signed-off-by: Alexey Budankov > --- > Documentation/admin-guide/index.rst | 1 + > 1 file changed

Re: [PATCH v3] code-of-conduct: Remove explicit list of discrimination factors

2018-12-03 Thread Greg KH
On Mon, Dec 03, 2018 at 12:53:00PM +0100, Geert Uytterhoeven wrote: > Hi Greg, > > On Mon, Dec 3, 2018 at 12:05 PM Greg Kroah-Hartman > wrote: > > On Sun, Dec 02, 2018 at 10:32:57AM +0100, Geert Uytterhoeven wrote: > > > Providing an explicit list of discrimination factors may give the false > >

Re: [PATCH v2 1/5] fs: kernfs: add poll file operation

2019-01-10 Thread Greg KH
On Thu, Jan 10, 2019 at 02:07:14PM -0800, Suren Baghdasaryan wrote: > From: Johannes Weiner > > Kernfs has a standardized poll/notification mechanism for waking all > pollers on all fds when a filesystem node changes. To allow polling > for custom events, add a .poll callback that can override th

Re: doc: stable-api-nonsense missing link

2019-01-17 Thread Greg KH
On Thu, Jan 17, 2019 at 03:19:53PM -0700, Jonathan Corbet wrote: > On Thu, 17 Jan 2019 23:14:08 +0100 > Federico Vaga wrote: > > > in this document > > > > Documentation/process/stable-api-nonsense.rst > > > > there is this note: > > > > > > > > Is it possible to get it fixed with the proper

Re: doc: stable-api-nonsense missing link

2019-01-17 Thread Greg KH
On Fri, Jan 18, 2019 at 08:20:31AM +0100, Greg KH wrote: > On Thu, Jan 17, 2019 at 03:19:53PM -0700, Jonathan Corbet wrote: > > On Thu, 17 Jan 2019 23:14:08 +0100 > > Federico Vaga wrote: > > > > > in this document > > > > > > Documentation/proce

Re: [RFC] Provide in-kernel headers for making it easy to extend the kernel

2019-01-19 Thread Greg KH
On Fri, Jan 18, 2019 at 05:55:43PM -0500, Joel Fernandes wrote: > --- /dev/null > +++ b/kernel/kheaders.c > @@ -0,0 +1,74 @@ > +// SPDX-License-Identifier: GPL-2.0 Nice, but: > +MODULE_LICENSE("GPL"); That means "GPL2+" (yeah, horrible, I know, we all get it wrong, look at include/linux/module

Re: [RFC] Provide in-kernel headers for making it easy to extend the kernel

2019-01-19 Thread Greg KH
On Fri, Jan 18, 2019 at 05:55:43PM -0500, Joel Fernandes wrote: > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -549,6 +549,16 @@ config IKCONFIG_PROC > This option enables access to the kernel configuration file > through /proc/config.gz. > > +config IKHEADERS_PROC > + tristat

Re: [PATCH] doc:process: remove note from 'stable api nonsense'

2019-01-19 Thread Greg KH
On Fri, Jan 18, 2019 at 10:58:04PM +0100, Federico Vaga wrote: > The link referred by the note can't be retrieved: this patch just > remove that old note. > > Signed-off-by: Federico Vaga > --- > Documentation/process/stable-api-nonsense.rst | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions

Re: [RFC] Provide in-kernel headers for making it easy to extend the kernel

2019-01-19 Thread Greg KH
On Sat, Jan 19, 2019 at 02:28:00AM -0800, Christoph Hellwig wrote: > This seems like a pretty horrible idea and waste of kernel memory. It's only a waste if you want it to be a waste, i.e. if you load the kernel module. This really isn't any different from how /proc/config.gz works. > Just add s

Re: [PATCH] doc:process: remove note from 'stable api nonsense'

2019-01-21 Thread Greg KH
On Mon, Jan 21, 2019 at 09:14:00AM +0100, Federico Vaga wrote: > On Monday, January 21, 2019 2:43:38 AM CET Jonathan Corbet wrote: > > On Fri, 18 Jan 2019 22:58:04 +0100 > > > > Federico Vaga wrote: > > > The link referred by the note can't be retrieved: this patch just > > > remove that old note

Re: [PATCH] doc: process: GPL -> GPL-compatible

2019-01-22 Thread Greg KH
On Tue, Jan 22, 2019 at 10:34:08AM +0100, Adam Borowski wrote: > Drivers under MIT, BSD-17-clause, or uncle-Bob's-newest-take-on-PD are > all fine, not just GPL. > > Signed-off-by: Adam Borowski > --- > Not reformatting to fill lines, it'll semi-conflict with another patch > that's been acked but

Re: [PATCH] Documentation/process/howto: Update for 4.x -> 5.x versioning

2019-02-24 Thread Greg KH
On Sun, Feb 24, 2019 at 11:16:56AM +0100, Federico Vaga wrote: > hello, > > I have just a general observation for the community, not related to the > content of this patch, but related with the idea behind. > > Is it really important to specify the major release number in the documents? > . >

Re: [PATCH] Documentation/process/howto: Update for 4.x -> 5.x versioning

2019-02-24 Thread Greg KH
On Sun, Feb 24, 2019 at 04:43:20PM +0800, Zenghui Yu wrote: > As linux-5.0 is coming up soon, the howto.rst document can be > updated for the new kernel version. Change all 4.x references > to 5.x now. > > Signed-off-by: Zenghui Yu > --- > Documentation/process/howto.rst | 24 ---

Re: [PATCH v3 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-02-28 Thread Greg KH
On Thu, Feb 28, 2019 at 10:00:54AM -0500, Joel Fernandes wrote: > > Hmm, isn't it easier to add kernel-headers package on Android? > > I have already been down that road. In the Android ecosystem, the Android > teams only provide a "userspace system image" which goes on the system > partition of t

  1   2   >