Re: [PATCH net-next v2] docs: try to encourage (netdev?) reviewers

s". Extend the section of 7.AdvancedTopics.rst which deals with reviews a little bit to add stuff we had been recommending locally. Signed-off-by: Jakub Kicinski Reviewed-by: Florian Fainelli LGTM! -- Florian

Re: [PATCH v4] docs: dt-bindings: add DTS Coding Style document

Reviewed-by: Geert Uytterhoeven Signed-off-by: Krzysztof Kozlowski Reviewed-by: Florian Fainelli -- Florian

[PATCH] Documentation: dontdiff: Update with additional entries

Add a bunch of entries reflective of programs that the kernel build: sortextable, dtc. And while at it, expand the lex*.c entries to cover e.g: dtc-lexer.c. Finally, exclude devicetable-offsets.h Signed-off-by: Florian Fainelli --- Documentation/dontdiff | 7 +-- 1 file changed, 5

[PATCH 2/2] hwmon: (lm70) Add support for TI TMP122/124

Add support for Texas Instruments TMP122/124 which are nearly identical to their TMP121/123 except that they also support programmable temperature thresholds. Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/hwmon/lm70.txt | 1 + Documentation/hwmon/lm70

[PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

We have a device reference, utilize it instead of pr_warn(). Signed-off-by: Florian Fainelli --- drivers/hwmon/lm70.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c index d6ecd1a4be59..52c5cdd00448 100644 --- a/drivers/hwmon

[PATCH 0/2] hwmon: (lm70) Couple patches

Hi Guenter, Here are a couple of patches against lm70. I plan on submitting support for configurable thresholds on TI TMP122/124 once I have resolved the lack SPI_3WIRE on the controller that connects to this chip on my board. Thanks! Florian Fainelli (2): hwmon: (lm70) Utilize dev_warn

Re: [PATCH 2/2] hwmon: (lm70) Add support for TI TMP122/124

On January 21, 2017 12:25:21 PM PST, Guenter Roeck wrote: >On 01/21/2017 11:20 AM, Florian Fainelli wrote: >> Add support for Texas Instruments TMP122/124 which are nearly >identical to >> their TMP121/123 except that they also support programmable >temperature >> thre

Re: [PATCH v1] net: phy: Delete unused function phy_ethtool_gset

On 06/05/2017 12:18 AM, Yuval Shaia wrote: > It's unused, so remove it. > > Signed-off-by: Yuval Shaia Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.or

Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys with __pa_symbol

ide: Replace uses of > virt_to_phys with __pa_symbol") > > Signed-off-by: Geert Uytterhoeven Acked-by: Florian Fainelli Sorry for not noticing earlier. > --- > Documentation/arm/firmware.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/D

Re: [PATCH 01/11] phy: add phy_interface_mode_is_8023z() helper

On 12/01/2017 02:24 AM, Russell King wrote: > Add and use phy_interface_mode_is_8023z() helper to identify the > interface modes that use 802.3z negotiation. Use it in phylink's > phylink_mac_an_restart(). > > Signed-off-by: Russell King Reviewed-by: Florian Fainell

Re: [PATCH 03/11] phylink: get rid of separate Cisco SGMII and 802.3z modes

g Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/11] phylink: merge SGMII and 802.3z handling

he same link handling behaviour as before. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/11] phylink: add support for 2500baseX and 10GbaseKR

On 12/01/2017 02:24 AM, Russell King wrote: > Add support for handling the faster 2.5G and 10G link modes when used > with SFP modules. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 05/11] phylink: remove phylink_init_eee()

On 12/01/2017 02:24 AM, Russell King wrote: > phylink_init_eee() serves no purpose, remove it. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord

Re: [PATCH 06/11] phylink: restart 802.3z negotiation when starting net device

On 12/01/2017 02:24 AM, Russell King wrote: > Restart 802.3z negotiation when the net device is brought up to ensure > that the link partner has our current link modes. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: s

Re: [PATCH 07/11] phylink: add documentation for kernel APIs

On 12/01/2017 02:24 AM, Russell King wrote: > Add kernel-doc documentation for phylink kernel APIs, and link it into > the networking kapi documentation under "Network device support". > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli Thanks! -- Florian

Re: [PATCH 08/11] sfp: add documentation for kernel APIs

On 12/01/2017 02:24 AM, Russell King wrote: > Add kernel-doc documentation for sfp kernel APIs, and link it into the > networking kapi documentation under "Network device support". > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian -- To unsubscrib

Re: [PATCH 09/11] sfp: fix sparse warning

On 12/01/2017 02:24 AM, Russell King wrote: > drivers/net/phy/sfp-bus.c:298:13: warning: context imbalance in > 'sfp_bus_release' - wrong count at exit > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the l

Re: [PATCH 10/11] sfp: convert to fwnode

On 12/01/2017 02:25 AM, Russell King wrote: > Convert sfp-bus to use fwnode rather than device_node internally, so > we can support more than just device tree firmware. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: s

Re: [PATCH 11/11] phylink: convert to fwnode

On 12/01/2017 02:25 AM, Russell King wrote: > Convert phylink to fwnode, switching phylink_create() from taking a > device_node to taking a fwnode_handle. This will allow other firmware > systems to take advantage of sfp/phylink support. > > Signed-off-by: Russell King Revie

Re: [PATCH] net: dsa: Remove documentation for port_fdb_prepare

not quite a functional change, but other than: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 11/13] net: dsa: lan9303: Added "alr_dump" sysfs port attribute

On 07/20/2017 01:49 AM, Egil Hjelmeland wrote: > Added read only file /sys/class/net//lan9303/alr_dump, > that output 168 first ALR entires. > > Currently "bridge fdb show" does not include the CPU port, while > "alr_dump" list all three ports per entry. Agreed, and this is a limitation we would

Re: [PATCH 10/13] net: dsa: lan9303: Only allocate 3 ports

On 07/20/2017 03:35 AM, Egil Hjelmeland wrote: > Saving 2628 bytes. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH 00/13] net: dsa: lan9303: unicast offload, fdb,mdb,STP

Hi, On 07/24/2017 07:47 AM, Egil Hjelmeland wrote: > This series extends the LAN9303 3 port switch DSA driver. Highlights: > - Make the MDIO interface work > - Bridging: Unicast offload > - Bridging: Added fdb/mdb handling > - Bridging: STP support > - Documentation > > The last three patche

Re: [PATCH 12/13] net: dsa: lan9303: Added "stp_enable" sysfs attribute

On 07/20/2017 06:42 AM, Egil Hjelmeland wrote: > Must be set to 1 by user space when STP is used on the lan9303. > If bridging without local STP, leave at 0, so external STP BPDUs > are forwarded. > > Hopefully the kernel can be improved so the driver can handle this > without user intervention, a

Re: [PATCH 13/13] net: dsa: lan9303: lan9303_port_mdb_del remove port 0

On 07/20/2017 06:57 AM, Egil Hjelmeland wrote: > Workaround for dsa_switch_mdb_add adding CPU port to group, > but forgetting to remove it: > > Remove port 0 if only port 0 is only port left. > > Signed-off-by: Egil Hjelmeland > --- > drivers/net/dsa/lan9303-core.c | 11 +++ > 1 file ch

Re: [PATCH] Documentation: networking: dsa: Update tagging protocols

On 11/04/2016 05:16 AM, Fabian Mewes wrote: > Add Qualcomm QCA tagging introduced in cafdc45c9 to the > list of supported protocols. > > Signed-off-by: Fabian Mewes Acked-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-doc&

Re: [PATCH 2/4] fpga: manager: change api, don't use drvdata

On 04/26/2018 06:26 PM, Moritz Fischer wrote: > From: Alan Tull > > Change fpga_mgr_register to not set or use drvdata. This supports > the case where a PCIe device has more than one manager. > > Add fpga_mgr_create/free functions. Change fpga_mgr_register and > fpga_mgr_unregister functions t

Re: [PATCH 2/4] fpga: manager: change api, don't use drvdata

On 04/27/2018 04:30 PM, Alan Tull wrote: > On Fri, Apr 27, 2018 at 1:26 PM, Florian Fainelli > wrote: >> On 04/26/2018 06:26 PM, Moritz Fischer wrote: >>> From: Alan Tull >>> >>> Change fpga_mgr_register to not set or use drvdata. This supports >>

Re: [PATCH v2 00/29] at24: remove at24_platform_data

On 10/3/2018 1:15 PM, Bartosz Golaszewski wrote: pt., 31 sie 2018 o 21:46 Brian Norris napisał(a): Hi, On Fri, Aug 10, 2018 at 10:04:57AM +0200, Bartosz Golaszewski wrote: Most boards use the EEPROM to store the MAC address. This series adds support for cell lookups to the nvmem framework

[PATCH] Documentation: SubmittingPatches: Add note about Reviewed-by tags

maintainer could be doing with those. Some maintainers did complain before that these tags had to be added when the patches get submitted to the public, while some just ignored and took the patches as-is. Signed-off-by: Florian Fainelli --- Documentation/SubmittingPatches | 8 1 file changed

Re: [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

// Call net_dim() 0.21 |4eaf6: call 4eafb To allow the caller to reuse the struct dim_sample already on the stack, pass the struct dim_sample by reference to net_dim(). Signed-off-by: Caleb Sander Mateos Reviewed-by: Florian Fainelli #bcm{sysport,genet}.c Thanks! -- Florian

Re: [resend PATCH 1/2] dim: make dim_calc_stats() inputs const pointers

On 10/30/24 17:23, Caleb Sander Mateos wrote: Make the start and end arguments to dim_calc_stats() const pointers to clarify that the function does not modify their values. Signed-off-by: Caleb Sander Mateos Reviewed-by: Florian Fainelli -- Florian