Re: [v2,3/7] soc: qcom: Add GENI based QUP Wrapper driver

2018-01-26 Thread Doug Anderson
Hi, On Fri, Jan 12, 2018 at 5:05 PM, Karthikeyan Ramasubramanian wrote: > This driver manages the Generic Interface (GENI) firmware based Qualcomm > Universal Peripheral (QUP) Wrapper. GENI based QUP is the next generation > programmable module composed of multiple Serial Engines (SE) and support

Re: [v2, 7/7] tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP

2018-02-23 Thread Doug Anderson
Hi, On Fri, Jan 12, 2018 at 5:05 PM, Karthikeyan Ramasubramanian wrote: > This driver supports GENI based UART Controller in the Qualcomm SOCs. The > Qualcomm Generic Interface (GENI) is a programmable module supporting a > wide range of serial interfaces including UART. This driver support conso

Re: [v3, 3/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-07 Thread Doug Anderson
Hi, On Tue, Feb 27, 2018 at 5:38 PM, Karthikeyan Ramasubramanian wrote: > This bus driver supports the GENI based i2c hardware controller in the > Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable > module supporting a wide range of serial interfaces including I2C. The > driv

Re: [v3, 3/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-07 Thread Doug Anderson
Hi, On Wed, Mar 7, 2018 at 6:42 PM, Sagar Dharia wrote: > Hi Doug, > Thank you for reviewing the patch. I will take a stab at a few comments > below. We will address most of the other comments in next version of I2C > patch. >> >> >> >>> + >>> +#define I2C_AUTO_SUSPEND_DELAY 250 >> >> >> Why 250

Re: [v3, 3/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-08 Thread Doug Anderson
Hi, On Wed, Mar 7, 2018 at 9:19 PM, Doug Anderson wrote: >>> DMA is hard and i2c transfers > 32 bytes are rare. Do we really gain >>> a lot by transferring i2c commands over DMA compared to a FIFO? >>> Enough to justify the code complexity and the set of bugs that

Re: [v3, 3/4] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-08 Thread Doug Anderson
Hi, On Thu, Mar 8, 2018 at 5:06 PM, Sagar Dharia wrote: > Hi Doug > > > On 3/8/2018 2:12 PM, Doug Anderson wrote: >> >> Hi, >> >> On Wed, Mar 7, 2018 at 9:19 PM, Doug Anderson >> wrote: >>>>> >>>>> DMA is hard and i2c trans

Re: [PATCH v4 6/6] arm64: dts: sdm845: Add I2C controller support

2018-03-16 Thread Doug Anderson
Hi, On Wed, Mar 14, 2018 at 4:58 PM, Karthikeyan Ramasubramanian wrote: > Add I2C master controller support for a built-in test I2C slave. > > Signed-off-by: Karthikeyan Ramasubramanian > --- > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 19 +++ > arch/arm64/boot/dts/qcom/sdm845.d

Re: [PATCH v4 3/6] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-19 Thread Doug Anderson
Hi, On Wed, Mar 14, 2018 at 4:58 PM, Karthikeyan Ramasubramanian wrote: > This bus driver supports the GENI based i2c hardware controller in the > Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable > module supporting a wide range of serial interfaces including I2C. The > driv

Re: [PATCH v4 6/6] arm64: dts: sdm845: Add I2C controller support

2018-03-19 Thread Doug Anderson
Hi, On Mon, Mar 19, 2018 at 3:15 PM, Sagar Dharia wrote: >>> + pinconf { >>> + pins = "gpio55", "gpio56"; >>> + drive-strength = <2>; >>> + bias-disable; >>> + };

Re: [PATCH v4 6/6] arm64: dts: sdm845: Add I2C controller support

2018-03-20 Thread Doug Anderson
Hi, On Tue, Mar 20, 2018 at 3:16 PM, Sagar Dharia wrote: > + pinconf { > + pins = "gpio55", "gpio56"; > + drive-strength = <2>; > + bias-disable; > +

Re: [PATCH v5 3/5] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-03-23 Thread Doug Anderson
Hi, On Fri, Mar 23, 2018 at 1:20 PM, Karthikeyan Ramasubramanian wrote: > This bus driver supports the GENI based i2c hardware controller in the > Qualcomm SOCs. The Qualcomm Generic Interface (GENI) is a programmable > module supporting a wide range of serial interfaces including I2C. The > driv

Re: [PATCH v5 5/5] arm64: dts: sdm845: Add support for an instance of I2C controller

2018-03-23 Thread Doug Anderson
Hi, On Fri, Mar 23, 2018 at 1:21 PM, Karthikeyan Ramasubramanian wrote: > + i2c10: i2c@a88000 { > + compatible = "qcom,geni-i2c"; > + reg = <0xa88000 0x4000>; > + clock-names = "se"; >

Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-04 Thread Doug Anderson
Hi, On Tue, Oct 3, 2017 at 9:05 PM, Masahiro Yamada wrote: > Thanks for the patches. The idea is interesting. > > I am not a Chrome developer, but cc-option could be improved somehow. > > > I examined two approaches to mitigate the pain. > > [1] Skip cc-option completely when we run non-build ta

Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-05 Thread Doug Anderson
Hi, On Thu, Oct 5, 2017 at 12:26 AM, Masahiro Yamada wrote: > As far as I tested, I always see only one space after ":=" in v2. > > I did not consider this deeply, > but something is working nicely behind the scene. Try adding this to the end of the main Makefile: +$(info LDFLAGS_BUILD_ID = $(L

Re: [PATCH v2 1/2] kbuild: Add a cache for generated variables

2017-10-11 Thread Doug Anderson
Hi, On Tue, Oct 10, 2017 at 8:59 PM, Masahiro Yamada wrote: > Hi Douglas, > > > 2017-10-05 7:37 GMT+09:00 Douglas Anderson : >> While timing a "no-op" build of the kernel (incrementally building the >> kernel even though nothing changed) in the Chrome OS build system I >> found that it was much s

Re: [RFC PATCH] kbuild: Allow specifying some base host CFLAGS

2017-10-19 Thread Doug Anderson
Hi, On Wed, Oct 18, 2017 at 9:45 AM, Masahiro Yamada wrote: > 2017-10-14 3:02 GMT+09:00 Douglas Anderson : >> Right now there is a way to add some CFLAGS that affect target builds, >> but no way to add CFLAGS that affect host builds. Let's add a way. >> We'll document two environment variables:

Re: [PATCH v5 3/5] i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller

2018-05-21 Thread Doug Anderson
Wolfram, On Fri, Mar 23, 2018 at 4:34 PM, Doug Anderson wrote: > Hi, > > On Fri, Mar 23, 2018 at 1:20 PM, Karthikeyan Ramasubramanian > wrote: >> This bus driver supports the GENI based i2c hardware controller in the >> Qualcomm SOCs. The Qualcomm Generic Interface

Re: [PATCH v6 4/5] arm64: dts: sdm845: Add serial console support

2018-05-23 Thread Doug Anderson
Rajendra, On Tue, May 22, 2018 at 11:30 PM, Rajendra Nayak wrote: > > > On 03/30/2018 10:38 PM, Karthikeyan Ramasubramanian wrote: >> From: Rajendra Nayak >> >> Add the qup uart node and geni se instance needed to >> support the serial console on the MTP. >> >> Signed-off-by: Rajendra Nayak >>

Re: [PATCH v8 06/10] watchdog: dw_wdt: Convert to use watchdog infrastructure

2016-03-01 Thread Doug Anderson
Guenter, On Sun, Feb 28, 2016 at 1:12 PM, Guenter Roeck wrote: > Convert driver to use watchdog infrastructure. This includes > infrastructure support to handle watchdog keepalive if the watchdog > is running while the watchdog device is closed. > > Signed-off-by: Guenter Roeck > > --- > v8: max

Re: [PATCH v6 0/5] dma-mapping: Patches for speeding up allocation

2016-01-26 Thread Doug Anderson
Hi, On Tue, Jan 26, 2016 at 3:59 PM, Andrew Morton wrote: > On Mon, 11 Jan 2016 09:30:22 -0800 Douglas Anderson > wrote: > >> This series of patches will speed up memory allocation in dma-mapping >> quite a bit. > > This is pretty much all ARM and driver stuff so I think I'll duck it. > But I c

Re: [RFT PATCH v7 9/9] watchdog: dw_wdt: Convert to use watchdog infrastructure

2016-01-29 Thread Doug Anderson
Guenter, On Mon, Jan 25, 2016 at 6:53 PM, Guenter Roeck wrote: > From: Guenter Roeck > > Convert driver to use watchdog infrastructure. This includes > infrastructure support to handle watchdog keepalive if the watchdog > is running while the watchdog device is closed. > > Signed-off-by: Guenter

Re: [PATCH v6 0/5] dma-mapping: Patches for speeding up allocation

2016-01-29 Thread Doug Anderson
Hi, On Fri, Jan 29, 2016 at 1:52 PM, Olof Johansson wrote: > On Tue, Jan 26, 2016 at 4:39 PM, Doug Anderson wrote: >> Hi, >> >> On Tue, Jan 26, 2016 at 3:59 PM, Andrew Morton >> wrote: >>> On Mon, 11 Jan 2016 09:30:22 -0800 Douglas Anderson >>>

Re: [PATCH v6 0/5] dma-mapping: Patches for speeding up allocation

2016-01-29 Thread Doug Anderson
Hi, On Fri, Jan 29, 2016 at 1:58 PM, Doug Anderson wrote: >> I think it makes sense to send these through Russell's tracker for him >> to merge, especially since I don't think there are any dependencies on >> them for SoC-specific patches coming up. > > Sounds