[PATCH] Documentation/ftrace: Correct wording on trace_options sharing

: nop > # > JZÊ<¿type: 154 > f>ï>¿type: 154 > -¸ó>¿type: 153 > vW.A?¿type: 154 It seems that since commit 16270145ce6b ("tracing: Add trace options for core options to instances") it is possible to set per-instance trace_options, with an exception to three of th

Re: [PATCH] Documentation/ftrace: Correct wording on trace_options sharing

On 2/20/24 21:00, Dmitry Safonov wrote: [..] > diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst > index 7e7b8ec17934..c79a6bcef3c9 100644 > --- a/Documentation/trace/ftrace.rst > +++ b/Documentation/trace/ftrace.rst > @@ -3603,9 +3603,9 @@ The files in th

Re: [PATCH net-next v2 1/6] net/tcp: Use static_branch_tcp_{md5,ao} to drop ifdefs

On Wed, 5 Jun 2024 at 05:50, Ratheesh Kannoth wrote: > > On 2024-06-05 at 07:50:02, Dmitry Safonov via B4 Relay > (devnull+0x7f454c46.gmail@kernel.org) wrote: > > From: Dmitry Safonov <0x7f454...@gmail.com> > > > > It's possible to clean-up some ifdefs

Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

Hi Eric, Thanks for the review, On Wed, 5 Jun 2024 at 09:07, Eric Dumazet wrote: > > On Wed, Jun 5, 2024 at 4:20 AM Dmitry Safonov via B4 Relay > wrote: > > > > From: Dmitry Safonov <0x7f454...@gmail.com> > > > > Two reasons: > > 1. It'

Re: [PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

On Wed, 5 Jun 2024 at 18:37, Eric Dumazet wrote: > > On Wed, Jun 5, 2024 at 7:35 PM Dmitry Safonov <0x7f454...@gmail.com> wrote: > > > > Hi Eric, > > > > Thanks for the review, > > > > On Wed, 5 Jun 2024 at 09:07, Eric Dumazet wrote: [..]

Re: [PATCH net-next v3 3/6] net/tcp: Move tcp_inbound_hash() from headers

Hi Matthieu, [re-sending as replying from mobile phone never works in plain text] On Thu, 6 Jun 2024 at 10:12, Matthieu Baerts wrote: > > Hi Dmitry, > > On 06/06/2024 02:58, Dmitry Safonov via B4 Relay wrote: > > From: Dmitry Safonov <0x7f454...@gmail.com> > > >

[PATCH] hung_task: Allow printing warnings every check interval

every detection interval. It's not ratelimited, so the root should be cautious configuring it. Cc: Andrew Morton Cc: Dmitry Vyukov Cc: Ingo Molnar Cc: Jonathan Corbet Cc: Tetsuo Handa Cc: Thomas Gleixner Cc: "Peter Zijlstra (Intel)" Cc: Vasiliy Khoruzhick Cc: linu

Re: [PATCH] hung_task: Allow printing warnings every check interval

On 7/25/19 11:38 AM, Tetsuo Handa wrote: > On 2019/07/25 2:02, Dmitry Safonov wrote: >> Hung task detector has one timeout and has two associated actions on it: >> - issuing warnings with names and stacks of blocked tasks >> - panic() >> >> We want switches to pan

Re: [PATCH] hung_task: Allow printing warnings every check interval

On 7/26/19 2:28 PM, Tetsuo Handa wrote: > On 2019/07/26 20:29, Tetsuo Handa wrote: >> On 2019/07/25 23:25, Dmitry Safonov wrote: >>> Yes, also current distributions already using the counter to print >>> warnings number of times and then silently ignore. I.e.,

[PATCH 0/5] pktgen: Behavior flags fixes

"Reshetova, Elena" Cc: net...@vger.kernel.org Dmitry Safonov (5): Documentation/pktgen: Clearify how-to use pktgen samples pktgen: Add missing !flag parameters pktgen: Add behavior flag names array - pkt_flag_names pktgen: Remove brute-force printing of flags pktgen: Clean read use

[PATCH 1/5] Documentation/pktgen: Clearify how-to use pktgen samples

to `source functions.sh`. o Document how-to unset a behaviour flag, note about history expansion. o Fix pgset spi parameter value. Cc: Jonathan Corbet Cc: linux-doc@vger.kernel.org Signed-off-by: Dmitry Safonov --- Documentation/networking/pktgen.txt | 19 ++- 1 file changed, 14

[PATCHv2 1/5] Documentation/pktgen: Clearify how-to use pktgen samples

to `source functions.sh`. o Document how-to unset a behaviour flag, note about history expansion. o Fix pgset spi parameter value. Cc: Jonathan Corbet Cc: linux-doc@vger.kernel.org Signed-off-by: Dmitry Safonov --- Documentation/networking/pktgen.txt | 19 ++- 1 file changed, 14

[PATCHv2 0/5] pktgen: Behavior flags fixes

Cc: Mark Rutland Cc: Radu Rendec Cc: "Reshetova, Elena" Cc: net...@vger.kernel.org Dmitry Safonov (5): Documentation/pktgen: Clearify how-to use pktgen samples pktgen: Add missing !flag parameters pktgen: Add behaviour flags macro to generate flags/names pktgen: Remove brute-for

[PATCH net-next v2 1/6] net/tcp: Use static_branch_tcp_{md5,ao} to drop ifdefs

From: Dmitry Safonov <0x7f454...@gmail.com> It's possible to clean-up some ifdefs by hiding that tcp_{md5,ao}_needed static branch is defined and compiled only under related configs, since commit 4c8530dc7d7d ("net/tcp: Only produce AO/MD5 logs if there are any keys").

[PATCH net-next v2 0/6] net/tcp: TCP-AO and TCP-MD5 tracepoints

Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- Changes in v2: - Fix the build with CONFIG_IPV6=m (Eric Dumazet) - Move unused keyid/rnext/maclen later in the series to the patch that uses them (Simon Horman) - Reworked tcp_ao selftest lib to allow async tracing non-tcp events

[PATCH net-next v2 2/6] net/tcp: Add a helper tcp_ao_hdr_maclen()

From: Dmitry Safonov <0x7f454...@gmail.com> It's going to be used more in TCP-AO tracepoints. Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- include/net/tcp_ao.h | 5 + net/ipv4/tcp_ao.c| 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/inc

[PATCH net-next v2 5/6] net/tcp: Remove tcp_hash_fail()

From: Dmitry Safonov <0x7f454...@gmail.com> Now there are tracepoints, that cover all functionality of tcp_hash_fail(), but also wire up missing places They are also faster, can be disabled and provide filtering. This potentially may create a regression if a userspace depends on dmes

[PATCH net-next v2 3/6] net/tcp: Move tcp_inbound_hash() from headers

From: Dmitry Safonov <0x7f454...@gmail.com> Two reasons: 1. It's grown up enough 2. In order to not do header spaghetti by including , which is necessary for TCP tracepoints. Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- inclu

[PATCH net-next v2 6/6] Documentation/tcp-ao: Add a few lines on tracepoints

From: Dmitry Safonov <0x7f454...@gmail.com> Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- Documentation/networking/tcp_ao.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/networking/tcp_ao.rst b/Documentation/networking/tcp_ao.rst index

[PATCH net-next v2 4/6] net/tcp: Add tcp-md5 and tcp-ao tracepoints

From: Dmitry Safonov <0x7f454...@gmail.com> Instead of forcing userspace to parse dmesg (that's what currently is happening, at least in codebase of my current company), provide a better way, that can be enabled/disabled in runtime. Currently, there are already tcp events, add hash

[PATCH net-next v3 0/6] net/tcp: TCP-AO and TCP-MD5 tracepoints

Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- Changes in v3: - Unexported tcp_inbound_ao_hash() and made static (Eric Dumazet) - Link to v2: https://lore.kernel.org/r/20240605-tcp_ao-tracepoints-v2-0-e91e16128...@gmail.com Changes in v2: - Fix the build with CONFIG_IPV6=m

[PATCH net-next v3 2/6] net/tcp: Add a helper tcp_ao_hdr_maclen()

From: Dmitry Safonov <0x7f454...@gmail.com> It's going to be used more in TCP-AO tracepoints. Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- include/net/tcp_ao.h | 5 + net/ipv4/tcp_ao.c| 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/inc

[PATCH net-next v3 4/6] net/tcp: Add tcp-md5 and tcp-ao tracepoints

From: Dmitry Safonov <0x7f454...@gmail.com> Instead of forcing userspace to parse dmesg (that's what currently is happening, at least in codebase of my current company), provide a better way, that can be enabled/disabled in runtime. Currently, there are already tcp events, add hash

[PATCH net-next v3 3/6] net/tcp: Move tcp_inbound_hash() from headers

From: Dmitry Safonov <0x7f454...@gmail.com> Two reasons: 1. It's grown up enough 2. In order to not do header spaghetti by including , which is necessary for TCP tracepoints. While at it, unexport and make static tcp_inbound_ao_hash(). Signed-off-by: Dmitry Safonov <0x7f45

[PATCH net-next v3 1/6] net/tcp: Use static_branch_tcp_{md5,ao} to drop ifdefs

From: Dmitry Safonov <0x7f454...@gmail.com> It's possible to clean-up some ifdefs by hiding that tcp_{md5,ao}_needed static branch is defined and compiled only under related configs, since commit 4c8530dc7d7d ("net/tcp: Only produce AO/MD5 logs if there are any keys"). Revi

[PATCH net-next v3 5/6] net/tcp: Remove tcp_hash_fail()

From: Dmitry Safonov <0x7f454...@gmail.com> Now there are tracepoints, that cover all functionality of tcp_hash_fail(), but also wire up missing places They are also faster, can be disabled and provide filtering. This potentially may create a regression if a userspace depends on dmes

[PATCH net-next v3 6/6] Documentation/tcp-ao: Add a few lines on tracepoints

From: Dmitry Safonov <0x7f454...@gmail.com> Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- Documentation/networking/tcp_ao.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/networking/tcp_ao.rst b/Documentation/networking/tcp_ao.rst index

[PATCH net-next v4 0/6] net/tcp: TCP-AO and TCP-MD5 tracepoints

Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- Changes in v4: - Fix the build for CONFIG_TCP_MD5SIG=n (Matthieu Baerts, netdev dashboard) - Link to v3: https://lore.kernel.org/r/20240606-tcp_ao-tracepoints-v3-0-13621988c...@gmail.com Changes in v3: - Unexported tcp_inbound_a

[PATCH net-next v4 1/6] net/tcp: Use static_branch_tcp_{md5,ao} to drop ifdefs

From: Dmitry Safonov <0x7f454...@gmail.com> It's possible to clean-up some ifdefs by hiding that tcp_{md5,ao}_needed static branch is defined and compiled only under related configs, since commit 4c8530dc7d7d ("net/tcp: Only produce AO/MD5 logs if there are any keys"). Revi

[PATCH net-next v4 4/6] net/tcp: Add tcp-md5 and tcp-ao tracepoints

From: Dmitry Safonov <0x7f454...@gmail.com> Instead of forcing userspace to parse dmesg (that's what currently is happening, at least in codebase of my current company), provide a better way, that can be enabled/disabled in runtime. Currently, there are already tcp events, add hash

[PATCH net-next v4 2/6] net/tcp: Add a helper tcp_ao_hdr_maclen()

From: Dmitry Safonov <0x7f454...@gmail.com> It's going to be used more in TCP-AO tracepoints. Reviewed-by: Eric Dumazet Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- include/net/tcp_ao.h | 5 + net/ipv4/tcp_ao.c| 2 +- 2 files changed, 6 insertions(+), 1

[PATCH net-next v4 5/6] net/tcp: Remove tcp_hash_fail()

From: Dmitry Safonov <0x7f454...@gmail.com> Now there are tracepoints, that cover all functionality of tcp_hash_fail(), but also wire up missing places They are also faster, can be disabled and provide filtering. This potentially may create a regression if a userspace depends on dmes

[PATCH net-next v4 3/6] net/tcp: Move tcp_inbound_hash() from headers

From: Dmitry Safonov <0x7f454...@gmail.com> Two reasons: 1. It's grown up enough 2. In order to not do header spaghetti by including , which is necessary for TCP tracepoints. While at it, unexport and make static tcp_inbound_ao_hash(). Reviewed-by: Eric Dumazet Signed-off-by: Dmi

[PATCH net-next v4 6/6] Documentation/tcp-ao: Add a few lines on tracepoints

From: Dmitry Safonov <0x7f454...@gmail.com> Signed-off-by: Dmitry Safonov <0x7f454...@gmail.com> --- Documentation/networking/tcp_ao.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/networking/tcp_ao.rst b/Documentation/networking/tcp_ao.rst index