Re: [PATCH v7 1/2] arm64: Define Documentation/arm64/tagged-address-abi.rst

2019-08-08 Thread Dave Martin
On Wed, Aug 07, 2019 at 01:38:16PM -0700, Dave Hansen wrote: [Random comments below on a couple of points] > On 8/7/19 8:53 AM, Catalin Marinas wrote: > > +- mmap() done by the process itself (or its parent), where either: > > + > > + - flags have the **MAP_ANONYMOUS** bit set > > + - the file

Re: [PATCH v7 1/2] arm64: Define Documentation/arm64/tagged-address-abi.rst

2019-08-13 Thread Dave Martin
On Mon, Aug 12, 2019 at 06:36:12PM +0100, Catalin Marinas wrote: > On Fri, Aug 09, 2019 at 07:10:18AM -0700, Dave Hansen wrote: > > On 8/8/19 10:27 AM, Catalin Marinas wrote: > > > On Wed, Aug 07, 2019 at 01:38:16PM -0700, Dave Hansen wrote: > > >> Also, shouldn't this be converted over to an arch_

Re: [PATCH v8 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-08-16 Thread Dave Martin
On Tue, Aug 13, 2019 at 01:52:20PM -0700, Yu-cheng Yu wrote: > An ELF file's .note.gnu.property indicates features the executable file > can support. For example, the property GNU_PROPERTY_X86_FEATURE_1_AND > indicates the file supports GNU_PROPERTY_X86_FEATURE_1_IBT and/or > GNU_PROPERTY_X86_FEAT

Re: [PATCH v8 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-08-20 Thread Dave Martin
On Tue, Aug 13, 2019 at 01:52:20PM -0700, Yu-cheng Yu wrote: > An ELF file's .note.gnu.property indicates features the executable file > can support. For example, the property GNU_PROPERTY_X86_FEATURE_1_AND > indicates the file supports GNU_PROPERTY_X86_FEATURE_1_IBT and/or > GNU_PROPERTY_X86_FEAT

Re: [PATCH v9 3/3] arm64: Relax Documentation/arm64/tagged-pointers.rst

2019-08-21 Thread Dave Martin
On Wed, Aug 21, 2019 at 06:33:53PM +0100, Will Deacon wrote: > On Wed, Aug 21, 2019 at 05:47:30PM +0100, Catalin Marinas wrote: > > From: Vincenzo Frascino > > > > On AArch64 the TCR_EL1.TBI0 bit is set by default, allowing userspace > > (EL0) to perform memory accesses through 64-bit pointers wi

Re: [PATCH v9 3/3] arm64: Relax Documentation/arm64/tagged-pointers.rst

2019-08-22 Thread Dave Martin
On Thu, Aug 22, 2019 at 04:55:32PM +0100, Catalin Marinas wrote: > On Wed, Aug 21, 2019 at 07:46:51PM +0100, Dave P Martin wrote: > > On Wed, Aug 21, 2019 at 06:33:53PM +0100, Will Deacon wrote: > > > On Wed, Aug 21, 2019 at 05:47:30PM +0100, Catalin Marinas wrote: > > > > @@ -59,6 +63,11 @@ be pre

Re: [PATCH v9 3/3] arm64: Relax Documentation/arm64/tagged-pointers.rst

2019-08-23 Thread Dave Martin
On Fri, Aug 23, 2019 at 05:19:13PM +0100, Catalin Marinas wrote: > On Thu, Aug 22, 2019 at 05:37:23PM +0100, Dave P Martin wrote: > > On Thu, Aug 22, 2019 at 04:55:32PM +0100, Catalin Marinas wrote: > > > On Wed, Aug 21, 2019 at 07:46:51PM +0100, Dave P Martin wrote: [...] > > > > sigaltstack() i

Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-07 Thread Dave Martin
On Thu, Jun 06, 2019 at 01:06:41PM -0700, Yu-cheng Yu wrote: > An ELF file's .note.gnu.property indicates features the executable file > can support. For example, the property GNU_PROPERTY_X86_FEATURE_1_AND > indicates the file supports GNU_PROPERTY_X86_FEATURE_1_IBT and/or > GNU_PROPERTY_X86_FEAT

Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-10 Thread Dave Martin
On Mon, Jun 10, 2019 at 09:29:04AM -0700, Yu-cheng Yu wrote: > On Fri, 2019-06-07 at 19:01 +0100, Dave Martin wrote: > > On Thu, Jun 06, 2019 at 01:06:41PM -0700, Yu-cheng Yu wrote: > > > An ELF file's .note.gnu.property indicates features the executable file > > >

Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-11 Thread Dave Martin
On Mon, Jun 10, 2019 at 07:24:43PM +0200, Florian Weimer wrote: > * Yu-cheng Yu: > > > To me, looking at PT_GNU_PROPERTY and not trying to support anything is a > > logical choice. And it breaks only a limited set of toolchains. > > > > I will simplify the parser and leave this patch as-is for an

Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-12 Thread Dave Martin
On Tue, Jun 11, 2019 at 12:31:34PM -0700, Yu-cheng Yu wrote: > On Tue, 2019-06-11 at 12:41 +0100, Dave Martin wrote: > > On Mon, Jun 10, 2019 at 07:24:43PM +0200, Florian Weimer wrote: > > > * Yu-cheng Yu: > > > > > > > To me, looking at PT_GNU_PROPERT

Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-13 Thread Dave Martin
On Wed, Jun 12, 2019 at 12:04:01PM -0700, Yu-cheng Yu wrote: > On Wed, 2019-06-12 at 10:32 +0100, Dave Martin wrote: > > On Tue, Jun 11, 2019 at 12:31:34PM -0700, Yu-cheng Yu wrote: > > > On Tue, 2019-06-11 at 12:41 +0100, Dave Martin wrote: > > > > On Mon, Ju

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Dave Martin
On Thu, Jun 13, 2019 at 01:28:21PM +0100, Catalin Marinas wrote: > On Thu, Jun 13, 2019 at 12:37:32PM +0100, Dave P Martin wrote: > > On Thu, Jun 13, 2019 at 11:15:34AM +0100, Vincenzo Frascino wrote: > > > On 12/06/2019 16:35, Catalin Marinas wrote: > > > > On Wed, Jun 12, 2019 at 03:21:10PM +0100

Re: [PATCH v4 1/2] arm64: Define Documentation/arm64/tagged-address-abi.txt

2019-06-13 Thread Dave Martin
On Thu, Jun 13, 2019 at 11:15:34AM +0100, Vincenzo Frascino wrote: > Hi Catalin, > > On 12/06/2019 16:35, Catalin Marinas wrote: > > Hi Vincenzo, > > > > Some minor comments below but it looks fine to me overall. Cc'ing > > Szabolcs as well since I'd like a view from the libc people. > > > > Th

Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-18 Thread Dave Martin
On Mon, Jun 17, 2019 at 02:20:40PM +0200, Thomas Gleixner wrote: > On Mon, 17 Jun 2019, Florian Weimer wrote: > > * Dave Martin: > > > On Tue, Jun 11, 2019 at 12:31:34PM -0700, Yu-cheng Yu wrote: > > >> We can probably check PT_GNU_PROPERTY first, and fallb

Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-18 Thread Dave Martin
On Tue, Jun 18, 2019 at 02:55:12PM +0200, Peter Zijlstra wrote: > On Tue, Jun 18, 2019 at 02:47:00PM +0200, Florian Weimer wrote: > > * Peter Zijlstra: > > > > > I'm not sure I read Thomas' comment like that. In my reading keeping the > > > PT_NOTE fallback is exactly one of those 'fly workarounds

Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-18 Thread Dave Martin
On Tue, Jun 18, 2019 at 09:00:35AM -0700, Yu-cheng Yu wrote: > On Tue, 2019-06-18 at 18:05 +0200, Florian Weimer wrote: > > * Yu-cheng Yu: > > > > > > I assumed that it would also parse the main executable and make > > > > adjustments based on that. > > > > > > Yes, Linux also looks at the main e

Re: [PATCH v7 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-18 Thread Dave Martin
On Tue, Jun 18, 2019 at 06:25:51PM +0200, Florian Weimer wrote: > * Dave Martin: > > > On Tue, Jun 18, 2019 at 09:00:35AM -0700, Yu-cheng Yu wrote: > >> On Tue, 2019-06-18 at 18:05 +0200, Florian Weimer wrote: > >> > * Yu-cheng Yu: > >> > > >

Re: [PATCH] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-06-27 Thread Dave Martin
On Wed, Jun 26, 2019 at 10:14:07AM -0700, Andy Lutomirski wrote: > On Thu, May 2, 2019 at 4:10 AM Dave Martin wrote: [...] > > A couple of questions before I look in more detail: > > > > 1) Can we rely on PT_GNU_PROPERTY being present in the phdrs to describe > > the

Re: [RFC PATCH] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-07-02 Thread Dave Martin
On Fri, Jun 28, 2019 at 10:22:03AM -0700, Yu-cheng Yu wrote: > This patch was part of the Intel Control-flow Enforcement (CET) series at: > > https://lkml.org/lkml/2019/6/6/1014. > > In the discussion, we decided to look at only an ELF header's > PT_GNU_PROPERTY, which is a shortcut pointing

Re: [RESEND PATCH] arm64: v8.4: Support for new floating point multiplication variant

2017-12-11 Thread Dave Martin
On Mon, Dec 11, 2017 at 08:47:00PM +0800, gengdongjiu wrote: > > On 2017/12/11 19:59, Dave P Martin wrote: > > On Sat, Dec 09, 2017 at 03:28:42PM +, Dongjiu Geng wrote: > >> ARM v8.4 extensions include support for new floating point > >> multiplication variant instructions to the AArch64 SIMD

Re: [PATCH v2] arm64: v8.4: Support for new floating point multiplication instructions

2017-12-12 Thread Dave Martin
intermediate rounding to the corresponding FP32 element in a third vector. > > This patch detects this feature and let the userspace know about it via a > HWCAP bit and MRS emulation. > > Cc: Dave Martin > Cc: Suzuki K Poulose > Signed-off-by: Dongjiu Geng > --- > Change s

Re: [PATCH v9 0/8] arm64: untag user pointers passed to the kernel

2018-12-12 Thread Dave Martin
On Mon, Dec 10, 2018 at 01:50:57PM +0100, Andrey Konovalov wrote: > arm64 has a feature called Top Byte Ignore, which allows to embed pointer > tags into the top byte of each pointer. Userspace programs (such as > HWASan, a memory debugging tool [1]) might use this feature and pass > tagged user po

Re: [RFC][PATCH 2/3] arm64: Define Documentation/arm64/elf_at_flags.txt

2018-12-12 Thread Dave Martin
On Mon, Dec 10, 2018 at 02:30:43PM +, Vincenzo Frascino wrote: > On arm64 the TCR_EL1.TBI0 bit has been set since Linux 3.x hence > the userspace (EL0) is allowed to set a non-zero value in the > top byte but the resulting pointers are not allowed at the > user-kernel syscall ABI boundary. > >

Re: [RFC][PATCH 0/3] arm64 relaxed ABI

2018-12-19 Thread Dave Martin
On Tue, Dec 18, 2018 at 05:59:38PM +, Catalin Marinas wrote: > On Tue, Dec 18, 2018 at 04:03:38PM +0100, Andrey Konovalov wrote: > > On Wed, Dec 12, 2018 at 4:02 PM Catalin Marinas > > wrote: > > > The summary of our internal discussions (mostly between kernel > > > developers) is that we can

Re: [PATCH v9 0/8] arm64: untag user pointers passed to the kernel

2019-02-11 Thread Dave Martin
On Mon, Feb 11, 2019 at 11:35:12AM +, Catalin Marinas wrote: > Hi Dave, > > On Wed, Dec 12, 2018 at 05:01:12PM +, Dave P Martin wrote: > > On Mon, Dec 10, 2018 at 01:50:57PM +0100, Andrey Konovalov wrote: > > > arm64 has a feature called Top Byte Ignore, which allows to embed pointer > > >

Re: [RFC][PATCH 0/3] arm64 relaxed ABI

2019-02-13 Thread Dave Martin
On Tue, Feb 12, 2019 at 06:02:24PM +, Catalin Marinas wrote: > On Mon, Feb 11, 2019 at 12:32:55PM -0800, Evgenii Stepanov wrote: > > On Mon, Feb 11, 2019 at 9:28 AM Kevin Brodsky wrote: > > > On 19/12/2018 12:52, Dave Martin wrote: [...] > > > > * A sing

Re: [RFC][PATCH 0/3] arm64 relaxed ABI

2019-02-13 Thread Dave Martin
On Wed, Feb 13, 2019 at 04:42:11PM +, Kevin Brodsky wrote: > (+Cc other people with MTE experience: Branislav, Ruben) [...] > >I'm wondering whether we can piggy-back on existing concepts. > > > >We could say that recolouring memory is safe when and only when > >unmapping of the page or remov