Re: [PATCH 04/36] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-12 Thread Darren Hart
the lock; > + * - <0 - error > * e.g. * Return: * * 0 - ready to wait * * 1 - acquired the lock * * <0 - error I'm fine with either though, just curious if this would be an improvement, or if we have an established policy (which I didn't find in the docs on docs..

Re: [PATCH 04/36] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-12 Thread Darren Hart
On Fri, May 12, 2017 at 06:51:50PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 12 May 2017 09:41:22 -0700 > Darren Hart escreveu: > > > On Fri, May 12, 2017 at 10:59:47AM -0300, Mauro Carvalho Chehab wrote: > > > There are a few issues on some kernel-doc markups that wa

Re: [PATCH 04/36] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-12 Thread Darren Hart
he ReST changes (with -) make the comment block any less readable in the C files. > It is an incentive not to use kerneldoc.. > I like the kerneldoc if for no other reason that it helps keeps formatting consistent. I would object if I started seeing XML or some other horrible formatting style sh

Re: [PATCH 04/36] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-15 Thread Darren Hart
automated publication reduces the barrier to access. The lack of this kind of tooling, honestly, also discourages participation among some groups of of capable contributors. That said, I support the direction both Mauro and Peter have voiced to minimize the impact to comment blocks. What

Re: [PATCH v2 04/53] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-16 Thread Darren Hart
xpected unindent. > > Fix them. > > No functional changes. > > Acked-by: Darren Hart (VMware) > Signed-off-by: Mauro Carvalho Chehab > --- What was the difference from v1? Quick scan didn't reveal anything obvious to me... (context left intact in case you wan

Re: [PATCH v2 04/53] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-16 Thread Darren Hart
On Tue, May 16, 2017 at 03:24:18PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 16 May 2017 10:35:40 -0700 > Darren Hart escreveu: > > > On Tue, May 16, 2017 at 09:15:56AM -0300, Mauro Carvalho Chehab wrote: > > > There are a few issues on some kernel-doc markups that wa

Re: [PATCH] docs: fix process/submit-checklist.rst Sphinx warning

2017-12-12 Thread Darren Hart
: Markus Heiser How embarrassing. Thanks Markus. Reviewed-by: Darren Hart (VMware) -- Darren Hart VMware Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH v5 11/11] intel_sgx: driver documentation

2017-11-17 Thread Darren Hart
symmetric key called *launch key*. > + > +The hardware platform contains a root key pair for signing the SIGTRUCT > +for a *launch enclave* that is able to acquire the *launch key* for > +creating EINITTOKEN's for other enclaves. For the launch enclave > +EINITTOKEN is not needed

Re: [PATCH v5 11/11] intel_sgx: driver documentation

2017-11-17 Thread Darren Hart
On Sat, Nov 18, 2017 at 12:34:33AM +0100, Thomas Gleixner wrote: > On Fri, 17 Nov 2017, Darren Hart wrote: > > @intel: I removed intel-sgx-kernel-...@lists.01.org from CC because I can > do without the silly moderation spam of that list. Please disable that > nonsense. > > &

[PATCH 0/2] Documentation: Add guidance on CONFIG default value

2017-11-20 Thread Darren Hart
From: "Darren Hart (VMware)" Document the preference for "default n" in kconfig-language.txt, and reference that in the submit-checklist.rst. Darren Hart (VMware) (2): Documentation/kbuild: Add guidance for the use of default Documentation/process: Add CONFIG def

[PATCH 1/2] Documentation/kbuild: Add guidance for the use of default

2017-11-20 Thread Darren Hart
From: "Darren Hart (VMware)" Document the preference [1] for new CONFIG options to "default n" (or not use default at all) in order to minimizes changes to the config, especially to avoid "make oldconfig" growing unnecessarily from release to release. Docum

[PATCH 2/2] Documentation/process: Add CONFIG default value to submit-checklist

2017-11-20 Thread Darren Hart
From: "Darren Hart (VMware)" Add default value review to the submit checklist, referring to the preference for "default n" from the previous patch added to Documentation/kbuild/kconfig-language.txt. Cc: "Yann E. MORIN" Cc: Masahiro Yamada Cc: Michal Marek Cc:

Re: [PATCH 2/2] ABI: ibm_rtl: the "What:" fields are incomplete

2016-11-01 Thread Darren Hart
Cc: Vernon Mauery > Cc: Darren Hart > Cc: platform-driver-...@vger.kernel.org > Signed-off-by: Mauro Carvalho Chehab Thanks, applied. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a m

Re: [PATCH 2/2] ABI: ibm_rtl: the "What:" fields are incomplete

2016-11-01 Thread Darren Hart
7 @@ Description:The state file allows a means by which to > change in and > Users: The ibm-prtm userspace daemon uses this interface. > > > -What: version > +What: /sys/devices/system/ibm_rtl/version > Date: Sep 2010 > KernelVers

Re: [PATCH v5 2/2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode

2016-12-12 Thread Darren Hart
e. > Values on this handle are either 0x1, laptop mode, or 0x6, tablet mode. > > Tested-by: Daniel Martin > Signed-off-by: Lyude Our apologies for the delay. Thank you for the updates. Queued to testing. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this l