t message to
> indicate the corresponding link
> - when to use lore.kernel.org vs patch.msgid.link domains
You should add something to checkpatch to complain about patch.msgid.link
URLs. Those URLs should only be added by the committers, not the patch
authors.
regards,
dan carpenter
Hi liaoweixiong,
url:
https://github.com/0day-ci/linux/commits/liaoweixiong/pstore-block-new-support-logger-for-block-devices/20190303-142003
base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git
for-next/pstore
smatch warnings:
fs/pstore/blkzone.c:180 blkz_zone_write() erro
recall someone else doing a broader use tool
> which I believe was not smatch, but my google-fu isn't
> finding it.
Yeah. Smatch has a check for this. Rasmus Villemoes wrote it.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 16, 2018 at 07:33:03PM +0530, Naveen Panwar wrote:
> Hi Guys,
>
> I submitted a new patch with the suggestions from Al Viro, did you guys
> check it?
>
The list seems to reject your patches. It rejected the first one as
well.
regards,
dan carpenter
--
To unsubs
Hi Waiman,
Thank you for the patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Waiman-Long/cgroup-Introducing-bypass-mode/20181123-030552
base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
smatch warnings:
kernel/cgroup/cgroup.c:48
7;t like out labels, but that's my opinion. There is nothing in
CodingStyle which says you can't do it.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> > > __fallthrough for some reason :-).
> >
> > Will this work with all of the static tools that are currently looking
> > for the comment instead?
>
> Does anyone have a list of the static tools that
> use comment style fallthrough notations?
>
It would only be CPPcheck I think.
regards,
dan carpenter
o the __fallthrough__
> > attribute means that we start gethting a lot of Coverity warnings,
>
> We could keep both.
What does that even mean? Use both the attribute and the comment until
Eclipse is updated?
case 3:
frob();
__fall_through; /* fall through */
case 4:
That seems like a wrong idea...
regards,
dan carpenter
e attribute because that would simplify things
in Smatch but it's not a huge deal to delay for another year.
regards,
dan carpenter
ing, the comment parsing and
the attribute so it's fine.
The only thing that we know for sure is an issue is Eclipse.
We need to test Coverity but it should work in theory. And we don't
know about CPPcheck.
regards,
dan carpenter
ell what the goto does.
5) If there is an if statement in allocation code, then put an mirror if
statement in the unwind code.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
cgroup:
506 kthread_stop(worker);
507 dev->worker = NULL;
508 err_worker:
509 if (dev->mm)
510 mmput(dev->mm);
511 dev->mm = NULL;
512 err_mm:
513 return err;
514 }
regards,
dan carpenter
--
To unsu
oes
that meaning make sense for err_cgroup in vhost_dev_set_owner()? What
needs to be skipped here?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
That's not my fault. :/ I have tried over and over and over to tell
that guy to stop sending patches but everyone else encourages him. I
feel like it should be a rule that if you introduce bugs, you should be
told to stop sending cleanup patches until you have fixed enough bugs to
redeem yourself.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Lol. The mossy side of a boulder is the alloc, the non-mossy side is
the free!
:P
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
corresponding bit
> > > of the
> >
> > This is not a typo. iff is if and only if
>
> +1
>
> https://en.wikipedia.org/wiki/If_and_only_if
>
Does "iff" really add anything over regular "if"? I would have thought the
"only if" could be assumed in this case. Or if it's really necessary then we
could spell it out.
regards,
dan carpenter
16 matches
Mail list logo
