On Wed, 15 Jan 2025 at 16:33, Brendan Jackman wrote:
> Changes in v2:
> - Switched to the "graveyard" instead of the actual commit message.
> - Link to v1:
> https://lore.kernel.org/r/20250113-checkpatch-ignore-v1-0-63a7a740f...@google.com
Hi Joe & Andy, any thoughts on this?
On Mon, 13 Jan 2025 at 17:20, Matthew Wilcox wrote:
> I think humans should always ignore checkpatch. It's basically
> worthless.
Do you know of anything better? I guess it's feasible to build
something that's actually good at this job using tree-sitter or
something, maybe it exists. But outside
which
falls afoul of EMAIL_SUBJECT due to the word "checkpatch" appearing in
the "Checkpatch-ignore" reference in the title - a good example of a
false positive.
[0] b4 - see "--check" arg
https://b4.docs.kernel.org/en/latest/contributor/prep.html
Checkpatch-ig
to ignore.
Signed-off-by: Brendan Jackman
---
Brendan Jackman (2):
checkpatch: Add support for Checkpatch-ignore patch footer
docs: checkpatch: Document Checkpatch-ignore patch footer
Documentation/dev-tools/checkpatch.rst | 9 -
scripts/checkpatch.pl
If included in patch descriptions, this will function much like the
--ignore flag.
Checkpatch-ignore: EMAIL_SUBJECT
Signed-off-by: Brendan Jackman
---
Documentation/dev-tools/checkpatch.rst | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Documentation/dev-tools
On Mon, 13 Jan 2025, 20:15 Joe Perches, wrote:
>
> On Mon, 2025-01-13 at 16:04 +, Brendan Jackman wrote:
> > Checkpatch sometimes has false positives. This makes it less useful for
> > automatic usage: tools like b4 [0] can run checkpatch on all of your
> > patc
On Tue, 14 Jan 2025 at 12:42, Brendan Jackman wrote:
> I think that's a downgrade from the Checkpatch-args approach
(Sorry I mean Checkpatch-ignore of course)
On Tue, 14 Jan 2025 at 14:34, Konstantin Ryabitsev
wrote:
> Do we really want this to become part of the permanent commit message? I'm
> pretty sure this won't go over well with many.
Why not?
On Tue, 14 Jan 2025 at 17:04, Konstantin Ryabitsev
wrote:
>
> On Tue, Jan 14, 2025 at 03:25:41PM +0100, Brendan Jackman wrote:
> > wrote:
> > > Do we really want this to become part of the permanent commit message? I'm
> > > pretty sure this won't
On Wed, 15 Jan 2025 at 16:33, Brendan Jackman wrote:
> +1. Configure git to include the `checkpatch-ignore` notes ref in formatted
Argh, make htmldocs just finished (it takes an extremely long time for
me...) and I realised I sent this without checking the docs output.
Turns out backticks are
ot;--check" arg
https://b4.docs.kernel.org/en/latest/contributor/prep.html
[1] https://git-scm.com/docs/git-notes
Signed-off-by: Brendan Jackman
---
Notes (checkpatch-ignore):
EMAIL_SUBJECT
scripts/checkpatch.pl | 34 --
1 file changed, 32 insertions(+), 2
If included in patch descriptions, this will function much like the
--ignore flag.
It requires some rather obscure Git features to take advantage of
this, so provide some examples of how to do that.
Signed-off-by: Brendan Jackman
---
Notes (checkpatch-ignore):
EMAIL_SUBJECT
Documentation
d not all tools that wrap Checkpatch
will automatically be able to take advantage. Changes are required for
`b4 prep --check` to work [0], I'll send that separately if this patch
is accepted.
[0] https://github.com/bjackman/b4/tree/checkpatch-ignore
Signed-off-by: Brendan Jackman
---
Ch
On Tue, 14 Jan 2025 at 20:26, Konstantin Ryabitsev
wrote:
>
> On Tue, Jan 14, 2025 at 07:29:14PM +0100, Brendan Jackman wrote:
> > is that something people really complain about?
>
> Yes, I expect Linus will reject commits that carry that trailer on the exact
> grounds that
d not all tools that wrap Checkpatch
will automatically be able to take advantage. Changes are required for
`b4 prep --check` to work [0], I'll send that separately if this patch
is accepted.
[0] https://github.com/bjackman/b4/tree/checkpatch-ignore
Signed-off-by: Brendan Jackman
---
Ch
If included in patch descriptions, this will function much like the
--ignore flag.
It requires some rather obscure Git features to take advantage of
this, so provide some examples of how to do that.
Signed-off-by: Brendan Jackman
---
Documentation/dev-tools/checkpatch.rst | 46
ot;--check" arg
https://b4.docs.kernel.org/en/latest/contributor/prep.html
[1] https://git-scm.com/docs/git-notes
Signed-off-by: Brendan Jackman
---
scripts/checkpatch.pl | 34 --
1 file changed, 32 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpat
On Mon, 24 Feb 2025 at 20:09, Jeff Johnson
wrote:
>
> On 1/15/2025 7:33 AM, Brendan Jackman wrote:
> > Checkpatch sometimes has false positives. This makes it less useful for
> > automatic usage: tools like b4 [0] can run checkpatch on all of your
> > patches and give yo
18 matches
Mail list logo
