Re: [PATCH net-next v3 2/6] selftests: ncdevmem: Implement devmem TCP TX

2025-02-04 Thread Mina Almasry
On Tue, Feb 4, 2025 at 9:56 AM Paolo Abeni wrote: > > On 2/4/25 6:35 PM, Mina Almasry wrote: > > On Tue, Feb 4, 2025 at 4:29 AM Paolo Abeni wrote: > >>> .../selftests/drivers/net/hw/ncdevmem.c | 300 +- > >>> 1 file changed, 289 insertions(+), 11 deletions(-) > >> > >> Why

Re: [PATCH net-next v3 2/6] selftests: ncdevmem: Implement devmem TCP TX

2025-02-04 Thread Stanislav Fomichev
On 02/04, Mina Almasry wrote: > On Tue, Feb 4, 2025 at 9:56 AM Paolo Abeni wrote: > > > > On 2/4/25 6:35 PM, Mina Almasry wrote: > > > On Tue, Feb 4, 2025 at 4:29 AM Paolo Abeni wrote: > > >>> .../selftests/drivers/net/hw/ncdevmem.c | 300 +- > > >>> 1 file changed, 289 ins

Re: [PATCH v2 0/6] module: Introduce hash-based integrity checking

2025-02-04 Thread Thomas Weißschuh
On 2025-02-03 14:14:41+0100, Christian Heusel wrote: > Hey Thomas, > > On 25/01/20 06:44PM, Thomas Weißschuh wrote: > > Thomas Weißschuh (6): > > kbuild: add stamp file for vmlinux BTF data > > module: Make module loading policy usable without MODULE_SIG > > module: Move integrit

Re: [PATCH v2 6/6] module: Introduce hash-based integrity checking

2025-02-04 Thread Thomas Weißschuh
Hi Petr, On 2025-02-03 15:22:54+0100, Petr Pavlu wrote: > On 1/20/25 18:44, Thomas Weißschuh wrote: > > The current signature-based module integrity checking has some drawbacks > > in combination with reproducible builds: > > Either the module signing key is generated at build time, which makes >

Re: [PATCH v6 23/26] mm: Remove pXX_devmap callers

2025-02-04 Thread Dan Williams
Alistair Popple wrote: > On Tue, Jan 14, 2025 at 10:50:49AM -0800, Dan Williams wrote: > > Alistair Popple wrote: > > > The devmap PTE special bit was used to detect mappings of FS DAX > > > pages. This tracking was required to ensure the generic mm did not > > > manipulate the page reference count

Re: [PATCH net-next v3 2/6] selftests: ncdevmem: Implement devmem TCP TX

2025-02-04 Thread Mina Almasry
On Tue, Feb 4, 2025 at 4:29 AM Paolo Abeni wrote: > > On 2/3/25 11:39 PM, Mina Almasry wrote: > > Add support for devmem TX in ncdevmem. > > > > This is a combination of the ncdevmem from the devmem TCP series RFCv1 > > which included the TX path, and work by Stan to include the netlink API > > an

Re: [PATCH net-next v3 2/6] selftests: ncdevmem: Implement devmem TCP TX

2025-02-04 Thread Paolo Abeni
On 2/4/25 6:35 PM, Mina Almasry wrote: > On Tue, Feb 4, 2025 at 4:29 AM Paolo Abeni wrote: >>> .../selftests/drivers/net/hw/ncdevmem.c | 300 +- >>> 1 file changed, 289 insertions(+), 11 deletions(-) >> >> Why devmem.py is not touched? AFAICS the test currently run ncdevmem

Re: [PATCH net] docs: netdev: Document guidance on inline functions

2025-02-04 Thread Simon Horman
On Tue, Feb 04, 2025 at 02:25:07PM +0100, Andrew Lunn wrote: > > Thanks, perhaps something like this would help: > > > > Using inline in .h files is fine and is encouraged in place of macros > > [reference section 12]. > > The other major use of them in headers is for stub functions when an >

Re: [PATCH net] docs: netdev: Document guidance on inline functions

2025-02-04 Thread Simon Horman
On Mon, Feb 03, 2025 at 04:10:24PM +0100, Andrew Lunn wrote: > > Conversely, spelling and grammar fixes are not discouraged. > > > > +Inline functions > > + > > + > > +The use of static inline functions in .c file is strongly discouraged > > I don't think 'static' is relevant he

[PATCH net-next v4 2/8] netconsole: Rename userdata to extradata

2025-02-04 Thread Breno Leitao
Rename "userdata" to "extradata" since this structure will hold both user and system data in future patches. Keep "userdata" term only for data that comes from userspace (configfs), while "extradata" encompasses both userdata and future kerneldata. These are the rules of the design 1. extradata_c

[PATCH net-next v4 3/8] netconsole: Helper to count number of used entries

2025-02-04 Thread Breno Leitao
Add a helper function nr_extradata_entries() to count the number of used extradata entries in a netconsole target. This refactors the duplicate code for counting entries into a single function, which will be reused by upcoming CPU sysdata changes. The helper uses list_count_nodes() to count the nu

[PATCH net-next v4 0/8] netconsole: Add support for CPU population

2025-02-04 Thread Breno Leitao
The current implementation of netconsole sends all log messages in parallel, which can lead to an intermixed and interleaved output on the receiving side. This makes it challenging to demultiplex the messages and attribute them to their originating CPUs. As a result, users and developers often str

[PATCH net-next v4 1/8] netconsole: consolidate send buffers into netconsole_target struct

2025-02-04 Thread Breno Leitao
Move the static buffers from send_msg_no_fragmentation() and send_msg_fragmented() into the netconsole_target structure. This simplifies the code by: - Eliminating redundant static buffers - Centralizing buffer management in the target structure - Reducing memory usage by 1KB (one buffer instead of

[PATCH net-next v4 4/8] netconsole: Introduce configfs helpers for sysdata features

2025-02-04 Thread Breno Leitao
This patch introduces a bitfield to store sysdata features in the netconsole_target struct. It also adds configfs helpers to enable or disable the CPU_NR feature, which populates the CPU number in sysdata. The patch provides the necessary infrastructure to set or unset the CPU_NR feature, but does

[PATCH net-next v4 6/8] netconsole: add support for sysdata and CPU population

2025-02-04 Thread Breno Leitao
Add infrastructure to automatically append kernel-generated data (sysdata) to netconsole messages. As the first use case, implement CPU number population, which adds the CPU that sent the message. This change introduces three distinct data types: - extradata: The complete set of appended data (sys

[PATCH net-next v4 5/8] netconsole: Include sysdata in extradata entry count

2025-02-04 Thread Breno Leitao
Modify count_extradata_entries() to include sysdata fields when calculating the total number of extradata entries. This change ensures that the sysdata feature, specifically the CPU number field, is correctly counted against the MAX_EXTRADATA_ITEMS limit. The modification adds a simple check for t

[PATCH net-next v4 7/8] netconsole: selftest: test for sysdata CPU

2025-02-04 Thread Breno Leitao
Add a new selftest to verify that the netconsole module correctly handles CPU runtime data in sysdata. The test validates three scenarios: 1. Basic CPU sysdata functionality - verifies that cpu=X is appended to messages 2. CPU sysdata with userdata - ensures CPU data works alongside userdata 3.

[PATCH net-next v4 8/8] netconsole: docs: Add documentation for CPU number auto-population

2025-02-04 Thread Breno Leitao
Update the netconsole documentation to explain the new feature that allows automatic population of the CPU number. The key changes include introducing a new section titled "CPU number auto population in userdata", explaining how to enable the CPU number auto-population feature by writing to the "p

RE: [PATCH bpf-next v7 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 5:50 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 08:49:06AM +0800, Song Yoong Siang wrote: >> Refactor the code for inserting an empty packet into a new function >> igc_insert_empty_packet(). This change extracts the logic for inserting >> an empty packet

Re: [xdp-hints] [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Maciej Fijalkowski
On Tue, Feb 04, 2025 at 08:49:07AM +0800, Song Yoong Siang wrote: > Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx > metadata framework. > > This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata > on Intel I225-LM Ethernet controller. Below are the tes

<    1   2