Re: [PATCH v10 00/14] riscv: Add support for xtheadvector

2025-01-21 Thread nexp_0x17
On Wed, 2024-11-13 at 18:44 -0800, Charlie Jenkins wrote: > On Mon, Sep 30, 2024 at 12:07:23AM +0800, Aoba K wrote: > > > > On 2024/9/12 13:55, Charlie Jenkins wrote: > > > xtheadvector is a custom extension that is based upon riscv > > > vector > > > version 0.7.1 [1]. All of the vector routines

Re: [PATCH bpf v8 1/5] strparser: add read_sock callback

2025-01-21 Thread Jakub Sitnicki
On Tue, Jan 21, 2025 at 01:07 PM +08, Jiayuan Chen wrote: > Added a new read_sock handler, allowing users to customize read operations > instead of relying on the native socket's read_sock. > > Signed-off-by: Jiayuan Chen > --- Reviewed-by: Jakub Sitnicki

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Roberto Sassu
On Tue, 2025-01-21 at 15:21 +0100, Thomas Weißschuh wrote: > On 2025-01-21 14:48:09+0100, Roberto Sassu wrote: > > On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > > > Hi Robert, > > > > > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > > > > From: Roberto Sassu > > > > > > > >

Re: [PATCH net-next v4 8/9] tap: Keep hdr_len in tap_get_user()

2025-01-21 Thread Willem de Bruijn
Akihiko Odaki wrote: > On 2025/01/20 20:24, Willem de Bruijn wrote: > > Akihiko Odaki wrote: > >> hdr_len is repeatedly used so keep it in a local variable. > >> > >> Signed-off-by: Akihiko Odaki > >> --- > >> drivers/net/tap.c | 17 +++-- > >> 1 file changed, 7 insertions(+), 10 de

Re: [PATCH net v3 9/9] tap: Use tun's vnet-related code

2025-01-21 Thread Willem de Bruijn
Akihiko Odaki wrote: > On 2025/01/20 20:19, Willem de Bruijn wrote: > > On Mon, Jan 20, 2025 at 1:37 AM Jason Wang wrote: > >> > >> On Fri, Jan 17, 2025 at 6:35 PM Akihiko Odaki > >> wrote: > >>> > >>> On 2025/01/17 18:23, Willem de Bruijn wrote: > Akihiko Odaki wrote: > > tun and tap i

Re: [PATCH bpf v8 2/5] bpf: fix wrong copied_seq calculation

2025-01-21 Thread Jakub Sitnicki
On Tue, Jan 21, 2025 at 01:07 PM +08, Jiayuan Chen wrote: > 'sk->copied_seq' was updated in the tcp_eat_skb() function when the > action of a BPF program was SK_REDIRECT. For other actions, like SK_PASS, > the update logic for 'sk->copied_seq' was moved to > tcp_bpf_recvmsg_parser() to ensure the a

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Thomas Weißschuh
On 2025-01-21 14:48:09+0100, Roberto Sassu wrote: > On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > > Hi Robert, > > > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > > > From: Roberto Sassu > > > > > > Add a parser of a generic Type-Length-Value (TLV) format: > > > > > > +--

Re: [PATCH bpf v8 3/5] bpf: disable non stream socket for strparser

2025-01-21 Thread Jakub Sitnicki
On Tue, Jan 21, 2025 at 01:07 PM +08, Jiayuan Chen wrote: > Currently, only TCP supports strparser, but sockmap doesn't intercept > non-TCP to attach strparser. For example, with UDP, although the > read/write handlers are replaced, strparser is not executed due to the > lack of read_sock operation

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Roberto Sassu
On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > Hi Robert, > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > > From: Roberto Sassu > > > > Add a parser of a generic Type-Length-Value (TLV) format: > > > > +--+--+-++-+ > > > field1 (u16) | l

Re: [PATCH v5 2/3] RISC-V: hwprobe: Expose Zicbom extension and its block size

2025-01-21 Thread Andrew Jones
On Wed, Jan 15, 2025 at 10:40:23AM +0800, Yunhui Cui wrote: > Expose Zicbom through hwprobe and also provide a key to extract its > respective block size. > > Signed-off-by: Yunhui Cui > --- > Documentation/arch/riscv/hwprobe.rst | 6 ++ > arch/riscv/include/asm/hwprobe.h | 2 +- > arc

Re: [PATCH v2 0/6] module: Introduce hash-based integrity checking

2025-01-21 Thread Roberto Sassu
On Mon, 2025-01-20 at 18:44 +0100, Thomas Weißschuh wrote: > The current signature-based module integrity checking has some drawbacks > in combination with reproducible builds: > Either the module signing key is generated at build time, which makes > the build unreproducible, or a static key is use

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Thomas Weißschuh
Hi Robert, On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > From: Roberto Sassu > > Add a parser of a generic Type-Length-Value (TLV) format: > > +--+--+-++-+ > | field1 (u16) | len1 (u32) | value1 (u8 len1) | > +--++---

Re: [PATCH v2 0/6] module: Introduce hash-based integrity checking

2025-01-21 Thread Roberto Sassu
On Tue, 2025-01-21 at 13:58 +0100, Thomas Weißschuh wrote: > Hi Roberto, > > On 2025-01-21 11:26:29+0100, Roberto Sassu wrote: > > On Mon, 2025-01-20 at 18:44 +0100, Thomas Weißschuh wrote: > > > The current signature-based module integrity checking has some drawbacks > > > in combination with rep

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Roberto Sassu
On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > Hi Robert, > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: > > From: Roberto Sassu > > > > Add a parser of a generic Type-Length-Value (TLV) format: > > > > +--+--+-++-+ > > > field1 (u16) | l

Re: [PATCH v2 0/6] module: Introduce hash-based integrity checking

2025-01-21 Thread Thomas Weißschuh
Hi Roberto, On 2025-01-21 11:26:29+0100, Roberto Sassu wrote: > On Mon, 2025-01-20 at 18:44 +0100, Thomas Weißschuh wrote: > > The current signature-based module integrity checking has some drawbacks > > in combination with reproducible builds: > > Either the module signing key is generated at bui

Re: [PATCH v5 2/3] RISC-V: hwprobe: Expose Zicbom extension and its block size

2025-01-21 Thread kernel test robot
Hi Yunhui, kernel test robot noticed the following build warnings: [auto build test WARNING on shuah-kselftest/next] [also build test WARNING on shuah-kselftest/fixes linus/master v6.13 next-20250121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH bpf v8 5/5] selftests/bpf: add strparser test for bpf

2025-01-21 Thread Jakub Sitnicki
Thanks for expanding tests. On Tue, Jan 21, 2025 at 01:07 PM +08, Jiayuan Chen wrote: > Add test cases for bpf + strparser and separated them from > sockmap_basic, as strparser has more encapsulation and parsing > capabilities compared to sockmap. > > Signed-off-by: Jiayuan Chen > --- > .../self

Re: [PATCH bpf v8 4/5] selftests/bpf: fix invalid flag of recv()

2025-01-21 Thread Jakub Sitnicki
On Tue, Jan 21, 2025 at 01:07 PM +08, Jiayuan Chen wrote: > SOCK_NONBLOCK flag is only effective during socket creation, not during > recv. Use MSG_DONTWAIT instead. > > Signed-off-by: Jiayuan Chen > --- Good catch. Fixes: 1fa1fe8ff161 ("bpf, sockmap: Test shutdown() correctly exits epoll and r

Re: [PATCH v5 08/14] iommufd/viommu: Add iommufd_viommu_report_event helper

2025-01-21 Thread Jason Gunthorpe
On Mon, Jan 20, 2025 at 12:52:09PM -0800, Nicolin Chen wrote: > The counter of the number of events in the vEVENTQ could decrease > when userspace reads the queue. But you were saying "the number of > events that were sent into the queue", which is like a PROD index > that would keep growing but re

Re: [PATCH v5 08/14] iommufd/viommu: Add iommufd_viommu_report_event helper

2025-01-21 Thread Nicolin Chen
On Tue, Jan 21, 2025 at 04:09:24PM -0400, Jason Gunthorpe wrote: > On Tue, Jan 21, 2025 at 11:55:16AM -0800, Nicolin Chen wrote: > > > > > IOMMU_VEVENTQ_STATE_OVERFLOW with a 0 length event is seen if events > > > > > have been lost and no subsequent events are present. It exists to > > > > > ensur

Re: [PATCH v5 08/14] iommufd/viommu: Add iommufd_viommu_report_event helper

2025-01-21 Thread Jason Gunthorpe
On Tue, Jan 21, 2025 at 01:02:16PM -0800, Nicolin Chen wrote: > On Tue, Jan 21, 2025 at 04:09:24PM -0400, Jason Gunthorpe wrote: > > On Tue, Jan 21, 2025 at 11:55:16AM -0800, Nicolin Chen wrote: > > > > > > IOMMU_VEVENTQ_STATE_OVERFLOW with a 0 length event is seen if events > > > > > > have been l

Re: [PATCH v5 08/14] iommufd/viommu: Add iommufd_viommu_report_event helper

2025-01-21 Thread Jason Gunthorpe
On Tue, Jan 21, 2025 at 11:55:16AM -0800, Nicolin Chen wrote: > Ack. Then I think we should name it "index", beside a "counter" > indicating the number of events in the queue. Or perhaps a pair > of consumer and producer indexes that wrap at end of a limit. sequence perhaps would be a good name >

Re: [PATCH v5 08/14] iommufd/viommu: Add iommufd_viommu_report_event helper

2025-01-21 Thread Nicolin Chen
On Tue, Jan 21, 2025 at 02:36:11PM -0400, Jason Gunthorpe wrote: > On Mon, Jan 20, 2025 at 12:52:09PM -0800, Nicolin Chen wrote: > > The counter of the number of events in the vEVENTQ could decrease > > when userspace reads the queue. But you were saying "the number of > > events that were sent int

Re: [PATCH v5 08/14] iommufd/viommu: Add iommufd_viommu_report_event helper

2025-01-21 Thread Jason Gunthorpe
On Tue, Jan 21, 2025 at 01:40:05PM -0800, Nicolin Chen wrote: > > There is also the minor detail of what happens if the hypervisor HW > > queue overflows - I don't know the answer here. It is security > > concerning since the VM can spam DMA errors at high rate. :| > > In my view, the hypervisor q

Re: [PATCH v5 08/14] iommufd/viommu: Add iommufd_viommu_report_event helper

2025-01-21 Thread Nicolin Chen
On Tue, Jan 21, 2025 at 05:14:04PM -0400, Jason Gunthorpe wrote: > On Tue, Jan 21, 2025 at 01:02:16PM -0800, Nicolin Chen wrote: > > On Tue, Jan 21, 2025 at 04:09:24PM -0400, Jason Gunthorpe wrote: > > > On Tue, Jan 21, 2025 at 11:55:16AM -0800, Nicolin Chen wrote: > > > > > > > IOMMU_VEVENTQ_STATE

Re: [PATCH v6 01/15] lib: Add TLV parser

2025-01-21 Thread Thomas Weißschuh
On 2025-01-21 15:55:28+0100, Roberto Sassu wrote: > On Tue, 2025-01-21 at 14:29 +0100, Thomas Weißschuh wrote: > > On 2024-11-19 11:49:08+0100, Roberto Sassu wrote: [..] > > > +typedef int (*callback)(void *callback_data, __u16 field, > > > + const __u8 *field_data, __u32 field_le

Re: [PATCH v5 08/14] iommufd/viommu: Add iommufd_viommu_report_event helper

2025-01-21 Thread Nicolin Chen
On Tue, Jan 21, 2025 at 08:21:28PM -0400, Jason Gunthorpe wrote: > On Tue, Jan 21, 2025 at 01:40:05PM -0800, Nicolin Chen wrote: > > > There is also the minor detail of what happens if the hypervisor HW > > > queue overflows - I don't know the answer here. It is security > > > concerning since the