Re: [RFCv1 4/6] misc/page_detective: Introduce Page Detective

2024-11-18 Thread Pasha Tatashin
On Sat, Nov 16, 2024 at 5:20 PM Jonathan Corbet wrote: > > Pasha Tatashin writes: > > > Page Detective is a kernel debugging tool that provides detailed > > information about the usage and mapping of physical memory pages. > > > > It operates through the Linux debugfs interface, providing access

Re: [RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table

2024-11-18 Thread Pasha Tatashin
On Mon, Nov 18, 2024 at 1:49 AM Christoph Hellwig wrote: > > On Sat, Nov 16, 2024 at 05:59:18PM +, Pasha Tatashin wrote: > > } while (start = next, start < end); > > return err; > > } > > +EXPORT_SYMBOL_GPL(walk_page_range); > > Umm, no. We really should not expose all these page

Re: [RFCv1 1/6] mm: Make get_vma_name() function public

2024-11-18 Thread Pasha Tatashin
On Mon, Nov 18, 2024 at 5:27 AM Lorenzo Stoakes wrote: > > On Sat, Nov 16, 2024 at 05:59:17PM +, Pasha Tatashin wrote: > > Page Detective will be using get_vma_name() that is currently used by > > fs/proc to show names of VMAs in /proc//smaps for example. > > > > Move this function to mm/vma.c

Re: [RFCv1 1/6] mm: Make get_vma_name() function public

2024-11-18 Thread Matthew Wilcox
On Mon, Nov 18, 2024 at 03:40:57PM -0500, Pasha Tatashin wrote: > > You're putting something in an mm/ C-file and the header in fs.h? Eh? > > This is done so we do not have to include struct path into vma.h. fs.h > already has some vma functions like: vma_is_dax() and vma_is_fsdax(). Yes, but DAX

Re: [RFCv1 6/6] selftests/page_detective: Introduce self tests for Page Detective

2024-11-18 Thread Pasha Tatashin
On Sun, Nov 17, 2024 at 1:25 AM Muhammad Usama Anjum wrote: > > On 11/16/24 10:59 PM, Pasha Tatashin wrote: > > Add self tests for Page Detective, it contains testing of several memory > > types, and also some negative/bad input tests. > > > > Signed-off-by: Pasha Tatashin > > --- > > MAINTAINER

Re: [RFCv1 0/6] Page Detective

2024-11-18 Thread Roman Gushchin
On Sat, Nov 16, 2024 at 05:59:16PM +, Pasha Tatashin wrote: > Page Detective is a new kernel debugging tool that provides detailed > information about the usage and mapping of physical memory pages. > > It is often known that a particular page is corrupted, but it is hard to > extract more inf

Re: [PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-11-18 Thread Rong Xu
This patch looks good to me. I assume the profile format change in the Android doc will be submitted soon. Since "extbinary" is a superset of "binary", using the "extbinary" format profile in Android shouldn't cause any compatibility issues. Reviewed-by: Rong Xu -Rong On Mon, Nov 18, 2024 at 2

Re: [RFCv1 0/6] Page Detective

2024-11-18 Thread Jann Horn
On Mon, Nov 18, 2024 at 11:24 PM Pasha Tatashin wrote: > On Mon, Nov 18, 2024 at 7:54 AM Jann Horn wrote: > > > > On Mon, Nov 18, 2024 at 12:17 PM Lorenzo Stoakes > > wrote: > > > On Sat, Nov 16, 2024 at 05:59:16PM +, Pasha Tatashin wrote: > > > > It operates through the Linux debugfs interf

Re: [RFCv1 1/6] mm: Make get_vma_name() function public

2024-11-18 Thread Pasha Tatashin
On Mon, Nov 18, 2024 at 3:44 PM Matthew Wilcox wrote: > > On Mon, Nov 18, 2024 at 03:40:57PM -0500, Pasha Tatashin wrote: > > > You're putting something in an mm/ C-file and the header in fs.h? Eh? > > > > This is done so we do not have to include struct path into vma.h. fs.h > > already has some

Re: [RFCv1 0/6] Page Detective

2024-11-18 Thread Pasha Tatashin
> Can you point me to where a refcounted reference to the page comes > from when page_detective_metadata() calls dump_page_lvl()? I am sorry, I remembered incorrectly, we are getting reference right after dump_page_lvl() in page_detective_memcg() -> folio_try_get(); I will move the folio_try_get()

Re: [PATCH net-next 2/4] netconsole: Add option to auto-populate CPU number in userdata

2024-11-18 Thread Jakub Kicinski
Sorry for the late review, I think this will miss v6.13 :( On Wed, 13 Nov 2024 07:10:53 -0800 Breno Leitao wrote: > /** > * struct netconsole_target - Represents a configured netconsole target. > * @list:Links this target into the target_list. > @@ -97,6 +105,7 @@ static struct console ne

Re: [PATCH net-next 4/4] netconsole: selftest: Validate CPU number auto-population in userdata

2024-11-18 Thread Jakub Kicinski
On Wed, 13 Nov 2024 07:10:55 -0800 Breno Leitao wrote: > + if ! grep -q "cpu=[0-9]\+" "${TMPFILENAME}"; then > + echo "FAIL: 'cpu=' not found in ${TMPFILENAME}" >&2 > + cat "${TMPFILENAME}" >&2 > + exit "${ksft_fail}" > + fi Could we try to do something

[PATCH v2] arm64: Allow CONFIG_AUTOFDO_CLANG to be selected

2024-11-18 Thread Yabin Cui
Select ARCH_SUPPORTS_AUTOFDO_CLANG to allow AUTOFDO_CLANG to be selected. On ARM64, ETM traces can be recorded and converted to AutoFDO profiles. Experiments on Android show 4% improvement in cold app startup time and 13% improvement in binder benchmarks. Signed-off-by: Yabin Cui --- Change-Log

Re: [RFCv1 0/6] Page Detective

2024-11-18 Thread Pasha Tatashin
On Mon, Nov 18, 2024 at 7:54 AM Jann Horn wrote: > > On Mon, Nov 18, 2024 at 12:17 PM Lorenzo Stoakes > wrote: > > On Sat, Nov 16, 2024 at 05:59:16PM +, Pasha Tatashin wrote: > > > It operates through the Linux debugfs interface, with two files: "virt" > > > and "phys". > > > > > > The "virt"

Re: [RFCv1 4/6] misc/page_detective: Introduce Page Detective

2024-11-18 Thread Jann Horn
On Sat, Nov 16, 2024 at 6:59 PM Pasha Tatashin wrote: > Page Detective is a kernel debugging tool that provides detailed > information about the usage and mapping of physical memory pages. > > It operates through the Linux debugfs interface, providing access > to both virtual and physical address

Re: [RFCv1 0/6] Page Detective

2024-11-18 Thread Pasha Tatashin
On Mon, Nov 18, 2024 at 2:11 PM Roman Gushchin wrote: > > On Sat, Nov 16, 2024 at 05:59:16PM +, Pasha Tatashin wrote: > > Page Detective is a new kernel debugging tool that provides detailed > > information about the usage and mapping of physical memory pages. > > > > It is often known that a

Re: [RFCv1 0/6] Page Detective

2024-11-18 Thread Greg KH
On Mon, Nov 18, 2024 at 05:08:42PM -0500, Pasha Tatashin wrote: > Additionally, using crash/drgn is not feasible for us at this time, it > requires keeping external tools on our hosts, also it requires > approval and a security review for each script before deployment in > our fleet. So it's ok to

Re: [RFCv1 4/6] misc/page_detective: Introduce Page Detective

2024-11-18 Thread Lorenzo Stoakes
On Sat, Nov 16, 2024 at 05:59:20PM +, Pasha Tatashin wrote: > Page Detective is a kernel debugging tool that provides detailed > information about the usage and mapping of physical memory pages. > > It operates through the Linux debugfs interface, providing access > to both virtual and physical

Re: [RFCv1 0/6] Page Detective

2024-11-18 Thread Jann Horn
On Mon, Nov 18, 2024 at 12:17 PM Lorenzo Stoakes wrote: > On Sat, Nov 16, 2024 at 05:59:16PM +, Pasha Tatashin wrote: > > It operates through the Linux debugfs interface, with two files: "virt" > > and "phys". > > > > The "virt" file takes a virtual address and PID and outputs information > >

Re: [RFCv1 1/6] mm: Make get_vma_name() function public

2024-11-18 Thread Lorenzo Stoakes
On Sat, Nov 16, 2024 at 05:59:17PM +, Pasha Tatashin wrote: > Page Detective will be using get_vma_name() that is currently used by > fs/proc to show names of VMAs in /proc//smaps for example. > > Move this function to mm/vma.c, and make it accessible by modules. This is incorrect. mm/vma.c i

Re: [RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table

2024-11-18 Thread Lorenzo Stoakes
On Sun, Nov 17, 2024 at 10:49:06PM -0800, Christoph Hellwig wrote: > On Sat, Nov 16, 2024 at 05:59:18PM +, Pasha Tatashin wrote: > > } while (start = next, start < end); > > return err; > > } > > +EXPORT_SYMBOL_GPL(walk_page_range); > > Umm, no. We really should not expose all these p

Re: [RFCv1 0/6] Page Detective

2024-11-18 Thread Lorenzo Stoakes
On Sat, Nov 16, 2024 at 05:59:16PM +, Pasha Tatashin wrote: > Page Detective is a new kernel debugging tool that provides detailed > information about the usage and mapping of physical memory pages. > > It is often known that a particular page is corrupted, but it is hard to > extract more info