Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Suren Baghdasaryan
On Mon, Oct 21, 2024 at 8:57 AM Michal Hocko wrote: > > On Mon 21-10-24 08:41:00, Suren Baghdasaryan wrote: > > On Mon, Oct 21, 2024 at 8:34 AM Michal Hocko wrote: > > > > > > On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: > > > [...] > > > > Yeah, I thought about adding new values to "mem_p

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Michal Hocko
On Mon 21-10-24 09:16:14, Suren Baghdasaryan wrote: > On Mon, Oct 21, 2024 at 8:57 AM Michal Hocko wrote: > > > > On Mon 21-10-24 08:41:00, Suren Baghdasaryan wrote: > > > On Mon, Oct 21, 2024 at 8:34 AM Michal Hocko wrote: > > > > > > > > On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: > > >

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Suren Baghdasaryan
On Mon, Oct 21, 2024 at 2:13 AM David Hildenbrand wrote: > > > > Am 21.10.24 um 09:26 schrieb Michal Hocko: > > On Fri 18-10-24 14:57:26, Suren Baghdasaryan wrote: > >> On Fri, Oct 18, 2024 at 10:45 AM Suren Baghdasaryan > >> wrote: > >>> > >>> On Fri, Oct 18, 2024 at 10:08 AM Michal Hocko wrot

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Michal Hocko
On Mon 21-10-24 08:41:00, Suren Baghdasaryan wrote: > On Mon, Oct 21, 2024 at 8:34 AM Michal Hocko wrote: > > > > On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: > > [...] > > > Yeah, I thought about adding new values to "mem_profiling" but it's a > > > bit complicated. Today it's a tristate:

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Michal Hocko
On Fri 18-10-24 10:45:39, Suren Baghdasaryan wrote: > On Fri, Oct 18, 2024 at 10:08 AM Michal Hocko wrote: > > > > On Fri 18-10-24 09:04:24, Suren Baghdasaryan wrote: > > > On Fri, Oct 18, 2024 at 6:03 AM Michal Hocko wrote: > > > > > > > > On Tue 15-10-24 08:58:59, Suren Baghdasaryan wrote: > >

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Michal Hocko
On Fri 18-10-24 14:57:26, Suren Baghdasaryan wrote: > On Fri, Oct 18, 2024 at 10:45 AM Suren Baghdasaryan wrote: > > > > On Fri, Oct 18, 2024 at 10:08 AM Michal Hocko wrote: > > > > > > On Fri 18-10-24 09:04:24, Suren Baghdasaryan wrote: > > > > On Fri, Oct 18, 2024 at 6:03 AM Michal Hocko wrote

Re: [PATCH v4 1/6] Add AutoFDO support for Clang build

2024-10-21 Thread Rong Xu
Thanks for the detailed suggestions! My comments are inlined below. Best regards, -Rong On Sun, Oct 20, 2024 at 9:33 AM Masahiro Yamada wrote: > > On Tue, Oct 15, 2024 at 6:33 AM Rong Xu wrote: > > > > +Customization > > += > > + > > +You can enable or disable AutoFDO build for ind

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread David Hildenbrand
Am 21.10.24 um 09:26 schrieb Michal Hocko: On Fri 18-10-24 14:57:26, Suren Baghdasaryan wrote: On Fri, Oct 18, 2024 at 10:45 AM Suren Baghdasaryan wrote: On Fri, Oct 18, 2024 at 10:08 AM Michal Hocko wrote: Automatic fallback is possible during boot, when we decide whether to enable page

Re: [PATCH v2 5/7] virtio-mem: s390 support

2024-10-21 Thread David Hildenbrand
Am 21.10.24 um 08:33 schrieb Christian Borntraeger: Am 15.10.24 um 10:37 schrieb Heiko Carstens: On Mon, Oct 14, 2024 at 09:16:45PM +0200, David Hildenbrand wrote: On 14.10.24 20:48, Heiko Carstens wrote: The cover letter is clearer on that: "One remaining work item is kdump support for v

Re: [PATCH v2 1/7] s390/kdump: implement is_kdump_kernel()

2024-10-21 Thread Alexander Egorenkov
Hi David, David Hildenbrand writes: > Makes sense, so it boils down to either > > bool is_kdump_kernel(void) > { > return oldmem_data.start; > } > > Which means is_kdump_kernel() can be "false" even though /proc/vmcore is > available or > > bool is_kdump_kernel(void) > { > r

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread John Hubbard
On 10/21/24 9:32 AM, Suren Baghdasaryan wrote: On Mon, Oct 21, 2024 at 9:23 AM Michal Hocko wrote: On Mon 21-10-24 09:16:14, Suren Baghdasaryan wrote: On Mon, Oct 21, 2024 at 8:57 AM Michal Hocko wrote: On Mon 21-10-24 08:41:00, Suren Baghdasaryan wrote: On Mon, Oct 21, 2024 at 8:34 AM Mich

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Michal Hocko
On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: [...] > Yeah, I thought about adding new values to "mem_profiling" but it's a > bit complicated. Today it's a tristate: > > mem_profiling=0|1|never > > 0/1 means we disable/enable memory profiling by default but the user > can enable it at runti

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Suren Baghdasaryan
On Mon, Oct 21, 2024 at 8:34 AM Michal Hocko wrote: > > On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: > [...] > > Yeah, I thought about adding new values to "mem_profiling" but it's a > > bit complicated. Today it's a tristate: > > > > mem_profiling=0|1|never > > > > 0/1 means we disable/ena

Re: [PATCH] docs: Remove redundant word "for"

2024-10-21 Thread Jonathan Corbet
Thorsten Blum writes: > s/for// > > Signed-off-by: Thorsten Blum > --- > Documentation/maintainer/pull-requests.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/maintainer/pull-requests.rst > b/Documentation/maintainer/pull-requests.rst > index 00b200f

Re: [PATCH v2 1/7] s390/kdump: implement is_kdump_kernel()

2024-10-21 Thread David Hildenbrand
Am 21.10.24 um 14:46 schrieb Alexander Egorenkov: Hi David, David Hildenbrand writes: Makes sense, so it boils down to either bool is_kdump_kernel(void) { return oldmem_data.start; } Which means is_kdump_kernel() can be "false" even though /proc/vmcore is available or bool is

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread David Hildenbrand
On 21.10.24 17:41, Suren Baghdasaryan wrote: On Mon, Oct 21, 2024 at 8:34 AM Michal Hocko wrote: On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: [...] Yeah, I thought about adding new values to "mem_profiling" but it's a bit complicated. Today it's a tristate: mem_profiling=0|1|never 0/

Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags

2024-10-21 Thread Suren Baghdasaryan
On Mon, Oct 21, 2024 at 9:23 AM Michal Hocko wrote: > > On Mon 21-10-24 09:16:14, Suren Baghdasaryan wrote: > > On Mon, Oct 21, 2024 at 8:57 AM Michal Hocko wrote: > > > > > > On Mon 21-10-24 08:41:00, Suren Baghdasaryan wrote: > > > > On Mon, Oct 21, 2024 at 8:34 AM Michal Hocko wrote: > > > >

Re: [PATCH v4 3/6] Change the symbols order when --ffuntion-sections is enabled

2024-10-21 Thread Rong Xu
On Sun, Oct 20, 2024 at 7:15 PM Masahiro Yamada wrote: > > On Tue, Oct 15, 2024 at 6:33 AM Rong Xu wrote: > > > > When the -ffunction-sections compiler option is enabled, each function > > is placed in a separate section named .text.function_name rather than > > putting all functions in a single

Re: [PATCH v4 4/6] AutoFDO: Enable -ffunction-sections for the AutoFDO build

2024-10-21 Thread Rong Xu
The answers are the same as the reply in [PATCH v4 5/6] On Sun, Oct 20, 2024 at 7:26 PM Masahiro Yamada wrote: > > On Tue, Oct 15, 2024 at 6:33 AM Rong Xu wrote: > > > > Enable -ffunction-sections by default for the AutoFDO build. > > > > With -ffunction-sections, the compiler places each functi

Re: [PATCH v4 5/6] AutoFDO: Enable machine function split optimization for AutoFDO

2024-10-21 Thread Rong Xu
On Sun, Oct 20, 2024 at 8:18 PM Masahiro Yamada wrote: > > On Tue, Oct 15, 2024 at 6:33 AM Rong Xu wrote: > > > > Enable the machine function split optimization for AutoFDO in Clang. > > > > Machine function split (MFS) is a pass in the Clang compiler that > > splits a function into hot and cold

Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.

2024-10-21 Thread Rong Xu
On Sun, Oct 20, 2024 at 10:49 AM Masahiro Yamada wrote: > > Please remove the period at the end of the commit subject. Will fix this. > > > > On Tue, Oct 15, 2024 at 6:34 AM Rong Xu wrote: > > > > Add the build support for using Clang's Propeller optimizer. Like > > AutoFDO, Propeller uses hard

Re: [PATCH v4 0/6] Add AutoFDO and Propeller support for Clang build

2024-10-21 Thread Rong Xu
On Sat, Oct 19, 2024 at 8:25 PM Nathan Chancellor wrote: > > Hi Rong, > > On Fri, Oct 18, 2024 at 11:20:02PM -0700, Rong Xu wrote: > > Thanks to all for the feedback and suggestions! We are ready to make any > > further > > changes needed. Is there anything else we can address for this patch? > >