Re: [PATCH RFC v5 04/10] tun: Unify vnet implementation

2024-10-12 Thread Akihiko Odaki
On 2024/10/09 22:55, Willem de Bruijn wrote: Akihiko Odaki wrote: Both tun and tap exposes the same set of virtio-net-related features. Unify their implementations to ease future changes. Signed-off-by: Akihiko Odaki --- MAINTAINERS| 1 + drivers/net/tap.c | 172 ++---

Re: [PATCH RFC v5 01/10] virtio_net: Add functions for hashing

2024-10-12 Thread Willem de Bruijn
Akihiko Odaki wrote: > On 2024/10/09 22:51, Willem de Bruijn wrote: > > Akihiko Odaki wrote: > >> They are useful to implement VIRTIO_NET_F_RSS and > >> VIRTIO_NET_F_HASH_REPORT. > >> > >> Signed-off-by: Akihiko Odaki > >> --- > >> include/linux/virtio_net.h | 188 > >> +

Re: [PATCH RFC v5 04/10] tun: Unify vnet implementation

2024-10-12 Thread Willem de Bruijn
Akihiko Odaki wrote: > On 2024/10/09 22:55, Willem de Bruijn wrote: > > Akihiko Odaki wrote: > >> Both tun and tap exposes the same set of virtio-net-related features. > >> Unify their implementations to ease future changes. > >> > >> Signed-off-by: Akihiko Odaki > >> --- > >> MAINTAINERS

[PATCH] docs:process:changes: fix version command for btrfs-progs

2024-10-12 Thread Nihar Chaithanya
The command given in the changes.rst document to check the version of btrfs-progs is: -> btrfsck which does not output the version, and according to manual page of the btrfs-progs the command to check the version of btrfs-progs is: -> btrfs --version Add a fix changing the command to check the ver

Re: [PATCH v5 4/5] KVM: selftests: Add test for PSCI SYSTEM_OFF2

2024-10-12 Thread David Woodhouse
On Tue, 2024-10-01 at 08:33 -0700, Oliver Upton wrote: > On Thu, Sep 26, 2024 at 07:37:59PM +0100, David Woodhouse wrote: > > +static void guest_test_system_off2(void) > > +{ > > +   uint64_t ret; > > + > > +   /* assert that SYSTEM_OFF2 is discoverable */ > > +   GUEST_ASSERT(psci_feat

Re: [PATCH RFC v5 06/10] tun: Introduce virtio-net hash reporting feature

2024-10-12 Thread Akihiko Odaki
On 2024/10/09 17:05, Jason Wang wrote: On Tue, Oct 8, 2024 at 2:55 PM Akihiko Odaki wrote: Allow the guest to reuse the hash value to make receive steering consistent between the host and guest, and to save hash computation. Signed-off-by: Akihiko Odaki I wonder if this would cause overhea

Re: [PATCH RFC v5 07/10] tun: Introduce virtio-net RSS

2024-10-12 Thread Akihiko Odaki
On 2024/10/09 17:14, Jason Wang wrote: On Tue, Oct 8, 2024 at 2:55 PM Akihiko Odaki wrote: RSS is a receive steering algorithm that can be negotiated to use with virtio_net. Conventionally the hash calculation was done by the VMM. However, computing the hash after the queue was chosen defeats

Re: [PATCH RFC v5 01/10] virtio_net: Add functions for hashing

2024-10-12 Thread Akihiko Odaki
On 2024/10/09 22:51, Willem de Bruijn wrote: Akihiko Odaki wrote: They are useful to implement VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT. Signed-off-by: Akihiko Odaki --- include/linux/virtio_net.h | 188 + No need for these to be in header fi