Re: [PATCH] remoteproc: Fix spelling error in remoteproc.rst

2024-10-09 Thread Everest K.C.
On Wed, Oct 9, 2024 at 9:54 AM Mathieu Poirier wrote: > > Good morning, > > This is a case of old english vs. new english. Using "implementors" is still > correct. Moreover, there are 33 instances of the word "implementor" in the > kernel tree. Unless there is an effor to change all occurences

Re: [PATCH] remoteproc: Fix spelling error in remoteproc.rst

2024-10-09 Thread Mathieu Poirier
Good morning, This is a case of old english vs. new english. Using "implementors" is still correct. Moreover, there are 33 instances of the word "implementor" in the kernel tree. Unless there is an effor to change all occurences I will not move forward with this patch. Thanks, Mathieu On Tue,

Re: [PATCH v13 11/40] arm64/gcs: Provide basic EL2 setup to allow GCS usage at EL0 and EL1

2024-10-09 Thread Nathan Chancellor
b6270c3bca987530eafc6a15f9d54ecd0033e0e3] Add linux-next specific files for 20241009 # good: [75b607fab38d149f232f01eae5e6392b394dd659] Merge tag 'sched_ext-for-6.12-rc2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext git bisect start 'b6270c3bca987530eafc

Re: [PATCH] remoteproc: Fix spelling error in remoteproc.rst

2024-10-09 Thread Everest K.C.
On Wed, Oct 9, 2024 at 12:06 PM Jonathan Corbet wrote: > > "Everest K.C." writes: > > > On Wed, Oct 9, 2024 at 9:54 AM Mathieu Poirier > > wrote: > >> > >> Good morning, > >> > >> This is a case of old english vs. new english. Using "implementors" is > >> still > >> correct. Moreover, there a

Re: [PATCH] remoteproc: Fix spelling error in remoteproc.rst

2024-10-09 Thread Jonathan Corbet
"Everest K.C." writes: > On Wed, Oct 9, 2024 at 9:54 AM Mathieu Poirier > wrote: >> >> Good morning, >> >> This is a case of old english vs. new english. Using "implementors" is still >> correct. Moreover, there are 33 instances of the word "implementor" in the >> kernel tree. Unless there is

Re: [PATCH RFC v5 07/10] tun: Introduce virtio-net RSS

2024-10-09 Thread Jason Wang
On Tue, Oct 8, 2024 at 2:55 PM Akihiko Odaki wrote: > > RSS is a receive steering algorithm that can be negotiated to use with > virtio_net. Conventionally the hash calculation was done by the VMM. > However, computing the hash after the queue was chosen defeats the > purpose of RSS. > > Another a

Re: [PATCH v6 06/33] riscv/Kconfig: enable HAVE_EXIT_THREAD for riscv

2024-10-09 Thread Mark Brown
On Tue, Oct 08, 2024 at 03:36:48PM -0700, Deepak Gupta wrote: > riscv will need an implementation for exit_thread to clean up shadow stack > when thread exits. If current thread had shadow stack enabled, shadow > stack is allocated by default for any new thread. FWIW both arm64 and x86 do this vi

Re: [PATCH v6 11/33] riscv/mm : ensure PROT_WRITE leads to VM_READ | VM_WRITE

2024-10-09 Thread Lorenzo Stoakes
On Tue, Oct 08, 2024 at 03:36:53PM -0700, Deepak Gupta wrote: > `arch_calc_vm_prot_bits` is implemented on risc-v to return VM_READ | > VM_WRITE if PROT_WRITE is specified. Similarly `riscv_sys_mmap` is > updated to convert all incoming PROT_WRITE to (PROT_WRITE | PROT_READ). > This is to make sure

Re: [PATCH RFC v5 05/10] tun: Pad virtio header with zero

2024-10-09 Thread Jason Wang
On Tue, Oct 8, 2024 at 2:55 PM Akihiko Odaki wrote: > > tun used to simply advance iov_iter when it needs to pad virtio header, > which leaves the garbage in the buffer as is. This is especially > problematic when tun starts to allow enabling the hash reporting > feature; even if the feature is en

Re: [PATCH v6 19/33] riscv: Implements arch agnostic shadow stack prctls

2024-10-09 Thread Mark Brown
On Tue, Oct 08, 2024 at 03:37:01PM -0700, Deepak Gupta wrote: > +int arch_lock_shadow_stack_status(struct task_struct *task, > + unsigned long arg) > +{ > + /* If shtstk not supported or not enabled on task, nothing to lock here > */ > + if (!cpu_supports_shado

Re: [PATCH net v2] docs: netdev: document guidance on cleanup patches

2024-10-09 Thread Simon Horman
On Wed, Oct 09, 2024 at 11:42:14AM +0200, Przemek Kitszel wrote: > On 10/9/24 11:12, Simon Horman wrote: > > The purpose of this section is to document what is the current practice > > regarding clean-up patches which address checkpatch warnings and similar > > problems. I feel there is a value in

Re: [PATCH RFC v5 06/10] tun: Introduce virtio-net hash reporting feature

2024-10-09 Thread Jason Wang
On Tue, Oct 8, 2024 at 2:55 PM Akihiko Odaki wrote: > > Allow the guest to reuse the hash value to make receive steering > consistent between the host and guest, and to save hash computation. > > Signed-off-by: Akihiko Odaki I wonder if this would cause overhead when hash reporting is not enable

Re: [PATCH net v2] docs: netdev: document guidance on cleanup patches

2024-10-09 Thread Przemek Kitszel
On 10/9/24 11:12, Simon Horman wrote: The purpose of this section is to document what is the current practice regarding clean-up patches which address checkpatch warnings and similar problems. I feel there is a value in having this documented so others can easily refer to it. Clearly this topic

Re: [PATCH RFC v5 01/10] virtio_net: Add functions for hashing

2024-10-09 Thread Willem de Bruijn
Akihiko Odaki wrote: > They are useful to implement VIRTIO_NET_F_RSS and > VIRTIO_NET_F_HASH_REPORT. > > Signed-off-by: Akihiko Odaki > --- > include/linux/virtio_net.h | 188 > + No need for these to be in header files

Re: [PATCH RFC v5 04/10] tun: Unify vnet implementation

2024-10-09 Thread Willem de Bruijn
Akihiko Odaki wrote: > Both tun and tap exposes the same set of virtio-net-related features. > Unify their implementations to ease future changes. > > Signed-off-by: Akihiko Odaki > --- > MAINTAINERS| 1 + > drivers/net/tap.c | 172 ++-- > d

Re: [PATCH RFC v5 06/10] tun: Introduce virtio-net hash reporting feature

2024-10-09 Thread Willem de Bruijn
Akihiko Odaki wrote: > Allow the guest to reuse the hash value to make receive steering > consistent between the host and guest, and to save hash computation. > > Signed-off-by: Akihiko Odaki > --- > Documentation/networking/tuntap.rst | 7 +++ > drivers/net/Kconfig | 1 + >

Re: [PATCH v6 16/33] riscv/shstk: If needed allocate a new shadow stack on clone

2024-10-09 Thread Mark Brown
On Tue, Oct 08, 2024 at 10:55:29PM +, Edgecombe, Rick P wrote: > A lot of this patch and the previous one is similar to x86's and arm's. It > great > that we can have consistency around this behavior. > There might be enough consistency to refactor some of the arch code into a > kernel/shstk

Re: [PATCH v6 00/33] riscv control-flow integrity for usermode

2024-10-09 Thread Mark Brown
On Tue, Oct 08, 2024 at 03:36:42PM -0700, Deepak Gupta wrote: > Equivalent to landing pad (zicfilp) on x86 is `ENDBRANCH` instruction in Intel > CET [3] and branch target identification (BTI) [4] on arm. > Similarly x86's Intel CET has shadow stack [5] and arm64 has guarded control > stack (GCS) [

Re: [PATCH v6 18/33] prctl: arch-agnostic prctl for indirect branch tracking

2024-10-09 Thread Mark Brown
On Tue, Oct 08, 2024 at 03:37:00PM -0700, Deepak Gupta wrote: > Three architectures (x86, aarch64, riscv) have support for indirect branch > tracking feature in a very similar fashion. On a very high level, indirect > branch tracking is a CPU feature where CPU tracks branches which uses > memory op

Re: [PATCH v6 02/33] mm: helper `is_shadow_stack_vma` to check shadow stack vma

2024-10-09 Thread Mark Brown
On Tue, Oct 08, 2024 at 03:36:44PM -0700, Deepak Gupta wrote: > VM_SHADOW_STACK (alias to VM_HIGH_ARCH_5) is used to encode shadow stack > VMA on three architectures (x86 shadow stack, arm GCS and RISC-V shadow > stack). In case architecture doesn't implement shadow stack, it's VM_NONE > Introducin

[PATCH net v2] docs: netdev: document guidance on cleanup patches

2024-10-09 Thread Simon Horman
The purpose of this section is to document what is the current practice regarding clean-up patches which address checkpatch warnings and similar problems. I feel there is a value in having this documented so others can easily refer to it. Clearly this topic is subjective. And to some extent the cu

Re: [PATCH v6 11/33] riscv/mm : ensure PROT_WRITE leads to VM_READ | VM_WRITE

2024-10-09 Thread Deepak Gupta
On Wed, Oct 09, 2024 at 02:36:12PM +0100, Lorenzo Stoakes wrote: On Tue, Oct 08, 2024 at 03:36:53PM -0700, Deepak Gupta wrote: `arch_calc_vm_prot_bits` is implemented on risc-v to return VM_READ | VM_WRITE if PROT_WRITE is specified. Similarly `riscv_sys_mmap` is updated to convert all incoming