Re: [PATCH RFC v3 7/9] tun: Introduce virtio-net RSS

2024-09-18 Thread Willem de Bruijn
Akihiko Odaki wrote: > RSS is a receive steering algorithm that can be negotiated to use with > virtio_net. Conventionally the hash calculation was done by the VMM. > However, computing the hash after the queue was chosen defeats the > purpose of RSS. > > Another approach is to use eBPF steering p

Re: [PATCH v2 07/25] KVM: VMX: Set intercept for FRED MSRs

2024-09-18 Thread Xin Li
MSR_IA32_FRED_SSP0 is an alias of the CET MSR_IA32_PL0_SSP and likely to be used in the same way as FRED RSP0, i.e., host FRED SSP0 _should_ be restored in arch_exit_to_user_mode_prepare(). However as of today Linux has no plan to utilize kernel shadow stack thus no one cares host FRED SSP0 (no?)

Re: [PATCH RFC v3 2/9] virtio_net: Add functions for hashing

2024-09-18 Thread Willem de Bruijn
Akihiko Odaki wrote: > They are useful to implement VIRTIO_NET_F_RSS and > VIRTIO_NET_F_HASH_REPORT. > > Signed-off-by: Akihiko Odaki > --- > include/linux/virtio_net.h | 198 > + > 1 file changed, 198 insertions(+) > > diff --git a/include/linux/vir

Re: [PATCH RFC v3 4/9] tap: Pad virtio header with zero

2024-09-18 Thread Willem de Bruijn
Akihiko Odaki wrote: > tap used to simply advance iov_iter when it needs to pad virtio header. > This leaves the garbage in the buffer as is and prevents telling if the > header is padded or contains some real data. > > In theory, a user of tap can fill the buffer with zero before calling > read()

Re: [PATCH RFC v3 1/9] skbuff: Introduce SKB_EXT_TUN_VNET_HASH

2024-09-18 Thread Willem de Bruijn
Akihiko Odaki wrote: > This new extension will be used by tun to carry the hash values and > types to report with virtio-net headers. > > Signed-off-by: Akihiko Odaki > --- > include/linux/skbuff.h | 10 ++ > net/core/skbuff.c | 3 +++ > 2 files changed, 13 insertions(+) > > diff

Re: [PATCH RFC v3 6/9] tun: Introduce virtio-net hash reporting feature

2024-09-18 Thread Willem de Bruijn
Akihiko Odaki wrote: > Allow the guest to reuse the hash value to make receive steering > consistent between the host and guest, and to save hash computation. > > Signed-off-by: Akihiko Odaki > --- > Documentation/networking/tuntap.rst | 7 ++ > drivers/net/Kconfig | 1 + > d