[PATCH RFC v3 2/9] virtio_net: Add functions for hashing

2024-09-16 Thread gur.stavi
+ +static inline void virtio_net_toeplitz(struct virtio_net_toeplitz_state *state, + const __be32 *input, size_t len) The function calculates a hash value but its name does not make it clear. Consider adding a 'calc'. +{ + u32 key; + + while (len)

[PATCH RFC v3 2/9] virtio_net: Add functions for hashing

2024-09-16 Thread gur.stavi
> + > +static inline void virtio_net_toeplitz(struct virtio_net_toeplitz_state > *state, > +const __be32 *input, size_t len) > > The function calculates a hash value but its name does not make it > clear. Consider adding a 'calc'. > > +{ > + u32 key; > + >

Re: [PATCH] kernel-docs: Add new section for Rust learning materials

2024-09-16 Thread Miguel Ojeda
On Wed, Sep 11, 2024 at 8:59 PM Carlos Bilbao wrote: > > Include a new section in the Index of Further Kernel Documentation with > resources to learn Rust. Reference it in the Rust index. Thanks for this, Carlos! It would be nice to mention that this came out of a session of Kangrejos with sugges

[PATCH RFC v3 2/9] virtio_net: Add functions for hashing

2024-09-16 Thread gur.stavi
> + > +static inline bool virtio_net_hash_rss(const struct sk_buff *skb, > +u32 types, const __be32 *key, > +struct virtio_net_hash *hash) Based on the guidelines, this function seems imperative rather than predicate and shoul

Re: [PATCH v5 00/14] integrity: Introduce the Integrity Digest Cache

2024-09-16 Thread Dr. Greg
On Thu, Sep 05, 2024 at 05:05:29PM +0200, Roberto Sassu wrote: Good morning, I hope the week is starting well for everyone Apologies for the delay in getting these thoughts out, scrambling to catch up on my e-mail backlog. I looped Linus in, secondary to the conversations surrounding the PGP ver

Re: [PATCH v10 14/14] riscv: Add ghostwrite vulnerability

2024-09-16 Thread Conor Dooley
On Wed, Sep 11, 2024 at 10:55:22PM -0700, Charlie Jenkins wrote: > Follow the patterns of the other architectures that use > GENERIC_CPU_VULNERABILITIES for riscv to introduce the ghostwrite > vulnerability and mitigation. The mitigation is to disable all vector > which is accomplished by clearing

Re: [PATCH v10 14/14] riscv: Add ghostwrite vulnerability

2024-09-16 Thread Charlie Jenkins
On Mon, Sep 16, 2024 at 06:12:04PM +0100, Conor Dooley wrote: > On Wed, Sep 11, 2024 at 10:55:22PM -0700, Charlie Jenkins wrote: > > Follow the patterns of the other architectures that use > > GENERIC_CPU_VULNERABILITIES for riscv to introduce the ghostwrite > > vulnerability and mitigation. The mi

Re: [PATCH v10 14/14] riscv: Add ghostwrite vulnerability

2024-09-16 Thread Conor Dooley
On Mon, Sep 16, 2024 at 11:44:04AM -0700, Charlie Jenkins wrote: > I figured that since T-Head didn't feel it was > valuable to change the archid/implid between cores that Linux shouldn't > go out of its way to fix the granularity issue. I mean, when you put it like that, I'm not particularly incl

Re: [PATCH v4 23/30] riscv signal: save and restore of shadow stack for signal

2024-09-16 Thread Deepak Gupta
On Fri, Sep 13, 2024 at 09:25:57PM +0200, Andy Chiu wrote: Hi Deepak, Deepak Gupta 於 2024年9月13日 週五 上午1:20寫道: Save shadow stack pointer in sigcontext structure while delivering signal. Restore shadow stack pointer from sigcontext on sigreturn. As part of save operation, kernel uses `ssamoswap

Re: [PATCH v4 21/30] riscv/traps: Introduce software check exception

2024-09-16 Thread Deepak Gupta
On Fri, Sep 13, 2024 at 09:35:50PM +0200, Andy Chiu wrote: Hi Deepak Deepak Gupta 於 2024年9月13日 週五 上午2:32寫道: zicfiss / zicfilp introduces a new exception to priv isa `software check exception` with cause code = 18. This patch implements software check exception. Additionally it implements a c