Re: [PATCH 2/2] Documentation: best practices for using Link trailers

2024-06-20 Thread Thorsten Leemhuis
On 18.06.24 18:42, Konstantin Ryabitsev wrote: > Based on multiple conversations, most recently on the ksummit mailing > list [1], add some best practices for using the Link trailer, such as: > > - how to use markdown-like bracketed numbers in the commit message to > indicate the corresponding lin

Re: [PATCH RESEND net-next v14 1/5] linux/dim: move useful macros to .h file

2024-06-20 Thread Simon Horman
On Tue, Jun 18, 2024 at 10:56:40AM +0800, Heng Qi wrote: > Useful macros will be used effectively elsewhere. > These will be utilized in subsequent patches. > > Signed-off-by: Heng Qi Reviewed-by: Simon Horman

Re: [PATCH RESEND net-next v14 2/5] dim: make DIMLIB dependent on NET

2024-06-20 Thread Simon Horman
On Tue, Jun 18, 2024 at 10:56:41AM +0800, Heng Qi wrote: > DIMLIB's capabilities are supplied by the dim, net_dim, and > rdma_dim objects, and dim's interfaces solely act as a base for > net_dim and rdma_dim and are not explicitly used anywhere else. > rdma_dim is utilized by the infiniband driver,

Re: [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim profile management

2024-06-20 Thread Simon Horman
On Tue, Jun 18, 2024 at 10:56:42AM +0800, Heng Qi wrote: > The NetDIM library, currently leveraged by an array of NICs, delivers > excellent acceleration benefits. Nevertheless, NICs vary significantly > in their dim profile list prerequisites. > > Specifically, virtio-net backends may present div

Re: [PATCH RESEND net-next v14 4/5] dim: add new interfaces for initialization and getting results

2024-06-20 Thread Simon Horman
On Tue, Jun 18, 2024 at 10:56:43AM +0800, Heng Qi wrote: > DIM-related mode and work have been collected in one same place, > so new interfaces are added to provide convenience. > > Signed-off-by: Heng Qi Reviewed-by: Simon Horman

Re: [PATCH RESEND net-next v14 5/5] virtio-net: support dim profile fine-tuning

2024-06-20 Thread Simon Horman
On Tue, Jun 18, 2024 at 10:56:44AM +0800, Heng Qi wrote: > Virtio-net has different types of back-end device implementations. > In order to effectively optimize the dim library's gains for different > device implementations, let's use the new interface params to > initialize and query dim results f

Re: [PATCH v6 2/2] proc: restrict /proc/pid/mem

2024-06-20 Thread Jeff Xu
On Wed, Jun 19, 2024 at 1:41 PM Kees Cook wrote: > > On Tue, Jun 18, 2024 at 03:39:44PM -0700, Jeff Xu wrote: > > Hi > > > > Thanks for the patch ! > > > > On Thu, Jun 13, 2024 at 6:40 AM Adrian Ratiu > > wrote: > > > > > > Prior to v2.6.39 write access to /proc//mem was restricted, > > > after

Re: [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim profile management

2024-06-20 Thread Jakub Kicinski
On Tue, 18 Jun 2024 10:56:42 +0800 Heng Qi wrote: > + if (dev->irq_moder && dev->irq_moder->profile_flags & DIM_PROFILE_RX) { > + ret = ethnl_update_profile(dev, &dev->irq_moder->rx_profile, > +tb[ETHTOOL_A_COALESCE_RX_PROFILE], > +

Re: [PATCH RESEND net-next v14 0/5] ethtool: provide the dim profile fine-tuning channel

2024-06-20 Thread Jakub Kicinski
On Tue, 18 Jun 2024 10:56:39 +0800 Heng Qi wrote: > The NetDIM library provides excellent acceleration for many modern > network cards. However, the default profiles of DIM limits its maximum > capabilities for different NICs, so providing a way which the NIC can > be custom configured is necessary

Re: [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim profile management

2024-06-20 Thread Jakub Kicinski
On Tue, 18 Jun 2024 10:56:42 +0800 Heng Qi wrote: > --- a/Documentation/networking/ethtool-netlink.rst > +++ b/Documentation/networking/ethtool-netlink.rst > @@ -1033,6 +1033,8 @@ Kernel response contents: >``ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES`` u32 max aggr size, Tx >``ETHTOOL_A_

Re: [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim profile management

2024-06-20 Thread Heng Qi
On Thu, 20 Jun 2024 20:39:18 -0700, Jakub Kicinski wrote: > On Tue, 18 Jun 2024 10:56:42 +0800 Heng Qi wrote: > > + if (dev->irq_moder && dev->irq_moder->profile_flags & DIM_PROFILE_RX) { > > + ret = ethnl_update_profile(dev, &dev->irq_moder->rx_profile, > > +

Re: [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim profile management

2024-06-20 Thread Heng Qi
On Thu, 20 Jun 2024 20:44:45 -0700, Jakub Kicinski wrote: > On Tue, 18 Jun 2024 10:56:42 +0800 Heng Qi wrote: > > --- a/Documentation/networking/ethtool-netlink.rst > > +++ b/Documentation/networking/ethtool-netlink.rst > > @@ -1033,6 +1033,8 @@ Kernel response contents: > >``ETHTOOL_A_COALESC

Re: [PATCH RESEND net-next v14 0/5] ethtool: provide the dim profile fine-tuning channel

2024-06-20 Thread Heng Qi
On Thu, 20 Jun 2024 20:40:25 -0700, Jakub Kicinski wrote: > On Tue, 18 Jun 2024 10:56:39 +0800 Heng Qi wrote: > > The NetDIM library provides excellent acceleration for many modern > > network cards. However, the default profiles of DIM limits its maximum > > capabilities for different NICs, so pr