Re: [PATCH] Documentation: coding-style: ask function-like macros to evaluate parameters

2024-03-21 Thread Barry Song
On Thu, Mar 21, 2024 at 5:40 PM Meiyong Yu wrote: > > > 在 2024/3/21 8:11, Barry Song 写道: > > On Thu, Mar 21, 2024 at 12:39 PM Meiyong Yu wrote: > >> > >>> On Mar 20, 2024, at 08:17, Barry Song <21cn...@gmail.com> wrote: > >>> > >>> From: Barry Song > >>> > >>> Recent commit 77292bb8ca69c80 ("cr

Re: [PATCH] Documentation: coding-style: ask function-like macros to evaluate parameters

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 07:48:36AM +1300, Barry Song wrote: > On Thu, Mar 21, 2024 at 4:49 AM Andrew Morton > wrote: > > Stronger than that please. Just tell people not to use macros in such > > situations. Always code it in C. > While I appreciate the consistency of always using "static inli

[PATCH] trace doc: Minor grammatical correction

2024-03-21 Thread Sarat Mandava
Use the correct relative pronoun. Signed-off-by: Sarat Mandava --- Documentation/trace/tracepoints.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/trace/tracepoints.rst b/Documentation/trace/tracepoints.rst index 0cb8d9ca3d60..decabcc77b56 100644 --- a/Docu

Re: [PATCH v2] Documentation: tpm_tis

2024-03-21 Thread Jarkko Sakkinen
On Wed Mar 20, 2024 at 6:15 PM EET, Stefan Berger wrote: > > > On 3/20/24 04:56, Jarkko Sakkinen wrote: > > Based recent discussions on LKML, provide preliminary bits of tpm_tis_core > > dependent drivers. Includes only bare essentials but can be extended later > > on case by case. This way some pe

Re: [PATCH v2] Documentation: tpm_tis

2024-03-21 Thread Jarkko Sakkinen
On Wed Mar 20, 2024 at 4:27 PM EET, Randy Dunlap wrote: > Hi, > > On 3/20/24 01:56, Jarkko Sakkinen wrote: > > Based recent discussions on LKML, provide preliminary bits of tpm_tis_core > > dependent drivers. Includes only bare essentials but can be extended later > > on case by case. This way some

Re: [PATCH v2] Documentation: tpm_tis

2024-03-21 Thread Stefan Berger
On 3/21/24 11:51, Jarkko Sakkinen wrote: On Wed Mar 20, 2024 at 6:15 PM EET, Stefan Berger wrote: On 3/20/24 04:56, Jarkko Sakkinen wrote: Based recent discussions on LKML, provide preliminary bits of tpm_tis_core dependent drivers. Includes only bare essentials but can be extended later o

Re: [PATCH v2] Documentation: tpm_tis

2024-03-21 Thread Jarkko Sakkinen
On Thu Mar 21, 2024 at 6:09 PM EET, Stefan Berger wrote: > > > On 3/21/24 11:51, Jarkko Sakkinen wrote: > > On Wed Mar 20, 2024 at 6:15 PM EET, Stefan Berger wrote: > >> > >> > >> On 3/20/24 04:56, Jarkko Sakkinen wrote: > >>> Based recent discussions on LKML, provide preliminary bits of tpm_tis_co

Re: [PATCH v2] Documentation: tpm_tis

2024-03-21 Thread Jarkko Sakkinen
On Thu Mar 21, 2024 at 6:24 PM EET, Jarkko Sakkinen wrote: > On Thu Mar 21, 2024 at 6:09 PM EET, Stefan Berger wrote: > > > > > > On 3/21/24 11:51, Jarkko Sakkinen wrote: > > > On Wed Mar 20, 2024 at 6:15 PM EET, Stefan Berger wrote: > > >> > > >> > > >> On 3/20/24 04:56, Jarkko Sakkinen wrote: > >

Re: [PATCH v2] Documentation: tpm_tis

2024-03-21 Thread Jarkko Sakkinen
On Thu Mar 21, 2024 at 6:32 PM EET, Jarkko Sakkinen wrote: > On Thu Mar 21, 2024 at 6:24 PM EET, Jarkko Sakkinen wrote: > > On Thu Mar 21, 2024 at 6:09 PM EET, Stefan Berger wrote: > > > > > > > > > On 3/21/24 11:51, Jarkko Sakkinen wrote: > > > > On Wed Mar 20, 2024 at 6:15 PM EET, Stefan Berger w

[PATCH v3] Documentation: tpm_tis

2024-03-21 Thread Jarkko Sakkinen
Based recent discussions on LKML, provide preliminary bits of tpm_tis_core dependent drivers. Includes only bare essentials but can be extended later on case by case. This way some people may even want to read it later on. Cc: Jonathan Corbet CC: Daniel P. Smith Cc: Lino Sanfilippo Cc: Jason Gu

Re: [PATCH v3] Documentation: tpm_tis

2024-03-21 Thread Jarkko Sakkinen
On Thu Mar 21, 2024 at 6:43 PM EET, Jarkko Sakkinen wrote: > Based recent discussions on LKML, provide preliminary bits of tpm_tis_core > dependent drivers. Includes only bare essentials but can be extended later > on case by case. This way some people may even want to read it later on. $ pdftotex

Re: [PATCH v3] Documentation: tpm_tis

2024-03-21 Thread Jarkko Sakkinen
On Thu Mar 21, 2024 at 6:54 PM EET, Jarkko Sakkinen wrote: > On Thu Mar 21, 2024 at 6:43 PM EET, Jarkko Sakkinen wrote: > > Based recent discussions on LKML, provide preliminary bits of tpm_tis_core > > dependent drivers. Includes only bare essentials but can be extended later > > on case by case.

Re: [PATCH] Documentation: coding-style: ask function-like macros to evaluate parameters

2024-03-21 Thread Andrew Morton
On Thu, 21 Mar 2024 07:48:36 +1300 Barry Song <21cn...@gmail.com> wrote: > > Stronger than that please. Just tell people not to use macros in such > > situations. Always code it in C. > > While I appreciate the consistency of always using "static inline" > instead of macros, > I've noticed nume

Re: [PATCH] Documentation: coding-style: ask function-like macros to evaluate parameters

2024-03-21 Thread Barry Song
On Fri, Mar 22, 2024 at 12:15 AM Mark Brown wrote: > > On Thu, Mar 21, 2024 at 07:48:36AM +1300, Barry Song wrote: > > On Thu, Mar 21, 2024 at 4:49 AM Andrew Morton > > wrote: > > > > Stronger than that please. Just tell people not to use macros in such > > > situations. Always code it in C. >

Re: [PATCH v6 05/37] fs: Convert alloc_inode_sb() to a macro

2024-03-21 Thread Andrew Morton
On Thu, 21 Mar 2024 09:36:27 -0700 Suren Baghdasaryan wrote: > From: Kent Overstreet > > We're introducing alloc tagging, which tracks memory allocations by > callsite. Converting alloc_inode_sb() to a macro means allocations will > be tracked by its caller, which is a bit more useful. I'd hav

Re: [PATCH v6 00/37] Memory allocation profiling

2024-03-21 Thread Andrew Morton
On Thu, 21 Mar 2024 09:36:22 -0700 Suren Baghdasaryan wrote: > Low overhead [1] per-callsite memory allocation profiling. Not just for > debug kernels, overhead low enough to be deployed in production. > > Example output: > root@moria-kvm:~# sort -rn /proc/allocinfo >12766412831168 mm/

Re: [PATCH v6 05/37] fs: Convert alloc_inode_sb() to a macro

2024-03-21 Thread Andrew Morton
On Thu, 21 Mar 2024 17:15:39 -0400 Kent Overstreet wrote: > On Thu, Mar 21, 2024 at 01:31:47PM -0700, Andrew Morton wrote: > > On Thu, 21 Mar 2024 09:36:27 -0700 Suren Baghdasaryan > > wrote: > > > > > From: Kent Overstreet > > > > > > We're introducing alloc tagging, which tracks memory al