While going through the submit checklist, the list order seemed rather
random, probably just by historical coincidences of always adding yet the
next point someone thought of at the end of the list.
Structure and order them by the category of such activity,
reviewing, documenting, checking with to
On Fri, 23 Feb 2024 11:41:46 -0600
John Groves wrote:
> This function should be called by fs-dax file systems after opening the
> devdax device. This adds holder_operations.
>
> This function serves the same role as fs_dax_get_by_bdev(), which dax
> file systems call after opening the pmem block
On Fri, 23 Feb 2024 11:41:47 -0600
John Groves wrote:
> bus.c can't call functions in device.c - that creates a circular linkage
> dependency.
>
> Signed-off-by: John Groves
This also adds the export which you should mention!
Do they need it already? Seems like tense of patch title
may be wro
On Fri, 23 Feb 2024 11:41:48 -0600
John Groves wrote:
> Save the kva from memremap because we need it for iomap rw support
>
> Prior to famfs, there were no iomap users of /dev/dax - so the virtual
> address from memremap was not needed.
>
> Also: in some cases dev_dax_probe() is called with th
On Fri, 23 Feb 2024 11:41:50 -0600
John Groves wrote:
> Add the CONFIG_DEV_DAX_IOMAP kernel config parameter to control building
> of the iomap functionality to support fsdax on devdax.
I would squash with previous patch.
Only reason I ever see for separate Kconfig patches is when there is some
On Fri, 23 Feb 2024 11:41:49 -0600
John Groves wrote:
> Notes about this commit:
>
> * These methods are based somewhat loosely on pmem_dax_ops from
> drivers/nvdimm/pmem.c
>
> * dev_dax_direct_access() is returns the hpa, pfn and kva. The kva was
> newly stored as dev_dax->virt_addr by dev
On Fri, 23 Feb 2024 11:41:51 -0600
John Groves wrote:
> Add uapi include file for famfs. The famfs user space uses ioctl on
> individual files to pass in mapping information and file size. This
> would be hard to do via sysfs or other means, since it's
> file-specific.
>
> Signed-off-by: John Gr
On Fri, 23 Feb 2024 11:41:52 -0600
John Groves wrote:
> Add the famfs_internal.h include file. This contains internal data
> structures such as the per-file metadata structure (famfs_file_meta)
> and extent formats.
>
> Signed-off-by: John Groves
Hi John,
Build this up as you add the definitio
On Mon, 26 Feb 2024, Lukas Bulwahn wrote:
> diff --git a/Documentation/process/submit-checklist.rst
> b/Documentation/process/submit-checklist.rst
> index b1bc2d37bd0a..7d8dba942fe8 100644
> --- a/Documentation/process/submit-checklist.rst
> +++ b/Documentation/process/submit-checklist.rst
> @@ -
On Fri, 23 Feb 2024 11:41:53 -0600
John Groves wrote:
> Introduce the famfs superblock operations
>
> Signed-off-by: John Groves
> ---
> fs/famfs/famfs_inode.c | 72 ++
> 1 file changed, 72 insertions(+)
> create mode 100644 fs/famfs/famfs_inode.c
>
>
On Fri, 23 Feb 2024 11:41:54 -0600
John Groves wrote:
> Famfs works on both /dev/pmem and /dev/dax devices. This commit introduces
> the function that opens a block (pmem) device and the struct
> dax_holder_operations that are needed for that ABI.
>
> In this commit, support for opening characte
On Fri, 23 Feb 2024 11:41:55 -0600
John Groves wrote:
> This commit introduces the famfs fs_context_operations and
> famfs_get_inode() which is used by the context operations.
>
> Signed-off-by: John Groves
Trivial comments inline.
> ---
> fs/famfs/famfs_inode.c | 178
On Fri, 23 Feb 2024 11:41:56 -0600
John Groves wrote:
> This commit introduces the famfs inode_operations. There is nothing really
> unique to famfs here in the inode_operations..
>
> This commit also introduces the famfs_file_system_type struct and the
> famfs_kill_sb() function.
>
> Signed-of
On 24/02/23 04:07PM, Luis Chamberlain wrote:
> On Fri, Feb 23, 2024 at 11:41:44AM -0600, John Groves wrote:
> > This patch set introduces famfs[1] - a special-purpose fs-dax file system
> > for sharable disaggregated or fabric-attached memory (FAM). Famfs is not
> > CXL-specific in anyway way.
> >
On Fri, 23 Feb 2024 11:41:57 -0600
John Groves wrote:
> This commit introduces the famfs iomap_ops. When either
> dax_iomap_fault() or dax_iomap_rw() is called, we get a callback
> via our iomap_begin() handler. The question being asked is
> "please resolve (file, offset) to (daxdev, offset)". Th
On Fri, 23 Feb 2024 11:41:58 -0600
John Groves wrote:
> This commit introduces the famfs file_operations. We call
> thp_get_unmapped_area() to force PMD page alignment. Our read and
> write handlers (famfs_dax_read_iter() and famfs_dax_write_iter())
> call dax_iomap_rw() to do the work.
>
> famf
On Fri, 23 Feb 2024 11:41:59 -0600
John Groves wrote:
> This commit introduces the per-file ioctl function famfs_file_ioctl()
> into struct file_operations, and introduces the famfs_file_init_dax()
> function (which is called by famfs_file_ioct())
>
> famfs_file_init_dax() associates a dax exten
On Fri, 23 Feb 2024 11:42:01 -0600
John Groves wrote:
> This commit introduces the module init and exit machinery for famfs.
>
> Signed-off-by: John Groves
I'd prefer to see this from the start with the functionality of the module
built up as you go + build logic in place. Makes it easy to spo
On Fri, 23 Feb 2024 11:42:02 -0600
John Groves wrote:
> This commit introduces the ability to open a character /dev/dax device
> instead of a block /dev/pmem device. This rests on the dev_dax_iomap
> patches earlier in this series.
Not sure the back reference is needed given it's in the series.
On 24/02/26 12:05PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:46 -0600
> John Groves wrote:
>
> > This function should be called by fs-dax file systems after opening the
> > devdax device. This adds holder_operations.
> >
> > This function serves the same role as fs_dax_get_by_bdev(),
On 24/02/26 12:10PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:47 -0600
> John Groves wrote:
>
> > bus.c can't call functions in device.c - that creates a circular linkage
> > dependency.
> >
> > Signed-off-by: John Groves
>
> This also adds the export which you should mention!
>
>
On 24/02/26 12:21PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:48 -0600
> John Groves wrote:
>
> > Save the kva from memremap because we need it for iomap rw support
> >
> > Prior to famfs, there were no iomap users of /dev/dax - so the virtual
> > address from memremap was not needed.
On Mon, Feb 26, 2024 at 07:27:18AM -0600, John Groves wrote:
> Run status group 0 (all jobs):
> WRITE: bw=29.6GiB/s (31.8GB/s), 29.6GiB/s-29.6GiB/s (31.8GB/s-31.8GB/s),
> io=44.7GiB (48.0GB), run=1511-1511msec
> This is run on an xfs file system on a SATA ssd.
To compare more closer apples to
On 24/02/26 12:32PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:49 -0600
> John Groves wrote:
>
> > Notes about this commit:
> >
> > * These methods are based somewhat loosely on pmem_dax_ops from
> > drivers/nvdimm/pmem.c
> >
> > * dev_dax_direct_access() is returns the hpa, pfn and
On 24/02/26 12:34PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:50 -0600
> John Groves wrote:
>
> > Add the CONFIG_DEV_DAX_IOMAP kernel config parameter to control building
> > of the iomap functionality to support fsdax on devdax.
>
> I would squash with previous patch.
>
> Only reaso
On 24/02/26 12:39PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:51 -0600
> John Groves wrote:
>
> > Add uapi include file for famfs. The famfs user space uses ioctl on
> > individual files to pass in mapping information and file size. This
> > would be hard to do via sysfs or other means
On Mon, 26 Feb 2024 10:44:43 -0600
John Groves wrote:
> On 24/02/26 12:39PM, Jonathan Cameron wrote:
> > On Fri, 23 Feb 2024 11:41:51 -0600
> > John Groves wrote:
> >
> > > Add uapi include file for famfs. The famfs user space uses ioctl on
> > > individual files to pass in mapping informatio
On 24/02/26 12:48PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:52 -0600
> John Groves wrote:
>
> > Add the famfs_internal.h include file. This contains internal data
> > structures such as the per-file metadata structure (famfs_file_meta)
> > and extent formats.
> >
> > Signed-off-by:
On 24/02/26 04:56PM, Jonathan Cameron wrote:
> On Mon, 26 Feb 2024 10:44:43 -0600
> John Groves wrote:
>
> > On 24/02/26 12:39PM, Jonathan Cameron wrote:
> > > On Fri, 23 Feb 2024 11:41:51 -0600
> > > John Groves wrote:
> > >
> > > > Add uapi include file for famfs. The famfs user space uses
On Mon, 26 Feb 2024 08:51:58 +0900
Masami Hiramatsu (Google) wrote:
> On Thu, 8 Feb 2024 21:18:14 +0800
> Huang Yiwei wrote:
>
> > Currently ftrace only dumps the global trace buffer on an OOPs. For
> > debugging a production usecase, instance trace will be helpful to
> > check specific problem
On Mon, 26 Feb 2024 14:24:39 -0500 Konstantin Ryabitsev wrote:
> In general, my previous experience enabling libravatar on git.kernel.org has
> taught me that many very vocal people *really* don't like to have any kind of
> statistics gathered about them. However, if it's just for docs.kernel.org,
Jakub Kicinski writes:
> On Mon, 26 Feb 2024 14:24:39 -0500 Konstantin Ryabitsev wrote:
>> In general, my previous experience enabling libravatar on git.kernel.org has
>> taught me that many very vocal people *really* don't like to have any kind of
>> statistics gathered about them. However, if i
On 24/02/26 07:53AM, Luis Chamberlain wrote:
> On Mon, Feb 26, 2024 at 07:27:18AM -0600, John Groves wrote:
> > Run status group 0 (all jobs):
> > WRITE: bw=29.6GiB/s (31.8GB/s), 29.6GiB/s-29.6GiB/s (31.8GB/s-31.8GB/s),
> > io=44.7GiB (48.0GB), run=1511-1511msec
>
> > This is run on an xfs file
On 24/02/26 12:51PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:53 -0600
> John Groves wrote:
>
> > Introduce the famfs superblock operations
> >
> > Signed-off-by: John Groves
> > ---
> > fs/famfs/famfs_inode.c | 72 ++
> > 1 file changed, 72 i
On 24/02/26 12:56PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:54 -0600
> John Groves wrote:
>
> > Famfs works on both /dev/pmem and /dev/dax devices. This commit introduces
> > the function that opens a block (pmem) device and the struct
> > dax_holder_operations that are needed for th
On 24/02/26 01:20PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:55 -0600
> John Groves wrote:
>
> > This commit introduces the famfs fs_context_operations and
> > famfs_get_inode() which is used by the context operations.
> >
> > Signed-off-by: John Groves
> Trivial comments inline.
>
On Mon, 26 Feb 2024 12:58:43 -0700 Jonathan Corbet wrote:
> Jakub Kicinski writes:
> > On Mon, 26 Feb 2024 14:24:39 -0500 Konstantin Ryabitsev wrote:
> >> In general, my previous experience enabling libravatar on git.kernel.org
> >> has
> >> taught me that many very vocal people *really* don't
On 24/02/26 01:25PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:56 -0600
> John Groves wrote:
>
> > This commit introduces the famfs inode_operations. There is nothing really
> > unique to famfs here in the inode_operations..
> >
> > This commit also introduces the famfs_file_system_typ
On 24/02/26 01:30PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:57 -0600
> John Groves wrote:
>
> > This commit introduces the famfs iomap_ops. When either
> > dax_iomap_fault() or dax_iomap_rw() is called, we get a callback
> > via our iomap_begin() handler. The question being asked is
On 24/02/26 01:32PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:58 -0600
> John Groves wrote:
>
> > This commit introduces the famfs file_operations. We call
> > thp_get_unmapped_area() to force PMD page alignment. Our read and
> > write handlers (famfs_dax_read_iter() and famfs_dax_writ
Hi Lukas,
I'll review the file changes separately. This is just replying
to the patch description comments.
On 2/26/24 02:46, Lukas Bulwahn wrote:
> While going through the submit checklist, the list order seemed rather
> random, probably just by historical coincidences of always adding yet the
On Mon, Feb 26, 2024 at 1:16 PM John Groves wrote:
>
> On 24/02/26 07:53AM, Luis Chamberlain wrote:
> > On Mon, Feb 26, 2024 at 07:27:18AM -0600, John Groves wrote:
> > > Run status group 0 (all jobs):
> > > WRITE: bw=29.6GiB/s (31.8GB/s), 29.6GiB/s-29.6GiB/s
> > > (31.8GB/s-31.8GB/s), io=44.7G
On Thu, 8 Feb 2024 21:18:14 +0800
Huang Yiwei wrote:
> Currently ftrace only dumps the global trace buffer on an OOPs. For
> debugging a production usecase, instance trace will be helpful to
> check specific problems since global trace buffer may be used for
> other purposes.
>
> This patch exte
On 24/02/26 04:58PM, Luis Chamberlain wrote:
> On Mon, Feb 26, 2024 at 1:16 PM John Groves wrote:
> >
> > On 24/02/26 07:53AM, Luis Chamberlain wrote:
> > > On Mon, Feb 26, 2024 at 07:27:18AM -0600, John Groves wrote:
> > > > Run status group 0 (all jobs):
> > > > WRITE: bw=29.6GiB/s (31.8GB/s),
Hi Jani,
On Mon, Feb 26, 2024 at 1:48 PM Jani Nikula wrote:
>
> On Mon, 26 Feb 2024, Lukas Bulwahn wrote:
> > diff --git a/Documentation/process/submit-checklist.rst
> > b/Documentation/process/submit-checklist.rst
> > index b1bc2d37bd0a..7d8dba942fe8 100644
> > --- a/Documentation/process/subm
45 matches
Mail list logo
