Re: [PATCH v4] tracing: Support to dump instance traces by ftrace_dump_on_oops

2024-02-08 Thread Huang Yiwei
On 2/7/2024 10:13 PM, Joel Fernandes wrote: On Wed, Feb 7, 2024 at 6:14 AM Steven Rostedt wrote: On Wed, 7 Feb 2024 05:24:58 -0500 Joel Fernandes wrote: Btw, hopefully the "trace off on warning" and related boot parameters also apply to instances, I haven't personally checked but I often

Re: [PATCH v4] tracing: Support to dump instance traces by ftrace_dump_on_oops

2024-02-08 Thread Joel Fernandes
On 2/8/2024 4:22 AM, Huang Yiwei wrote: > > > On 2/7/2024 10:13 PM, Joel Fernandes wrote: [..] >>> Perhaps we need an option for these too, and have all options be >>> updated via the command line. That way we don't need to make special >>> boot line parameters for this. If we move these to op

Re: [PATCH v4] tracing: Support to dump instance traces by ftrace_dump_on_oops

2024-02-08 Thread Steven Rostedt
On Thu, 8 Feb 2024 04:26:30 -0500 Joel Fernandes wrote: > > And for this patchset, shall I fix the typo and resend again? Thanks. > > That is fine with me but it is up to tracing maintainers. ;-) The rest of the patch looks good to me. Please send a v5 with the typo fix and I'll try to get it

[PATCH v5] tracing: Support to dump instance traces by ftrace_dump_on_oops

2024-02-08 Thread Huang Yiwei
Currently ftrace only dumps the global trace buffer on an OOPs. For debugging a production usecase, instance trace will be helpful to check specific problems since global trace buffer may be used for other purposes. This patch extend the ftrace_dump_on_oops parameter to dump a specific or multiple

[PATCH] docs: staging: fix typo in docs

2024-02-08 Thread Vincenzo Mezzela
This patch resolves a spelling error in the documentation found with codespell. It is submitted as part of my application to the "Linux Kernel Bug Fixing Spring Unpaid 2024" mentorship program of the Linux Kernel Foundation. Signed-off-by: Vincenzo Mezzela --- Documentation/staging/rpmsg.rst |

Re: [PATCH] docs: staging: fix typo in docs

2024-02-08 Thread Jonathan Corbet
Vincenzo Mezzela writes: So your fix is fine, but I need to point out a couple of things with the changelog. > This patch resolves a spelling error in the documentation found > with codespell. If you look at Documentation/process/submitting-patches.rst, you'll see that changelog text should be