Re: [PATCH v13 26/35] x86/fred: FRED entry/exit and dispatch code

2023-12-06 Thread Andrew Cooper
On 06/12/2023 7:45 am, Li, Xin3 wrote: >>> + case X86_TRAP_OF: >>> + exc_overflow(regs); >>> + return; >>> + >>> + /* INT3 */ >>> + case X86_TRAP_BP: >>> + exc_int3(regs); >>> + return; >> ... neither OF nor BP will ever enter fred_intx() because they'r

Re: [RFC 05/33] KVM: x86: hyper-v: Introduce VTL call/return prologues in hypercall page

2023-12-06 Thread Maxim Levitsky
On Tue, 2023-12-05 at 16:07 -0800, Sean Christopherson wrote: > On Tue, Dec 05, 2023, Maxim Levitsky wrote: > > On Tue, 2023-12-05 at 11:21 -0800, Sean Christopherson wrote: > > > On Fri, Dec 01, 2023, Nicolas Saenz Julienne wrote: > > > > On Fri Dec 1, 2023 at 5:47 PM UTC, Sean Christopherson wrot

RE: [PATCH v13 26/35] x86/fred: FRED entry/exit and dispatch code

2023-12-06 Thread Li, Xin3
> >>> + case X86_TRAP_OF: > >>> + exc_overflow(regs); > >>> + return; > >>> + > >>> + /* INT3 */ > >>> + case X86_TRAP_BP: > >>> + exc_int3(regs); > >>> + return; > >> ... neither OF nor BP will ever enter fred_intx() because they're > >> type SWEXC not SWINT. > > Pe

RE: [PATCH v13 26/35] x86/fred: FRED entry/exit and dispatch code

2023-12-06 Thread H. Peter Anvin
On December 6, 2023 11:19:26 AM PST, "Li, Xin3" wrote: >> >>> +case X86_TRAP_OF: >> >>> +exc_overflow(regs); >> >>> +return; >> >>> + >> >>> +/* INT3 */ >> >>> +case X86_TRAP_BP: >> >>> +exc_int3(regs); >> >>> +

Re: [PATCH v13 26/35] x86/fred: FRED entry/exit and dispatch code

2023-12-06 Thread Brian Gerst
On Wed, Dec 6, 2023 at 2:19 PM Li, Xin3 wrote: > > > >>> + case X86_TRAP_OF: > > >>> + exc_overflow(regs); > > >>> + return; > > >>> + > > >>> + /* INT3 */ > > >>> + case X86_TRAP_BP: > > >>> + exc_int3(regs); > > >>> + return; > > >> ... neither OF nor BP will ever