Re: [Patch v6 11/12] pstore/ram: Add ramoops ready notifier support

2023-11-27 Thread Pavan Kondeti
On Sat, Nov 25, 2023 at 03:49:54AM +0530, Mukesh Ojha wrote: > Client like minidump, is only interested in ramoops > region addresses/size so that it could register them > with its table and also it is only deals with ram > backend and does not use pstorefs to read the records. > Let's introduce a

Re: [Patch v6 10/12] pstore/ram: Add dynamic ramoops region support through commandline

2023-11-27 Thread Pavan Kondeti
On Sat, Nov 25, 2023 at 03:49:53AM +0530, Mukesh Ojha wrote: > The reserved memory region for ramoops is assumed to be at a fixed > and known location when read from the devicetree. This may not be > required for something like Qualcomm's minidump which is interested > in knowing addresses of ramoo

Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document

2023-11-27 Thread Geert Uytterhoeven
Hi Krzysztof, On Sat, Nov 25, 2023 at 7:44 PM Krzysztof Kozlowski wrote: > Document preferred coding style for Devicetree sources (DTS and DTSI), > to bring consistency among all (sub)architectures and ease in reviews. > > Cc: Andrew Davis > cc: Andrew Lunn > Cc: AngeloGioacchino Del Regno > C

[PATCH] Took care of some grammatical mistakes

2023-11-27 Thread attreyee-muk
Respected Maintainers, I have made some grammatical changes in the livepatch.rst file where I felt that the sentence would have sounded more correct and would have become easy for beginners to understand by reading. Requesting review of my proposed changes from the mainatiners. Thank You Attr

Re: [PATCH] Took care of some grammatical mistakes

2023-11-27 Thread Jonathan Corbet
attreyee-muk writes: > Respected Maintainers, > > I have made some grammatical changes in the livepatch.rst file where I > felt that the sentence would have sounded more correct and would have become > easy for > beginners to understand by reading. > Requesting review of my proposed changes fr

Re: [PATCH] docs: submitting-patches: improve the base commit explanation

2023-11-27 Thread Jonathan Corbet
Borislav Petkov writes: > From: "Borislav Petkov (AMD)" > > After receiving a second patchset this week without knowing which tree > it applies on and trying to apply it on the obvious ones and failing, > make sure the base tree information which needs to be supplied in the > 0th message of the

Re: [PATCH] Took care of some grammatical mistakes

2023-11-27 Thread Randy Dunlap
Hi, On 11/27/23 07:57, attreyee-muk wrote: > Respected Maintainers, > > I have made some grammatical changes in the livepatch.rst file where I > felt that the sentence would have sounded more correct and would have become > easy for > beginners to understand by reading. > Requesting review of

Re: [PATCH v3] docs: dt-bindings: add DTS Coding Style document

2023-11-27 Thread Rob Herring
On Sun, Nov 26, 2023 at 04:53:40PM +0200, Laurent Pinchart wrote: > Hi Krzysztof, > > On Sun, Nov 26, 2023 at 11:32:17AM +0100, Krzysztof Kozlowski wrote: > > On 25/11/2023 20:37, Laurent Pinchart wrote: > > > On Sat, Nov 25, 2023 at 07:44:22PM +0100, Krzysztof Kozlowski wrote: > > >> Document pre

Re: [RFC 04/33] KVM: x86: hyper-v: Move hypercall page handling into separate function

2023-11-27 Thread Maxim Levitsky
On Wed, 2023-11-08 at 11:17 +, Nicolas Saenz Julienne wrote: > The hypercall page patching is about to grow considerably, move it into > its own function. > > No functional change intended. > > Signed-off-by: Nicolas Saenz Julienne > --- > arch/x86/kvm/hyperv.c | 69

Re: [RFC 05/33] KVM: x86: hyper-v: Introduce VTL call/return prologues in hypercall page

2023-11-27 Thread Maxim Levitsky
On Wed, 2023-11-08 at 11:17 +, Nicolas Saenz Julienne wrote: > VTL call/return hypercalls have their own entry points in the hypercall > page because they don't follow normal hyper-v hypercall conventions. > Move the VTL call/return control input into ECX/RAX and set the > hypercall code into E

Re: [RFC 08/33] KVM: x86: Don't use hv_timer if CAP_HYPERV_VSM enabled

2023-11-27 Thread Maxim Levitsky
On Wed, 2023-11-08 at 11:17 +, Nicolas Saenz Julienne wrote: > VSM's VTLs are modeled by using a distinct vCPU per VTL. While one VTL > is running the rest of vCPUs are left idle. This doesn't play well with > the approach of tracking emulated timer expiration by using the VMX > preemption time

Re: [RFC 10/33] KVM: x86: hyper-v: Introduce KVM_HV_GET_VSM_STATE

2023-11-27 Thread Maxim Levitsky
On Wed, 2023-11-08 at 11:17 +, Nicolas Saenz Julienne wrote: > HVCALL_GET_VP_REGISTERS exposes the VTL call hypercall page entry > offsets to the guest. This hypercall is implemented in user-space while > the hypercall page patching happens in-kernel. So expose it as part of > the partition wid

Re: [RFC 12/33] KVM: x86: hyper-v: Handle VSM hcalls in user-space

2023-11-27 Thread Maxim Levitsky
On Wed, 2023-11-08 at 11:17 +, Nicolas Saenz Julienne wrote: > Let user-space handle all hypercalls that fall under the AccessVsm > partition privilege flag. That is: > - HVCALL_MODIFY_VTL_PROTECTION_MASK: > - HVCALL_ENABLE_PARTITION_VTL: > - HVCALL_ENABLE_VP_VTL: > - HVCALL_VTL_CALL: > -

Re: [RFC 16/33] KVM: x86/mmu: Expose R/W/X flags during memory fault exits

2023-11-27 Thread Maxim Levitsky
On Wed, 2023-11-08 at 11:17 +, Nicolas Saenz Julienne wrote: > Include the fault's read, write and execute status when exiting to > user-space. > > Signed-off-by: Nicolas Saenz Julienne > --- > arch/x86/kvm/mmu/mmu.c | 4 ++-- > include/linux/kvm_host.h | 9 +++-- > include/uapi/linux/

Re: [RFC 17/33] KVM: x86/mmu: Allow setting memory attributes if VSM enabled

2023-11-27 Thread Maxim Levitsky
On Wed, 2023-11-08 at 11:17 +, Nicolas Saenz Julienne wrote: > VSM is also a user of memory attributes, so let it use > kvm_set_mem_attributes(). > > Signed-off-by: Nicolas Saenz Julienne > --- > arch/x86/kvm/mmu/mmu.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff -

Re: [RFC 19/33] KVM: x86: Decouple kvm_range_has_memory_attributes() from struct kvm's mem_attr_array

2023-11-27 Thread Maxim Levitsky
On Wed, 2023-11-08 at 11:17 +, Nicolas Saenz Julienne wrote: > Decouple kvm_range_has_memory_attributes() from struct kvm's > mem_attr_array to allow other memory attribute sources to use the > function. > > Signed-off-by: Nicolas Saenz Julienne > --- > arch/x86/kvm/mmu/mmu.c | 3 ++- > in

Re: [RFC 26/33] KVM: x86: hyper-vsm: Allow setting per-VTL memory attributes

2023-11-27 Thread Maxim Levitsky
On Wed, 2023-11-08 at 11:17 +, Nicolas Saenz Julienne wrote: > Introduce KVM_SET_MEMORY_ATTRIBUTES ioctl support for VTL KVM devices. > The attributes are stored in an xarray private to the VTL device. > > The following memory attributes are supported: > - KVM_MEMORY_ATTRIBUTE_READ > - KVM_M

Re: [RFC 27/33] KVM: x86/mmu/hyper-v: Validate memory faults against per-VTL memprots

2023-11-27 Thread Maxim Levitsky
On Wed, 2023-11-08 at 11:18 +, Nicolas Saenz Julienne wrote: > Introduce a new step in __kvm_faultin_pfn() that'll validate the > fault against the vCPU's VTL protections and generate a user space exit > when invalid. > > Note that kvm_hv_faultin_pfn() has to be run after resolving the fault >