Re: [PATCH RFC 10/22] drivers: base: Move cpu_dev_init() after node_dev_init()

2023-11-13 Thread Russell King (Oracle)
On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote: > > > On 11/7/23 20:30, Russell King (Oracle) wrote: > > From: James Morse > > > > NUMA systems require the node descriptions to be ready before CPUs are > > registered. This is so that the node symlinks can be created in sysfs. > > >

Re: [PATCH RFC 05/22] ACPI: Move ACPI_HOTPLUG_CPU to be disabled on arm64 and riscv

2023-11-13 Thread Russell King (Oracle)
On Mon, Nov 13, 2023 at 10:29:39AM +1000, Gavin Shan wrote: > On 11/7/23 20:29, Russell King (Oracle) wrote: > > From: James Morse > > > > Neither arm64 nor riscv support physical hotadd of CPUs that were not > > present at boot. For arm64 much of the platform description is in static > > tables

Re: [PATCH v12 19/37] x86/fred: Update MSR_IA32_FRED_RSP0 during task switch

2023-11-13 Thread Borislav Petkov
On Mon, Oct 02, 2023 at 11:24:40PM -0700, Xin Li wrote: > From: "H. Peter Anvin (Intel)" > > MSR_IA32_FRED_RSP0 is used during ring 3 event delivery, and needs to > be updated to point to the top of next task stack during task switch. > > Signed-off-by: H. Peter Anvin (Intel) > Tested-by: Shan

Re: [PATCH RFC 05/22] ACPI: Move ACPI_HOTPLUG_CPU to be disabled on arm64 and riscv

2023-11-13 Thread Gavin Shan
On 11/13/23 18:56, Russell King (Oracle) wrote: On Mon, Nov 13, 2023 at 10:29:39AM +1000, Gavin Shan wrote: On 11/7/23 20:29, Russell King (Oracle) wrote: From: James Morse Neither arm64 nor riscv support physical hotadd of CPUs that were not present at boot. For arm64 much of the platform

Re: [PATCH V11 00/17] riscv: Add Native/Paravirt qspinlock support

2023-11-13 Thread Leonardo Bras Soares Passos
On Sun, Nov 12, 2023 at 1:24 AM Guo Ren wrote: > > On Mon, Nov 6, 2023 at 3:42 PM Leonardo Bras wrote: > > > > On Sun, Sep 10, 2023 at 04:28:54AM -0400, guo...@kernel.org wrote: > > > From: Guo Ren > > > > > > patch[1 - 10]: Native qspinlock > > > patch[11 -17]: Paravirt qspinlock > > > > > >

Re: [PATCH v12 19/37] x86/fred: Update MSR_IA32_FRED_RSP0 during task switch

2023-11-13 Thread H. Peter Anvin
On November 13, 2023 4:37:42 AM EST, Borislav Petkov wrote: >On Mon, Oct 02, 2023 at 11:24:40PM -0700, Xin Li wrote: >> From: "H. Peter Anvin (Intel)" >> >> MSR_IA32_FRED_RSP0 is used during ring 3 event delivery, and needs to >> be updated to point to the top of next task stack during task swit

Re: [PATCH v12 19/37] x86/fred: Update MSR_IA32_FRED_RSP0 during task switch

2023-11-13 Thread Borislav Petkov
On Mon, Nov 13, 2023 at 12:36:04PM -0500, H. Peter Anvin wrote: > A resource cannot be consumed after the value has been written; this > is the only necessary level of serialization, equivalent to, say, RAX. Lemme see if I understand this correctly using this context as an example: after this MSR_

Re: [PATCH v12 19/37] x86/fred: Update MSR_IA32_FRED_RSP0 during task switch

2023-11-13 Thread H. Peter Anvin
On November 13, 2023 1:29:47 PM EST, Borislav Petkov wrote: >On Mon, Nov 13, 2023 at 12:36:04PM -0500, H. Peter Anvin wrote: >> A resource cannot be consumed after the value has been written; this >> is the only necessary level of serialization, equivalent to, say, RAX. > >Lemme see if I understan

RE: [PATCH v12 01/37] x86/cpufeatures: Add the cpu feature bit for WRMSRNS

2023-11-13 Thread Li, Xin3
> Then, further down in the patchset, it says: > > + if (cpu_feature_enabled(X86_FEATURE_FRED)) { > + /* WRMSRNS is a baseline feature for FRED. */ > > but WRMSRNS is not mentioned in the FRED spec "Document Number: > 346446-005US, Revision: 5.0" which, according to > > https://w

Re: [PATCH v12 01/37] x86/cpufeatures: Add the cpu feature bit for WRMSRNS

2023-11-13 Thread Borislav Petkov
On Tue, Nov 14, 2023 at 12:43:38AM +, Li, Xin3 wrote: > No. tglx asked for it: > https://lkml.kernel.org/kvm/87y1h81ht4.ffs@tglx/ Aha "According to the CPU folks FRED systems are guaranteed to have WRMSRNS - I asked for that :). It's just not yet documented." so I'm going to expect that to

RE: [PATCH v12 01/37] x86/cpufeatures: Add the cpu feature bit for WRMSRNS

2023-11-13 Thread Li, Xin3
> and if you had to be precise, the code should do: > > if (cpu_feature_enabled(X86_FEATURE_FRED)) { > if (cpu_feature_enabled(X86_FEATURE_WRMSRNS)) > wrmsrns(MSR_IA32_FRED_RSP0, (unsigned > long)task_stack_page(task) + THREAD_SIZE); > else >