Re: [PATCH net-next v2] docs: try to encourage (netdev?) reviewers

2023-10-11 Thread Bagas Sanjaya
On Tue, Oct 10, 2023 at 07:42:24PM -0700, Jakub Kicinski wrote: > +Another technique that is useful in case of a disagreement is to ask for > others > +to chime in. If a discussion reaches a stalemate after a few exchanges, > +then call for opinions of other reviewers or maintainers. Often those i

Re: [RFC PATCH 11/14] mm/slub: allocate slabs from virtual memory

2023-10-11 Thread Matteo Rizzo
On Fri, 15 Sept 2023 at 23:57, Dave Hansen wrote: > > I assume that the TLB flushes in the queue are going to be pretty sparse > on average. > > At least on x86, flush_tlb_kernel_range() falls back pretty quickly from > individual address invalidation to just doing a full flush. It might > not ev

[PATCH v2 01/10] appletalk: make localtalk and ppp support conditional

2023-10-11 Thread Arnd Bergmann
From: Arnd Bergmann The last localtalk driver is gone now, and ppp support was never fully merged, but the code to support them for phase1 networking still calls the deprecated .ndo_do_ioctl() helper. In order to better isolate the localtalk and ppp portions of appletalk, guard all of the corres

[PATCH v2 02/10] ieee802154: avoid deprecated .ndo_do_ioctl callback

2023-10-11 Thread Arnd Bergmann
From: Arnd Bergmann The ieee802154 socket implementation is the last remaining caller of the netdevice ioctl callback. In order to completely remove this, add a custom pointer to the existing wpan_dev specific operations structure. Since that structure is currently only used to wrap the 'create'

[PATCH v2 03/10] ethernet: sp7021: fix ioctl callback pointer

2023-10-11 Thread Arnd Bergmann
From: Arnd Bergmann The old .ndo_do_ioctl() callback is never called any more, instead the driver should set .ndo_eth_ioctl() for the phy operations. Fixes: fd3040b9394c5 ("net: ethernet: Add driver for Sunplus SP7021") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/sunplus/spl2sw_drive

[PATCH v2 05/10] staging: rtl8192: remove unused legacy ioctl handlers

2023-10-11 Thread Arnd Bergmann
From: Arnd Bergmann The .ndo_do_ioctl functions are never called, and can just be removed, especially since this is a staging driver. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Arnd Bergmann --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 41 -- drivers/staging/rtl8192u/ieee80211/dot

[PATCH v2 04/10] staging: ks7010: remove unused ioctl handler

2023-10-11 Thread Arnd Bergmann
From: Arnd Bergmann The ndo_do_ioctl function has no actual callers, and doesn't do much here, so just remove it entirely as preparation for removing the callback pointer from net_device_ops. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Arnd Bergmann --- drivers/staging/ks7010/ks_wlan_net.c

[PATCH v2 06/10] staging: rtl8712: remove unused legacy ioctl handlers

2023-10-11 Thread Arnd Bergmann
From: Arnd Bergmann The .ndo_do_ioctl functions are never called, and can just be removed, especially since this is a staging driver. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Arnd Bergmann --- drivers/staging/rtl8712/os_intfs.c| 1 - drivers/staging/rtl8712/osdep_intf.h

[PATCH v2 07/10] staging: rtl8723bs: remove dead code

2023-10-11 Thread Arnd Bergmann
From: Arnd Bergmann The .ndo_do_ioctl functions are never called, so the three implementation here is useless but only works as a way to identify the device in the notifiers, which can really be removed as well. Looking through the exported functions, I found a bunch more that have no callers, s

[PATCH v2 08/10] wifi: atmel: remove unused ioctl function

2023-10-11 Thread Arnd Bergmann
From: Arnd Bergmann This function has no callers, and for the past 20 years, the request_firmware interface has been in place instead of the custom firmware loader. Acked-by: Kalle Valo Signed-off-by: Arnd Bergmann --- drivers/staging/wireless/atmel/atmel.c | 72 -- 1

[PATCH v2 09/10] wifi: hostap: remove unused ioctl function

2023-10-11 Thread Arnd Bergmann
From: Arnd Bergmann The ioctl handler has no actual callers in the kernel and is useless. All the functionality should be reachable through the regualar interfaces. Acked-by: Kalle Valo Signed-off-by: Arnd Bergmann --- drivers/staging/wireless/hostap/hostap.h | 1 - .../staging/wireles

[PATCH v2 10/10] net: remove ndo_do_ioctl handler

2023-10-11 Thread Arnd Bergmann
From: Arnd Bergmann All of the references to the callback pointer are gone, so remove the pointer itself before we grow new references to it. Signed-off-by: Arnd Bergmann --- Documentation/networking/netdevices.rst | 8 include/linux/netdevice.h | 7 --- 2 files chan

Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional

2023-10-11 Thread Jiri Pirko
Could you provide a cover letter for the set please?

Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional

2023-10-11 Thread Arnd Bergmann
On Wed, Oct 11, 2023, at 17:04, Jiri Pirko wrote: > Could you provide a cover letter for the set please? Subject: [PATCH v2 00/10] remove final .ndo_do_ioctl references The .ndo_do_ioctl() netdev operation used to be how one communicates with a network driver from userspace, but since my previous

Re: [REBASE PATCH v5 04/17] remoteproc: qcom: Remove minidump related data from qcom_common.c

2023-10-11 Thread Mathieu Poirier
On Fri, Oct 06, 2023 at 08:38:52PM +0530, Mukesh Ojha wrote: > Hi Bjorn/Mathieu, > > Patches from 2/17-4/17 is just a movement of functions to separate > config/file. > > Do you think, these can be picked independently from this series ? > I can send them separately, if required. Bjorn handles

RE: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-11 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 10, 2023 10:16 PM > To: Haiyang Zhang > Cc: Yuchung Cheng ; linux-hyp...@vger.kernel.org; > net...@vger.kernel.org; KY Srinivasan ; > da...@davemloft.net; eduma...@google.com; k...@kernel.org; > pab...@redhat.com;

Re: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-11 Thread Eric Dumazet
On Wed, Oct 11, 2023 at 8:49 PM Haiyang Zhang wrote: > > > > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday, October 10, 2023 10:16 PM > > To: Haiyang Zhang > > Cc: Yuchung Cheng ; linux-hyp...@vger.kernel.org; > > net...@vger.kernel.org; KY Srinivasan ; > > da...@dav

[PATCH net-next,v3] tcp: Set pingpong threshold via sysctl

2023-10-11 Thread Haiyang Zhang
TCP pingpong threshold is 1 by default. But some applications, like SQL DB may prefer a higher pingpong threshold to activate delayed acks in quick ack mode for better performance. The pingpong threshold and related code were changed to 3 in the year 2019 in: commit 4a41f453bedf ("tcp: change pi

RE: [PATCH v3] Documentation/process/coding-style.rst: space around const

2023-10-11 Thread Dan Williams
Max Kellermann wrote: > There are currently no rules on the placement of "const", but a recent > code submission revealed that there is clearly a preference for spaces > around it. > > checkpatch.pl has no check at all for this; though it does sometimes > complain, but only because it erroneously

Re: [PATCH net-next v2] docs: try to encourage (netdev?) reviewers

2023-10-11 Thread Florian Fainelli
On 10/10/2023 7:42 PM, Jakub Kicinski wrote: Add a section to netdev maintainer doc encouraging reviewers to chime in on the mailing list. The questions about "when is it okay to share feedback" keep coming up (most recently at netconf) and the answer is "pretty much always". Extend the sect