Re: [PATCH net-next] docs: try to encourage (netdev?) reviewers

2023-10-10 Thread Donald Hunter
Jakub Kicinski writes: > Add a section to netdev maintainer doc encouraging reviewers > to chime in on the mailing list. > > The questions about "when is it okay to share feedback" > keep coming up (most recently at netconf) and the answer > is "pretty much always". > > Extend the section of 7.Ad

[PATCH] Documentation/process/coding-style.rst: space around const/volatile

2023-10-10 Thread Max Kellermann
There are currently no rules on the placement of "const" and "volatile", but a recent code submission revealed that there is clearly a preference for spaces around them. checkpatch.pl has no check at all for this; though it does sometimes complain, but only because it erroneously thinks that the "

Re: [PATCH] Documentation/process/coding-style.rst: space around const/volatile

2023-10-10 Thread Greg KH
On Tue, Oct 10, 2023 at 12:12:40PM +0200, Max Kellermann wrote: > There are currently no rules on the placement of "const" and > "volatile", but a recent code submission revealed that there is > clearly a preference for spaces around them. > > checkpatch.pl has no check at all for this; though it

Re: [PATCH] Documentation/process/coding-style.rst: space around const/volatile

2023-10-10 Thread Max Kellermann
On Tue, Oct 10, 2023 at 1:37 PM Greg KH wrote: > Don't encourage the use of volatile please I don't mean to - but I figured IF "volatile" is used (for whatever reason, whether correct or not), it should follow the same coding style as "const". Do you want me to remove mentions of "volatile" (lea

Re: [PATCH] Documentation/process/coding-style.rst: space around const/volatile

2023-10-10 Thread Greg KH
On Tue, Oct 10, 2023 at 02:03:25PM +0200, Max Kellermann wrote: > On Tue, Oct 10, 2023 at 1:37 PM Greg KH wrote: > > Don't encourage the use of volatile please > > I don't mean to - but I figured IF "volatile" is used (for whatever > reason, whether correct or not), it should follow the same codi

[PATCH v2] Documentation/process/coding-style.rst: space around const

2023-10-10 Thread Max Kellermann
There are currently no rules on the placement of "const", but a recent code submission revealed that there is clearly a preference for spaces around them. checkpatch.pl has no check at all for this; though it does sometimes complain, but only because it erroneously thinks that the "*" (on local va

Re: [PATCH v2] Documentation/process/coding-style.rst: space around const

2023-10-10 Thread Greg KH
On Tue, Oct 10, 2023 at 02:29:35PM +0200, Max Kellermann wrote: > There are currently no rules on the placement of "const", but a recent > code submission revealed that there is clearly a preference for spaces > around them. > > checkpatch.pl has no check at all for this; though it does sometimes

[PATCH v3] Documentation/process/coding-style.rst: space around const

2023-10-10 Thread Max Kellermann
There are currently no rules on the placement of "const", but a recent code submission revealed that there is clearly a preference for spaces around it. checkpatch.pl has no check at all for this; though it does sometimes complain, but only because it erroneously thinks that the "*" (on local vari

Re: [PATCH net-next] docs: try to encourage (netdev?) reviewers

2023-10-10 Thread Matthieu Baerts
Hi Jakub, On 10/10/2023 00:56, Jakub Kicinski wrote: > Add a section to netdev maintainer doc encouraging reviewers > to chime in on the mailing list. > > The questions about "when is it okay to share feedback" > keep coming up (most recently at netconf) and the answer > is "pretty much always".

Re: [PATCH net-next] docs: try to encourage (netdev?) reviewers

2023-10-10 Thread Geert Uytterhoeven
Hi Matt, On Tue, Oct 10, 2023 at 5:19 PM Matthieu Baerts wrote: > On 10/10/2023 00:56, Jakub Kicinski wrote: > > Add a section to netdev maintainer doc encouraging reviewers > > to chime in on the mailing list. > > > > The questions about "when is it okay to share feedback" > > keep coming up (mo

Re: [PATCH net-next] docs: try to encourage (netdev?) reviewers

2023-10-10 Thread Matthieu Baerts
Hi Geert, On 10/10/2023 17:52, Geert Uytterhoeven wrote: > Hi Matt, > > On Tue, Oct 10, 2023 at 5:19 PM Matthieu Baerts wrote: >> On 10/10/2023 00:56, Jakub Kicinski wrote: >>> Add a section to netdev maintainer doc encouraging reviewers >>> to chime in on the mailing list. >>> >>> The questions

[PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-10 Thread Haiyang Zhang
TCP pingpong threshold is 1 by default. But some applications, like SQL DB may prefer a higher pingpong threshold to activate delayed acks in quick ack mode for better performance. The pingpong threshold and related code were changed to 3 in the year 2019 in: commit 4a41f453bedf ("tcp: change pi

Re: [PATCH v3] Documentation/process/coding-style.rst: space around const

2023-10-10 Thread Greg KH
On Tue, Oct 10, 2023 at 02:58:31PM +0200, Max Kellermann wrote: > There are currently no rules on the placement of "const", but a recent > code submission revealed that there is clearly a preference for spaces > around it. > > checkpatch.pl has no check at all for this; though it does sometimes >

Re: [PATCH v1] docs: move riscv under arch

2023-10-10 Thread Jonathan Corbet
Costa Shulyupin writes: > and fix all in-tree references. > > Architecture-specific documentation is being moved into Documentation/arch/ > as a way of cleaning up the top-level documentation directory and making > the docs hierarchy more closely match the source hierarchy. > > Signed-off-by: Cos

Re: [PATCH v2] docs: submitting-patches: encourage direct notifications to commenters

2023-10-10 Thread Jonathan Corbet
Thomas Weißschuh writes: > Commenters may not receive new versions of patches via the lists. > Without a directed notification to them they might miss those new > versions. > > This is frustrating for the patch developers as they don't receive their > earned Reviewed-by. > It is also frustrating

Re: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-10 Thread Neal Cardwell
On Tue, Oct 10, 2023 at 3:24 PM Haiyang Zhang wrote: > > TCP pingpong threshold is 1 by default. But some applications, like SQL DB > may prefer a higher pingpong threshold to activate delayed acks in quick > ack mode for better performance. > > The pingpong threshold and related code were changed

Re: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-10 Thread Kuniyuki Iwashima
From: Haiyang Zhang Date: Tue, 10 Oct 2023 12:23:30 -0700 > TCP pingpong threshold is 1 by default. But some applications, like SQL DB > may prefer a higher pingpong threshold to activate delayed acks in quick > ack mode for better performance. > > The pingpong threshold and related code were cha

RE: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-10 Thread Haiyang Zhang
> -Original Message- > From: Neal Cardwell > Sent: Tuesday, October 10, 2023 4:07 PM > To: Haiyang Zhang > Cc: linux-hyp...@vger.kernel.org; net...@vger.kernel.org; KY Srinivasan > ; da...@davemloft.net; eduma...@google.com; > k...@kernel.org; pab...@redhat.com; cor...@lwn.net; > dsah..

RE: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-10 Thread Haiyang Zhang
> -Original Message- > From: Kuniyuki Iwashima > Sent: Tuesday, October 10, 2023 4:12 PM > To: Haiyang Zhang > Cc: cor...@lwn.net; da...@davemloft.net; dsah...@kernel.org; > eduma...@google.com; k...@kernel.org; kun...@amazon.com; KY > Srinivasan ; linux-doc@vger.kernel.org; linux- > h

Re: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-10 Thread Stephen Hemminger
On Tue, 10 Oct 2023 12:23:30 -0700 Haiyang Zhang wrote: > TCP pingpong threshold is 1 by default. But some applications, like SQL DB > may prefer a higher pingpong threshold to activate delayed acks in quick > ack mode for better performance. > > The pingpong threshold and related code were chan

Re: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-10 Thread Yuchung Cheng
On Tue, Oct 10, 2023 at 3:14 PM Stephen Hemminger wrote: > > On Tue, 10 Oct 2023 12:23:30 -0700 > Haiyang Zhang wrote: > > > TCP pingpong threshold is 1 by default. But some applications, like SQL DB > > may prefer a higher pingpong threshold to activate delayed acks in quick > > ack mode for bet

RE: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-10 Thread Haiyang Zhang
> -Original Message- > From: Yuchung Cheng > Sent: Tuesday, October 10, 2023 6:27 PM > To: Stephen Hemminger > Cc: Haiyang Zhang ; linux-hyp...@vger.kernel.org; > net...@vger.kernel.org; KY Srinivasan ; > da...@davemloft.net; eduma...@google.com; k...@kernel.org; > pab...@redhat.com; co

Re: [PATCH v3] Documentation/process/coding-style.rst: space around const

2023-10-10 Thread Guenter Roeck
On Tue, Oct 10, 2023 at 02:58:31PM +0200, Max Kellermann wrote: > There are currently no rules on the placement of "const", but a recent > code submission revealed that there is clearly a preference for spaces > around it. > > checkpatch.pl has no check at all for this; though it does sometimes >

Re: [PATCH v3] Documentation/process/coding-style.rst: space around const

2023-10-10 Thread Joe Perches
On Tue, 2023-10-10 at 14:58 +0200, Max Kellermann wrote: > There are currently no rules on the placement of "const", but a recent > code submission revealed that there is clearly a preference for spaces > around it. > > checkpatch.pl has no check at all for this; though it does sometimes > complai

Re: [PATCH net-next,v2] tcp: Set pingpong threshold via sysctl

2023-10-10 Thread Stephen Hemminger
On Tue, 10 Oct 2023 22:59:49 + Haiyang Zhang wrote: > > > If this an application specific optimization, it should be in a socket > > > option > > > rather than system wide via sysctl. > > Initially I had a similar comment but later decided a sysctl could > > still be useful if > > 1) the e

[PATCH net-next v2] docs: try to encourage (netdev?) reviewers

2023-10-10 Thread Jakub Kicinski
Add a section to netdev maintainer doc encouraging reviewers to chime in on the mailing list. The questions about "when is it okay to share feedback" keep coming up (most recently at netconf) and the answer is "pretty much always". Extend the section of 7.AdvancedTopics.rst which deals with revie