[PATCH] tracing: document buffer_size_kb more precisely

2023-09-25 Thread Christian Loehle
buffer_size_kb no longer shows the requested amount, but the one that is actually used internally for the ring buffer. commit 6d98a0f2ac3c ("tracing: Set actual size after ring buffer resize") changed the sysfs behavior such that value read will always show the actual size, while previously it sho

Re: [PATCH] tracing: document buffer_size_kb more precisely

2023-09-25 Thread Zheng Yejian
On 2023/9/25 18:02, Christian Loehle wrote: buffer_size_kb no longer shows the requested amount, but the one that is actually used internally for the ring buffer. commit 6d98a0f2ac3c ("tracing: Set actual size after ring buffer resize") changed the sysfs behavior such that value read will always

Re: [PATCH v11 35/37] x86/syscall: Split IDT syscall setup code into idt_syscall_init()

2023-09-25 Thread H. Peter Anvin
On September 23, 2023 2:42:10 AM PDT, Xin Li wrote: >Because FRED uses the ring 3 FRED entrypoint for SYSCALL and SYSENTER and >ERETU is the only legit instruction to return to ring 3, there is NO need >to setup SYSCALL and SYSENTER MSRs for FRED, except the IA32_STAR MSR. > >Split IDT syscall set

RE: [PATCH v11 35/37] x86/syscall: Split IDT syscall setup code into idt_syscall_init()

2023-09-25 Thread Li, Xin3
> >diff --git a/arch/x86/kernel/cpu/common.c > >b/arch/x86/kernel/cpu/common.c index 20bbedbf6dcb..2ee4e7b597a3 100644 > >--- a/arch/x86/kernel/cpu/common.c > >+++ b/arch/x86/kernel/cpu/common.c > >@@ -2071,10 +2071,8 @@ static void wrmsrl_cstar(unsigned long val) > > wrmsrl(MSR_CSTAR,

RE: [PATCH v11 35/37] x86/syscall: Split IDT syscall setup code into idt_syscall_init()

2023-09-25 Thread H. Peter Anvin
On September 25, 2023 10:56:44 AM PDT, "Li, Xin3" wrote: >> >diff --git a/arch/x86/kernel/cpu/common.c >> >b/arch/x86/kernel/cpu/common.c index 20bbedbf6dcb..2ee4e7b597a3 100644 >> >--- a/arch/x86/kernel/cpu/common.c >> >+++ b/arch/x86/kernel/cpu/common.c >> >@@ -2071,10 +2071,8 @@ static void wrm

RE: [PATCH v11 35/37] x86/syscall: Split IDT syscall setup code into idt_syscall_init()

2023-09-25 Thread Li, Xin3
> >Yes, this is a noop, just a cleanup patch w/o functionality change. > > > It just seems to be completely redundant. We can just drop it, no? If we > aren't going > to explicitly clobber the registers there is no harm in setting them up for > IDT > unconditionally. If no objection, I can make