Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-19 Thread Guo Ren
On Tue, Sep 19, 2023 at 1:13 PM Leonardo Bras wrote: > > On Sun, Sep 17, 2023 at 10:34:36PM +0800, Guo Ren wrote: > > On Sat, Sep 16, 2023 at 9:25 AM Leonardo Bras wrote: > > > > > > On Fri, Sep 15, 2023 at 08:36:31PM +0800, Guo Ren wrote: > > > > On Wed, Sep 13, 2023 at 4:50 PM Leonardo Bras >

Re: [PATCH V11 08/17] riscv: qspinlock: Add virt_spin_lock() support for KVM guest

2023-09-19 Thread Guo Ren
On Tue, Sep 19, 2023 at 1:30 PM Leonardo Bras wrote: > > On Sun, Sep 17, 2023 at 11:12:31PM +0800, Guo Ren wrote: > > On Thu, Sep 14, 2023 at 4:02 PM Leonardo Bras wrote: > > > > > > On Sun, Sep 10, 2023 at 04:29:02AM -0400, guo...@kernel.org wrote: > > > > From: Guo Ren > > > > > > > > Add a st

Re: [PATCH v10 36/38] x86/fred: Add fred_syscall_init()

2023-09-19 Thread Thomas Gleixner
On Wed, Sep 13 2023 at 21:48, Xin Li wrote: > +static inline void fred_syscall_init(void) > +{ > + /* > + * Per FRED spec 5.0, FRED uses the ring 3 FRED entrypoint for SYSCALL > + * and SYSENTER, and ERETU is the only legit instruction to return to > + * ring 3, as a result there

[PATCH] rtla: fix a example in rtla-timerlat-hist.rst

2023-09-19 Thread Xie XiuQi
From: Xie XiuQi The following error message is reported when running the example in document. # timerlat hist -d 10m -c 0-4 -P d:100us:1ms -p 1ms --no-aa Failed to set timerlat period Could not apply config The unit of the period is microsecond, '1ms' cannot be accepted. usage: [rtla]

Re: [RFC PATCH 00/14] Prevent cross-cache attacks in the SLUB allocator

2023-09-19 Thread Matteo Rizzo
On Mon, 18 Sept 2023 at 19:39, Ingo Molnar wrote: > > What's the split of the increase in overhead due to SLAB_VIRTUAL=y, between > user-space execution and kernel-space execution? > Same benchmark as before (compiling a kernel on a system running the patched kernel): Intel Skylake: LABEL

Re: [PATCH] rtla: fix a example in rtla-timerlat-hist.rst

2023-09-19 Thread Daniel Bristot de Oliveira
On 9/19/23 15:30, Xie XiuQi wrote: > From: Xie XiuQi > > The following error message is reported when running the example in document. > > # timerlat hist -d 10m -c 0-4 -P d:100us:1ms -p 1ms --no-aa > Failed to set timerlat period > Could not apply config > > The unit of the period is mic

Re: [PATCH V11 03/17] riscv: Use Zicbop in arch_xchg when available

2023-09-19 Thread Leonardo Bras
On Tue, Sep 19, 2023 at 03:53:22PM +0800, Guo Ren wrote: > On Tue, Sep 19, 2023 at 1:13 PM Leonardo Bras wrote: > > > > On Sun, Sep 17, 2023 at 10:34:36PM +0800, Guo Ren wrote: > > > On Sat, Sep 16, 2023 at 9:25 AM Leonardo Bras wrote: > > > > > > > > On Fri, Sep 15, 2023 at 08:36:31PM +0800, Guo

Re: [PATCH V11 08/17] riscv: qspinlock: Add virt_spin_lock() support for KVM guest

2023-09-19 Thread Leonardo Bras
On Tue, Sep 19, 2023 at 04:04:48PM +0800, Guo Ren wrote: > On Tue, Sep 19, 2023 at 1:30 PM Leonardo Bras wrote: > > > > On Sun, Sep 17, 2023 at 11:12:31PM +0800, Guo Ren wrote: > > > On Thu, Sep 14, 2023 at 4:02 PM Leonardo Bras wrote: > > > > > > > > On Sun, Sep 10, 2023 at 04:29:02AM -0400, guo

Re: [RFC PATCH 00/14] Prevent cross-cache attacks in the SLUB allocator

2023-09-19 Thread Matteo Rizzo
On Mon, 18 Sept 2023 at 20:05, Linus Torvalds wrote: > > ... and equally importantly, what about DMA? I'm not exactly sure what you mean by this, I don't think this should affect the performance of DMA. > Or what about the fixed-size slabs (aka kmalloc?) What's the point of > "never re-use the s

Re: [RFC PATCH 00/14] Prevent cross-cache attacks in the SLUB allocator

2023-09-19 Thread Dave Hansen
On 9/19/23 06:42, Matteo Rizzo wrote: > On Mon, 18 Sept 2023 at 19:39, Ingo Molnar wrote: >> What's the split of the increase in overhead due to SLAB_VIRTUAL=y, between >> user-space execution and kernel-space execution? >> > Same benchmark as before (compiling a kernel on a system running the pat

Re: [RFC PATCH 00/14] Prevent cross-cache attacks in the SLUB allocator

2023-09-19 Thread Dave Hansen
On 9/19/23 08:48, Matteo Rizzo wrote: >> I think the whole "make it one single compile-time option" model is >> completely and fundamentally broken. > Wouldn't making this toggleable at boot time or runtime make performance > even worse? Maybe. But you can tolerate even more of a performance impa

Re: [RFC PATCH 00/14] Prevent cross-cache attacks in the SLUB allocator

2023-09-19 Thread Kees Cook
On September 19, 2023 9:02:07 AM PDT, Dave Hansen wrote: >On 9/19/23 08:48, Matteo Rizzo wrote: >>> I think the whole "make it one single compile-time option" model is >>> completely and fundamentally broken. >> Wouldn't making this toggleable at boot time or runtime make performance >> even worse

Re: [RFC PATCH 00/14] Prevent cross-cache attacks in the SLUB allocator

2023-09-19 Thread Linus Torvalds
On Tue, 19 Sept 2023 at 08:48, Matteo Rizzo wrote: > > On Mon, 18 Sept 2023 at 20:05, Linus Torvalds > wrote: > > > > ... and equally importantly, what about DMA? > > I'm not exactly sure what you mean by this, I don't think this should > affect the performance of DMA. I was more worried about j

RE: [PATCH v10 36/38] x86/fred: Add fred_syscall_init()

2023-09-19 Thread Li, Xin3
> > +static inline void fred_syscall_init(void) { > > + /* > > +* Per FRED spec 5.0, FRED uses the ring 3 FRED entrypoint for SYSCALL > > +* and SYSENTER, and ERETU is the only legit instruction to return to > > +* ring 3, as a result there is _no_ need to setup the SYSCALL and > > +