Re: [PATCH v6 09/10] device-dax: set mapping prior to vmf_insert_pfn{,_pmd,pud}()

2021-11-29 Thread Joao Martins
On 11/29/21 07:32, Christoph Hellwig wrote: > On Fri, Nov 26, 2021 at 06:39:39PM +, Joao Martins wrote: >> @@ -230,23 +235,18 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault >> *vmf, >> id = dax_read_lock(); >> switch (pe_size) { >> case PE_SIZE_PTE: >> -faul

Re: [PATCH v6 09/10] device-dax: set mapping prior to vmf_insert_pfn{,_pmd,pud}()

2021-11-29 Thread Christoph Hellwig
On Mon, Nov 29, 2021 at 03:49:46PM +, Joao Martins wrote: > Hmmm -- if by individual helpers moving to __dev_dax_{pte,pmd,pud}_fault() > it would be slightly less straighforward. Unless you might mean to move > to check_vma() (around the dax_alive() check) and that might actually > remove the o

Re: [PATCH v6 09/10] device-dax: set mapping prior to vmf_insert_pfn{,_pmd,pud}()

2021-11-29 Thread Joao Martins
On 11/29/21 15:49, Joao Martins wrote: > On 11/29/21 07:32, Christoph Hellwig wrote: >> On Fri, Nov 26, 2021 at 06:39:39PM +, Joao Martins wrote: >> Aso it seems like pfn is only an input >> parameter now and doesn't need to be passed by reference. >> > It's actually just an output parameter (t