Re: [PATCH v6 2/2] drivers/perf: Add CCPI2 PMU support in ThunderX2 UNCORE driver.

2019-10-17 Thread Ganapatrao Kulkarni
Hi John, On Wed, Oct 16, 2019 at 7:01 PM John Garry wrote: > > > > +TX2_EVENT_ATTR(req_pktsent, CCPI2_EVENT_REQ_PKT_SENT); > > +TX2_EVENT_ATTR(snoop_pktsent, CCPI2_EVENT_SNOOP_PKT_SENT); > > +TX2_EVENT_ATTR(data_pktsent, CCPI2_EVENT_DATA_PKT_SENT); > > +TX2_EVENT_ATTR(gic_pktsent, CCPI2_EVENT_GIC

Re: [PATCH v10 4/6] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-17 Thread Lee Jones
On Wed, 16 Oct 2019, Jakub Kicinski wrote: > On Wed, 16 Oct 2019 19:23:21 +0200, Thomas Bogendoerfer wrote: > > On Tue, 15 Oct 2019 12:23:49 -0700 > > Jakub Kicinski wrote: > > > > > On Tue, 15 Oct 2019 14:09:49 +0200, Thomas Bogendoerfer wrote: > > > > SGI IOC3 chip has integrated ethernet, k

Re: [PATCH 1/8] kcsan: Add Kernel Concurrency Sanitizer infrastructure

2019-10-17 Thread Peter Zijlstra
On Wed, Oct 16, 2019 at 09:34:05PM +0200, Marco Elver wrote: > On Wed, 16 Oct 2019 at 20:44, Peter Zijlstra wrote: > > > + /* > > > + * Disable interrupts & preemptions, to ignore races due to > > > accesses in > > > + * threads running on the same CPU. > > > + */ > > > + l

[PATCH v3 0/1] DRM fbconv helpers for converting fbdev drivers

2019-10-17 Thread Thomas Zimmermann
I rebased v2 of this patchset onto v5.3 and uploaded the result into the git repo at https://gitlab.freedesktop.org/tzimmermann/linux/tree/fbconv I'll keep the helpers updated for new Linux releases from time to time. The attached patch adds a new item to the TODO list that refers to the extern

[PATCH v3 1/1] drm: Add TODO item for fbdev driver conversion

2019-10-17 Thread Thomas Zimmermann
The DRM TODO list now contains an entry for converting fbdev drivers over to DRM. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/todo.rst | 27 +++ 1 file changed, 27 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 7978555

Re: [PATCH 1/8] kcsan: Add Kernel Concurrency Sanitizer infrastructure

2019-10-17 Thread Marco Elver
On Thu, 17 Oct 2019 at 09:47, Peter Zijlstra wrote: > > On Wed, Oct 16, 2019 at 09:34:05PM +0200, Marco Elver wrote: > > On Wed, 16 Oct 2019 at 20:44, Peter Zijlstra wrote: > > > > + /* > > > > + * Disable interrupts & preemptions, to ignore races due to > > > > accesses in > > > > +

Re: [PATCH v6 01/10] KVM: arm64: Document PV-time interface

2019-10-17 Thread Steven Price
On 15/10/2019 18:56, Mark Rutland wrote: > Hi Steven, > > On Fri, Oct 11, 2019 at 01:59:21PM +0100, Steven Price wrote: >> Introduce a paravirtualization interface for KVM/arm64 based on the >> "Arm Paravirtualized Time for Arm-Base Systems" specification DEN 0057A. > > I notice that as published

Re: [PATCH v10 4/6] mfd: ioc3: Add driver for SGI IOC3 chip

2019-10-17 Thread Thomas Bogendoerfer
On Wed, 16 Oct 2019 10:38:13 -0700 Jakub Kicinski wrote: > On Wed, 16 Oct 2019 19:23:21 +0200, Thomas Bogendoerfer wrote: > > On Tue, 15 Oct 2019 12:23:49 -0700 > > Jakub Kicinski wrote: > > > > > On Tue, 15 Oct 2019 14:09:49 +0200, Thomas Bogendoerfer wrote: > > > > SGI IOC3 chip has integra

Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support it.

2019-10-17 Thread Andrey Ryabinin
On 10/8/19 9:11 AM, Nick Hu wrote: > Skip the memmove checking for those archs who don't support it. The patch is fine but the changelog sounds misleading. We don't skip memmove checking. If arch don't have memmove than the C implementation from lib/string.c used. It's instrumented by compile

[PATCH v3 1/6] thermal: Remove netlink support

2019-10-17 Thread Amit Kucheria
There are no users of netlink messages for thermal inside the kernel. Remove the code and adjust the documentation. Signed-off-by: Amit Kucheria --- .../driver-api/thermal/sysfs-api.rst | 26 + drivers/thermal/thermal_core.c| 107 +- include/linux/th

[PATCH v3 0/6] Initialise thermal framework and cpufreq earlier during boot

2019-10-17 Thread Amit Kucheria
Changes since v2: - Missed one patch when posting v2. Respinning. Changes since v1: - Completely get rid of netlink support in the thermal framework. - This changes the early init patch to a single line - change to core_initcall. Changed authorship of patch since it is nothing like the origina

[PATCH v2 1/8] kcsan: Add Kernel Concurrency Sanitizer infrastructure

2019-10-17 Thread Marco Elver
Kernel Concurrency Sanitizer (KCSAN) is a dynamic data-race detector for kernel space. KCSAN is a sampling watchpoint-based data-race detector. See the included Documentation/dev-tools/kcsan.rst for more details. This patch adds basic infrastructure, but does not yet enable KCSAN for any architect

[PATCH v2 0/8] Add Kernel Concurrency Sanitizer (KCSAN)

2019-10-17 Thread Marco Elver
This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). KCSAN is a sampling watchpoint-based data-race detector. More details are included in Documentation/dev-tools/kcsan.rst. This patch-series only enables KCSAN for x86, but we expect adding support for other architectures is relat

[PATCH v2 2/8] objtool, kcsan: Add KCSAN runtime functions to whitelist

2019-10-17 Thread Marco Elver
This patch adds KCSAN runtime functions to the objtool whitelist. Signed-off-by: Marco Elver --- tools/objtool/check.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 044c9a3cb247..d1acc867b43c 100644 --- a/tools/objtool/

[PATCH v2 4/8] seqlock, kcsan: Add annotations for KCSAN

2019-10-17 Thread Marco Elver
Since seqlocks in the Linux kernel do not require the use of marked atomic accesses in critical sections, we teach KCSAN to assume such accesses are atomic. KCSAN currently also pretends that writes to `sequence` are atomic, although currently plain writes are used (their corresponding reads are RE

[PATCH v2 5/8] seqlock: Require WRITE_ONCE surrounding raw_seqcount_barrier

2019-10-17 Thread Marco Elver
This patch proposes to require marked atomic accesses surrounding raw_write_seqcount_barrier. We reason that otherwise there is no way to guarantee propagation nor atomicity of writes before/after the barrier [1]. For example, consider the compiler tears stores either before or after the barrier; i

[PATCH v2 3/8] build, kcsan: Add KCSAN build exceptions

2019-10-17 Thread Marco Elver
This blacklists several compilation units from KCSAN. See the respective inline comments for the reasoning. Signed-off-by: Marco Elver --- kernel/Makefile | 5 + kernel/sched/Makefile | 6 ++ mm/Makefile | 8 3 files changed, 19 insertions(+) diff --git a/kernel

[PATCH v2 6/8] asm-generic, kcsan: Add KCSAN instrumentation for bitops

2019-10-17 Thread Marco Elver
Add explicit KCSAN checks for bitops. Signed-off-by: Marco Elver --- v2: * Use kcsan_check{,_atomic}_{read,write} instead of kcsan_check_{access,atomic}. --- include/asm-generic/bitops-instrumented.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/asm-generic/bi

[PATCH v2 7/8] locking/atomics, kcsan: Add KCSAN instrumentation

2019-10-17 Thread Marco Elver
This adds KCSAN instrumentation to atomic-instrumented.h. Signed-off-by: Marco Elver --- v2: * Use kcsan_check{,_atomic}_{read,write} instead of kcsan_check_{access,atomic}. * Introduce __atomic_check_{read,write} [Suggested by Mark Rutland]. --- include/asm-generic/atomic-instrumented.h | 393

[PATCH v2 8/8] x86, kcsan: Enable KCSAN for x86

2019-10-17 Thread Marco Elver
This patch enables KCSAN for x86, with updates to build rules to not use KCSAN for several incompatible compilation units. Signed-off-by: Marco Elver --- v2: * Document build exceptions where no previous above comment explained why we cannot instrument. --- arch/x86/Kconfig

Re: [PATCH 0/8] Add Kernel Concurrency Sanitizer (KCSAN)

2019-10-17 Thread Marco Elver
On Wed, 16 Oct 2019 at 10:41, Marco Elver wrote: > > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > KCSAN is a sampling watchpoint-based data-race detector. More details > are included in Documentation/dev-tools/kcsan.rst. This patch-series > only enables KCSAN for x86, b

Re: [PATCH v5] printf: add support for printing symbolic error names

2019-10-17 Thread Petr Mladek
On Wed 2019-10-16 19:31:33, Andy Shevchenko wrote: > On Wed, Oct 16, 2019 at 5:52 PM Petr Mladek wrote: > > > > On Wed 2019-10-16 16:49:41, Andy Shevchenko wrote: > > > On Tue, Oct 15, 2019 at 10:07 PM Rasmus Villemoes > > > wrote: > > > > > > > +const char *errname(int err) > > > > +{ > > > > +

Re: [PATCH v6 2/2] drivers/perf: Add CCPI2 PMU support in ThunderX2 UNCORE driver.

2019-10-17 Thread Will Deacon
On Thu, Oct 17, 2019 at 12:38:51PM +0530, Ganapatrao Kulkarni wrote: > On Wed, Oct 16, 2019 at 7:01 PM John Garry wrote: > > > +TX2_EVENT_ATTR(req_pktsent, CCPI2_EVENT_REQ_PKT_SENT); > > > +TX2_EVENT_ATTR(snoop_pktsent, CCPI2_EVENT_SNOOP_PKT_SENT); > > > +TX2_EVENT_ATTR(data_pktsent, CCPI2_EVENT_D

Re: [PATCH] Documentation: admin-guide: add earlycon documentation for RISC-V

2019-10-17 Thread Christoph Hellwig
On Wed, Oct 09, 2019 at 12:53:50PM -0700, Paul Walmsley wrote: > > Kernels booting on RISC-V can specify "earlycon" with no options on > the Linux command line, and the generic DT earlycon support will query > the "chosen/stdout-path" property (if present) to determine which > early console device

Re: [PATCH v3] tpm/tpm_ftpm_tee: add shutdown call back

2019-10-17 Thread Jarkko Sakkinen
On Wed, Oct 16, 2019 at 12:31:14PM -0400, Pavel Tatashin wrote: > Add shutdown call back to close existing session with fTPM TA > to support kexec scenario. > > Add parentheses to function names in comments as specified in kdoc. > > Signed-off-by: Thirupathaiah Annapureddy > Signed-off-by: Pavel

Re: [PATCH v3 01/11] coresight: etm4x: Fixes for ETM v4.4 architecture updates.

2019-10-17 Thread Mathieu Poirier
Hi Mike, On Tue, Oct 15, 2019 at 10:19:54PM +0100, Mike Leach wrote: > ETMv4.4 adds in support for tracing secure EL2 (per arch 8.x updates). > Patch accounts for this new capability. > > Reviewed-by: Leo Yan > Signed-off-by: Mike Leach > --- > .../hwtracing/coresight/coresight-etm4x-sysfs.c

Re: [PATCH v3 02/11] coresight: etm4x: Fix input validation for sysfs.

2019-10-17 Thread Mathieu Poirier
On Tue, Oct 15, 2019 at 10:19:55PM +0100, Mike Leach wrote: > A number of issues are fixed relating to sysfs input validation:- > > 1) bb_ctrl_store() - incorrect compare of bit select field to absolute > value. Reworked per ETMv4 specification. > 2) seq_event_store() - incorrect mask value - regi

Re: [PATCH v3 03/11] coresight: etm4x: Add missing API to set EL match on address filters

2019-10-17 Thread Mathieu Poirier
On Tue, Oct 15, 2019 at 10:19:56PM +0100, Mike Leach wrote: > TRCACATRn registers have match bits for secure and non-secure exception > levels which are not accessible by the sysfs API. > This adds a new sysfs parameter to enable this - addr_exlevel_s_ns. > > Reviewed-by: Suzuki K Poulose > Signe

Re: [PATCH v3] tpm/tpm_ftpm_tee: add shutdown call back

2019-10-17 Thread Sasha Levin
On Thu, Oct 17, 2019 at 07:22:51PM +0300, Jarkko Sakkinen wrote: On Wed, Oct 16, 2019 at 12:31:14PM -0400, Pavel Tatashin wrote: Add shutdown call back to close existing session with fTPM TA to support kexec scenario. Add parentheses to function names in comments as specified in kdoc. Signed-o

[PATCH v3 linux-kselftest-test 0/6] kunit: support building core/tests as modules

2019-10-17 Thread Alan Maguire
The current kunit execution model is to provide base kunit functionality and tests built-in to the kernel. The aim of this series is to allow building kunit itself and tests as modules. This in turn allows a simple form of selective execution; load the module you wish to test. In doing so, kunit

[PATCH v3 linux-kselftest-test 3/6] kunit: add kunit_find_symbol() function for symbol lookup

2019-10-17 Thread Alan Maguire
In preparation for module support for kunit and kunit tests, we need a way of retrieving non-exported symbols from the core kernel and modules. kunit_find_symbol() supports this. Signed-off-by: Alan Maguire Signed-off-by: Knut Omang --- include/kunit/test.h | 8 lib/kunit/test-test.

[PATCH v3 linux-kselftest-test 4/6] kunit: allow kunit tests to be loaded as a module

2019-10-17 Thread Alan Maguire
as tests are added to kunit, it will become less feasible to execute all built tests together. By supporting modular tests we provide a simple way to do selective execution on a running system; specifying CONFIG_KUNIT=y CONFIG_KUNIT_EXAMPLE_TEST=m ...means we can simply "insmod example-test.ko"

[PATCH v3 linux-kselftest-test 1/6] kunit: move string-stream.h to lib/kunit/string-stream-impl.h

2019-10-17 Thread Alan Maguire
string stream interfaces are not intended for external use; move them from include/kunit to lib/kunit/string-stream-impl.h accordingly. Signed-off-by: Alan Maguire Signed-off-by: Knut Omang --- include/kunit/assert.h | 3 ++- include/kunit/string-stream.h | 51

[PATCH v3 linux-kselftest-test 2/6] kunit: hide unexported try-catch interface in try-catch-impl.h

2019-10-17 Thread Alan Maguire
also remove unused kunit_generic_try_catch Signed-off-by: Alan Maguire --- include/kunit/try-catch.h | 10 -- lib/kunit/test-test.c | 1 + lib/kunit/test.c | 1 + lib/kunit/try-catch-impl.h | 23 +++ lib/kunit/try-catch.c | 1 + 5 files changed

[PATCH v3 linux-kselftest-test 5/6] kunit: allow kunit to be loaded as a module

2019-10-17 Thread Alan Maguire
Making kunit itself buildable as a module allows for "always-on" kunit configuration; specifying CONFIG_KUNIT=m means the module is built but only used when loaded. Kunit test modules will load kunit.ko as an implicit dependency, so simply running "modprobe my-kunit-tests" will load the tests alon

[PATCH v3 linux-kselftest-test 6/6] kunit: update documentation to describe module-based build

2019-10-17 Thread Alan Maguire
Documentation should describe how to build kunit and tests as modules. Signed-off-by: Alan Maguire Signed-off-by: Knut Omang --- Documentation/dev-tools/kunit/faq.rst | 3 ++- Documentation/dev-tools/kunit/index.rst | 3 +++ Documentation/dev-tools/kunit/usage.rst | 16 3 f

Re: [PATCH v3 03/11] coresight: etm4x: Add missing API to set EL match on address filters

2019-10-17 Thread Mathieu Poirier
On Thu, 17 Oct 2019 at 12:00, Mathieu Poirier wrote: > > On Tue, Oct 15, 2019 at 10:19:56PM +0100, Mike Leach wrote: > > TRCACATRn registers have match bits for secure and non-secure exception > > levels which are not accessible by the sysfs API. > > This adds a new sysfs parameter to enable this

Re: [PATCH v3 08/11] coresight: etm4x: Add missing single-shot control API to sysfs

2019-10-17 Thread Mathieu Poirier
On Tue, Oct 15, 2019 at 10:20:01PM +0100, Mike Leach wrote: > An API to control single-shot comparator operation was missing from sysfs. > This adds the parameters to sysfs to allow programming of this feature. > > Signed-off-by: Mike Leach > --- > .../coresight/coresight-etm4x-sysfs.c |

Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support it.

2019-10-17 Thread Paul Walmsley
On Thu, 17 Oct 2019, Andrey Ryabinin wrote: > On 10/8/19 9:11 AM, Nick Hu wrote: > > Skip the memmove checking for those archs who don't support it. > > The patch is fine but the changelog sounds misleading. We don't skip memmove > checking. > If arch don't have memmove than the C implementatio

Re: [PATCH v6 2/2] drivers/perf: Add CCPI2 PMU support in ThunderX2 UNCORE driver.

2019-10-17 Thread Ganapatrao Kulkarni
Hi Will, On Thu, Oct 17, 2019 at 9:17 PM Will Deacon wrote: > > On Thu, Oct 17, 2019 at 12:38:51PM +0530, Ganapatrao Kulkarni wrote: > > On Wed, Oct 16, 2019 at 7:01 PM John Garry wrote: > > > > +TX2_EVENT_ATTR(req_pktsent, CCPI2_EVENT_REQ_PKT_SENT); > > > > +TX2_EVENT_ATTR(snoop_pktsent, CCPI2_

Re: [PATCH v3 1/6] thermal: Remove netlink support

2019-10-17 Thread Viresh Kumar
On 17-10-19, 17:57, Amit Kucheria wrote: > There are no users of netlink messages for thermal inside the kernel. > Remove the code and adjust the documentation. > > Signed-off-by: Amit Kucheria > --- > .../driver-api/thermal/sysfs-api.rst | 26 + > drivers/thermal/thermal_core.c