Re: [PATCH v2 3/3] arm64: implement KPROBES_ON_FTRACE

2019-08-20 Thread Jisheng Zhang
On Tue, 20 Aug 2019 03:54:20 + Jisheng Zhang wrote: > > > KPROBES_ON_FTRACE avoids much of the overhead with regular kprobes as it > eliminates the need for a trap, as well as the need to emulate or > single-step instructions. > > This patch implements KPROBES_ON_FTRACE for arm64. > > Test

Re: [PATCH v5 15/17] mfd: ioc3: Add driver for SGI IOC3 chip

2019-08-20 Thread Thomas Bogendoerfer
On Tue, 20 Aug 2019 08:23:08 +0200 Alexandre Belloni wrote: > On 19/08/2019 18:31:38+0200, Thomas Bogendoerfer wrote: > > diff --git a/drivers/mfd/ioc3.c b/drivers/mfd/ioc3.c > > new file mode 100644 > > index ..5bcb3461a189 > > --- /dev/null > > +++ b/drivers/mfd/ioc3.c > > @@ -0,0 +1

Re: [PATCH v2 3/3] arm64: implement KPROBES_ON_FTRACE

2019-08-20 Thread Thomas Gleixner
On Tue, 20 Aug 2019, Jisheng Zhang wrote: > KPROBES_ON_FTRACE avoids much of the overhead with regular kprobes as it > eliminates the need for a trap, as well as the need to emulate or > single-step instructions. > > This patch implements KPROBES_ON_FTRACE for arm64. git grep 'This patch' Docum

Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set

2019-08-20 Thread Thomas Gleixner
On Tue, 20 Aug 2019, Jisheng Zhang wrote: > This is to make the x86 kprobe_ftrace_handler() more common so that > the code could be reused in future. While I agree with the change in general, I can't find anything which reuses that code. So the change log is pretty useless and I have no idea how

Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set

2019-08-20 Thread Jisheng Zhang
Hi Thomas, On Tue, 20 Aug 2019 10:53:58 +0200 (CEST) Thomas Gleixner wrote: > > > On Tue, 20 Aug 2019, Jisheng Zhang wrote: > > > This is to make the x86 kprobe_ftrace_handler() more common so that > > the code could be reused in future. > > While I agree with the change in general, I can't

Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set

2019-08-20 Thread Jisheng Zhang
On Tue, 20 Aug 2019 09:02:59 + Jisheng Zhang wrote: > > > Hi Thomas, > > On Tue, 20 Aug 2019 10:53:58 +0200 (CEST) Thomas Gleixner wrote: > > > > > > > On Tue, 20 Aug 2019, Jisheng Zhang wrote: > > > > > This is to make the x86 kprobe_ftrace_handler() more common so that > > > the code

Re: [PATCH v8 22/27] binfmt_elf: Extract .note.gnu.property from an ELF file

2019-08-20 Thread Dave Martin
On Tue, Aug 13, 2019 at 01:52:20PM -0700, Yu-cheng Yu wrote: > An ELF file's .note.gnu.property indicates features the executable file > can support. For example, the property GNU_PROPERTY_X86_FEATURE_1_AND > indicates the file supports GNU_PROPERTY_X86_FEATURE_1_IBT and/or > GNU_PROPERTY_X86_FEAT

Re: [PATCH v2 2/3] kprobes: adjust kprobe addr for KPROBES_ON_FTRACE

2019-08-20 Thread Naveen N. Rao
Jisheng Zhang wrote: For KPROBES_ON_FTRACE case, we need to adjust the kprobe's addr correspondingly. Signed-off-by: Jisheng Zhang --- kernel/kprobes.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/kernel/kprobes.c b/kernel/kprobes.c index 9873fc627d61..3fd2f68

Re: [PATCH v2 2/3] kprobes: adjust kprobe addr for KPROBES_ON_FTRACE

2019-08-20 Thread Jisheng Zhang
On Tue, 20 Aug 2019 15:45:24 +0530 "Naveen N. Rao" wrote: > > > Jisheng Zhang wrote: > > For KPROBES_ON_FTRACE case, we need to adjust the kprobe's addr > > correspondingly. > > > > Signed-off-by: Jisheng Zhang > > --- > > kernel/kprobes.c | 10 +++--- > > 1 file changed, 7 insertions(+),

Re: [PATCH V3 2/3] KVM/Hyper-V: Add new KVM cap KVM_CAP_HYPERV_DIRECT_TLBFLUSH

2019-08-20 Thread Tianyu Lan
Hi Thomas: Thanks for your review. Will fix your comment in the next version. On Mon, Aug 19, 2019 at 9:27 PM Thomas Gleixner wrote: > > On Mon, 19 Aug 2019, lantianyu1...@gmail.com wrote: > > > From: Tianyu Lan > > > > This patch adds > > Same git grep command as before > > > ne

Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set

2019-08-20 Thread Peter Zijlstra
On Tue, Aug 20, 2019 at 09:02:59AM +, Jisheng Zhang wrote: > In v2, actually, the arm64 version's kprobe_ftrace_handler() is the same > as x86's, the only difference is comment, e.g > > /* Kprobe handler expects regs->ip = ip + 1 as breakpoint hit */ > > while in arm64 > > /* Kprobe handler

Re: [PATCH] docs: mtd: Update spi nor reference driver

2019-08-20 Thread John Garry
On 19/08/2019 05:39, Vignesh Raghavendra wrote: Hi, On 16/08/19 3:50 PM, John Garry wrote: On 06/08/2019 17:40, Schrempf Frieder wrote: [...] Hi, Could someone kindly advise on the following: Hi Vignesh, I am looking at ACPI support only for an mtd spi nor driver we're targeting for ma

Re: [PATCH v2] Documentation/admin-guide: Embargoed hardware security issues

2019-08-20 Thread Josh Poimboeuf
On Thu, Aug 15, 2019 at 11:25:05PM +0200, Greg Kroah-Hartman wrote: > +Contact > +--- > + > +The Linux kernel hardware security team is separate from the regular Linux > +kernel security team. > + > +The team only handles the coordination of embargoed hardware security > +issues. Reports of pu

Re: [PATCH v6 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-20 Thread Guenter Roeck
On Mon, Aug 19, 2019 at 05:15:09PM +0800, John Wang wrote: > Add the driver to monitor Inspur Power System power supplies > with hwmon over pmbus. > > This driver adds sysfs attributes for additional power supply data, > including vendor, model, part_number, serial number, > firmware revision, har

Re: [PATCH v8 18/27] mm: Introduce do_mmap_locked()

2019-08-20 Thread Yu-cheng Yu
On Mon, 2019-08-19 at 18:02 -0700, Sean Christopherson wrote: > On Tue, Aug 13, 2019 at 01:52:16PM -0700, Yu-cheng Yu wrote: > > There are a few places that need do_mmap() with mm->mmap_sem held. > > Create an in-line function for that. > > > > Signed-off-by: Yu-cheng Yu > > --- > > include/linu

Re: [PATCH v2 2/6] arm64: Introduce config for S32

2019-08-20 Thread Stefan-gabriel Mirea
Hello Shawn, On 8/19/2019 11:15 AM, Shawn Guo wrote: > On Fri, Aug 09, 2019 at 11:29:10AM +, Stefan-gabriel Mirea wrote: >> +config ARCH_S32 >> + bool "Freescale S32 SoC Family" > > So you still want to use 'Freescale' than 'NXP' here? > >> + help >> + This enables support for

Re: [PATCH v2 3/6] arm64: dts: fsl: Add device tree for S32V234-EVB

2019-08-20 Thread Stefan-gabriel Mirea
Hello Shawn, Thank you for your suggestions! On 8/19/2019 11:58 AM, Shawn Guo wrote: > On Fri, Aug 09, 2019 at 11:29:12AM +, Stefan-gabriel Mirea wrote: >> .../boot/dts/freescale/fsl-s32v234-evb.dts| 24 > > The 'fsl-' prefix can be saved here, so that we can distinguish three > fa

Re: [PATCH v2] Documentation/admin-guide: Embargoed hardware security issues

2019-08-20 Thread Greg Kroah-Hartman
On Tue, Aug 20, 2019 at 09:58:50AM -0500, Josh Poimboeuf wrote: > On Thu, Aug 15, 2019 at 11:25:05PM +0200, Greg Kroah-Hartman wrote: > > +Contact > > +--- > > + > > +The Linux kernel hardware security team is separate from the regular Linux > > +kernel security team. > > + > > +The team only h

Re: [PATCH] docs: mtd: Update spi nor reference driver

2019-08-20 Thread Mark Brown
On Tue, Aug 20, 2019 at 03:09:15PM +0100, John Garry wrote: > On 19/08/2019 05:39, Vignesh Raghavendra wrote: > > On 16/08/19 3:50 PM, John Garry wrote: > > > About the child spi flash devices, is the recommendation to just use > > > PRP0001 HID and "jedec,spi-nor" compatible? > > I am not quite

Re: [PATCH v7 3/7] of/platform: Add functional dependency link from DT bindings

2019-08-20 Thread Saravana Kannan
On Mon, Aug 19, 2019 at 9:26 PM Frank Rowand wrote: > > On 8/19/19 5:09 PM, Saravana Kannan wrote: > > On Mon, Aug 19, 2019 at 2:30 PM Frank Rowand wrote: > >> > >> On 8/19/19 1:49 PM, Saravana Kannan wrote: > >>> On Mon, Aug 19, 2019 at 10:16 AM Frank Rowand > >>> wrote: > > On 8/15/

Re: [RFC 01/19] kbuild: Fixes to rules for host-cshlib and host-cxxshlib

2019-08-20 Thread Masahiro Yamada
On Wed, Aug 14, 2019 at 9:53 PM Knut Omang wrote: > > On Wed, 2019-08-14 at 07:52 +0200, Knut Omang wrote: > > On Wed, 2019-08-14 at 11:02 +0900, Masahiro Yamada wrote: > > > Hi Knut, > > > > > > On Wed, Aug 14, 2019 at 1:19 AM Knut Omang wrote: > > > > On Tue, 2019-08-13 at 23:01 +0900, Masahiro

Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set

2019-08-20 Thread Masami Hiramatsu
Hi Jisheng, On Tue, 20 Aug 2019 09:02:59 + Jisheng Zhang wrote: > Hi Thomas, > > On Tue, 20 Aug 2019 10:53:58 +0200 (CEST) Thomas Gleixner wrote: > > > > > > > On Tue, 20 Aug 2019, Jisheng Zhang wrote: > > > > > This is to make the x86 kprobe_ftrace_handler() more common so that > > > t

Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set

2019-08-20 Thread Jisheng Zhang
Hi Peter, On Tue, 20 Aug 2019 15:21:10 +0200 Peter Zijlstra wrote: > > > On Tue, Aug 20, 2019 at 09:02:59AM +, Jisheng Zhang wrote: > > In v2, actually, the arm64 version's kprobe_ftrace_handler() is the same > > as x86's, the only difference is comment, e.g > > > > /* Kprobe handler expect

Re: [PATCH v2 2/3] kprobes: adjust kprobe addr for KPROBES_ON_FTRACE

2019-08-20 Thread Masami Hiramatsu
Hi Jisheng, On Tue, 20 Aug 2019 03:53:31 + Jisheng Zhang wrote: > For KPROBES_ON_FTRACE case, we need to adjust the kprobe's addr > correspondingly. Either KPROBES_ON_FTRACE=y or not, ftrace_location() check must be done correctly. If it failed, kprobes can modify the instruction which can

Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set

2019-08-20 Thread Jisheng Zhang
Hi, On Wed, 21 Aug 2019 10:52:47 +0900 Masami Hiramatsu wrote: > > > Hi Jisheng, > > On Tue, 20 Aug 2019 09:02:59 + > Jisheng Zhang wrote: > > > Hi Thomas, > > > > On Tue, 20 Aug 2019 10:53:58 +0200 (CEST) Thomas Gleixner wrote: > > > > > > > > > > > On Tue, 20 Aug 2019, Jisheng Zhang w

Re: [PATCH v2 2/3] kprobes: adjust kprobe addr for KPROBES_ON_FTRACE

2019-08-20 Thread Jisheng Zhang
Hi, On Wed, 21 Aug 2019 11:07:39 +0900 Masami Hiramatsu wrote: > > > Hi Jisheng, > > On Tue, 20 Aug 2019 03:53:31 + > Jisheng Zhang wrote: > > > For KPROBES_ON_FTRACE case, we need to adjust the kprobe's addr > > correspondingly. > > Either KPROBES_ON_FTRACE=y or not, ftrace_location(

Re: [PATCH v5 1/9] fpga: dfl: make init callback optional

2019-08-20 Thread Moritz Fischer
Hi, On Mon, Aug 12, 2019 at 10:49:56AM +0800, Wu Hao wrote: > This patch makes init callback of sub features optional. With > this change, people don't need to prepare any empty init callback. > > Signed-off-by: Wu Hao Acked-by: Moritz Fischer > --- > drivers/fpga/dfl.c | 10 ++ > 1 f

Re: [PATCH v5 2/9] fpga: dfl: fme: convert platform_driver to use dev_groups

2019-08-20 Thread Moritz Fischer
Hi Hao, On Mon, Aug 12, 2019 at 10:49:57AM +0800, Wu Hao wrote: > This patch takes advantage of driver core which helps to create > and remove sysfs attribute files, so there is no need to register > sysfs entries manually in dfl-fme platform river code. Nit: s/river/driver > > Signed-off-by: Wu

Re: [RFC 01/19] kbuild: Fixes to rules for host-cshlib and host-cxxshlib

2019-08-20 Thread Knut Omang
On Wed, 2019-08-21 at 10:47 +0900, Masahiro Yamada wrote: > On Wed, Aug 14, 2019 at 9:53 PM Knut Omang wrote: > > > > On Wed, 2019-08-14 at 07:52 +0200, Knut Omang wrote: > > > On Wed, 2019-08-14 at 11:02 +0900, Masahiro Yamada wrote: > > > > Hi Knut, > > > > > > > > On Wed, Aug 14, 2019 at 1:19 A

Re: [PATCH v5 1/9] fpga: dfl: make init callback optional

2019-08-20 Thread Wu Hao
On Tue, Aug 20, 2019 at 08:24:06PM -0700, Moritz Fischer wrote: > Hi, > > On Mon, Aug 12, 2019 at 10:49:56AM +0800, Wu Hao wrote: > > This patch makes init callback of sub features optional. With > > this change, people don't need to prepare any empty init callback. > > > > Signed-off-by: Wu Hao