Re: [PATCH v2 1/2] rcu/tree: Add basic support for kfree_rcu batching

2019-08-12 Thread Byungchul Park
On Sat, Aug 10, 2019 at 10:49:55PM -0400, Joel Fernandes (Google) wrote: > Recently a discussion about stability and performance of a system > involving a high rate of kfree_rcu() calls surfaced on the list [1] > which led to another discussion how to prepare for this situation. > > This patch add

Re: [PATCH v7 1/2] arm64: Define Documentation/arm64/tagged-address-abi.rst

2019-08-12 Thread Andrew Murray
On Thu, Aug 08, 2019 at 06:04:24PM +0100, Will Deacon wrote: > On Wed, Aug 07, 2019 at 04:53:20PM +0100, Catalin Marinas wrote: > > From: Vincenzo Frascino > > > > On arm64 the TCR_EL1.TBI0 bit has been always enabled hence > > the userspace (EL0) is allowed to set a non-zero value in the > > top

Re: [PATCH v3 2/2] drivers/perf: Add CCPI2 PMU support in ThunderX2 UNCORE driver.

2019-08-12 Thread Mark Rutland
On Tue, Jul 23, 2019 at 09:16:28AM +, Ganapatrao Kulkarni wrote: > CCPI2 is a low-latency high-bandwidth serial interface for connecting > ThunderX2 processors. This patch adds support to capture CCPI2 perf events. It would be worth pointing out in the commit message how the CCPI2 counters dif

Re: [PATCH 3/3] driver/core: Fix build error when SRCU and lockdep disabled

2019-08-12 Thread Joel Fernandes
On Mon, Aug 12, 2019 at 07:02:56AM +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 11, 2019 at 06:11:11PM -0400, Joel Fernandes (Google) wrote: > > Properly check if lockdep lock checking is disabled at config time. If > > so, then lock_is_held() is undefined so don't do any checking. > > > > This

Re: [PATCH v2 1/2] rcu/tree: Add basic support for kfree_rcu batching

2019-08-12 Thread Joel Fernandes
On Mon, Aug 12, 2019 at 07:29:17PM +0900, Byungchul Park wrote: [snip] > > diff --git a/include/linux/rcutiny.h b/include/linux/rcutiny.h > > index 8e727f57d814..383f2481750f 100644 > > --- a/include/linux/rcutiny.h > > +++ b/include/linux/rcutiny.h > > @@ -39,6 +39,11 @@ static inline void kfree_c

Re: [PATCH v5 1/6] mm/page_idle: Add per-pid idle page tracking using virtual index

2019-08-12 Thread Joel Fernandes
On Thu, Aug 08, 2019 at 10:00:44AM +0200, Michal Hocko wrote: > On Wed 07-08-19 17:31:05, Joel Fernandes wrote: > > On Wed, Aug 07, 2019 at 01:58:40PM -0700, Andrew Morton wrote: > > > On Wed, 7 Aug 2019 16:45:30 -0400 Joel Fernandes > > > wrote: > > > > > > > On Wed, Aug 07, 2019 at 01:04:02PM

Re: [PATCH 1/1] kbuild: recursive build of external kernel modules

2019-08-12 Thread Masahiro Yamada
On Fri, Aug 9, 2019 at 9:21 AM Shaun Tancheff wrote: > > When building a tree of external modules stage 2 fails > silently as the root modules.order is empty. > > Modify the modules.order location to be fixed to the > root when KBUILD_EXTMOD is specified and write all > module paths to the single

[PATCH v1] kernel-doc: Allow anonymous enum

2019-08-12 Thread Andy Shevchenko
In C is a valid construction to have an anonymous enumerator. Though we have now: drivers/pinctrl/intel/pinctrl-intel.c:240: error: Cannot parse enum! Support it in the kernel-doc script. Signed-off-by: Andy Shevchenko --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v2 1/2] Documentation: sphinx: Add missing comma to list of strings

2019-08-12 Thread Jonathan Neuschäfer
In Python, like in C, when a comma is omitted in a list of strings, the two strings around the missing comma are concatenated. Signed-off-by: Jonathan Neuschäfer --- v2: - new patch --- Documentation/sphinx/automarkup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Docume

[PATCH v2 2/2] Documentation: sphinx: Don't parse socket() as identifier reference

2019-08-12 Thread Jonathan Neuschäfer
With the introduction of Documentation/sphinx/automarkup.py, socket() is parsed as a reference to the in-kernel definition of socket. Sphinx then decides that struct socket is a good match, which is usually not intended, when the syscall is meant instead. This was observed in Documentation/networki

Re: [PATCH v2 2/2] Documentation: sphinx: Don't parse socket() as identifier reference

2019-08-12 Thread Mauro Carvalho Chehab
Em Mon, 12 Aug 2019 18:07:05 +0200 Jonathan Neuschäfer escreveu: > With the introduction of Documentation/sphinx/automarkup.py, socket() is > parsed as a reference to the in-kernel definition of socket. Sphinx then > decides that struct socket is a good match, which is usually not > intended, whe

Re: [PATCH v7 1/2] arm64: Define Documentation/arm64/tagged-address-abi.rst

2019-08-12 Thread Catalin Marinas
On Mon, Aug 12, 2019 at 11:46:06AM +0100, Andrew Murray wrote: > On Thu, Aug 08, 2019 at 06:04:24PM +0100, Will Deacon wrote: > > On Wed, Aug 07, 2019 at 04:53:20PM +0100, Catalin Marinas wrote: > > > + > > > +- mmap() addr parameter. > > > + > > > +- mremap() new_address parameter. > > > + > > > +

Re: [PATCH 1/1] kbuild: recursive build of external kernel modules

2019-08-12 Thread Shaun Tancheff
On Mon, Aug 12, 2019 at 10:24 AM Masahiro Yamada wrote: > > On Fri, Aug 9, 2019 at 9:21 AM Shaun Tancheff wrote: > > > > When building a tree of external modules stage 2 fails > > silently as the root modules.order is empty. > > > > Modify the modules.order location to be fixed to the > > root wh

Re: [PATCH v7 1/2] arm64: Define Documentation/arm64/tagged-address-abi.rst

2019-08-12 Thread Catalin Marinas
On Fri, Aug 09, 2019 at 07:10:18AM -0700, Dave Hansen wrote: > On 8/8/19 10:27 AM, Catalin Marinas wrote: > > On Wed, Aug 07, 2019 at 01:38:16PM -0700, Dave Hansen wrote: > >> Also, shouldn't this be converted over to an arch_prctl()? > > > > What do you mean by arch_prctl()? We don't have such th

Re: [PATCH 3/3] driver/core: Fix build error when SRCU and lockdep disabled

2019-08-12 Thread Steven Rostedt
On Mon, 12 Aug 2019 09:03:10 -0400 Joel Fernandes wrote: > > > drivers/base/core.c | 6 +- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/base/core.c b/drivers/base/core.c > > > index 32cf83d1c744..fe25cf690562 100644 > > > --- a/drivers/base/core.c

Re: [PATCH v5 1/6] mm/page_idle: Add per-pid idle page tracking using virtual index

2019-08-12 Thread Jann Horn
On Wed, Aug 7, 2019 at 7:16 PM Joel Fernandes (Google) wrote: > The page_idle tracking feature currently requires looking up the pagemap > for a process followed by interacting with /sys/kernel/mm/page_idle. > Looking up PFN from pagemap in Android devices is not supported by > unprivileged proces

Re: [PATCH v2 1/6] dt-bindings: arm: fsl: Add the S32V234-EVB board

2019-08-12 Thread Rob Herring
On Fri, Aug 9, 2019 at 5:29 AM Stefan-gabriel Mirea wrote: > > From: Eddy Petrișor > > Add entry for the NXP S32V234 Customer Evaluation Board to the board/SoC > bindings. > > Signed-off-by: Eddy Petrișor > Signed-off-by: Stefan-Gabriel Mirea > --- > Documentation/devicetree/bindings/arm/fsl.y

Re: [PATCH v3 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-12 Thread Guenter Roeck
On Mon, Aug 12, 2019 at 12:48:34PM +0800, John Wang wrote: > > So I should > > 1. Add SENSOR_INSPUR_IPSPS to the end of the file > 2. Add SENSOR_INSPUR_IPSPS in alphabetical order, without additional tab > 3. other suggestions > I would suggest 2). Just use a space before += instead of a tab. G

Re: [PATCH 3/3] driver/core: Fix build error when SRCU and lockdep disabled

2019-08-12 Thread Joel Fernandes
On Mon, Aug 12, 2019 at 02:11:19PM -0400, Steven Rostedt wrote: > On Mon, 12 Aug 2019 09:03:10 -0400 > Joel Fernandes wrote: > > > > > > drivers/base/core.c | 6 +- > > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/base/core.c b/drivers/base/core

Re: [PATCH 3/3] driver/core: Fix build error when SRCU and lockdep disabled

2019-08-12 Thread Steven Rostedt
On Mon, 12 Aug 2019 16:01:25 -0400 Joel Fernandes wrote: > > some/header/file.h: > > > > #ifdef CONFIG_DEBUG_LOCK_ALLOC > > # define CHECK_DEVICE_LINKS_READ_LOCK_HELD() > > WARN_ON_ONCE(!defice_links_read_lock_held()) > > #else > > # define CHECK_DEVICE_LINKS_READ_LOCK_HELD() do { } while (0) >

Re: [PATCH 2/3] doc: Update documentation about list_for_each_entry_rcu (v1)

2019-08-12 Thread Paul E. McKenney
On Sun, Aug 11, 2019 at 06:11:10PM -0400, Joel Fernandes (Google) wrote: > This patch updates the documentation with information about > usage of lockdep with list_for_each_entry_rcu(). > > Signed-off-by: Joel Fernandes (Google) Thank you!!! I queued this for v5.5 with the following wordsmithin

Re: [PATCH 2/3] doc: Update documentation about list_for_each_entry_rcu (v1)

2019-08-12 Thread Joel Fernandes
On Mon, Aug 12, 2019 at 01:22:41PM -0700, Paul E. McKenney wrote: > On Sun, Aug 11, 2019 at 06:11:10PM -0400, Joel Fernandes (Google) wrote: > > This patch updates the documentation with information about > > usage of lockdep with list_for_each_entry_rcu(). > > > > Signed-off-by: Joel Fernandes (G

Re: [PATCH v9 04/18] kunit: test: add kunit_stream a std::stream like logger

2019-08-12 Thread Brendan Higgins
On Thu, Aug 1, 2019 at 2:43 PM Brendan Higgins wrote: > > On Thu, Aug 1, 2019 at 2:14 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-08-01 11:59:57) > > > On Thu, Aug 1, 2019 at 11:55 AM Brendan Higgins > > > wrote: > > > > > > > > On Fri, Jul 26, 2019 at 1:31 AM Petr Mladek wrote

Re: [PATCH v2 1/2] Documentation: sphinx: Add missing comma to list of strings

2019-08-12 Thread Jonathan Corbet
On Mon, 12 Aug 2019 18:07:04 +0200 Jonathan Neuschäfer wrote: > In Python, like in C, when a comma is omitted in a list of strings, the > two strings around the missing comma are concatenated. > > Signed-off-by: Jonathan Neuschäfer > --- > > v2: > - new patch > --- > Documentation/sphinx/auto

Re: [PATCH v1] kernel-doc: Allow anonymous enum

2019-08-12 Thread Jonathan Corbet
On Mon, 12 Aug 2019 19:06:31 +0300 Andy Shevchenko wrote: > In C is a valid construction to have an anonymous enumerator. > > Though we have now: > > drivers/pinctrl/intel/pinctrl-intel.c:240: error: Cannot parse enum! > > Support it in the kernel-doc script. So I don't get this error; I gu

Re: [PATCH] docs: Fix typo on pull requests guide

2019-08-12 Thread Jonathan Corbet
On Fri, 9 Aug 2019 18:29:07 -0500 Marco Villegas wrote: > Signed-off-by: Marco Villegas > --- > Documentation/maintainer/pull-requests.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/maintainer/pull-requests.rst > b/Documentation/maintainer/pull-req

Re: [PATCH v2] Documentation: virt: Fix broken reference to virt tree's index

2019-08-12 Thread Jonathan Corbet
On Fri, 9 Aug 2019 14:23:49 +0100 Sheriff Esseson wrote: > Fix broken reference to virt/index.rst. > > Fixes: 2f5947dfcaec ("Documentation: move Documentation/virtual to > Documentation/virt") > > Signed-off-by: Sheriff Esseson Note that you should keep the "Fixes:" tag on a single line, and

Re: [PATCH v2] docs/zh_CN: update Chinese howto.rst for latexdocs making

2019-08-12 Thread Jonathan Corbet
On Fri, 9 Aug 2019 20:04:47 +0800 Alex Shi wrote: > Mauro Carvalho Chehab found a reference > error in Chinese howto.rst. and further more there more infos of > latexdocs/epubdocs format doc making in English howto.rst. > > So I update this part according to latest howto.rst and settled > the

Re: [PATCH 1/2] Documentation/arm/sa1100: Remove some obsolete documentation

2019-08-12 Thread Jonathan Corbet
On Thu, 8 Aug 2019 18:58:55 +0200 Jonathan Neuschäfer wrote: > The support for the following boards, among others, was removed in 2004 > with commit "[ARM] Remove broken SA1100 machine support.": > > - ADS Bitsy > - Brutus > - Freebird > - ADS GraphicsClient Plus > - ADS GraphicsMaster > - Höft

Re: [PATCH 2/3] doc: Update documentation about list_for_each_entry_rcu (v1)

2019-08-12 Thread Paul E. McKenney
On Mon, Aug 12, 2019 at 04:42:05PM -0400, Joel Fernandes wrote: > On Mon, Aug 12, 2019 at 01:22:41PM -0700, Paul E. McKenney wrote: > > On Sun, Aug 11, 2019 at 06:11:10PM -0400, Joel Fernandes (Google) wrote: > > > This patch updates the documentation with information about > > > usage of lockdep w

Re: [PATCH 2/2] Documentation/arm/sa1100/assabet: Fix 'make assabet_defconfig' command

2019-08-12 Thread Jonathan Corbet
On Thu, 8 Aug 2019 18:58:56 +0200 Jonathan Neuschäfer wrote: > "make assabet_config" doesn't work. > > Signed-off-by: Jonathan Neuschäfer > --- > Documentation/arm/sa1100/assabet.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/arm/sa1100/assabet.rst

Re: [PATCH] Documentation/arm/samsung-s3c24xx: Remove stray U+FEFF character to fix title

2019-08-12 Thread Jonathan Corbet
On Thu, 8 Aug 2019 18:48:09 +0200 Jonathan Neuschäfer wrote: > It seems a UTF-8 byte order mark (the least useful kind of BOM...) snuck > into the file and broke Sphinx's detection of the title line. > > Besides making arm/samsung-s3c24xx/index.html look a little better, this > patch also confi

[PATCH v2] driver/core: Fix build error when SRCU and lockdep disabled

2019-08-12 Thread Joel Fernandes (Google)
Check if lockdep lock checking is disabled. If so, then do not define device_links_read_lock_held(). It is used only from places where lockdep checking is enabled. Also fix a bug where I was not checking dep_map. Previously, I did not test !SRCU configs so this got missed. Now it is sorted. Link:

Re: [PATCH 1/1] kbuild: recursive build of external kernel modules

2019-08-12 Thread Masahiro Yamada
On Tue, Aug 13, 2019 at 2:34 AM Shaun Tancheff wrote: > > On Mon, Aug 12, 2019 at 10:24 AM Masahiro Yamada > wrote: > > > > On Fri, Aug 9, 2019 at 9:21 AM Shaun Tancheff wrote: > > > > > > When building a tree of external modules stage 2 fails > > > silently as the root modules.order is empty. >

Re: [PATCH v2] driver/core: Fix build error when SRCU and lockdep disabled

2019-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2019 at 05:49:17PM -0400, Joel Fernandes (Google) wrote: > Check if lockdep lock checking is disabled. If so, then do not define > device_links_read_lock_held(). It is used only from places where lockdep > checking is enabled. > > Also fix a bug where I was not checking dep_map. Pr

[RFC 00/19] Integration of Kernel Test Framework (KTF) into the kernel tree

2019-08-12 Thread Knut Omang
KTF has already been available for a while as a separate git repository with means to facilitate use with any kernel version. KTF can be used both for "pure" unit testing and for more pragmatic approaches to component testing. Apart from some useful features that KTF uses from the kernel toolbox (

[RFC 08/19] ktf: Configurable context support for network info setup

2019-08-12 Thread Knut Omang
An implementation of configurable contexts for exchanging network information, to make it easier to run network tests potentially involving more than one kernel. ktf_netctx.h:Configurable context setup for multinode network tests Signed-off-by: Knut Omang --- tools/testing/selftests/ktf/ker

[RFC 04/19] ktf: An implementation of a generic associative array container

2019-08-12 Thread Knut Omang
This container is mapping from an index datatype to a "value" datatatype, using rbtree for the implementation. This datatype is used for various purposes by ktf to store and find data related to the actual test cases. ktf_map.c: Implementation of a kernel version independent std::map like A

[RFC 06/19] ktf: A simple debugfs interface to test results

2019-08-12 Thread Knut Omang
From: Alan Maguire While test results is available via netlink from user space, sometimes it may be useful to be able to access the results from the kernel as well, for instance due to a crash. Make that possible via debugfs. ktf_debugfs.h: Support for creating a debugfs representation of test

[RFC 09/19] ktf: resolve: A helper utility to aid in exposing private kernel symbols to KTF tests.

2019-08-12 Thread Knut Omang
Takes an input file foo.txt with a list of symbols on the form: #module foo #header foo.h private_foo_symbol_1 private_foo_symbol_2 and creates usable definitions to access these (requires CONFIG_KALLSYMS_ALL). This is useful to be able to easily and cleanly test internal interfaces of a module.

[RFC 07/19] ktf: Simple coverage support

2019-08-12 Thread Knut Omang
From: Alan Maguire Allows reports of code coverage and memory allocation. ktf_cov.c: Code coverage support implementation for KTF. ktf_cov.h: Code coverage support interface for KTF. Signed-off-by: Alan Maguire Signed-off-by: Knut Omang --- tools/testing/selftests/ktf/kernel/ktf_

[RFC 15/19] ktf: Some simple examples

2019-08-12 Thread Knut Omang
A few simple examples, and example of other test modules to make it easier to get started with ktf. Signed-off-by: Knut Omang --- tools/testing/selftests/ktf/examples/Makefile | 17 - tools/testing/selftests/ktf/examples/h2.c | 45 +++- tools/testing/selftests/ktf/examples/h3.c

[RFC 18/19] kselftests: Enable building ktf

2019-08-12 Thread Knut Omang
Signed-off-by: Knut Omang --- tools/testing/selftests/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 9781ca7..a24c2fe 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -20

[RFC 03/19] ktf: Introduce a generic netlink protocol for test result communication

2019-08-12 Thread Knut Omang
The generic netlink protocol used to communicate between kernel and user space about tests and test results, as well as some means for configuring tests within the kernel. Unlike other kernel side test code in the kernel, ktf does not print anything from inside the kernel (except for optional debu

Re: [PATCH 9/9] arm64: Retrieve stolen time as paravirtualized guest

2019-08-12 Thread Zenghui Yu
On 2019/8/12 18:39, Steven Price wrote: On 09/08/2019 14:51, Zenghui Yu wrote: [...] Hi Steven, Since userspace is not involved yet (right?), no one will create the PV_TIME device for guest (and no one will specify the IPA of the shared stolen time region), and I guess we will get a "not suppor

[RFC 14/19] ktf: Internal debugging facilities

2019-08-12 Thread Knut Omang
Utilities for convenient and runtime enabled/disabled printk debugging mainly intended for debugging ktf itself and subtle early issues with execution/running of tests. ktf_debug.h: User mode debug function definitions Signed-off-by: Knut Omang --- tools/testing/selftests/ktf/lib/ktf_debug.

[RFC 10/19] ktf: Add documentation for Kernel Test Framework (KTF)

2019-08-12 Thread Knut Omang
Signed-off-by: Knut Omang --- Documentation/dev-tools/ktf/concepts.rst | 242 ++- Documentation/dev-tools/ktf/debugging.rst | 248 +++- Documentation/dev-tools/ktf/examples.rst | 26 ++- Documentation/dev-tools/ktf/features.rst | 307 +++

[RFC 17/19] ktf: Toplevel ktf Makefile/makefile includes and scripts to run from kselftest

2019-08-12 Thread Knut Omang
Signed-off-by: Knut Omang --- tools/testing/selftests/ktf/Makefile| 21 - tools/testing/selftests/ktf/scripts/ktf_syms.mk | 16 +++- tools/testing/selftests/ktf/scripts/runtests.mk | 3 +- tools/testing/selftests/ktf/scripts/runtests.sh | 100 +- tools/testing/

[RFC 11/19] ktf: Add a small test suite with a few tests to test KTF itself

2019-08-12 Thread Knut Omang
context.c: Parameterized context test case, kernel side: context.h: Parameterized context test case, kernel side. context_self.h: The data structure passed between user level and kernel for the hybrid.c:Hybrid (combined user level and kernel) self tests, hybrid.h:Hybrid

[RFC 16/19] ktf: Some user applications to run tests

2019-08-12 Thread Knut Omang
Some minimal user land executables to run tests and to enable/disable coverage: ktfrun: Simple generic test runner for generic ktf tests ktftest:A test runner for the ktf selftests. Contains code to configure specific selftest context objects. ktfcov: A util

[RFC 12/19] ktf: Main part of user land library for executing tests

2019-08-12 Thread Knut Omang
Implementation of the main part of the user library to communicate with the kernel side of ktf about tests, configuration and test results. ktf.h: User mode side of KTF extensions to the gtest unit test framework. ktf_int.cc: Implementation of Gtest user land test management ktf_int

[RFC 19/19] Documentation/dev-tools: Add index entry for KTF documentation

2019-08-12 Thread Knut Omang
Signed-off-by: Knut Omang --- Documentation/dev-tools/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/dev-tools/index.rst b/Documentation/dev-tools/index.rst index b0522a4..f155205 100644 --- a/Documentation/dev-tools/index.rst +++ b/Documentation/dev-tools/index.rst

[RFC 13/19] ktf: Integration logic for running ktf tests from googletest

2019-08-12 Thread Knut Omang
Currently ktf only supports integration with googletest on the user side, but there's nothing that prevents integration towards other user land frameworks for running and reporting, if so desired. Signed-off-by: Knut Omang --- tools/testing/selftests/ktf/lib/ktf_run.cc | 177

[RFC 05/19] ktf: Implementation of ktf support for overriding function entry and return.

2019-08-12 Thread Knut Omang
From: Alan Maguire This is a very powerful and yet simple way to verify or modify behaviour of kernel calls. It uses the same technique as the error injection framework in kernel/fail_function.c to to override function entry and return. In addition to error injection, this is very useful to for i

[RFC 01/19] kbuild: Fixes to rules for host-cshlib and host-cxxshlib

2019-08-12 Thread Knut Omang
C++ libraries interfacing to C APIs might sometimes need some glue logic more easily written in C. Allow a C++ library to also contain 0 or more C objects. Also fix rules for both C and C++ shared libraries: - C++ shared libraries depended on .c instead of .cc files - Rules were referenced as -obj

[RFC 02/19] ktf: Introduce the main part of the kernel side of ktf

2019-08-12 Thread Knut Omang
The ktf module itself and basic data structures for management of test cases and tests and contexts for tests. Also contains the top level include file for kernel clients in ktf.h. More elaborate documentation follows towards the end of the patch set. This patch set contains both user level and k