[PATCH v2] Documentation/checkpatch: Prefer str_has_prefix over strncmp

2019-08-05 Thread Chuhong Yuan
Add "strncmp() on string prefix" to Documentation/process/deprecated.rst since using strncmp() to check whether a string starts with a prefix is error-prone. The safe replacement is str_has_prefix(). Also add check to the newly introduced deprecated_string_apis in checkpatch.pl. This patch depend

Re: [PATCH v3 1/2] mm/page_idle: Add per-pid idle page tracking using virtual indexing

2019-08-05 Thread Minchan Kim
Hi Joel, On Wed, Jul 31, 2019 at 01:19:37PM -0400, Joel Fernandes wrote: > > > -static struct page *page_idle_get_page(unsigned long pfn) > > > +static struct page *page_idle_get_page(struct page *page_in) > > > > Looks weird function name after you changed the argument. > > Maybe "bool check_val

Re: [PATCH 0/6] hwspinlock: allow sharing of hwspinlocks

2019-08-05 Thread Fabien DESSENNE
On 01/08/2019 9:14 PM, Bjorn Andersson wrote: > On Wed 13 Mar 08:50 PDT 2019, Fabien Dessenne wrote: > >> The current implementation does not allow two different devices to use >> a common hwspinlock. This patch set proposes to have, as an option, some >> hwspinlocks shared between several users.

[PATCH] Input: docs: fix spelling mistake "potocol" -> "protocol"

2019-08-05 Thread Colin King
From: Colin Ian King There is a minor spelling mistake in the documentation, fix it. Signed-off-by: Colin Ian King --- Documentation/input/multi-touch-protocol.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/input/multi-touch-protocol.rst b/Documentation/

Re: [PATCH v3 1/2] mm/page_idle: Add per-pid idle page tracking using virtual indexing

2019-08-05 Thread Joel Fernandes
On Mon, Aug 05, 2019 at 04:55:47PM +0900, Minchan Kim wrote: > Hi Joel, Hi Minchan, > On Wed, Jul 31, 2019 at 01:19:37PM -0400, Joel Fernandes wrote: > > > > -static struct page *page_idle_get_page(unsigned long pfn) > > > > +static struct page *page_idle_get_page(struct page *page_in) > > > > >

Re: [PATCH] Documentation/admin-guide: Embargoed hardware security issues

2019-08-05 Thread Eric W. Biederman
I skimmed this and a couple things jumped out at me. 1) PGP and S/MIME because of their use of long term keys do not provide forward secrecy. Which can makes it worth while to cryptographically factor a key or to obtain knowledge of a private key without the key holders knowledge. As

Re: [PATCH] Documentation/admin-guide: Embargoed hardware security issues

2019-08-05 Thread Greg Kroah-Hartman
On Mon, Aug 05, 2019 at 09:40:21AM -0500, Eric W. Biederman wrote: > > I skimmed this and a couple things jumped out at me. > > 1) PGP and S/MIME because of their use of long term keys do not provide >forward secrecy. Which can makes it worth while to cryptographically >factor a key or t

Re: [PATCH] Documentation/admin-guide: Embargoed hardware security issues

2019-08-05 Thread Greg Kroah-Hartman
On Sun, Aug 04, 2019 at 02:17:00AM +0200, Jiri Kosina wrote: > On Thu, 25 Jul 2019, Greg Kroah-Hartman wrote: > > > To address the requirements of embargoed hardware issues, like Meltdown, > > Spectre, L1TF, etc. it is necessary to define and document a process for > > handling embargoed hardware

Re: [PATCH 5/6] tty: serial: Add linflexuart driver for S32V234

2019-08-05 Thread gre...@linuxfoundation.org
On Fri, Aug 02, 2019 at 07:47:23PM +, Stefan-gabriel Mirea wrote: > --- a/include/uapi/linux/serial_core.h > +++ b/include/uapi/linux/serial_core.h > @@ -293,4 +293,7 @@ > /* SiFive UART */ > #define PORT_SIFIVE_V0 120 > > +/* Freescale Linflex UART */ > +#define PORT_LINFLEXUART

Re: [PATCH v4 04/12] fpga: dfl: afu: add userclock sysfs interfaces.

2019-08-05 Thread Greg KH
On Sun, Aug 04, 2019 at 06:20:14PM +0800, Wu Hao wrote: > This patch introduces userclock sysfs interfaces for AFU, user > could use these interfaces for clock setting to AFU. > > Please note that, this is only working for port header feature > with revision 0, for later revisions, userclock setti

Re: [PATCH v4 06/12] fpga: dfl: afu: export __port_enable/disable function.

2019-08-05 Thread Greg KH
On Sun, Aug 04, 2019 at 06:20:16PM +0800, Wu Hao wrote: > As these two functions are used by other private features. e.g. > in error reporting private feature, it requires to check port status > and reset port for error clearing. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Acked-by: Mo

Re: [PATCH v4 07/12] fpga: dfl: afu: add error reporting support.

2019-08-05 Thread Greg KH
On Sun, Aug 04, 2019 at 06:20:17PM +0800, Wu Hao wrote: > Error reporting is one important private feature, it reports error > detected on port and accelerated function unit (AFU). It introduces > several sysfs interfaces to allow userspace to check and clear > errors detected by hardware. > > Sig

Re: [PATCH v4 11/12] fpga: dfl: fme: add global error reporting support

2019-08-05 Thread Greg KH
On Sun, Aug 04, 2019 at 06:20:21PM +0800, Wu Hao wrote: > +static int fme_global_err_init(struct platform_device *pdev, > +struct dfl_feature *feature) > +{ > + struct device *dev; > + int ret = 0; > + > + dev = kzalloc(sizeof(*dev), GFP_KERNEL); > + if (

[PATCH] kernel-doc: ignore __printf attribute

2019-08-05 Thread Randy Dunlap
robot Signed-off-by: Randy Dunlap Cc: Brendan Higgins Tested-by: Brendan Higgins --- scripts/kernel-doc |1 + 1 file changed, 1 insertion(+) --- linux-next-20190805.orig/scripts/kernel-doc +++ linux-next-20190805/scripts/kernel-doc @@ -1580,6 +1580,7 @@ sub dump_function($$) {

[PATCH v4 4/5] page_idle: Drain all LRU pagevec before idle tracking

2019-08-05 Thread Joel Fernandes (Google)
During idle tracking, we see that sometimes faulted anon pages are in pagevec but are not drained to LRU. Idle tracking considers pages only on LRU. Drain all CPU's LRU before starting idle tracking. Signed-off-by: Joel Fernandes (Google) --- mm/page_idle.c | 6 ++ 1 file changed, 6 insertio

[PATCH v4 5/5] doc: Update documentation for page_idle virtual address indexing

2019-08-05 Thread Joel Fernandes (Google)
This patch updates the documentation with the new page_idle tracking feature which uses virtual address indexing. Reviewed-by: Mike Rapoport Reviewed-by: Sandeep Patil Signed-off-by: Joel Fernandes (Google) --- .../admin-guide/mm/idle_page_tracking.rst | 43 --- 1 file chan

[PATCH v4 2/5] [RFC] x86: Add support for idle bit in swap PTE

2019-08-05 Thread Joel Fernandes (Google)
This bit will be used by idle page tracking code to correctly identify if a page that was swapped out was idle before it got swapped out. Without this PTE bit, we lose information about if a page is idle or not since the page frame gets unmapped and the page gets freed. Bits 2-6 are unused in the

[PATCH v4 3/5] [RFC] arm64: Add support for idle bit in swap PTE

2019-08-05 Thread Joel Fernandes (Google)
This bit will be used by idle page tracking code to correctly identify if a page that was swapped out was idle before it got swapped out. Without this PTE bit, we lose information about if a page is idle or not since the page frame gets unmapped. In this patch we reuse PTE_DEVMAP bit since idle pa

[PATCH v4 1/5] mm/page_idle: Add per-pid idle page tracking using virtual indexing

2019-08-05 Thread Joel Fernandes (Google)
The page_idle tracking feature currently requires looking up the pagemap for a process followed by interacting with /sys/kernel/mm/page_idle. Looking up PFN from pagemap in Android devices is not supported by unprivileged process and requires SYS_ADMIN and gives 0 for the PFN. This patch adds supp

Re: [PATCH 0/6] hwspinlock: allow sharing of hwspinlocks

2019-08-05 Thread Bjorn Andersson
On Mon 05 Aug 01:48 PDT 2019, Fabien DESSENNE wrote: > > On 01/08/2019 9:14 PM, Bjorn Andersson wrote: > > On Wed 13 Mar 08:50 PDT 2019, Fabien Dessenne wrote: > > > >> The current implementation does not allow two different devices to use > >> a common hwspinlock. This patch set proposes to have

Re: [PATCH v8 0/2] fTPM: firmware TPM running in TEE

2019-08-05 Thread Sasha Levin
On Mon, Aug 05, 2019 at 12:44:28AM +0300, Jarkko Sakkinen wrote: On Thu, Jul 11, 2019 at 11:08:58PM +0300, Jarkko Sakkinen wrote: On Fri, Jul 05, 2019 at 04:47:44PM -0400, Sasha Levin wrote: > Changes from v7: > > - Address Jarkko's comments. > > Sasha Levin (2): > fTPM: firmware TPM running

Re: [PATCH v8 0/2] fTPM: firmware TPM running in TEE

2019-08-05 Thread Jarkko Sakkinen
On Mon, Aug 05, 2019 at 02:05:18PM -0400, Sasha Levin wrote: > On Mon, Aug 05, 2019 at 12:44:28AM +0300, Jarkko Sakkinen wrote: > > On Thu, Jul 11, 2019 at 11:08:58PM +0300, Jarkko Sakkinen wrote: > > > On Fri, Jul 05, 2019 at 04:47:44PM -0400, Sasha Levin wrote: > > > > Changes from v7: > > > > >