Re: [PATCH v2 3/9] rcu/sync: Remove custom check for reader-section

2019-07-15 Thread Oleg Nesterov
On 07/12, Joel Fernandes wrote: > > static inline bool rcu_sync_is_idle(struct rcu_sync *rsp) > { > - RCU_LOCKDEP_WARN(!rcu_read_lock_held() && > - !rcu_read_lock_bh_held() && > - !rcu_read_lock_sched_held(), > + RCU_LOCKDEP_WARN(!rcu_read_lock_an

[PATCH v2 7/8] docs: load_config.py: avoid needing a conf.py just due to LaTeX docs

2019-07-15 Thread Mauro Carvalho Chehab
Right now, for every directory that we need to have LaTeX output, a conf.py file is required. That causes an extra overhead and it is actually a hack, as the latex_documents line there are usually a copy of the ones that are there already at the main conf.py. So, instead, re-use the global latex_

Re: [PATCH] tracing/fgraph: support recording function return values

2019-07-15 Thread Will Deacon
On Sat, Jul 13, 2019 at 08:10:26PM +0800, Changbin Du wrote: > This patch adds a new trace option 'funcgraph-retval' and is disabled by > default. When this option is enabled, fgraph tracer will show the return > value of each function. This is useful to find/analyze a original error > source in a

Re: [PATCH v8 0/2] fTPM: firmware TPM running in TEE

2019-07-15 Thread Ilias Apalodimas
On Fri, Jul 12, 2019 at 06:37:58AM +0300, Jarkko Sakkinen wrote: > On Thu, Jul 11, 2019 at 11:10:59PM +0300, Ilias Apalodimas wrote: > > Will report back any issues when we start using it on real hardware > > rather than QEMU > > > > Thanks > > /Ilias > > That would awesome. PR is far away so the

[PATCH] docs: fix broken doc links due to renames

2019-07-15 Thread Mauro Carvalho Chehab
Some files got renamed but the patch was incomplete, as it forgot to update the documentation reference accordingly. Signed-off-by: Mauro Carvalho Chehab --- This patch is against current linus/master branch. Documentation/RCU/rculist_nulls.txt | 2 +- Documentation/devicetre

Re: [PATCH] tracing/fgraph: support recording function return values

2019-07-15 Thread Peter Zijlstra
On Mon, Jul 15, 2019 at 09:29:30AM +0100, Will Deacon wrote: > On Sat, Jul 13, 2019 at 08:10:26PM +0800, Changbin Du wrote: > > This patch adds a new trace option 'funcgraph-retval' and is disabled by > > default. When this option is enabled, fgraph tracer will show the return > > value of each fun

Kindly Respond

2019-07-15 Thread Donald Douglas
Hello, I am Barr Fredrick Mbogo a business consultant i have a lucrative business to discuss with you from the Eastern part of Africa Uganda to be precise aimed at agreed percentage upon your acceptance of my hand in business and friendship. Kindly respond to me if you are interested to partner wit

[PATCH AUTOSEL 5.2 117/249] x86/atomic: Fix smp_mb__{before,after}_atomic()

2019-07-15 Thread Sasha Levin
From: Peter Zijlstra [ Upstream commit 69d927bba39517d0980462efc051875b7f4db185 ] Recent probing at the Linux Kernel Memory Model uncovered a 'surprise'. Strongly ordered architectures where the atomic RmW primitive implies full memory ordering and smp_mb__{before,after}_atomic() are a simple ba

[PATCH AUTOSEL 5.2 113/249] sched/fair: Fix "runnable_avg_yN_inv" not used warnings

2019-07-15 Thread Sasha Levin
From: Qian Cai [ Upstream commit 509466b7d480bc5d22e90b9fbe6122ae0e2fbe39 ] runnable_avg_yN_inv[] is only used in kernel/sched/pelt.c but was included in several other places because they need other macros all came from kernel/sched/sched-pelt.h which was generated by Documentation/scheduler/sch

[PATCH AUTOSEL 5.1 103/219] x86/atomic: Fix smp_mb__{before,after}_atomic()

2019-07-15 Thread Sasha Levin
From: Peter Zijlstra [ Upstream commit 69d927bba39517d0980462efc051875b7f4db185 ] Recent probing at the Linux Kernel Memory Model uncovered a 'surprise'. Strongly ordered architectures where the atomic RmW primitive implies full memory ordering and smp_mb__{before,after}_atomic() are a simple ba

[PATCH AUTOSEL 4.19 077/158] x86/atomic: Fix smp_mb__{before,after}_atomic()

2019-07-15 Thread Sasha Levin
From: Peter Zijlstra [ Upstream commit 69d927bba39517d0980462efc051875b7f4db185 ] Recent probing at the Linux Kernel Memory Model uncovered a 'surprise'. Strongly ordered architectures where the atomic RmW primitive implies full memory ordering and smp_mb__{before,after}_atomic() are a simple ba

[PATCH AUTOSEL 4.14 053/105] sched/fair: Fix "runnable_avg_yN_inv" not used warnings

2019-07-15 Thread Sasha Levin
From: Qian Cai [ Upstream commit 509466b7d480bc5d22e90b9fbe6122ae0e2fbe39 ] runnable_avg_yN_inv[] is only used in kernel/sched/pelt.c but was included in several other places because they need other macros all came from kernel/sched/sched-pelt.h which was generated by Documentation/scheduler/sch

[PATCH AUTOSEL 4.14 054/105] x86/atomic: Fix smp_mb__{before,after}_atomic()

2019-07-15 Thread Sasha Levin
From: Peter Zijlstra [ Upstream commit 69d927bba39517d0980462efc051875b7f4db185 ] Recent probing at the Linux Kernel Memory Model uncovered a 'surprise'. Strongly ordered architectures where the atomic RmW primitive implies full memory ordering and smp_mb__{before,after}_atomic() are a simple ba

[PATCH 7/9] x86/pci: Pass lockdep condition to pcm_mmcfg_list iterator (v1)

2019-07-15 Thread Joel Fernandes (Google)
The pcm_mmcfg_list is traversed with list_for_each_entry_rcu without a reader-lock held, because the pci_mmcfg_lock is already held. Make this known to the list macro so that it fixes new lockdep warnings that trigger due to lockdep checks added to list_for_each_entry_rcu(). Signed-off-by: Joel Fe

[PATCH 5/9] driver/core: Convert to use built-in RCU list checking (v1)

2019-07-15 Thread Joel Fernandes (Google)
list_for_each_entry_rcu has built-in RCU and lock checking. Make use of it in driver core. Acked-by: Greg Kroah-Hartman Signed-off-by: Joel Fernandes (Google) --- drivers/base/base.h | 1 + drivers/base/core.c | 10 ++ drivers/base/power/runtime.c | 15 ++-

[PATCH 9/9] doc: Update documentation about list_for_each_entry_rcu (v1)

2019-07-15 Thread Joel Fernandes (Google)
This patch updates the documentation with information about usage of lockdep with list_for_each_entry_rcu(). Signed-off-by: Joel Fernandes (Google) --- Documentation/RCU/lockdep.txt | 15 +++ Documentation/RCU/whatisRCU.txt | 9 - 2 files changed, 19 insertions(+), 5 delet

[PATCH 8/9] acpi: Use built-in RCU list checking for acpi_ioremaps list (v1)

2019-07-15 Thread Joel Fernandes (Google)
list_for_each_entry_rcu has built-in RCU and lock checking. Make use of it for acpi_ioremaps list traversal. Signed-off-by: Joel Fernandes (Google) --- drivers/acpi/osl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index 9c0ed

[PATCH 6/9] workqueue: Convert for_each_wq to use built-in list check (v2)

2019-07-15 Thread Joel Fernandes (Google)
list_for_each_entry_rcu now has support to check for RCU reader sections as well as lock. Just use the support in it, instead of explictly checking in the caller. Signed-off-by: Joel Fernandes (Google) --- kernel/workqueue.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff

[PATCH 4/9] ipv4: add lockdep condition to fix for_each_entry (v1)

2019-07-15 Thread Joel Fernandes (Google)
Using the previous support added, use it for adding lockdep conditions to list usage here. Signed-off-by: Joel Fernandes (Google) --- net/ipv4/fib_frontend.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 317339cd7f03

[PATCH 3/9] rcu/sync: Remove custom check for reader-section (v2)

2019-07-15 Thread Joel Fernandes (Google)
The rcu/sync code was doing its own check whether we are in a reader section. With RCU consolidating flavors and the generic helper added in this series, this is no longer need. We can just use the generic helper and it results in a nice cleanup. Cc: Oleg Nesterov Acked-by: Oleg Nesterov Signed-

[PATCH 2/9] rcu: Add support for consolidated-RCU reader checking (v3)

2019-07-15 Thread Joel Fernandes (Google)
This patch adds support for checking RCU reader sections in list traversal macros. Optionally, if the list macro is called under SRCU or other lock/mutex protection, then appropriate lockdep expressions can be passed to make the checks pass. Existing list_for_each_entry_rcu() invocations don't nee

[PATCH 0/9] Harden list_for_each_entry_rcu() and family

2019-07-15 Thread Joel Fernandes (Google)
Hi, This series aims to provide lockdep checking to RCU list macros for additional kernel hardening. RCU has a number of primitives for "consumption" of an RCU protected pointer. Most of the time, these consumers make sure that such accesses are under a RCU reader-section (such as rcu_dereference{

[PATCH 1/9] rcu/update: Remove useless check for debug_locks (v1)

2019-07-15 Thread Joel Fernandes (Google)
In rcu_read_lock_sched_held(), debug_locks can never be true at the point we check it because we already check debug_locks in debug_lockdep_rcu_enabled() in the beginning. Remove the check. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/update.c | 6 +- 1 file changed, 1 insertion(+),

[PATCH AUTOSEL 4.19 075/158] sched/fair: Fix "runnable_avg_yN_inv" not used warnings

2019-07-15 Thread Sasha Levin
From: Qian Cai [ Upstream commit 509466b7d480bc5d22e90b9fbe6122ae0e2fbe39 ] runnable_avg_yN_inv[] is only used in kernel/sched/pelt.c but was included in several other places because they need other macros all came from kernel/sched/sched-pelt.h which was generated by Documentation/scheduler/sch

[PATCH AUTOSEL 5.1 099/219] sched/fair: Fix "runnable_avg_yN_inv" not used warnings

2019-07-15 Thread Sasha Levin
From: Qian Cai [ Upstream commit 509466b7d480bc5d22e90b9fbe6122ae0e2fbe39 ] runnable_avg_yN_inv[] is only used in kernel/sched/pelt.c but was included in several other places because they need other macros all came from kernel/sched/sched-pelt.h which was generated by Documentation/scheduler/sch

Re: [PATCH v8] Documentation: filesystem: Convert xfs.txt to ReST

2019-07-15 Thread Matthew Wilcox
On Sun, Jul 14, 2019 at 01:58:31PM +0100, Sheriff Esseson wrote: > Move xfs.txt to admin-guide, convert xfs.txt to ReST and broken references > > Signed-off-by: Sheriff Esseson Reviewed-by: Matthew Wilcox (Oracle)

Re: [PATCH v5 1/1] sched/fair: Fix low cpu usage with high throttling by removing expiration of cpu-local slices

2019-07-15 Thread Dave Chiluk
On Fri, Jul 12, 2019 at 5:10 PM wrote: > Ugh. Maybe we /do/ just give up and say that most people don't seem to > be using cfs_b in a way that expiration of the leftover 1ms matters. That was my conclusion as well. Does this mean you want to proceed with my patch set? Do you have any changes yo

Re: [PATCH v8] Documentation: filesystem: Convert xfs.txt to ReST

2019-07-15 Thread Darrick J. Wong
On Sun, Jul 14, 2019 at 01:58:31PM +0100, Sheriff Esseson wrote: > Move xfs.txt to admin-guide, convert xfs.txt to ReST and broken references > > Signed-off-by: Sheriff Esseson Looks ok, will pull through the XFS tree. Thanks for the submission! Reviewed-by: Darrick J. Wong --D > --- > > ch

Re: [PATCH 7/9] x86/pci: Pass lockdep condition to pcm_mmcfg_list iterator (v1)

2019-07-15 Thread Bjorn Helgaas
On Mon, Jul 15, 2019 at 10:37:03AM -0400, Joel Fernandes (Google) wrote: > The pcm_mmcfg_list is traversed with list_for_each_entry_rcu without a > reader-lock held, because the pci_mmcfg_lock is already held. Make this > known to the list macro so that it fixes new lockdep warnings that > trigger

Re: [PATCH 8/9] acpi: Use built-in RCU list checking for acpi_ioremaps list (v1)

2019-07-15 Thread Rafael J. Wysocki
On Mon, Jul 15, 2019 at 4:43 PM Joel Fernandes (Google) wrote: > > list_for_each_entry_rcu has built-in RCU and lock checking. Make use of > it for acpi_ioremaps list traversal. > > Signed-off-by: Joel Fernandes (Google) Acked-by: Rafael J. Wysocki > --- > drivers/acpi/osl.c | 6 -- > 1 f

Re: [PATCH v8] Documentation: filesystem: Convert xfs.txt to ReST

2019-07-15 Thread Sheriff Esseson
On Sun, Jul 14, 2019 at 01:58:31PM +0100, Sheriff Esseson wrote: > Move xfs.txt to admin-guide, convert xfs.txt to ReST and broken references > > Signed-off-by: Sheriff Esseson >Reviewed-by: Matthew Wilcox (Oracle) Sorry, I missed something. Will fix in v9.

Re: [PATCH v8] Documentation: filesystem: Convert xfs.txt to ReST

2019-07-15 Thread Sheriff Esseson
On Sun, Jul 14, 2019 at 01:58:31PM +0100, Sheriff Esseson wrote: >> Move xfs.txt to admin-guide, convert xfs.txt to ReST and broken references >> >> Signed-off-by: Sheriff Esseson >Looks ok, will pull through the XFS tree. Thanks for the submission! >Reviewed-by: Darrick J. Wong >--D Sorry,

Re: [PATCH v9] Documentation: filesystem: Convert xfs.txt to ReST

2019-07-15 Thread Sheriff Esseson
Move xfs.txt to admin-guide, convert to ReST and fix broken references. Signed-off-by: Sheriff Esseson --- Changes in v9: - fix table for "Removed Sysctls". - "Deprecated Mount Options", just like "Deprecated Sysctls", currently needs no table - remove table. Do

Re: [PATCH 7/9] x86/pci: Pass lockdep condition to pcm_mmcfg_list iterator (v1)

2019-07-15 Thread Joel Fernandes
On Mon, Jul 15, 2019 at 03:02:35PM -0500, Bjorn Helgaas wrote: > On Mon, Jul 15, 2019 at 10:37:03AM -0400, Joel Fernandes (Google) wrote: > > The pcm_mmcfg_list is traversed with list_for_each_entry_rcu without a > > reader-lock held, because the pci_mmcfg_lock is already held. Make this > > known

[PATCH] rculist: Add build check for single optional list argument

2019-07-15 Thread Joel Fernandes (Google)
In a previous patch series [1], we added an optional lockdep expression argument to list_for_each_entry_rcu() and the hlist equivalent. This also meant more than one optional argument can be passed to them with that error going unnoticed. To fix this, let us force a compiler error more than one opt