Re: [PATCH] docs: Bump version to 5.x

2019-01-14 Thread Andrew Donnellan
On 14/1/19 5:12 pm, Joel Stanley wrote: This shows up in the index of https://www.kernel.org/doc/html/latest/ so I figured it should be updated. Fixes: bfeffd15528 ("Linux 5.0-rc1") Signed-off-by: Joel Stanley -- We could also remove the version number instead of applying this patch. You miss

updating user verbs documentation

2019-01-14 Thread Joel Nider
A small patchset to update the verbs API documentation with some information regarding the ioctl syscall. First patch converts the file format to ReST, since this is the new preferred format. 2nd patch links this file to the main index so we can actually find it by browsing (search will work in any

[PATCH 1/3] docs-rst: infiniband: Convert user verbs doc to rst

2019-01-14 Thread Joel Nider
Replace the existing Documentation/infiniband/user_verbs.txt with Documentation/infiniband/user_verbs.rst. No substantial changes to the content - just some minor reformatting to have the rendering come out nicely. This is in preparation for updating the content in a subsequent patch. Signed-off-b

[PATCH 2/3] docs-rst: update index file with infiniband docs

2019-01-14 Thread Joel Nider
Link the previously converted Documentation/infiniband/user_verbs.rst to the main index by creating a new subsystem (Infiniband) under the root document. This manifests as a new section under "Kernel API Documentation" in the index.html, as well as a new section in the table of contents pane. This

[PATCH 3/3] docs-rst: infiniband: update verbs API details

2019-01-14 Thread Joel Nider
It is important to understand the existing framework when implementing a new verb. The majority of existing API functions are implemented using the write syscall, but this has been superceded by the ioctl syscall for new commands. This patch updates the documentation regarding how to go about imple

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Borislav Petkov
On Mon, Jan 14, 2019 at 09:52:14AM +0800, lijiang wrote: > I would like to remove this variable and post again. No, you should remove the vmcoreinfo export too: kernel/crash_core.c:398:VMCOREINFO_OSRELEASE(init_uts_ns.name.release); after making sure userspace is not using it and *then*

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Borislav Petkov
On Mon, Jan 14, 2019 at 01:30:30PM +0800, lijiang wrote: > I noticed that the checkpatch was coded in Perl. But i am not familiar with > the Perl program language, that would be beyond my ability to do this, i have > to learn the Perl program language step by step. :-) You could give it a try - it

[PATCH] Documentation/dev-tools: Use gcc version number instead svn revision number

2019-01-14 Thread Sebastian Andrzej Siewior
svn commit 231296 matches commit d29e939c63b71 ("Add fuzzing coverage support") in the gcc git. The change is part of gcc 6.1.0. Replace the svn commit number with a gcc version which everyone can easily compare. Signed-off-by: Sebastian Andrzej Siewior --- Documentation/dev-tools/kcov.rst | 2

Re: [PATCH v2 5/5] psi: introduce psi monitor

2019-01-14 Thread Peter Zijlstra
On Thu, Jan 10, 2019 at 02:07:18PM -0800, Suren Baghdasaryan wrote: > +/* > + * psi_update_work represents slowpath accounting part while > + * psi_group_change represents hotpath part. > + * There are two potential races between these path: > + * 1. Changes to group->polling when slowpath checks f

Re: [PATCH v2] cpuidle: Add 'above' and 'below' idle state metrics

2019-01-14 Thread Daniel Lezcano
Hi Rafael, sorry for the delay. On 10/01/2019 11:20, Rafael J. Wysocki wrote: [ ... ] >>> if (entered_state >= 0) { >>> + s64 diff, delay = drv->states[entered_state].exit_latency; >>> + int i; >>> + >>> /* >>>* Update cpuidle counte

Re: [PATCH v10 08/12] mfd: intel-peci-client: Add PECI client driver

2019-01-14 Thread Joel Stanley
On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: > > This commit adds PECI client driver. It looks like it's a PECI driver for the three CPU families, and it implements cpu and dimm temp, with sideband functions deferred to the future. If you add that information with a few more words it would ma

Re: [PATCH v10 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers

2019-01-14 Thread Joel Stanley
On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: > > This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. > > Cc: Guenter Roeck > Cc: Jean Delvare > Cc: Jonathan Corbet > Cc: Jason M Biils > Cc: Randy Dunlap > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Haiyue Wang > Revie

[PATCH] docs/core-api: memory-allocation: add mention of kmem_cache_create_userspace

2019-01-14 Thread Mike Rapoport
Mention that when a part of a slab cache might be exported to the userspace, the cache should be created using kmem_cache_create_usercopy() Signed-off-by: Mike Rapoport --- Documentation/core-api/memory-allocation.rst | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Do

[PATCH 1/1 RESEND] doc: net: fix bad references to network drivers

2019-01-14 Thread Otto Sabart
Fix "reference to nonexisting document" warnings. Fixes: b255e500c8dc ("net: documentation: build a directory structure for drivers") Signed-off-by: Otto Sabart --- Documentation/networking/index.rst | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a

Re: [PATCH] fgraph: record function return value

2019-01-14 Thread Mark Rutland
On Sat, Jan 12, 2019 at 02:57:01PM +0800, Changbin Du wrote: > This patch adds a new trace option 'funcgraph-retval' and is disabled by > default. When this option is enabled, fgraph tracer will show the return > value of each function. This is useful to find/analyze a original error > source in a

Re: [RFC AFBC 03/12] drm/afbc: Add AFBC modifier usage documentation

2019-01-14 Thread Jani Nikula
On Fri, 11 Jan 2019, Liviu Dudau wrote: > On Thu, Jan 03, 2019 at 05:44:26PM -0300, Ezequiel Garcia wrote: >> Hi Liviu, >> >> On Mon, 2018-12-03 at 11:31 +, Ayan Halder wrote: >> > From: Brian Starkey >> > >> > AFBC is a flexible, proprietary, lossless compression protocol and >> > format,

Re: [RFC AFBC 03/12] drm/afbc: Add AFBC modifier usage documentation

2019-01-14 Thread Brian Starkey
Hi Jani, On Mon, Jan 14, 2019 at 02:23:46PM +0200, Jani Nikula wrote: > On Fri, 11 Jan 2019, Liviu Dudau wrote: > > On Thu, Jan 03, 2019 at 05:44:26PM -0300, Ezequiel Garcia wrote: > >> Hi Liviu, > >> > >> On Mon, 2018-12-03 at 11:31 +, Ayan Halder wrote: > >> > From: Brian Starkey > >> >

Re: [RFC AFBC 03/12] drm/afbc: Add AFBC modifier usage documentation

2019-01-14 Thread Jani Nikula
On Mon, 14 Jan 2019, Brian Starkey wrote: > AFBC is a relatively well-established name, whereas arm-fbc is not a > term anyone will be familiar with. First time I ever heard of AFBC. ;) > We could name the file "arm-afbc.rst", though I am slightly against > namespacing it that way for the reason

Re: [PATCH 0/5] Improve the latency tracers

2019-01-14 Thread Steven Rostedt
On Sat, 12 Jan 2019 12:05:33 +0800 Changbin Du wrote: > Hi Steven, Have you checked this serias yet? :) > Not yet, I'll try to do it today. -- Steve

Re: [PATCH] Documentation: fix coding-style.rst Sphinx warning

2019-01-14 Thread Jonathan Corbet
On Sun, 13 Jan 2019 19:28:58 -0800 Randy Dunlap wrote: > Fix Sphinx warning in coding-style.rst: > > Documentation/process/coding-style.rst:446: WARNING: Inline interpreted text > or phrase reference start-string without end-string. > > Signed-off-by: Randy Dunlap Applied, thanks. jon

Re: [PATCH] Documentation: add ibmvmc to toctree(index) and fix warnings

2019-01-14 Thread Jonathan Corbet
On Sun, 13 Jan 2019 19:21:46 -0800 Randy Dunlap wrote: > Fix Sphinx warnings in ibmvmc.rst, add an index.rst file in > Documentation/misc-devices/, and insert that index file into the > top-level index file. > > Documentation/misc-devices/ibmvmc.rst:2: WARNING: Explicit markup ends > without a

Re: [PATCH] fgraph: record function return value

2019-01-14 Thread Changbin Du
On Mon, Jan 14, 2019 at 12:11:56PM +, Mark Rutland wrote: > On Sat, Jan 12, 2019 at 02:57:01PM +0800, Changbin Du wrote: > > This patch adds a new trace option 'funcgraph-retval' and is disabled by > > default. When this option is enabled, fgraph tracer will show the return > > value of each fu

Re: [PATCH] fgraph: record function return value

2019-01-14 Thread Steven Rostedt
On Sat, 12 Jan 2019 14:57:01 +0800 Changbin Du wrote: > This patch adds a new trace option 'funcgraph-retval' and is disabled by > default. When this option is enabled, fgraph tracer will show the return > value of each function. This is useful to find/analyze a original error > source in a call

Re: [PATCH 2/3] docs-rst: update index file with infiniband docs

2019-01-14 Thread Jason Gunthorpe
On Mon, Jan 14, 2019 at 11:00:50AM +0200, Joel Nider wrote: > Link the previously converted Documentation/infiniband/user_verbs.rst > to the main index by creating a new subsystem (Infiniband) under the > root document. This manifests as a new section under "Kernel API > Documentation" in the index

Re: [PATCH 1/3] docs-rst: infiniband: Convert user verbs doc to rst

2019-01-14 Thread Jason Gunthorpe
On Mon, Jan 14, 2019 at 11:00:49AM +0200, Joel Nider wrote: > Replace the existing Documentation/infiniband/user_verbs.txt with > Documentation/infiniband/user_verbs.rst. No substantial changes to > the content - just some minor reformatting to have the rendering > come out nicely. > This is in pre

Re: [PATCH v4] coding-style: Clarify the expectations around bool

2019-01-14 Thread Jason Gunthorpe
On Fri, Jan 11, 2019 at 07:29:40AM -1000, Joey Pabalinas wrote: > On Thu, Jan 10, 2019 at 11:48:13PM +, Jason Gunthorpe wrote: > > There has been some confusion since checkpatch started warning about bool > > use in structures, and people have been avoiding using it. > > > > Many people feel t

Re: [PATCH v4] coding-style: Clarify the expectations around bool

2019-01-14 Thread Jason Gunthorpe
On Sun, Jan 13, 2019 at 08:49:36AM -0800, Matthew Wilcox wrote: > On Thu, Jan 10, 2019 at 11:48:13PM +, Jason Gunthorpe wrote: > > +The Linux kernel bool type is an alias for the C99 _Bool type. bool values > > can > > +only evaluate to 0 or 1, and implicit or explicit conversion to bool > > +

Re: [PATCH v4] coding-style: Clarify the expectations around bool

2019-01-14 Thread Jason Gunthorpe
On Sun, Jan 13, 2019 at 05:01:39PM +0100, Federico Vaga wrote: > > -17) Don't re-invent the kernel macros > > +17) Using bool > > +-- > > + > > +The Linux kernel bool type is an alias for the C99 _Bool type. bool > > values can > > +only evaluate to 0 or 1, and implicit or explicit con

Re: [PATCH 1/3] docs-rst: infiniband: Convert user verbs doc to rst

2019-01-14 Thread Jonathan Corbet
On Mon, 14 Jan 2019 09:56:21 -0700 Jason Gunthorpe wrote: > > Documentation/infiniband/user_verbs.rst | 70 > > + > > Documentation/infiniband/user_verbs.txt | 69 > > > > 2 files changed, 70 insertions(+), 69 deletions(-) > > c

RE: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Kazuhito Hagio
On 1/11/2019 7:33 AM, Borislav Petkov wrote: > On Thu, Jan 10, 2019 at 08:19:43PM +0800, Lianbo Jiang wrote: >> +init_uts_ns.name.release >> + >> + >> +The version of the Linux kernel. Used to find the corresponding source >> +code from which the kernel has been built. >> +

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Borislav Petkov
On Mon, Jan 14, 2019 at 05:48:48PM +, Kazuhito Hagio wrote: > As for makedumpfile, it will be not impossible to remove the > init_uts_ns.name.relase (OSRELEASE), but some fixes are needed. > Because historically OSRELEASE has been a kind of a mandatory entry > in vmcoreinfo from the beginning o

[PATCH] docs/core-api/mm: fix GFP combinations section name

2019-01-14 Thread Mike Rapoport
Fix the mismatch between "Useful GFP flag combinations" section naming in the DOC: section in include/linux/gfp.h and Documentation/core-api/mm-api.rst Signed-off-by: Mike Rapoport --- Documentation/core-api/mm-api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documenta

Re: [PATCH 1/3] docs-rst: infiniband: Convert user verbs doc to rst

2019-01-14 Thread Joel Nider
Jonathan Corbet wrote on 01/14/2019 07:34:21 PM: > From: Jonathan Corbet > To: Jason Gunthorpe > Cc: Joel Nider , Leon Romanovsky , Doug > Ledford , Mike Rapoport , linux- > d...@vger.kernel.org, linux-ker...@vger.kernel.org > Date: 01/14/2019 07:37 PM > Subject: Re: [PATCH 1/3] docs-rst: in

Re: [PATCH 1/3] docs-rst: infiniband: Convert user verbs doc to rst

2019-01-14 Thread Jason Gunthorpe
On Mon, Jan 14, 2019 at 08:52:14PM +0200, Joel Nider wrote: > > > Jonathan/linux-doc: Can you Ack at least the build system parts of > > > this please? I can take it through the rdma tree, unless you prefer > > > otherwise? > > > > Can I make a request? This appears to be user-oriented documentat

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Dave Anderson
- Original Message - > On Mon, Jan 14, 2019 at 05:48:48PM +, Kazuhito Hagio wrote: > > As for makedumpfile, it will be not impossible to remove the > > init_uts_ns.name.relase (OSRELEASE), but some fixes are needed. > > Because historically OSRELEASE has been a kind of a mandatory en

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Borislav Petkov
On Mon, Jan 14, 2019 at 01:58:32PM -0500, Dave Anderson wrote: > Preferably it would be left as-is. The crash utility has a "crash > --osrelease vmcore" > option that only looks at the dumpfile header, and just dump the string. > With respect > to compressed kdumps, crash could alternatively lo

Re: [PATCH v2 5/5] psi: introduce psi monitor

2019-01-14 Thread Suren Baghdasaryan
On Mon, Jan 14, 2019 at 2:22 AM Peter Zijlstra wrote: > > On Thu, Jan 10, 2019 at 02:07:18PM -0800, Suren Baghdasaryan wrote: > > +/* > > + * psi_update_work represents slowpath accounting part while > > + * psi_group_change represents hotpath part. > > + * There are two potential races between th

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Dave Anderson
- Original Message - > On Mon, Jan 14, 2019 at 01:58:32PM -0500, Dave Anderson wrote: > > Preferably it would be left as-is. The crash utility has a "crash > > --osrelease vmcore" > > option that only looks at the dumpfile header, and just dump the string. > > With respect > > to compr

Re: [PATCH v2 5/5] psi: introduce psi monitor

2019-01-14 Thread Johannes Weiner
On Mon, Jan 14, 2019 at 11:30:12AM -0800, Suren Baghdasaryan wrote: > On Mon, Jan 14, 2019 at 2:22 AM Peter Zijlstra wrote: > > > > On Thu, Jan 10, 2019 at 02:07:18PM -0800, Suren Baghdasaryan wrote: > > > +/* > > > + * psi_update_work represents slowpath accounting part while > > > + * psi_group_

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Borislav Petkov
On Mon, Jan 14, 2019 at 02:36:47PM -0500, Dave Anderson wrote: > There's no reading of the dumpfile's memory involved, and that being the case, > the vmlinux file is not utilized. That's the whole point of the crash > option, i.e., > taking a vmcore file, and trying to determine what kernel shoul

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Dave Anderson
- Original Message - > On Mon, Jan 14, 2019 at 02:36:47PM -0500, Dave Anderson wrote: > > There's no reading of the dumpfile's memory involved, and that being the > > case, > > the vmlinux file is not utilized. That's the whole point of the crash > > option, i.e., > > taking a vmcore

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Borislav Petkov
On Mon, Jan 14, 2019 at 03:07:33PM -0500, Dave Anderson wrote: > That's what it *does* utilize -- it takes a standalone vmcore dumpfile, and > pulls out the OSRELEASE string from it, so that a user can determine what > vmlinux file should be used with that vmcore for normal crash analysis. And th

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Dave Anderson
- Original Message - > On Mon, Jan 14, 2019 at 03:07:33PM -0500, Dave Anderson wrote: > > That's what it *does* utilize -- it takes a standalone vmcore dumpfile, and > > pulls out the OSRELEASE string from it, so that a user can determine what > > vmlinux file should be used with that vm

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Borislav Petkov
On Mon, Jan 14, 2019 at 03:26:32PM -0500, Dave Anderson wrote: > No. It needs *both* the vmlinux file and the vmcore file in order to read > kernel > virtual memory, so just having a kernel virtual address is insufficient. > > So it's a chicken-and-egg situation. This particular --osrelease opt

Re: [PATCH v2 5/5] psi: introduce psi monitor

2019-01-14 Thread Suren Baghdasaryan
On Mon, Jan 14, 2019 at 11:42 AM Johannes Weiner wrote: > > On Mon, Jan 14, 2019 at 11:30:12AM -0800, Suren Baghdasaryan wrote: > > On Mon, Jan 14, 2019 at 2:22 AM Peter Zijlstra wrote: > > > > > > On Thu, Jan 10, 2019 at 02:07:18PM -0800, Suren Baghdasaryan wrote: > > > > +/* > > > > + * psi_upd

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

2019-01-14 Thread Dave Anderson
- Original Message - > On Mon, Jan 14, 2019 at 03:26:32PM -0500, Dave Anderson wrote: > > No. It needs *both* the vmlinux file and the vmcore file in order to read > > kernel > > virtual memory, so just having a kernel virtual address is insufficient. > > > > So it's a chicken-and-egg

Re: [RFC PATCH] x86/speculation: Don't inherit TIF_SSBD on execve()

2019-01-14 Thread Waiman Long
On 01/11/2019 02:52 PM, Thomas Gleixner wrote: > On Wed, 19 Dec 2018, Waiman Long wrote: > >> With the default SPEC_STORE_BYPASS_SECCOMP/SPEC_STORE_BYPASS_PRCTL mode, >> the TIF_SSBD bit will be inherited when a new task is fork'ed or cloned. >> >> As only certain class of applications (like Java)

Re: [PATCH v10 09/12] Documentation: hwmon: Add documents for PECI hwmon client drivers

2019-01-14 Thread Jae Hyun Yoo
On 1/14/2019 3:43 AM, Joel Stanley wrote: On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: This commit adds hwmon documents for PECI cputemp and dimmtemp drivers. Cc: Guenter Roeck Cc: Jean Delvare Cc: Jonathan Corbet Cc: Jason M Biils Cc: Randy Dunlap Signed-off-by: Jae Hyun Yoo Review

Re: [PATCH v10 08/12] mfd: intel-peci-client: Add PECI client driver

2019-01-14 Thread Jae Hyun Yoo
On 1/14/2019 3:42 AM, Joel Stanley wrote: On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: This commit adds PECI client driver. It looks like it's a PECI driver for the three CPU families, and it implements cpu and dimm temp, with sideband functions deferred to the future. If you add that in

Re: [PATCH v2] cpuidle: Add 'above' and 'below' idle state metrics

2019-01-14 Thread Rafael J. Wysocki
On Mon, Jan 14, 2019 at 11:39 AM Daniel Lezcano wrote: > > > Hi Rafael, > > sorry for the delay. > > On 10/01/2019 11:20, Rafael J. Wysocki wrote: > > [ ... ] > > >>> if (entered_state >= 0) { > >>> + s64 diff, delay = drv->states[entered_state].exit_latency; > >>> +

Re: [PATCH v1 1/2] Documentation/filesystems: add binderfs

2019-01-14 Thread Jonathan Corbet
On Fri, 11 Jan 2019 14:40:59 +0100 Christian Brauner wrote: > This documents the Android binderfs filesystem used to dynamically add and > remove binder devices that are private to each instance. > > Signed-off-by: Christian Brauner Two quick notes: > --- > /* Changelog */ > v1: > - switch fr

Re: [PATCH] Documentation/sysctl/vm.txt: Fix drop_caches bit number

2019-01-14 Thread Jonathan Corbet
On Fri, 11 Jan 2019 17:14:10 +0100 Vincent Whitchurch wrote: > Bits are usually numbered starting from zero, so 4 should be bit 2, not > bit 3. > > Suggested-by: Matthew Wilcox > Signed-off-by: Vincent Whitchurch > --- > Documentation/sysctl/vm.txt | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] Documentation/dev-tools: Use gcc version number instead svn revision number

2019-01-14 Thread Jonathan Corbet
On Mon, 14 Jan 2019 11:08:07 +0100 Sebastian Andrzej Siewior wrote: > svn commit 231296 matches commit d29e939c63b71 ("Add fuzzing coverage > support") in the gcc git. The change is part of gcc 6.1.0. > > Replace the svn commit number with a gcc version which everyone can > easily compare. > >

Re: [PATCH] docs/core-api: memory-allocation: add mention of kmem_cache_create_userspace

2019-01-14 Thread Jonathan Corbet
On Mon, 14 Jan 2019 13:47:34 +0200 Mike Rapoport wrote: > Mention that when a part of a slab cache might be exported to the > userspace, the cache should be created using kmem_cache_create_usercopy() > > Signed-off-by: Mike Rapoport Hmm...I didn't know that :) Applied, thanks. jon

Re: [PATCH] docs/core-api/mm: fix GFP combinations section name

2019-01-14 Thread Jonathan Corbet
On Mon, 14 Jan 2019 20:32:58 +0200 Mike Rapoport wrote: > Fix the mismatch between "Useful GFP flag combinations" section naming in > the DOC: section in include/linux/gfp.h and > Documentation/core-api/mm-api.rst > > Signed-off-by: Mike Rapoport > --- > Documentation/core-api/mm-api.rst | 2 +

Re: [PATCH v2] docs-rst: doc-guide: Minor grammar fixes

2019-01-14 Thread Jonathan Corbet
On Mon, 14 Jan 2019 09:14:59 +0200 Joel Nider wrote: > While using this guide to learn the new documentation method, I saw > a few phrases that I felt could be improved. These small changes > improve the grammar and choice of words to further enhance the > installation instructions. > > Signed-o

Re: [PATCH] fgraph: record function return value

2019-01-14 Thread Changbin Du
Hi Steven, On Mon, Jan 14, 2019 at 11:21:15AM -0500, Steven Rostedt wrote: > On Sat, 12 Jan 2019 14:57:01 +0800 > Changbin Du wrote: > > > This patch adds a new trace option 'funcgraph-retval' and is disabled by > > default. When this option is enabled, fgraph tracer will show the return > > valu