Re: [PATCH] doc: fix a typo in adding-syscalls.rst

2018-10-18 Thread Jonathan Corbet
On Thu, 18 Oct 2018 17:47:50 +0200 cor...@poussif.eu wrote: > There was a typo in adding-syscalls.rst that could mislead developers > to add a C filename in a makefile instead of an object filename. > This error, while not keeping developers from contributing could slow > the development process d

[PATCH] doc: fix a typo in adding-syscalls.rst

2018-10-18 Thread corwin
From: Guillaume Dore There was a typo in adding-syscalls.rst that could mislead developers to add a C filename in a makefile instead of an object filename. This error, while not keeping developers from contributing could slow the development process down by introducing build errors. Signed-off-b

Re: [PATCH] kernel-doc: fix declaration type determination

2018-10-18 Thread Jani Nikula
On Wed, 17 Oct 2018, Randy Dunlap wrote: > From: Randy Dunlap > > Make declaration type determination more robust. > > When scripts/kernel-doc is deciding if some kernel-doc notation > contains an enum, a struct, a union, a typedef, or a function, > it does a pattern match on the beginning of the

Re: [PATCH v5 03/27] x86/fpu/xstate: Introduce XSAVES system states

2018-10-18 Thread Pavel Machek
On Thu 2018-10-18 00:58:29, Borislav Petkov wrote: > On Wed, Oct 17, 2018 at 03:39:47PM -0700, Randy Dunlap wrote: > > Would you mind explaining this request? (requirement?) > > Other than to say that it is the preference of some maintainers, > > please say Why it is preferred. > > > > and since t

Re: [PATCH v5 03/27] x86/fpu/xstate: Introduce XSAVES system states

2018-10-18 Thread Borislav Petkov
On Wed, Oct 17, 2018 at 04:17:01PM -0700, Randy Dunlap wrote: > I asked what I really wanted to know. Then the answer is a bit better readability, I'd guess. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH v5 03/27] x86/fpu/xstate: Introduce XSAVES system states

2018-10-18 Thread Pavel Machek
On Thu 2018-10-18 11:26:03, Borislav Petkov wrote: > On Wed, Oct 17, 2018 at 04:17:01PM -0700, Randy Dunlap wrote: > > I asked what I really wanted to know. > > Then the answer is a bit better readability, I'd guess. Normally, similar local variables are grouped together, with initialized variabl

Re: [PATCH v14 19/19] x86/sgx: Driver documentation

2018-10-18 Thread Pavel Machek
On Thu 2018-10-18 02:45:27, Jarkko Sakkinen wrote: > On Mon, 15 Oct 2018, Pavel Machek wrote: > >On Tue 2018-09-25 16:06:56, Jarkko Sakkinen wrote: > >>+Intel(R) SGX is a set of CPU instructions that can be used by applications > >>to > >>+set aside private regions of code and data. The code outsi

Re: [GIT PULL] IDA/IDR fixes for 4.19

2018-10-18 Thread Greg Kroah-Hartman
On Wed, Oct 17, 2018 at 11:26:34PM -0700, Christoph Hellwig wrote: > On Tue, Oct 16, 2018 at 10:16:08AM -0700, Matthew Wilcox wrote: > > > > git://git.infradead.org/users/willy/linux-dax.git ida-fixes-4.19-rc8 > > > > > > How about you at least test these in linux-next? Putting things on top >

Re: [PATCH v9 00/24] ILP32 for ARM64

2018-10-18 Thread Catalin Marinas
On Sun, Oct 14, 2018 at 09:49:01PM +0200, Arnd Bergmann wrote: > On Sat, Oct 13, 2018 at 9:36 PM Andy Lutomirski wrote: > > > > On Wed, May 16, 2018 at 1:19 AM Yury Norov > > wrote: > > > > > > This series enables AARCH64 with ILP32 mode. > > > > > > As supporting work, it introduces ARCH_32BIT_

Re: [PATCH v5 03/27] x86/fpu/xstate: Introduce XSAVES system states

2018-10-18 Thread Borislav Petkov
On Thu, Oct 18, 2018 at 11:31:25AM +0200, Pavel Machek wrote: > We want readable sources, not neat ascii art everywhere. And we want pink ponies. Reverse xmas tree order is and has been the usual variable sorting in the tip tree for years. -- Regards/Gruss, Boris. Good mailing practices fo

Re: [PATCH RFC] doc: rcu: remove obsolete (non-)requirement about disabling preemption

2018-10-18 Thread Paul E. McKenney
On Wed, Oct 17, 2018 at 07:07:51PM -0700, Joel Fernandes wrote: > On Wed, Oct 17, 2018 at 01:33:24PM -0700, Paul E. McKenney wrote: > > On Wed, Oct 17, 2018 at 11:15:05AM -0700, Joel Fernandes wrote: > > > On Wed, Oct 17, 2018 at 09:11:00AM -0700, Paul E. McKenney wrote: > > > > On Tue, Oct 16, 201

Re: [RESEND PATCH v5 1/9] pwm: extend PWM framework with PWM modes

2018-10-18 Thread Thierry Reding
On Wed, Oct 17, 2018 at 12:42:00PM +, claudiu.bez...@microchip.com wrote: > On 16.10.2018 15:25, Thierry Reding wrote: > > On Tue, Aug 28, 2018 at 04:01:18PM +0300, Claudiu Beznea wrote: [...] > >> +const char *pwm_mode_desc(struct pwm_device *pwm, unsigned long mode) > >> +{ > >> + static con

Re: [RESEND PATCH v5 0/9] extend PWM framework to support PWM modes

2018-10-18 Thread Thierry Reding
On Wed, Oct 17, 2018 at 12:41:53PM +, claudiu.bez...@microchip.com wrote: > > > On 16.10.2018 15:03, Thierry Reding wrote: > > On Fri, Sep 14, 2018 at 06:20:48PM +0200, Nicolas Ferre wrote: > >> Thierry, > >> > >> On 28/08/2018 at 15:01, Claudiu Beznea wrote: > >>> Hi, > >>> > >>> Please give

Re: [PATCH 2/4] iommu/arm-smmu: Workaround for Marvell Armada-AP806 SoC erratum #582743

2018-10-18 Thread Robin Murphy
On 16/10/18 09:25, Hanna Hawa wrote: Hi Robin, On 10/15/2018 04:00 PM, Robin Murphy wrote: Hi Hanna, On 15/10/18 13:00, han...@marvell.com wrote: From: Hanna Hawa Due to erratum #582743, the Marvell Armada-AP806 can't access 64bit to ARM SMMUv2 registers. This patch split the writeq/readq

Re: [PATCH v7 7/8] arm64: update Documentation/arm64/tagged-pointers.txt

2018-10-18 Thread Catalin Marinas
On Wed, Oct 10, 2018 at 04:09:25PM +0200, Andrey Konovalov wrote: > On Wed, Oct 3, 2018 at 7:32 PM, Catalin Marinas > wrote: > > On Tue, Oct 02, 2018 at 03:12:42PM +0200, Andrey Konovalov wrote: [...] > > Also, how is user space supposed to know that it can now pass tagged > > pointers into the k

Re: [PATCH v7 0/8] arm64: untag user pointers passed to the kernel

2018-10-18 Thread Catalin Marinas
On Wed, Oct 17, 2018 at 01:25:42PM -0700, Evgenii Stepanov wrote: > On Wed, Oct 17, 2018 at 7:20 AM, Andrey Konovalov > wrote: > > On Wed, Oct 17, 2018 at 4:06 PM, Vincenzo Frascino > > wrote: > >> I have been thinking a bit lately on how to address the problem of > >> user tagged pointers passe

Re: [PATCH] kernel-doc: fix declaration type determination

2018-10-18 Thread Jonathan Corbet
On Wed, 17 Oct 2018 21:07:27 -0700 Randy Dunlap wrote: > From: Randy Dunlap > > Make declaration type determination more robust. > > When scripts/kernel-doc is deciding if some kernel-doc notation > contains an enum, a struct, a union, a typedef, or a function, > it does a pattern match on the

Re: [PATCH v2] docs: Introduce deprecated APIs list

2018-10-18 Thread Jonathan Corbet
On Wed, 17 Oct 2018 16:45:32 -0700 Kees Cook wrote: > As discussed in the "API replacement/deprecation" thread[1], this makes > an effort to document what things shouldn't get (re)added to the kernel, > by introducing Documentation/process/deprecated.rst. > > [1] > https://lists.linuxfoundation

Re: [PATCH v2] docs/uio: fix a grammar nitpick

2018-10-18 Thread Jonathan Corbet
On Tue, 16 Oct 2018 08:57:44 + (UTC) Will Korteland wrote: > This patch fixes a minor, incorrect piece of grammar in the UIO howto. > > Signed-off-by: Will Korteland > Acked-by: Randy Dunlap > --- > The sole change since v1 is that I re-did the patch against > linux-next-20181016 instead o

Re: [PATCH v5 03/27] x86/fpu/xstate: Introduce XSAVES system states

2018-10-18 Thread Randy Dunlap
On 10/18/18 2:26 AM, Borislav Petkov wrote: > On Wed, Oct 17, 2018 at 04:17:01PM -0700, Randy Dunlap wrote: >> I asked what I really wanted to know. > > Then the answer is a bit better readability, I'd guess. > Thanks for the reply. -- ~Randy

Re: dm: add secdel target

2018-10-18 Thread Mike Snitzer
On Sun, Oct 14 2018 at 7:24am -0400, Vitaly Chikunov wrote: > Report to the upper level ability to discard, and translate arriving > discards to the writes of random or zero data to the underlying level. > > Signed-off-by: Vitaly Chikunov > --- > This target is the same as the linear target

Re: [PATCH 3/4] dt-bindings: iommu/arm, smmu: add compatible string for Marvell

2018-10-18 Thread Rob Herring
On Mon, Oct 15, 2018 at 02:11:52PM +0100, Robin Murphy wrote: > On 15/10/18 13:00, han...@marvell.com wrote: > > From: Hanna Hawa > > > > Add specific compatible string for Marvell usage due errata of > > accessing 64bit registers of ARM SMMU, in AP806. > > > > AP806 SOC use the generic ARM-MMU5

[PATCH v5 01/13] arch/x86: Start renaming the rdt files to more generic names

2018-10-18 Thread Moger, Babu
New generation of AMD processors start supporting RDT(or QOS) features. With more than one vendors supporting these features, it seems more appropriate to rename these files. Changed intel_rdt to resctrl where applicable. Signed-off-by: Babu Moger --- arch/x86/include/asm/{intel_rdt_sched.h =>

[PATCH v5 12/13] Documentation/x86: Rename and update intel_rdt_ui.txt

2018-10-18 Thread Moger, Babu
Rename intel_rdt_ui.txt to generic resctrl_ui.txt and update the documentation for AMD. Signed-off-by: Babu Moger --- Documentation/x86/{intel_rdt_ui.txt => resctrl_ui.txt} | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) rename Documentation/x86/{intel_rdt_ui.txt => resctrl_ui.tx

[PATCH v5 11/13] arch/x86: Introduce QOS feature for AMD

2018-10-18 Thread Moger, Babu
Enables QOS feature on AMD. Following QoS sub-features are supported in AMD if the underlying hardware supports it. - L3 Cache allocation enforcement - L3 Cache occupancy monitoring - L3 Code-Data Prioritization support - Memory Bandwidth Enforcement(Allocation) The specification for this feat

[PATCH v5 13/13] MAINTAINERS: Update the file and documentation names in arch/x86

2018-10-18 Thread Moger, Babu
Update the MAINTAINERS to reflect the changed file(and documentation) names in arch/x86/kernel/cpu. The file names have changed from intel_rdt* to resctrl*. Signed-off-by: Babu Moger --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINE

[PATCH v5 04/13] arch/x86: Bring all the macros to resctrl.h

2018-10-18 Thread Moger, Babu
Bring all the macros to resctrl.h and rename for consistency. Signed-off-by: Babu Moger --- arch/x86/kernel/cpu/resctrl.c | 3 --- arch/x86/kernel/cpu/resctrl.h | 5 + arch/x86/kernel/cpu/resctrl_monitor.c | 7 ++- 3 files changed, 7 insertions(+), 8 deletions(-) diff --

[PATCH v5 09/13] arch/x86: Introduce new config parameter AMD_QOS

2018-10-18 Thread Moger, Babu
Introduces the new config parameter AMD_QOS. This parameter will be used to enable cache and memory bandwidth allocation and monitoring features on AMD processors. This will enable common config parameter RESCTRL if selected. Signed-off-by: Babu Moger --- arch/x86/Kconfig | 17 -

[PATCH v5 06/13] arch/x86: Use new config parameter RESCTRL for compilation

2018-10-18 Thread Moger, Babu
Use newly added config parameter RESCTRL to compile sources. This is common parameter across both Intel and AMD. Signed-off-by: Babu Moger --- arch/x86/include/asm/resctrl_sched.h | 4 ++-- arch/x86/kernel/cpu/Makefile | 4 ++-- include/linux/sched.h| 2 +- 3 files change

[PATCH v5 07/13] arch/x86: Initialize the resource functions that are different

2018-10-18 Thread Moger, Babu
Initialize the resource functions that are different between the vendors. Some features are initialized differently between the vendors. Add _intel suffix to Intel specific functions. For example, MBA feature varies significantly between Intel and AMD. Separate the initialization of these resource

[PATCH v5 05/13] arch/x86: Introduce a new config parameter RESCTRL

2018-10-18 Thread Moger, Babu
Introduces a new config parameter RESCTRL. This will be used as a common config parameter for both Intel and AMD. Each vendor will have their own config parameter to enable RDT feature. One for Intel(INTEL_RDT) and one for AMD(AMD_QOS). It can be enabled or disabled separately. The new parameter R

[PATCH v5 08/13] arch/x86: Bring cbm_validate function into the resource structure

2018-10-18 Thread Moger, Babu
Idea is to bring all the functions that are different between the vendors into resource structure and initialize them dynamically. Add _intel suffix to Intel specific functions. Following function is implemented separately for each vendors. cbm_validate : Cache bitmask validate function. AMD allo

[PATCH v5 03/13] arch/x86: Re-arrange RDT init code

2018-10-18 Thread Moger, Babu
Separate the call sequence for rdt_quirks and MBA feature. This is in preparation to handle vendor differences in these call sequences. Signed-off-by: Babu Moger --- arch/x86/kernel/cpu/resctrl.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/a

[PATCH v5 10/13] arch/x86: Add AMD feature bit X86_FEATURE_MBA in cpuid bits array

2018-10-18 Thread Moger, Babu
From: Sherry Hurwitz The feature bit X86_FEATURE_MBA is detected via CPUID leaf 0x8008 EBX Bit 06. This bit indicates the support of AMD's MBA feature. This feature is supported by both Intel and AMD. But they are detected in different CPUID leaves. Signed-off-by: Sherry Hurwitz Signed-off

[PATCH v5 02/13] arch/x86: Rename the RDT functions and definitions

2018-10-18 Thread Moger, Babu
As AMD is starting to support RDT(or QOS) features, rename the RDT functions and definitions to more generic names. Replace intel_rdt to resctrl where applicable. Signed-off-by: Babu Moger --- arch/x86/include/asm/resctrl_sched.h | 24 arch/x86/kernel/cpu/resctrl.c

[PATCH v5 00/13] arch/x86: AMD QoS support

2018-10-18 Thread Moger, Babu
This series adds support for AMD64 architectural extensions for Platform Quality of Service. These extensions are intended to provide for the monitoring of the usage of certain system resources by one or more processors and for the separate allocation and enforcement of limits on the use of certain

Re: [PATCH RFC] doc: rcu: remove obsolete (non-)requirement about disabling preemption

2018-10-18 Thread Joel Fernandes
On Thu, Oct 18, 2018 at 07:46:37AM -0700, Paul E. McKenney wrote: [..] > > > > > > > > > > > > > > > > > > > > > commit 07921e8720907f58f82b142f2027fc56d5abdbfd > > > > > > > Author: Paul E. McKenney > > > > > > > Date: Tu

Re: [PATCH 1/3] printk: Introduce per-console loglevel setting

2018-10-18 Thread Sergey Senozhatsky
On (09/28/17 17:43), Calvin Owens wrote: > Not all consoles are created equal: depending on the actual hardware, > the latency of a printk() call can vary dramatically. The worst examples > are serial consoles, where it can spin for tens of milliseconds banging > the UART to emit a message, which c

Re: [PATCH RFC] doc: rcu: remove obsolete (non-)requirement about disabling preemption

2018-10-18 Thread Paul E. McKenney
On Thu, Oct 18, 2018 at 05:03:50PM -0700, Joel Fernandes wrote: > On Thu, Oct 18, 2018 at 07:46:37AM -0700, Paul E. McKenney wrote: > [..] > > > > > > > > > > > > > > > > > > > > > > > > commit 07921e8720907f58f82b142f2027fc5

Re: [PATCH RFC] doc: rcu: remove obsolete (non-)requirement about disabling preemption

2018-10-18 Thread Steven Rostedt
On Thu, 18 Oct 2018 17:19:32 -0700 "Paul E. McKenney" wrote: > I figured that whoever calls preempt_enable_no_resched() is taking the > responsibility for permitting preemption in the near future, and if they > fail to do so, they will get called on it. Hard to hide from the latency > tracer, af

Re: [PATCH RFC] doc: rcu: remove obsolete (non-)requirement about disabling preemption

2018-10-18 Thread Joel Fernandes
On Thu, Oct 18, 2018 at 05:19:32PM -0700, Paul E. McKenney wrote: > On Thu, Oct 18, 2018 at 05:03:50PM -0700, Joel Fernandes wrote: > > On Thu, Oct 18, 2018 at 07:46:37AM -0700, Paul E. McKenney wrote: > > [..] > > > > > > > > > --

Re: [PATCH RFC] doc: rcu: remove obsolete (non-)requirement about disabling preemption

2018-10-18 Thread Joel Fernandes
On Thu, Oct 18, 2018 at 09:12:45PM -0400, Steven Rostedt wrote: > On Thu, 18 Oct 2018 17:19:32 -0700 > "Paul E. McKenney" wrote: > > > I figured that whoever calls preempt_enable_no_resched() is taking the > > responsibility for permitting preemption in the near future, and if they > > fail to do

Re: [PATCH RFC] doc: rcu: remove obsolete (non-)requirement about disabling preemption

2018-10-18 Thread Steven Rostedt
On Thu, 18 Oct 2018 18:26:45 -0700 Joel Fernandes wrote: > Yes, local_irq_restore is light weight, and does not check for reschedules. > > I was thinking of case where ksoftirqd is woken up, but does not run unless > we set the NEED_RESCHED flag. But that should get set anyway since probably > k

Re: [PATCH RFC] doc: rcu: remove obsolete (non-)requirement about disabling preemption

2018-10-18 Thread Joel Fernandes
On Thu, Oct 18, 2018 at 09:50:35PM -0400, Steven Rostedt wrote: > On Thu, 18 Oct 2018 18:26:45 -0700 > Joel Fernandes wrote: > > > Yes, local_irq_restore is light weight, and does not check for reschedules. > > > > I was thinking of case where ksoftirqd is woken up, but does not run unless > > w

Re: [PATCH RFC] doc: rcu: remove obsolete (non-)requirement about disabling preemption

2018-10-18 Thread Steven Rostedt
On Thu, 18 Oct 2018 19:25:29 -0700 Joel Fernandes wrote: > On Thu, Oct 18, 2018 at 09:50:35PM -0400, Steven Rostedt wrote: > > On Thu, 18 Oct 2018 18:26:45 -0700 > > Joel Fernandes wrote: > > > > > Yes, local_irq_restore is light weight, and does not check for > > > reschedules. > > > > > >

Re: [PATCH RFC] doc: rcu: remove obsolete (non-)requirement about disabling preemption

2018-10-18 Thread Joel Fernandes
On Thu, Oct 18, 2018 at 10:52:23PM -0400, Steven Rostedt wrote: > On Thu, 18 Oct 2018 19:25:29 -0700 > Joel Fernandes wrote: > > > On Thu, Oct 18, 2018 at 09:50:35PM -0400, Steven Rostedt wrote: > > > On Thu, 18 Oct 2018 18:26:45 -0700 > > > Joel Fernandes wrote: > > > > > > > Yes, local_irq_

Re: [dm-devel] [PATCH] dm: add secdel target

2018-10-18 Thread Christoph Hellwig
Just as a note: the name is a complete misowner, a couple overwrite are not in any way secure deletion. So naming it this way and exposing this as erase is a problem that is going to get back to bite us. If you really want this anyway at least give it a different way, and do a one-time warning w