Re: [PATCH] mm,hugetlb,migration: don't migrate kernelcore hugepages

2017-10-03 Thread Michal Hocko
On Tue 03-10-17 07:42:25, Alexandru Moise wrote: > On Mon, Oct 02, 2017 at 06:15:00PM +0200, Michal Hocko wrote: [...] > > I really fail to see why kernel vs. movable zones play any role here. > > Zones should be mostly an implementation detail which userspace > > shouldn't really care about. > >

Re: [v9 2/5] mm: implement mem_cgroup_scan_tasks() for the root memory cgroup

2017-10-03 Thread Michal Hocko
On Wed 27-09-17 14:09:33, Roman Gushchin wrote: > Implement mem_cgroup_scan_tasks() functionality for the root > memory cgroup to use this function for looking for a OOM victim > task in the root memory cgroup by the cgroup-ware OOM killer. > > The root memory cgroup should be treated as a leaf cg

Re: [v9 3/5] mm, oom: cgroup-aware OOM killer

2017-10-03 Thread Michal Hocko
On Wed 27-09-17 14:09:34, Roman Gushchin wrote: > Traditionally, the OOM killer is operating on a process level. > Under oom conditions, it finds a process with the highest oom score > and kills it. > > This behavior doesn't suit well the system with many running > containers: > > 1) There is no

Re: [v9 4/5] mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer

2017-10-03 Thread Michal Hocko
On Wed 27-09-17 14:09:35, Roman Gushchin wrote: > Add a "groupoom" cgroup v2 mount option to enable the cgroup-aware > OOM killer. If not set, the OOM selection is performed in > a "traditional" per-process way. > > The behavior can be changed dynamically by remounting the cgroupfs. I do not have

Re: [v9 3/5] mm, oom: cgroup-aware OOM killer

2017-10-03 Thread Roman Gushchin
On Tue, Oct 03, 2017 at 01:48:48PM +0200, Michal Hocko wrote: > On Wed 27-09-17 14:09:34, Roman Gushchin wrote: > > Traditionally, the OOM killer is operating on a process level. > > Under oom conditions, it finds a process with the highest oom score > > and kills it. > > > > This behavior doesn't

Re: [v9 4/5] mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer

2017-10-03 Thread Roman Gushchin
On Tue, Oct 03, 2017 at 01:50:36PM +0200, Michal Hocko wrote: > On Wed 27-09-17 14:09:35, Roman Gushchin wrote: > > Add a "groupoom" cgroup v2 mount option to enable the cgroup-aware > > OOM killer. If not set, the OOM selection is performed in > > a "traditional" per-process way. > > > > The beha

Re: [v9 2/5] mm: implement mem_cgroup_scan_tasks() for the root memory cgroup

2017-10-03 Thread Roman Gushchin
On Tue, Oct 03, 2017 at 12:49:39PM +0200, Michal Hocko wrote: > On Wed 27-09-17 14:09:33, Roman Gushchin wrote: > > Implement mem_cgroup_scan_tasks() functionality for the root > > memory cgroup to use this function for looking for a OOM victim > > task in the root memory cgroup by the cgroup-ware

Re: [v9 3/5] mm, oom: cgroup-aware OOM killer

2017-10-03 Thread Michal Hocko
On Tue 03-10-17 13:37:21, Roman Gushchin wrote: > On Tue, Oct 03, 2017 at 01:48:48PM +0200, Michal Hocko wrote: [...] > > Wrt. to the implicit inheritance you brought up in a separate email > > thread [1]. Let me quote > > : after some additional thinking I don't think anymore that implicit > > : p

Re: [v9 4/5] mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer

2017-10-03 Thread Michal Hocko
On Tue 03-10-17 13:49:36, Roman Gushchin wrote: > On Tue, Oct 03, 2017 at 01:50:36PM +0200, Michal Hocko wrote: > > On Wed 27-09-17 14:09:35, Roman Gushchin wrote: > > > Add a "groupoom" cgroup v2 mount option to enable the cgroup-aware > > > OOM killer. If not set, the OOM selection is performed i

Re: [v9 3/5] mm, oom: cgroup-aware OOM killer

2017-10-03 Thread Roman Gushchin
On Tue, Oct 03, 2017 at 03:36:23PM +0200, Michal Hocko wrote: > On Tue 03-10-17 13:37:21, Roman Gushchin wrote: > > On Tue, Oct 03, 2017 at 01:48:48PM +0200, Michal Hocko wrote: > [...] > > > Wrt. to the implicit inheritance you brought up in a separate email > > > thread [1]. Let me quote > > > :

Re: [v9 3/5] mm, oom: cgroup-aware OOM killer

2017-10-03 Thread Michal Hocko
On Tue 03-10-17 15:08:41, Roman Gushchin wrote: > On Tue, Oct 03, 2017 at 03:36:23PM +0200, Michal Hocko wrote: [...] > > I guess we want to inherit the value on the memcg creation but I agree > > that enforcing parent setting is weird. I will think about it some more > > but I agree that it is san

Re: [v9 3/5] mm, oom: cgroup-aware OOM killer

2017-10-03 Thread Tejun Heo
Hello, Michal. On Tue, Oct 03, 2017 at 04:22:46PM +0200, Michal Hocko wrote: > On Tue 03-10-17 15:08:41, Roman Gushchin wrote: > > On Tue, Oct 03, 2017 at 03:36:23PM +0200, Michal Hocko wrote: > [...] > > > I guess we want to inherit the value on the memcg creation but I agree > > > that enforcing

Re: [v9 3/5] mm, oom: cgroup-aware OOM killer

2017-10-03 Thread Roman Gushchin
On Tue, Oct 03, 2017 at 04:22:46PM +0200, Michal Hocko wrote: > On Tue 03-10-17 15:08:41, Roman Gushchin wrote: > > On Tue, Oct 03, 2017 at 03:36:23PM +0200, Michal Hocko wrote: > [...] > > > I guess we want to inherit the value on the memcg creation but I agree > > > that enforcing parent setting

Re: [v9 3/5] mm, oom: cgroup-aware OOM killer

2017-10-03 Thread Michal Hocko
On Tue 03-10-17 15:38:08, Roman Gushchin wrote: > On Tue, Oct 03, 2017 at 04:22:46PM +0200, Michal Hocko wrote: > > On Tue 03-10-17 15:08:41, Roman Gushchin wrote: > > > On Tue, Oct 03, 2017 at 03:36:23PM +0200, Michal Hocko wrote: > > [...] > > > > I guess we want to inherit the value on the memcg

[PATCH] Documentation: Improve softlockup_panic= description text

2017-10-03 Thread Borislav Petkov
From: Borislav Petkov It should say what that range is and what that integer value means. I had to look at the code... Signed-off-by: Borislav Petkov Cc: Jonathan Corbet Cc: linux-doc@vger.kernel.org --- Documentation/admin-guide/kernel-parameters.txt | 6 ++ 1 file changed, 6 insertions

Re: [PATCH] Documentation: Improve softlockup_panic= description text

2017-10-03 Thread Jonathan Corbet
On Tue, 3 Oct 2017 17:54:07 +0200 Borislav Petkov wrote: > It should say what that range is and what that integer value > means. I had to look at the code... > > Signed-off-by: Borislav Petkov > Cc: Jonathan Corbet > Cc: linux-doc@vger.kernel.org > --- > Documentation/admin-guide/kernel-par

Re: [PATCH] Documentation/features/KASAN: mark KASAN as supported only on 64-bit on x86

2017-10-03 Thread Jonathan Corbet
On Sat, 30 Sep 2017 05:57:39 +0200 Adam Borowski wrote: > Relevant part is: > arch/x86/Kconfig: select HAVE_ARCH_KASAN if X86_64 && SPARSEMEM_VMEMMAP > > Signed-off-by: Adam Borowski > --- > Documentation/features/debug/KASAN/arch-support.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH v2 1/1] docs: Update binfmt_misc links

2017-10-03 Thread Jonathan Corbet
On Wed, 27 Sep 2017 17:02:09 -0500 Tom Saeger wrote: > Documentation/binfmt_misc.txt was moved to > Documentation/admin-guide/binfmt_misc.rst These are good changes, but could I ask you a favor, please? Split the patch into two, one for Documentation/ and the other for fs/. Then I can apply th

Re: [PATCH] Documentation: Improve softlockup_panic= description text

2017-10-03 Thread Borislav Petkov
On Tue, Oct 03, 2017 at 02:39:17PM -0600, Jonathan Corbet wrote: > So I hate to be fussy. (OK, perhaps I like it, but I'll act reluctant > anyway...:) If it's an integer value, how can it be null? Can we say "a > non-zero value" instead? non-zero yap, I was looking for that version but somehow

Re: [PATCH] Documentation: Improve softlockup_panic= description text

2017-10-03 Thread Jonathan Corbet
On Tue, 3 Oct 2017 22:54:29 +0200 Borislav Petkov wrote: > non-zero yap, I was looking for that version but somehow it evaded > me. Can you change it while applying or should I send a new one? Man that's a lot of work...much easier to just whine about it on the mailing lists...:) (Yes, I tweake

[PATCH v3 0/2] docs: Update binfmt_misc links

2017-10-03 Thread Tom Saeger
v3: - Split into `docs` and `fs` patch as suggested by Jonathan Corbet -- Tom Saeger (2): docs: Update binfmt_misc links fs: Update binfmt_misc links Documentation/sysctl/README | 2 +- Documentation/sysctl/fs.txt | 2 +- fs/Kconfig.binfmt | 2 +- fs/binfmt_misc.c| 3

[PATCH v3 1/2] docs: Update binfmt_misc links

2017-10-03 Thread Tom Saeger
Documentation/binfmt_misc.txt moved to Documentation/admin-guide/binfmt-misc.rst Signed-off-by: Tom Saeger --- Documentation/sysctl/README | 2 +- Documentation/sysctl/fs.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/sysctl/README b/Documentation/sysctl

[PATCH v3 2/2] fs: Update binfmt_misc links

2017-10-03 Thread Tom Saeger
Documentation/binfmt_misc.txt was moved to Documentation/admin-guide/binfmt-misc.rst Signed-off-by: Tom Saeger --- fs/Kconfig.binfmt | 2 +- fs/binfmt_misc.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/Kconfig.binfmt b/fs/Kconfig.binfmt index b2f82cf6bf86..cb35347

Re: [PATCH v3 1/2] docs: Update binfmt_misc links

2017-10-03 Thread Jonathan Corbet
On Tue, 3 Oct 2017 16:16:37 -0500 Tom Saeger wrote: > Documentation/binfmt_misc.txt moved to > Documentation/admin-guide/binfmt-misc.rst > > Signed-off-by: Tom Saeger > --- > Documentation/sysctl/README | 2 +- > Documentation/sysctl/fs.txt | 2 +- > 2 files changed, 2 insertions(+), 2 deletio

Re: [PATCH] Documentation: Improve softlockup_panic= description text

2017-10-03 Thread Borislav Petkov
On Tue, Oct 03, 2017 at 03:13:23PM -0600, Jonathan Corbet wrote: > Man that's a lot of work...much easier to just whine about it on the > mailing lists...:) You could've just said "nah, you do it" :) > (Yes, I tweaked it, thanks). Thanks! -- Regards/Gruss, Boris. Good mailing practices fo

Re: [PATCH v3 1/2] docs: Update binfmt_misc links

2017-10-03 Thread Tom Saeger
On Tue, Oct 03, 2017 at 09:23:59PM +, Jonathan Corbet wrote: > On Tue, 3 Oct 2017 16:16:37 -0500 > Tom Saeger wrote: > > > Documentation/binfmt_misc.txt moved to > > Documentation/admin-guide/binfmt-misc.rst > > > > Signed-off-by: Tom Saeger > > --- > > Documentation/sysctl/README | 2 +- >

[PATCH] linux/kernel.h: add/correct kernel-doc notation

2017-10-03 Thread Randy Dunlap
From: Randy Dunlap Add kernel-doc notation for some macros. Correct kernel-doc comments & typos for a few macros. Signed-off-by: Randy Dunlap --- include/linux/kernel.h | 90 --- 1 file changed, 74 insertions(+), 16 deletions(-) --- lnx-414-rc3.orig/inclu

Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-03 Thread Masahiro Yamada
Hi Douglas, 2017-09-27 2:55 GMT+09:00 Douglas Anderson : > While timing a "no-op" build of the kernel (incrementally building the > kernel even though nothing changed) in the Chrome OS build system I > found that it was much slower than I expected. > > Digging into things a bit, I found that quit