Re: [RFC 01/10] crypto: factor async completion for general use

2017-05-11 Thread Gilad Ben-Yossef
Hi Eric, On Thu, May 11, 2017 at 6:55 AM, Eric Biggers wrote: > Hi Gilad, > > On Sat, May 06, 2017 at 03:59:50PM +0300, Gilad Ben-Yossef wrote: >> Invoking a possibly async. crypto op and waiting for completion >> while correctly handling backlog processing is a common task >> in the crypto API i

Re: [RFC 01/10] crypto: factor async completion for general use

2017-05-11 Thread Eric Biggers
On Thu, May 11, 2017 at 10:29:47AM +0300, Gilad Ben-Yossef wrote: > > With regards to the wait being uninterruptible, I agree that this should be > > the > > default behavior, because I think users waiting for specific crypto > > requests are > > generally not prepared to handle the wait actually

[PATCH] doc: replace FTP URL to kernel.org with HTTPS one

2017-05-11 Thread Michael Heimpold
FTP services were shutdown some weeks ago, so the FTP URL does not work anymore. Fix this by replacing it with corresponding HTTPS URL. Signed-off-by: Michael Heimpold --- Documentation/admin-guide/README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/admin

Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

2017-05-11 Thread Martin Kepplinger
On 2017-05-08 18:11, Rob Herring wrote: > On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote: >> The datasheet and application note does not mention an allowed range for >> the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set >> lower values than 20 and they seem t

Re: [RFC 01/10] crypto: factor async completion for general use

2017-05-11 Thread Gilad Ben-Yossef
On Thu, May 11, 2017 at 11:09 AM, Eric Biggers wrote: > On Thu, May 11, 2017 at 10:29:47AM +0300, Gilad Ben-Yossef wrote: >> > With regards to the wait being uninterruptible, I agree that this should >> > be the >> > default behavior, because I think users waiting for specific crypto >> > reques

Re: [PATCH] docs-rst: add input docs at main index and use kernel-figure

2017-05-11 Thread Mauro Carvalho Chehab
Em Tue, 9 May 2017 13:41:53 -0600 Jonathan Corbet escreveu: > On Tue, 11 Apr 2017 07:01:19 -0300 > Mauro Carvalho Chehab wrote: > > > The input subsystem documentation got converted into ReST. > > > > Add it to the main documentation index and use kernel-figure > > for the two svg images there

[PATCH 4/4] crypto: Documentation: fix none signal safe sample

2017-05-11 Thread Gilad Ben-Yossef
The sample code was showing use of wait_for_completion_interruptible() for waiting for an async. crypto op to finish. However, if a signal arrived it would free the buffers used even while crypto HW might still DMA from/into the buffers. Resolve this by using wait_for_completion() instead. Report

[PATCH 3/4] crypto: gcm wait for crypto op not signal safe

2017-05-11 Thread Gilad Ben-Yossef
crypto_gcm_setkey() was using wait_for_completion_interruptible() to wait for completion of async crypto op but if a signal occurs it may return before DMA ops of HW crypto provider finish, thus corrupting the data buffer that is kfree'ed in this case. Resolve this by using wait_for_completion() i

[PATCH 1/4] crypto: handle EBUSY due to backlog correctly

2017-05-11 Thread Gilad Ben-Yossef
public_key_verify_signature() was passing the CRYPTO_TFM_REQ_MAY_BACKLOG flag to akcipher_request_set_callback() but was not handling correctly the case where a -EBUSY error could be returned from the call to crypto_akcipher_verify() if backlog was used, possibly casuing data corruption due to use-

[PATCH 0/4] crypto: async crypto op fixes

2017-05-11 Thread Gilad Ben-Yossef
This patch set fixes various usage and documentation errors in waiting for async crypto op to complete which can result in data corruption. Note: these were discovered in the process of working on a patch set that replaces these call sites and more with a generic implementation that will prevent t

[PATCH 2/4] crypto: drbg wait for crypto op not signal safe

2017-05-11 Thread Gilad Ben-Yossef
drbg_kcapi_sym_ctr() was using wait_for_completion_interruptible() to wait for completion of async crypto op but if a signal occurs it may return before DMA ops of HW crypto provider finish, thus corrupting the output buffer. Resolve this by using wait_for_completion() instead. Reported-by: Eric

Re: [PATCH v2 04/10] pinctrl: sunxi: switch A20's pinctrl driver to use the A10 version

2017-05-11 Thread Linus Walleij
On Thu, May 4, 2017 at 3:50 PM, Icenowy Zheng wrote: > As we added A20 support to A10 pinctrl driver, now we can delete the > dedicated A20 pinctrl driver, and enable A10 driver for A20. > > Signed-off-by: Icenowy Zheng Looks all right to me but I'm waiting for Maxime's review on these patches.

Re: [PATCH v2 10/10] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Ultra

2017-05-11 Thread Linus Walleij
On Thu, May 4, 2017 at 3:50 PM, Icenowy Zheng wrote: > From: Chen-Yu Tsai > > The Banana Pi M2 Ultra is an SBC based on the Allwinner R40 SoC. The > form factor and position of various connectors, leds and buttons is > similar to the Banana Pi M1+, Banana Pi M3, and is exactly the same > as the

Re: [PATCH v9 7/9] coresight: add support for CPU debug module

2017-05-11 Thread Mathieu Poirier
On Tue, May 09, 2017 at 10:50:00AM +0800, Leo Yan wrote: > Coresight includes debug module and usually the module connects with CPU > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > description for related info in "Part H: External Debug". > > Chapter H7 "The Sample-based

Re: [PATCH v9 8/9] arm64: dts: hi6220: register debug module

2017-05-11 Thread Mathieu Poirier
On Tue, May 09, 2017 at 10:50:01AM +0800, Leo Yan wrote: > Bind debug module driver for Hi6220. > > Signed-off-by: Leo Yan Reviewed-by: Mathieu Poirier > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 64 > +++ > 1 file changed, 64 insertions(+) > > diff --git

Re: [PATCH v9 9/9] arm64: dts: qcom: msm8916: Add debug unit

2017-05-11 Thread Mathieu Poirier
On Tue, May 09, 2017 at 10:50:02AM +0800, Leo Yan wrote: > Add debug unit on Qualcomm msm8916 based platforms, including the > DragonBoard 410c board. > > Signed-off-by: Leo Yan Reviewed-by: Mathieu Poirier > --- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 32 >

Re: [PATCH v9 2/9] doc: Add documentation for Coresight CPU debug

2017-05-11 Thread Mathieu Poirier
On Tue, May 09, 2017 at 10:49:55AM +0800, Leo Yan wrote: > Add detailed documentation for Coresight CPU debug driver, which > contains the info for driver implementation, Mike Leach excellent > summary for "clock and power domain". At the end some examples on how > to enable the debugging functiona

Re: [PATCH v9 3/9] doc: Add coresight_cpu_debug.enable to kernel-parameters.txt

2017-05-11 Thread Mathieu Poirier
On Tue, May 09, 2017 at 10:49:56AM +0800, Leo Yan wrote: > Add coresight_cpu_debug.enable to kernel-parameters.txt, this flag is > used to enable/disable the CPU sampling based debugging. > > Signed-off-by: Leo Yan Reviewed-by: Mathieu Poirier > --- > Documentation/admin-guide/kernel-paramete

Re: [PATCH v9 4/9] MAINTAINERS: update file entries for Coresight subsystem

2017-05-11 Thread Mathieu Poirier
On Tue, May 09, 2017 at 10:49:57AM +0800, Leo Yan wrote: > Update document file entries for Coresight debug module. > > Signed-off-by: Leo Yan Reviewed-by: Mathieu Poirier > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b948dfa

Re: [PATCH v9 7/9] coresight: add support for CPU debug module

2017-05-11 Thread Suzuki K Poulose
On 09/05/17 03:50, Leo Yan wrote: Coresight includes debug module and usually the module connects with CPU debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has description for related info in "Part H: External Debug". Chapter H7 "The Sample-based Profiling Extension" introduces

Re: [PATCH] docs-rst: add input docs at main index and use kernel-figure

2017-05-11 Thread Jonathan Corbet
On Thu, 11 May 2017 07:44:24 -0300 Mauro Carvalho Chehab wrote: > > I do reserve the right to break apart and reorganize this documentation, > > a bit; it's got the classic problem of jumbling stuff for different > > audiences into one big document. But that's for another day when I have > > som

Re: [PATCH] doc: replace FTP URL to kernel.org with HTTPS one

2017-05-11 Thread Jonathan Corbet
On Thu, 11 May 2017 10:13:44 +0200 Michael Heimpold wrote: > FTP services were shutdown some weeks ago, so the FTP URL > does not work anymore. Fix this by replacing it with > corresponding HTTPS URL. Applied, we definitely don't want to have broken pointers. That said, I have to wonder...does

[PULL] A few small documentation updates

2017-05-11 Thread Jonathan Corbet
The following changes since commit 4a1e31c68e9f40be32838944931178b0d9ed9162: Merge tag 'arc-4.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc (2017-05-09 10:10:15 -0700) are available in the git repository at: git://git.lwn.net/linux.git tags/docs-4.12-2 for you to fet

[PATCH] mm, docs: update memory.stat description with workingset* entries

2017-05-11 Thread Roman Gushchin
Commit 4b4cea91691d ("mm: vmscan: fix IO/refault regression in cache workingset transition") introduced three new entries in memory stat file: - workingset_refault, - workingset_activate, - workingset_nodereclaim. This commit adds a corresponding description to the cgroup v2 docs.

[PATCH] mm: per-cgroup memory reclaim stats

2017-05-11 Thread Roman Gushchin
Track the following reclaim counters for every memory cgroup: PGREFILL, PGSCAN, PGSTEAL, PGACTIVATE, PGDEACTIVATE, PGLAZYFREE and PGLAZYFREED. These values are exposed using the memory.stats interface of cgroup v2. The meaning of each value is the same as for global counters, available using /pro

Re: [PATCH] doc: replace FTP URL to kernel.org with HTTPS one

2017-05-11 Thread Michael Heimpold
Hi, Am Donnerstag, 11. Mai 2017, 11:53:49 CEST schrieb Jonathan Corbet: > On Thu, 11 May 2017 10:13:44 +0200 > > Michael Heimpold wrote: > > FTP services were shutdown some weeks ago, so the FTP URL > > does not work anymore. Fix this by replacing it with > > corresponding HTTPS URL. > > Applie

Re: [PATCH v9 7/9] coresight: add support for CPU debug module

2017-05-11 Thread Leo Yan
On Thu, May 11, 2017 at 11:12:32AM -0600, Mathieu Poirier wrote: [...] > > +static int debug_probe(struct amba_device *adev, const struct amba_id *id) > > +{ > > + void __iomem *base; > > + struct device *dev = &adev->dev; > > + struct debug_drvdata *drvdata; > > + struct resource *res =

Re: [PATCH] mm: per-cgroup memory reclaim stats

2017-05-11 Thread Balbir Singh
On Thu, 2017-05-11 at 20:16 +0100, Roman Gushchin wrote: > Track the following reclaim counters for every memory cgroup: > PGREFILL, PGSCAN, PGSTEAL, PGACTIVATE, PGDEACTIVATE, PGLAZYFREE and > PGLAZYFREED. > > These values are exposed using the memory.stats interface of cgroup v2. The changelog c