Re: [RFC v2] dma-mapping: Use unsigned long for dma_attrs

2016-06-01 Thread Christoph Hellwig
On Wed, Jun 01, 2016 at 07:36:42AM +0200, Krzysztof Kozlowski wrote: > > No really for this patch, but I would much prefer to document them next > > to the code in the long run. Also I really think these BIT() macros > > are a distraction compared to the (1 << N) notation. > > Not much difference

[PATCH] doc/sphinx: Pass right filename as source

2016-06-01 Thread Daniel Vetter
With this error output becomes almost readable. The line numbers are still totally bonghits, but that's a lot harder to pull out of kerneldoc. We'd essentially have to insert some special markers in the kernel-doc output, split the output along these markers and then insert each block separately us

Re: [PATCH] doc/sphinx: Pass right filename as source

2016-06-01 Thread Jani Nikula
On Wed, 01 Jun 2016, Daniel Vetter wrote: > With this error output becomes almost readable. The line numbers are > still totally bonghits, but that's a lot harder to pull out of > kerneldoc. We'd essentially have to insert some special markers in the > kernel-doc output, split the output along the

[PATCH 6/8] cpufreq: Drop freq-table param to cpufreq_frequency_table_target()

2016-06-01 Thread Viresh Kumar
The policy already has this pointer set, use it instead. Signed-off-by: Viresh Kumar --- Documentation/cpu-freq/cpu-drivers.txt | 1 - drivers/cpufreq/amd_freq_sensitivity.c | 3 +-- drivers/cpufreq/cpufreq.c | 4 ++-- drivers/cpufreq/cpufreq_ondemand.c | 11 +-- driv

[PATCH 8/8] cpufreq: Return index from cpufreq_frequency_table_target()

2016-06-01 Thread Viresh Kumar
This routine can't fail unless the frequency table is invalid and doesn't contain any valid entries. Make it return the index and WARN() in case it is used for an invalid table. Signed-off-by: Viresh Kumar --- Documentation/cpu-freq/cpu-drivers.txt | 7 +++ drivers/cpufreq/amd_freq_sensiti

[PATCH 1/3] iio: adc: ina3221: Add DT binding details

2016-06-01 Thread Laxman Dewangan
The INA3221 is a three-channel, high-side current and bus voltage monitor with an I2C interface from Texas Instruments. The INA3221 monitors both shunt voltage drops and bus supply voltages in addition to having programmable conversion times and averaging modes for these signals. The INA3221 offers

[PATCH 2/3] iio: adc: ina3221: Add support for IIO ADC driver for TI INA3221

2016-06-01 Thread Laxman Dewangan
The INA3221 is a three-channel, high-side current and bus voltage monitor with an I2C interface from Texas Instruments. The INA3221 monitors both shunt voltage drops and bus supply voltages in addition to having programmable conversion times and averaging modes for these signals. The INA3221 offers

[PATCH 3/3] iio: adc: ina3221: Add sysfs details for TI INA3221

2016-06-01 Thread Laxman Dewangan
The INA3221 is a three-channel, high-side current and bus voltage monitor with an I2C interface from Texas Instruments. The INA3221 monitors both shunt voltage drops and bus supply voltages in addition to having programmable conversion times and averaging modes for these signals. The INA3221 offers

Re: [PATCH v2 02/27] staging: unisys: visorchipset change -1 return value

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:28PM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch changes the vague -1 return value to -EINVAL > > Signed-off-by: Erik Arfvidson > Signed-off-by: David Kershner > Reviewed-by: Tim Sell > --- > drivers/staging/unisys/visorbus/visorchipset.c

Re: [PATCH v2 01/27] staging: unisys: visorbus change -1 return values

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:27PM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch changes the vague -1 return values to -EFAULT since > it would be the most appropriate, given that this error > would only occur in an unexpected bad offset field. > Resulting in a bad address. >

Re: [PATCH v2 03/27] staging: unisys: iovmcall_gnuc.h change -1 return values

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:29PM -0400, David Kershner wrote: > From: Erik Arfvidson > > This patch changes the vague -1 return values to -EPERM. > This operation is not supported is a good alternative > to -1 because the return is basically telling the caller > that the processor doesn't suppo

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread James Bottomley
On Tue, 2016-05-31 at 16:38 +0800, Wei Fang wrote: > sas_ata_strategy_handler() adds the works of the ata error handler > to system_unbound_wq. This workqueue asynchronously runs work items, > so the ata error handler will be performed concurrently on different > CPUs. In this case, ->host_failed w

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Neil Horman
On Tue, May 31, 2016 at 10:26:36PM -0400, David Kershner wrote: > From: Tim Sell > > Locking in the _interrupt() function is NOT necessary so long as we ensure > that interrupts have been stopped whenever we need to pause or resume the > device, which we now do. > > While a device is paused, we

Re: [PATCH 1/5] Documentation: dt: socfpga: Add interrupt-controller to ecc-manager

2016-06-01 Thread Rob Herring
On Wed, May 25, 2016 at 11:29:39AM -0500, ttha...@opensource.altera.com wrote: > From: Thor Thayer > > Designate the ECC Manager as an interrupt controller and add child > interrupts. > > Signed-off-by: Thor Thayer > --- > .../bindings/arm/altera/socfpga-eccmgr.txt | 14 +

RE: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Kevin Groeneveld
> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of > ->host_failed I wonder if this could be related to http://www.spinics.net/lists/linux-scsi/msg86808.html? I never did get to the bottom of that. If I have time I hope to retest my scsi hang issue with this patch.

RE: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Sell, Timothy C
> -Original Message- > From: Neil Horman [mailto:nhor...@redhat.com] > Sent: Wednesday, June 01, 2016 10:18 AM > To: Kershner, David A > Cc: cor...@lwn.net; t...@linutronix.de; mi...@redhat.com; > h...@zytor.com; gre...@linuxfoundation.org; Arfvidson, Erik; Sell, Timothy > C; hof...@osadl.o

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread James Bottomley
On Wed, 2016-06-01 at 08:29 -0700, Bart Van Assche wrote: > On 06/01/2016 07:36 AM, Kevin Groeneveld wrote: > > > Subject: [PATCH v2 1/2] scsi: fix race between simultaneous > > > decrements of ->host_failed > > > > I wonder if this could be related to > > http://www.spinics.net/lists/linux-scsi/

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Bart Van Assche
On 06/01/2016 07:36 AM, Kevin Groeneveld wrote: Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed I wonder if this could be related to http://www.spinics.net/lists/linux-scsi/msg86808.html? I never did get to the bottom of that. If I have time I hope to

Re: [2/3] hwmon: xgene: Adds hwmon driver

2016-06-01 Thread Guenter Roeck
On Tue, May 31, 2016 at 11:00:05PM -0700, Hoan Tran wrote: > Hi Guenter, > > > > > Overall, I have to say that the code is quite complex due to the repeated > > checks for ACPI. I am close to suggest having two separate drivers, > > one for ACPI and one for non-ACPI. Any chance to separate ACPI vs

Re: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Neil Horman
On Wed, Jun 01, 2016 at 03:09:13PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Wednesday, June 01, 2016 10:18 AM > > To: Kershner, David A > > Cc: cor...@lwn.net; t...@linutronix.de; mi...@redhat.com; > > h...@zytor.com; g

[PATCH 2/4] scripts/kernel-doc: Also give functions symbolic names

2016-06-01 Thread Daniel Vetter
state3 = prototype parsing, so name them accordingly. Cc: Jani Nikula Cc: linux-doc@vger.kernel.org Cc: Jonathan Corbet Signed-off-by: Daniel Vetter --- scripts/kernel-doc | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index

[PATCH 1/4] scripts/kernel-doc: Remove duplicated DOC: start handling

2016-06-01 Thread Daniel Vetter
Further up in the state machinery we switch from STATE_NAME to STATE_DOCBLOCK when we match /$doc_block/. Which means this block of code here is entirely unreachable. Nuke it. Cc: Jani Nikula Cc: linux-doc@vger.kernel.org Cc: Jonathan Corbet Signed-off-by: Daniel Vetter --- scripts/kernel-doc

[PATCH 4/4] drm/doc: Appease sphinx

2016-06-01 Thread Daniel Vetter
Mostly this is unexpected indents. But really it's just a demonstration for my patch, all these issues have been found&fixed using the correct source file and line number support I just added. All line numbers have been perfectly accurate. One issue looked a bit fishy in intel_lrc.c, where I don't

[PATCH 3/4] scripts/kernel-doc: Track line-number of starting blocks

2016-06-01 Thread Daniel Vetter
Design is pretty simple: kernel-doc inserts breadcrumbs with line numbers, and sphinx picks them up. At first I went with a sphinx comment, but inserting those at random places seriously upsets the parser, and must be filtered. Hence why this version now uses "#define LINEO " since one of these eve

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Wei Fang
Hi, James, On 2016/6/1 22:06, James Bottomley wrote: > On Tue, 2016-05-31 at 16:38 +0800, Wei Fang wrote: >> sas_ata_strategy_handler() adds the works of the ata error handler >> to system_unbound_wq. This workqueue asynchronously runs work items, >> so the ata error handler will be performed conc

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Wei Fang
Hi, Kevin, On 2016/6/1 22:36, Kevin Groeneveld wrote: >> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of >> ->host_failed > > I wonder if this could be related to > http://www.spinics.net/lists/linux-scsi/msg86808.html? > > I never did get to the bottom of that. If I

Re: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-01 Thread Wei Fang
On 2016/6/2 10:37, Wei Fang wrote: > Hi, Kevin, > > On 2016/6/1 22:36, Kevin Groeneveld wrote: >>> Subject: [PATCH v2 1/2] scsi: fix race between simultaneous decrements of >>> ->host_failed >> >> I wonder if this could be related to >> http://www.spinics.net/lists/linux-scsi/msg86808.html? >>

RE: [PATCH v2 10/27] staging: unisys: visorinput: remove unnecessary locking

2016-06-01 Thread Sell, Timothy C
> -Original Message- > From: Neil Horman [mailto:nhor...@redhat.com] > Sent: Wednesday, June 01, 2016 2:43 PM > To: Sell, Timothy C > Cc: Kershner, David A; cor...@lwn.net; t...@linutronix.de; > mi...@redhat.com; h...@zytor.com; gre...@linuxfoundation.org; > Arfvidson, Erik; hof...@osadl.or

[RESEND PATCH v2 3/4] PCI: Add a new option for resource_alignment to reassign alignment

2016-06-01 Thread Yongji Xie
When using resource_alignment kernel parameter, the current implement reassigns the alignment by changing resources' size which can potentially break some drivers. For example, the driver uses the size to locate some register whose length is related to the size. This patch adds a new option "nores

[RESEND PATCH v2 2/4] PCI: Do not Use IORESOURCE_STARTALIGN to identify bridge resources

2016-06-01 Thread Yongji Xie
Now we use the IORESOURCE_STARTALIGN to identify bridge resources in __assign_resources_sorted(). That's quite fragile. We can't make sure that the PCI devices' resources will not use IORESOURCE_STARTALIGN any more. In this patch, we try to use a more robust way to identify bridge resources. Sign

[RESEND PATCH v2 0/4] PCI: Add support for enforcing all MMIO BARs not to share PAGE_SIZE

2016-06-01 Thread Yongji Xie
This series aims to add an option for PCI resource allocator to force BARs not to share PAGE_SIZE. This would make sense to VFIO driver. Because current VFIO implementation disallows to mmap sub-page(size < PAGE_SIZE) MMIO BARs which may share the same page with other BARs for security reasons

[RESEND PATCH v2 4/4] PCI: Add support for enforcing all MMIO BARs to be page aligned

2016-06-01 Thread Yongji Xie
When vfio passthrough a PCI device of which MMIO BARs are smaller than PAGE_SIZE, guest will not handle the mmio accesses to the BARs which leads to mmio emulations in host. This is because vfio will not allow to passthrough one BAR's mmio page which may be shared with other BARs. Otherwise, there

[RESEND PATCH v2 1/4] PCI: Ignore resource_alignment if PCI_PROBE_ONLY was set

2016-06-01 Thread Yongji Xie
The resource_alignment will releases memory resources allocated by firmware so that kernel can reassign new resources later on. But this will cause the problem that no resources can be allocated by kernel if PCI_PROBE_ONLY was set, e.g. on pSeries platform because PCI_PROBE_ONLY force kernel to use