Hi Guenter
I want to thank you again for the fast and detailed code review.
I really appreciate it.
Am 30.05.2016 um 17:45 schrieb Guenter Roeck:
Hi Pascal,
On 05/30/2016 07:46 AM, Pascal Sachs wrote:
From: David Frey
This driver implements support for the Sensirion SHT3x-DIS chip,
a humidi
Am 30.05.2016 um 22:05 schrieb Jani Nikula :
> On Mon, 30 May 2016, Markus Heiser wrote:
>> Am 30.05.2016 um 16:46 schrieb Jani Nikula :
>>> I am not proposing to merge the documents that I've converted mostly as
>>> samples in the branch. I needed something to demonstrate the build is
>>> sane.
On Tue, May 31, 2016 at 9:27 AM, Markus Heiser
wrote:
I find it totally unacceptable to require explicitly marking kernel-doc
comments or source files as being reStructuredText.
Note that it's all opt-in already. If you add a .rst file that includes
kernel-doc via the kernel-do
Update the new concurrency rules of ->host_failed.
Signed-off-by: Wei Fang
---
Documentation/scsi/scsi_eh.txt |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/scsi/scsi_eh.txt b/Documentation/scsi/scsi_eh.txt
index 8638f61..e6d0de2 100644
--- a/Documentat
sas_ata_strategy_handler() adds the works of the ata error handler
to system_unbound_wq. This workqueue asynchronously runs work items,
so the ata error handler will be performed concurrently on different
CPUs. In this case, ->host_failed will be decreased simultaneously in
scsi_eh_finish_cmd() on
Hi,
On Mar 16 2016 or thereabouts, Benjamin Tissoires wrote:
> Hi,
>
> this is a quick respin of the series with the kbuild test bot fixes and the
> requested lm90 change.
>
> Again, I think applying the RMI4 input driver needs the merge of the input
> tree
> in master first, but having reviews
Am 31.05.2016 um 10:07 schrieb Daniel Vetter :
> On Tue, May 31, 2016 at 9:27 AM, Markus Heiser
> wrote:
> I find it totally unacceptable to require explicitly marking kernel-doc
> comments or source files as being reStructuredText.
> Note that it's all opt-in already. If you add a .
The i801 chip can handle the Host Notify feature since ICH 3 as mentioned
in
http://www.intel.com/content/dam/doc/datasheet/82801ca-io-controller-hub-3-datasheet.pdf
Enable the functionality unconditionally and propagate the alert
on each notification.
With a T440s and a Synaptics touchpad that
SMBus Host Notify allows a slave device to act as a master on a bus to
notify the host of an interrupt. On Intel chipsets, the functionality
is directly implemented in the firmware. We just need to export a
function to call .alert() on the proper device driver.
i2c_handle_smbus_host_notify() behav
Code obtained from
https://raw.githubusercontent.com/mightybigcar/synaptics-rmi4/jf/drivers/input/rmi4/rmi_smbus.c
and updated to match upstream. And fixed to make it work.
Signed-off-by: Benjamin Tissoires
Signed-off-by: Andrew Duggan
---
new in v5
no changes in v6
changes in v7:
- fixed typ
.alert() is meant to be generic, but there is currently no way
for the device driver to know which protocol generated the alert.
Add a parameter in .alert() to help the device driver to understand
what is given in data.
This patch is required to have the support of SMBus Host Notify protocol
throu
Hi,
this is mostly a resubmission of the v6 with the acks, tested-by and few typos
here and there.
We really need this to be integrated in the kernel to be able to finally
support the touchpads found in many laptops (such as the Lenovo Thinkpad series,
some HPs, and probably many others). Current
On Sat, May 21, 2016 at 01:36:43PM +0200, Andrea Gelmini wrote:
> Signed-off-by: Andrea Gelmini
Applied.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linu
Am 30.05.2016 um 23:23 schrieb Mauro Carvalho Chehab :
> Em Mon, 30 May 2016 23:05:34 +0300
> Jani Nikula escreveu:
>
>>> I worry a little bit in that reST will be only one more toolchain
>>> beside DocBook .. in the long term, kernel's documentation
>>> should get rid of all the DocBook arti
On Tue, 31 May 2016, Markus Heiser wrote:
> Am 31.05.2016 um 10:07 schrieb Daniel Vetter :
>> 0-day builds all docs, and checks for new warnings. Even in today's
>> gpu.tmpl build there's a massive pile of warnings, so yes developers
>> don't look. But 0-day does, and then developers look at the n
Hello Jonathan,
I've been doing some digging around the diskstats code and there is
something which bothers me. The 11th field is described as:
"
Field 11 -- weighted # of milliseconds spent doing I/Os
This field is incremented at each I/O start, I/O completion, I/O
merge, or read of these stats
Am 31.05.2016 um 12:30 schrieb Jani Nikula :
> On Tue, 31 May 2016, Markus Heiser wrote:
>> Am 31.05.2016 um 10:07 schrieb Daniel Vetter :
>>> 0-day builds all docs, and checks for new warnings. Even in today's
>>> gpu.tmpl build there's a massive pile of warnings, so yes developers
>>> don't lo
On Tue, May 31, 2016 at 04:38:17PM +0800, Wei Fang wrote:
> sas_ata_strategy_handler() adds the works of the ata error handler
> to system_unbound_wq. This workqueue asynchronously runs work items,
Are there more than one error handling work items per host?
Thanks.
--
tejun
--
To unsubscribe fr
From: David Frey
This driver implements support for the Sensirion SHT3x-DIS chip,
a humidity and temperature sensor. Temperature is measured
in degrees celsius, relative humidity is expressed as a percentage.
In the sysfs interface, all values are scaled by 1000,
i.e. the value for 31.5 degrees c
Signed-off-by: Andrew F. Davis
---
Documentation/hwmon/tmp401 | 18 +--
drivers/hwmon/Kconfig | 2 +-
drivers/hwmon/tmp401.c | 81 ++
3 files changed, 92 insertions(+), 9 deletions(-)
diff --git a/Documentation/hwmon/tmp401 b/Document
On Mon, May 30, 2016 at 01:54:06PM +0200, Krzysztof Kozlowski wrote:
> The dma-mapping core and the implementations do not change the
> DMA attributes passed by pointer. Thus the pointer can point to const
> data. However the attributes do not have to be a bitfield. Instead
> unsigned long will d
On Tue, May 31, 2016 at 09:08:27AM +0200, Pascal Sachs wrote:
> Hi Guenter
>
> I want to thank you again for the fast and detailed code review.
> I really appreciate it.
>
Sorry it took so long.
[ ... ]
> >>+static struct sht3x_data *sht3x_update_client(struct device *dev)
> >>+{
> >>+stru
On Mon, May 30, 2016 at 01:54:06PM +0200, Krzysztof Kozlowski wrote:
> The dma-mapping core and the implementations do not change the
> DMA attributes passed by pointer. Thus the pointer can point to const
> data. However the attributes do not have to be a bitfield. Instead
> unsigned long will d
On Mon, 30 May 2016 07:43:09 -0700
Marc MERLIN wrote:
> > There is a bcache documentation update available:
> >
> > > > git pull https://bitbucket.org/ewheelerinc/linux
> > > > v4.6-rc1-bcache-documentation
> >
> > Is this the right list to submit such documentation?
>
> Howdy,
>
> I j
On Tue, May 31, 2016 at 04:55:08PM -0600, Jonathan Corbet wrote:
> On Mon, 30 May 2016 07:43:09 -0700
> Marc MERLIN wrote:
>
> > > There is a bcache documentation update available:
> > >
> > > > > git pull https://bitbucket.org/ewheelerinc/linux
> > > > > v4.6-rc1-bcache-documentation
> > >
2016-05-14 Javier Martinez Canillas :
> There are two sentences in the Sync File documentation where the
> english is a little off. This patch is an attempt to fix these.
>
> Signed-off-by: Javier Martinez Canillas
>
> ---
>
> Documentation/sync_file.txt | 6 +++---
> 1 file changed, 3 insert
On Mon, 30 May 2016 11:10:26 +0200
Daniel Vetter wrote:
> I think next steps is to get this merged into docs-next, with a stable
> tag, so that I can pull it into drm-misc.
So, I want to take another look at this, which probably will need another
day or two before it can happen. First impressio
Hi, Tejun,
On 2016/5/31 22:33, Tejun Heo wrote:
> On Tue, May 31, 2016 at 04:38:17PM +0800, Wei Fang wrote:
>> sas_ata_strategy_handler() adds the works of the ata error handler
>> to system_unbound_wq. This workqueue asynchronously runs work items,
>
> Are there more than one error handling work
From: David Binder
Modifies the format string of snprintf to expect an unsigned int
instead of a signed one, per the supplied argument.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
1 file changed,
Update include/linux to include the s-Par associated common include
header files needed for the s-Par visorbus.
Since we have now moved the include directories over to
include/linux/visorbus this patch makes all of the visor
drivers visorbus, visorinput, visornic, and visorhba use
the new include
This patch simple does a git mv of the
drivers/staging/unisys/Documentation directory to Documentation. Renames
overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to
the correct name sysfs-bus-visorbus.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
.../ABI/stable/sys
From: David Binder
Removes unused module parameters from visorbus_main.c, in response to
findings by SonarQube.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 9 +
1 file changed, 1 insertion(+), 8
visorbus is currently located at drivers/staging/visorbus,
this patch moves it to drivers/virt.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/Kconfig| 3 +--
drivers/staging/unisys/Makefile
From: Bryan Thompson
visordriver_callback_lock is just a binary semaphore that logically
makes more sense as a mutex.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 3 ++-
drivers/staging/unisys/visorbu
From: Bryan Thompson
The STANDALONE_CLIENT define is no longer used by Unisys driver code.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unis
From: Tim Sell
These files were made no-longer-necessary by recent commits.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/include/periodic_work.h | 40 -
drivers/staging/unisys/visorbus/Makefile| 1 -
drivers/staging/unisys/visorbus/periodic_
From: David Binder
Per audit feedback from Thomas Gleixner, function descriptions in
vbusdeviceinfo.h now utilize a more kerneldoc-like formatting. The
affected comments do not implement other kerneldoc requirements.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Se
From: Erik Arfvidson
This patch changes the vague -1 return values to -EPERM.
This operation is not supported is a good alternative
to -1 because the return is basically telling the caller
that the processor doesn't support vmcall operations.
Signed-off-by: Erik Arfvidson
Signed-off-by: David K
From: Bryan Thompson
The driver that is now visorbus started out as multiple separate drivers,
and when they were merged the EXPORT_SYMBOL statements that were required
for separate drivers were left in the code. This patch removes those now
unnecessary exports.
Signed-off-by: Bryan Thompson
Si
From: David Binder
Code relating to ktheads was previously removed from s-Par driver code.
This patch cleans up lingering remnants of kthreads by removing thread-
related enum types.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/in
From: David Binder
Removes unused struct definition, channel_size_info, in response to
findings by SonarQube.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6 --
1 file changed, 6 deletions(-)
diff -
From: Erik Arfvidson
This patch changes the vague -1 return value to -EINVAL
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagin
From: David Binder
Fixes a comment spelling mistake in visornic.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/viso
From: Erik Arfvidson
This patch changes the vague -1 return values to -EFAULT since
it would be the most appropriate, given that this error
would only occur in an unexpected bad offset field.
Resulting in a bad address.
Signed-off-by: Erik Arfvidson
Signed-off-by: David Kershner
Reviewed-by: T
From: Tim Sell
periodic_test_workqueue was an unused relic from the past, and was removed.
Signed-off-by: Tim Sell
Signed-off-by: David Kershner
---
drivers/staging/unisys/visorbus/visorbus_main.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/unisys/visor
tglx: The following patchset fixes issues you raised during your
code review of visorbus on 5/18.
Greg: Please drop all other patch series sent in from me as this
patch series incorporates the required patches from the previous
series.
Converts visorbus to use a kernel timer for periodic device-
From: David Binder
Per audit feedback from Thomas Gleixner, function descriptions in
visorbus_private.h now utilize a more kerneldoc-like formatting. The
affected comments do not implement other kerneldoc requirements.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim
From: David Binder
Per audit feedback from Thomas Gleixner, function descriptions in
visorbus_main.c now utilize a more kerneldoc-like formatting. The affected
comments do not implement other kerneldoc requirements.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sel
From: Bryan Thompson
Remove visorbus_clear_channel, visorchannel_signalqueue_slots_avail,
visorchannel_signalqueue_max_slots, visorchannel_clear, and
visorchannel_debug which are no longer called by any driver.
Signed-off-by: Bryan Thompson
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
From: David Binder
Moves function prototypes that are unique to visorbus from
include/visorbus.h to visorbus/visorbus_private.h.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 25
d
From: David Binder
Per audit feedback from Thomas Gleixner, function descriptions in
visorchipset.c now utilize a more kerneldoc-like formatting. The affected
comments do not implement other kerneldoc requirements.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
From: David Binder
Adds kerneldoc-style comments for those functions which may be used outside
of the visorbus driver.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 127
drivers/s
Only visorbus needs this header file so move it to visorbus
directory.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/{include => visorbus}/vbushelper.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename drivers/staging/unisys/{include => visorbus}/vbus
From: Tim Sell
A kernel timer is now used as the vehicle to periodically call the
channel_interrupt function of registered visor drivers, instead of a
workqueue.
This simplifies a lot of things by making periodic_work.c and
periodic_work.h no longer necessary. This change also means that the
ch
From: David Binder
Per audit feedback from Thomas Gleixner, function descriptions in
visorchannel.c now utilize a more kerneldoc-like formatting. The affected
comments do not implement other kerneldoc requirements.
Signed-off-by: David Binder
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
From: Tim Sell
Locking in the _interrupt() function is NOT necessary so long as we ensure
that interrupts have been stopped whenever we need to pause or resume the
device, which we now do.
While a device is paused, we ensure that interrupts stay disabled, i.e.
that the _interrupt() function will
On Tue, May 31, 2016 at 1:38 AM, Wei Fang wrote:
> sas_ata_strategy_handler() adds the works of the ata error handler
> to system_unbound_wq. This workqueue asynchronously runs work items,
> so the ata error handler will be performed concurrently on different
> CPUs. In this case, ->host_failed wi
On Tue, May 31, 2016 at 8:21 PM, Dan Williams wrote:
> On Tue, May 31, 2016 at 1:38 AM, Wei Fang wrote:
>> sas_ata_strategy_handler() adds the works of the ata error handler
>> to system_unbound_wq. This workqueue asynchronously runs work items,
>> so the ata error handler will be performed concu
On 05/31/2016 07:04 PM, Christoph Hellwig wrote:
> On Mon, May 30, 2016 at 01:54:06PM +0200, Krzysztof Kozlowski wrote:
>> The dma-mapping core and the implementations do not change the
>> DMA attributes passed by pointer. Thus the pointer can point to const
>> data. However the attributes do not
Hi Guenter,
Thanks for your review !
On Sun, May 29, 2016 at 10:25 PM, Guenter Roeck wrote:
> On Mon, May 16, 2016 at 09:17:26AM -0700, hotran wrote:
>> This patch adds hardware temperature and power reading support for
>> APM X-Gene SoC's using the mailbox communication interface.
>>
> Please d
On 05/31/2016 08:15 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, May 30, 2016 at 01:54:06PM +0200, Krzysztof Kozlowski wrote:
>> The dma-mapping core and the implementations do not change the
>> DMA attributes passed by pointer. Thus the pointer can point to const
>> data. However the attributes do
On Wed, Jun 1, 2016 at 3:07 AM, Jonathan Corbet wrote:
> On Mon, 30 May 2016 11:10:26 +0200
> Daniel Vetter wrote:
>
>> I think next steps is to get this merged into docs-next, with a stable
>> tag, so that I can pull it into drm-misc.
>
> So, I want to take another look at this, which probably w
On Tue, 31 May 2016, David Kershner wrote:
> + /*
> + * If we're not paused, really enable interrupts.
> + * Regardless of whether we are paused, set a flag indicating
> + * interrupts should be enabled so when we resume, interrupts
> + * will really be enabled.
> + */
On Tue, 31 May 2016, David Kershner wrote:
> From: David Binder
>
> Per audit feedback from Thomas Gleixner, function descriptions in
> visorchannel.c now utilize a more kerneldoc-like formatting. The affected
> comments do not implement other kerneldoc requirements.
That was not my feedback.
On Tue, 31 May 2016, David Kershner wrote:
> From: Bryan Thompson
>
> visordriver_callback_lock is just a binary semaphore that logically
> makes more sense as a mutex.
>
> Signed-off-by: Bryan Thompson
> Signed-off-by: David Kershner
> Reviewed-by: Tim Sell
> ---
> drivers/staging/unisys/i
65 matches
Mail list logo
