Re: staging: ks7010: Rename jump labels

2016-07-26 Thread SF Markus Elfring
> I have a lot of other things to work on, of much greater interest (to me.) This is fine. Thanks for your feedback. >>> Personally I see no value in such statistics. >> >> Do they indicate any code smells eventually? > > I have no idea what you mean, sorry. How do you think about to take ano

Re: staging: ks7010: Rename jump labels

2016-07-25 Thread Jean Delvare
Hello Markus, On lun., 2016-07-25 at 18:19 +0200, SF Markus Elfring wrote: > >> Would you like to support the renaming of a label like "error_out1" > >> (in the function "ks7010_upload_firmware" for example)? > > > > They should be renamed too. Anything using numbers instead of explicit > > Inte

Re: staging: ks7010: Rename jump labels

2016-07-25 Thread SF Markus Elfring
>> Would you like to support the renaming of a label like "error_out1" >> (in the function "ks7010_upload_firmware" for example)? > > They should be renamed too. Anything using numbers instead of explicit Interesting … > Anything using numbers instead of explicit labels should be updated. Woul

Re: staging: ks7010: Rename jump labels

2016-07-25 Thread Jean Delvare
Hi Markus, On Thu, 21 Jul 2016 22:11:53 +0200, SF Markus Elfring wrote: > >> How do you generally think about jump label renaming? > > > > Renaming from "out0:", "out1:" etc to something meaningful, yes. > > I suggest to take another look at such identifiers. > > Would you like to support the r

Re: staging: ks7010: Rename jump labels

2016-07-21 Thread SF Markus Elfring
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=92d21ac74a9e3c09b0b01c764e530657e4c85c49#n4326 > > "#goto labels aren't indented, allow a single space however" > > Can't be clearer :-) Should such information from a comment in this script be also