Re: kernel-doc mishandles declarations split into lines

2017-06-16 Thread Johannes Berg
On Fri, 2017-06-16 at 17:29 +0200, Markus Heiser wrote: > > This has the same problem as all the other versions proposed here - > > if you have > > > > enum foo { > > X, > > > > Y, > > }; > > > > (note the blank line) > > > > you'll get > > > > warning: Enum value ' ' not described in enum 'fo

Re: kernel-doc mishandles declarations split into lines

2017-06-16 Thread Markus Heiser
> Am 16.06.2017 um 15:11 schrieb Johannes Berg : > > Hi Markus, > >> The parser part is same state machine as the the perl one … with same >> problems ;) > > :-) > >> Problem here; function process_proto_type() concatenates the striped >> lines of declaration without any whitespace. A one-line

Re: kernel-doc mishandles declarations split into lines

2017-06-16 Thread Johannes Berg
Hi Markus, > The parser part is same state machine as the the perl one … with same > problems ;) :-) > Problem here; function process_proto_type() concatenates the striped > lines of declaration without any whitespace. A one-liner of:: > >   struct something { > struct foo > bar

Re: kernel-doc mishandles declarations split into lines

2017-06-16 Thread Markus Heiser
> Am 06.06.2017 um 15:28 schrieb Johannes Berg : > > Hi, > > Apologies for the long CC list, wasn't sure who really feels like they > understand this script anymore ... Markus, I think you had a rewrite of > the script in python? Hi Johannes, hi Mauro, (Jon) sorry for my late reply. Yes I have

Re: kernel-doc mishandles declarations split into lines

2017-06-06 Thread Johannes Berg
> > [PATCH] be sure that multiline definitions will be properly espaced > > When handling comments from structs with multiple lines, like: > /** >* struct something >* @very_long_member_name: abcde >*/ > struct something { > struct > this_is_a_ve

Re: kernel-doc mishandles declarations split into lines

2017-06-06 Thread Mauro Carvalho Chehab
Em Tue, 06 Jun 2017 16:12:30 +0200 Johannes Berg escreveu: > On Tue, 2017-06-06 at 10:59 -0300, Mauro Carvalho Chehab wrote: > > > > A trivial "fix" would be to use just one line for the struct field :- > > ) > > Sure, we did this, but it makes checkpatch unhappy. We have a > relatively long

Re: kernel-doc mishandles declarations split into lines

2017-06-06 Thread Johannes Berg
On Tue, 2017-06-06 at 10:59 -0300, Mauro Carvalho Chehab wrote: > > A trivial "fix" would be to use just one line for the struct field :- > ) Sure, we did this, but it makes checkpatch unhappy. We have a relatively long struct name, a relatively long member name, and then it's also an array so yo

Re: kernel-doc mishandles declarations split into lines

2017-06-06 Thread Mauro Carvalho Chehab
Em Tue, 06 Jun 2017 15:28:34 +0200 Johannes Berg escreveu: > Hi, > > Apologies for the long CC list, wasn't sure who really feels like they > understand this script anymore ... Markus, I think you had a rewrite of > the script in python? > > If you have something like this: > > /** > * struct

kernel-doc mishandles declarations split into lines

2017-06-06 Thread Johannes Berg
Hi, Apologies for the long CC list, wasn't sure who really feels like they understand this script anymore ... Markus, I think you had a rewrite of the script in python? If you have something like this: /** * struct something * @very_long_member_name: abcde */ struct something { struct